dfukalov added inline comments.
================
Comment at: llvm/include/llvm/Analysis/AliasAnalysis.h:800
case Instruction::Invoke:
- return getModRefInfo((const InvokeInst *)I, Loc, AAQIP);
+ return getModRefInfo((const CallBase *)I, Loc, AAQIP);
case Instruction::CatchPad:
----------------
RKSimon wrote:
> Is this necessary? It doesn't seem to match the pattern used for all the
> other Instruction types.
Actually there are no `getModRefInfo(CallInst *` nor `getModRefInfo(InvokeInst
*` but the only `getModRefInfo(CallBase *`.
There were two implicit casts from `CallInst` and `InvokeInst` in the calls to
their base `CallBase` and it was masked by included Instructions.h.
My thought was we use explicit cast here so I decided to refine this calls.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92852/new/
https://reviews.llvm.org/D92852
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
