[PATCH] D92257: [clang-format] Add option to control the space at the front of a line comment

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, klimek, krasimir. HazardyKnusperkeks added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. HazardyKnusperkeks requested review of this revision. I'm not sur

[PATCH] D91996: [clang-format] Remove double trim

HazardyKnusperkeks updated this revision to Diff 308134. HazardyKnusperkeks added a comment. Formatted and now superfluous comment removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91996/new/ https://reviews.llvm.org/D91996 Files: clang/lib

[PATCH] D91996: [clang-format] Remove double trim

HazardyKnusperkeks added a comment. In D91996#2417892 , @klimek wrote: > Isn't the comment incorrect after this patch? I actually thought the same after I saw the diff here, but had no time yet to modify it. I will now also remove the comment. Reposito

[PATCH] D91507: [clang-format] Add option for case sensitive regexes for sorted includes

HazardyKnusperkeks added a comment. Thanks, than someone needs to commit it. Regards Björn. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91507/new/ https://reviews.llvm.org/D91507 ___ cfe-commits mail

[PATCH] D92256: [VE] Specify vector alignments

kaz7 created this revision. kaz7 added reviewers: simoll, k-ishizaka. kaz7 added projects: LLVM, VE. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added a project: clang. kaz7 requested review of this revision. Specify alignments for all vector types. Update a regression

[PATCH] D92041: [clangd] Add hover info for `this` expr

xndcn added a comment. In D92041#2420251 , @kadircet wrote: > Do you have commit access or should I commit this for you? I still don't have commit access, so please help me commit this, thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 updated this revision to Diff 308122. njames93 added a comment. Fix failing test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/ https://reviews.llvm.org/D73413 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt cl

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 updated this revision to Diff 308121. njames93 added a comment. I thought I'd bring this back up. - Rebased and tweaked to use a few new library features in clang-tidy since when this was first proposed. - It definitely has value but still maybe got a little bit before its ready to lan

[PATCH] D78903: [Driver] Add option -fproc-stat-report

ZarkoCA added inline comments. Comment at: clang/test/Driver/report-stat.c:1 +// RUN: %clang -c -fproc-stat-report %s | FileCheck %s +// CHECK: clang{{.*}}: output={{.*}}.o, total={{[0-9.]+}} ms, user={{[0-9.]+}} ms, mem={{[0-9]+}} Kb ZarkoCA wrote: > Hi @sepavl

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

ye-luo added a comment. This patch caused severe regression in Clang 11. https://bugs.llvm.org/show_bug.cgi?id=48177 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80743/new/ https://reviews.llvm.org/D80743 _

[clang] 979bcbd - Add -fintegrated-as to clang invocation

Author: Zarko Todorovski Date: 2020-11-27T15:54:37-05:00 New Revision: 979bcbd3a6f7ea784f2098ad4cf613fbd6b09e38 URL: https://github.com/llvm/llvm-project/commit/979bcbd3a6f7ea784f2098ad4cf613fbd6b09e38 DIFF: https://github.com/llvm/llvm-project/commit/979bcbd3a6f7ea784f2098ad4cf613fbd6b09e38.di

[PATCH] D92245: -fstack-clash-protection: Return an actual error when used on unsupported OS

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. sylvestre.ledru requested review of this revision. $ clang-12: error: -fstack-clash-protection is not supported on Windows or Mac OS X

[clang-tools-extra] ca64c89 - [NFC] SmallVector to SmallString<...>

Author: Nathan James Date: 2020-11-27T20:36:09Z New Revision: ca64c8948f495ccdfb33f30675e72b7362b390ff URL: https://github.com/llvm/llvm-project/commit/ca64c8948f495ccdfb33f30675e72b7362b390ff DIFF: https://github.com/llvm/llvm-project/commit/ca64c8948f495ccdfb33f30675e72b7362b390ff.diff LOG:

[PATCH] D92244: [OpenCL] Prevent adding vendor extensions for all targets

Anastasia created this revision. Anastasia added reviewers: svenvh, AlexeySotkin, azabaznov. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Some extensions were defined in the headers without guarding by the target. This commit fixes this and also removed

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

pvellien added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:134 + if (isAmdHsaOS() && getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS) { +report_fatal_error("GFX6 (SI) ASICs does not support AMD HSA OS type \n", + false);

[PATCH] D91055: [clang-tidy] Introduce misc No Integer To Pointer Cast check

aqjune added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/misc-no-inttoptr.rst:12 +if you got that integral value via a pointer-to-integer cast originally, +the new pointer will lack the provenance information from the original pointer. +

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

t-tye added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:134 + if (isAmdHsaOS() && getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS) { +report_fatal_error("GFX6 (SI) ASICs does not support AMD HSA OS type \n", + false); --

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

pvellien added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:2109-2112 +Caution: + AMD HSA Os is not supported in Southern Islands (GFX6) ASICs. + For example: t-tye wrote: > This is not the right place for mentioning this. The Processor table would >

[PATCH] D91438: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4b80efea98f: [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS} (authored by avieira). Changed prior to commit: https://reviews.llvm.org/D91438?vs=305504&id=308081#toc Repository: rG LLVM Github Monorep

[clang] a4b80ef - [AArch64] Define __ARM_FEATURE_{CRC32,ATOMICS}

Author: Andre Vieira Date: 2020-11-27T17:42:43Z New Revision: a4b80efea98fc0b6421db40f9718c5c369fecec0 URL: https://github.com/llvm/llvm-project/commit/a4b80efea98fc0b6421db40f9718c5c369fecec0 DIFF: https://github.com/llvm/llvm-project/commit/a4b80efea98fc0b6421db40f9718c5c369fecec0.diff LOG:

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

t-tye requested changes to this revision. t-tye added inline comments. This revision now requires changes to proceed. Comment at: llvm/docs/AMDGPUUsage.rst:2109-2112 +Caution: + AMD HSA Os is not supported in Southern Islands (GFX6) ASICs. + For example: This i

[PATCH] D91806: [SVE] Remove warning from debug info on scalable vector.

fpetrogalli updated this revision to Diff 308078. fpetrogalli added a comment. Reverted `getFragmentSizeInBits` to return an integral type and not `TypeSize`, because scalable variables cannot be part of structs/arrays - hence they cannot be pointed by fragments. Repository: rG LLVM Github M

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

svenvh added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8638 // array, this recursive call only happens once. return getOpenCLKernelParameterType(S, QualType(UnderlyingTy, 0)); } Anastasia wrote: > Btw I am surprised that we recurse to

[PATCH] D92091: [OpenCL] Allow pointer-to-pointer kernel args beyond CL 1.2

svenvh updated this revision to Diff 308075. svenvh added a comment. Recursively call `getOpenCLKernelParameterType` to check address spaces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92091/new/ https://reviews.llvm.org/D92091 Files: clang/l

[PATCH] D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308074. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83940/new/ https://reviews.llvm.org/D83940 Files: clang/include/clang/Driver/Options.td clang/lib/Frontend/Co

[PATCH] D77056: [Sema] Allow non-member operators for sizeless SVE types

rsandifo-arm added a comment. Sorry for reviving this after so long, but I'd like to bump it from an RFC to an RFA. As the new covering message says, the spec is now part of the ACLE specification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[PATCH] D77056: [Sema][SVE] Allow non-member operators for SVE types

rsandifo-arm updated this revision to Diff 308073. rsandifo-arm added a comment. Rebase onto current trunk, and also on top of: https://reviews.llvm.org/D9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77056/new/ https://reviews.llvm.org/D77056

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

saudi updated this revision to Diff 308068. saudi added a comment. Removed `/Fo` option. `-o` is also supported by clang-cl and overrides /Fo options that are found earlier in the command line. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92191/new/ https://reviews.llvm.org/D92191 Fi

[PATCH] D88712: [CGBuiltin] Respect asm labels and redefine_extname for builtins with specialized emitting

glaubitz added a comment. Not sure if this is related, but on SPARC, stage2 builds recently started to fail with: [379/5552] Building CXX object projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/ubsan_diag.cpp.o FAILED: projects/compiler-rt/lib/ubsan/CMakeFiles/RTUbsan.sparc.dir/

[PATCH] D87702: [Frontend] Add pragma align natural and sort out pragma pack stack effect

Xiangling_L updated this revision to Diff 308065. Xiangling_L added a comment. Adjusted the logic of operator == for class AlignPackInfo; Removed mac68k sentinel; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87702/new/ https://reviews.llvm.org/D87702 Files: clang/include/clang/Basic

[PATCH] D83940: [clang][cli] Port HeaderSearch option flags to new option parsing system

jansvoboda11 updated this revision to Diff 308064. jansvoboda11 added a comment. Rebase & revert move of options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83940/new/ https://reviews.llvm.org/D83940 Files: clang/include/clang/Driver/Options.t

[PATCH] D83940: Port HeaderSearch option flags to new option parsing system

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83940/new/ https://reviews.llvm.org/D8

[PATCH] D92041: [clangd] Add hover info for `this` expr

kadircet added a comment. Do you have commit access or should I commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92041/new/ https://reviews.llvm.org/D92041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D92231: [OpenCL] Implement extended subgroups fully in headers

Anastasia created this revision. Anastasia added reviewers: azabaznov, AlexeySotkin, mantognini, svenvh, PiotrFusik. Herald added subscribers: ebevhan, yaxunl. Anastasia requested review of this revision. Extended subgroups extensions were added in https://reviews.llvm.org/D79781, however, in th

[PATCH] D92198: [clangd] Implement remote index handshake

kadircet added a comment. Haven't checked the details but is there a specific reason for implementing a custom protocol rather than making use of `NotifyOnStateChange` (https://grpc.github.io/grpc/cpp/classgrpc_1_1_channel_interface.html) or even `WaitForStateChange` if we really want to block

[PATCH] D43159: [libc++] Replace several uses of 0 by nullptr

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG527a7fdfbd74: [libc++] Replace several uses of 0 by nullptr (authored by brucem, committed by ldionne). Repository: rG

[PATCH] D92117: [AIX] Enabling vector type arguments and return for AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGff8e8c1b14ea: [AIX] Enabling vector type arguments and return for AIX (authored by ZarkoCA). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92117/new/ https:

[clang] ff8e8c1 - [AIX] Enabling vector type arguments and return for AIX

Author: Zarko Todorovski Date: 2020-11-27T09:55:52-05:00 New Revision: ff8e8c1b14eafbcdc2778dcf1c9fc12c82f078d7 URL: https://github.com/llvm/llvm-project/commit/ff8e8c1b14eafbcdc2778dcf1c9fc12c82f078d7 DIFF: https://github.com/llvm/llvm-project/commit/ff8e8c1b14eafbcdc2778dcf1c9fc12c82f078d7.di

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

svenvh added a comment. > I am still unclear what should we do with testing though. We probably don't want to hold up this patch until we have more thorough testing in place, since we don't even have any concrete plans for such testing at the moment. Perhaps we should just land the patch once

[PATCH] D80450: [CUDA][HIP] Fix HD function resolution

yaxunl updated this revision to Diff 308032. yaxunl retitled this revision from "[CUDA][HIP] Fix implicit HD function resolution" to "[CUDA][HIP] Fix HD function resolution". yaxunl edited the summary of this revision. yaxunl added a comment. If -fgpu-defer-diags is off, keep original behavior.

[PATCH] D92004: [OpenCL] add CL 3.0 optional feature support to opencl-c.h

Anastasia added a comment. Thanks! This looks much cleaner. I am still unclear what should we do with testing though. Comment at: clang/lib/Headers/opencl-c-base.h:284 memory_scope_work_group = __OPENCL_MEMORY_SCOPE_WORK_GROUP, +#if defined(__OPENCL_CPP_VERSION__) || (__OPE

[clang] 0ce32a7 - Revert "[ASTMatchers] Matcher macros with params move params instead of copying"

Author: Hans Wennborg Date: 2020-11-27T14:51:27+01:00 New Revision: 0ce32a79825f307d2f46b8a5823489a67d6d072f URL: https://github.com/llvm/llvm-project/commit/0ce32a79825f307d2f46b8a5823489a67d6d072f DIFF: https://github.com/llvm/llvm-project/commit/0ce32a79825f307d2f46b8a5823489a67d6d072f.diff

[PATCH] D90928: [OpenCL] Check for extension string extension lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rG7793db35ca2c: [OpenCL] Check for extension string extension lookup (authored by erik2020, committed by frasercrmck). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] 7793db3 - [OpenCL] Check for extension string extension lookup

Author: Erik Tomusk Date: 2020-11-27T13:16:39Z New Revision: 7793db35ca2c1fe63687c0a7140cbec540a9aded URL: https://github.com/llvm/llvm-project/commit/7793db35ca2c1fe63687c0a7140cbec540a9aded DIFF: https://github.com/llvm/llvm-project/commit/7793db35ca2c1fe63687c0a7140cbec540a9aded.diff LOG: [

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

njames93 accepted this revision. njames93 added a comment. This revision is now accepted and ready to land. LGTM, with a couple of nits that could easily be disregarded. Comment at: clang-tools-extra/clangd/TidyProvider.cpp:84-105 +for (auto I = path::begin(Parent, path::St

[PATCH] D89909: [SYCL] Implement SYCL address space attributes handling

Anastasia added a comment. In D89909#2403069 , @bader wrote: >> Did anyone conclude there that the language address spaces should be added >> for SYCL? I can't see any of this. In fact I don't even think there was any >> conclusion on the RFC. You should

[PATCH] D92222: [Sema] Make more overload candidate types use iterator_ranges (NFC)

rsandifo-arm created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. rsandifo-arm requested review of this revision. I have a patch that adds another group of candidate types to BuiltinCandidateTypeSet. Currently two styles are in use: the older begin/end pai

[PATCH] D92202: [clangd] Add symbol origin for remote index

kbobyrev updated this revision to Diff 308016. kbobyrev added a comment. Don't assign additional Remote Origin: overwrite it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92202/new/ https://reviews.llvm.org/D92202 Files: clang-tools-extra/clang

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added a comment. My understanding is that the following current behavour ` asm("AA" : "DEF" : "GHI"); asm volatile( "AAA" : "DEF" : "

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

pvellien updated this revision to Diff 308015. pvellien added a comment. Updated with stanislav comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92115/new/ https://reviews.llvm.org/D92115 Files: clang/test/CodeGenOpenCL/amdgpu-attrs.cl llvm/docs/AMDGPUUsage.rst llvm/lib/Ta

[PATCH] D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage()

kbobyrev added a comment. Hm, yes, this makes sense. I just found it awkward that memory usage estimate will spike right after the first request but that's actually the reality (loading the index is deferred until the first actual index request). My confusion here is that I don't really underst

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

MyDeveloperDay added a comment. 1. You need to default initialize BreakBeforeInlineASMColon in the LLVM style. FormatStyle getLLVMStyle(FormatStyle::LanguageKind Language) { ... LLVMStyle.BreakBeforeInlineASMColon = false; ... 2. You need a "CHECK_PARSE_BOOL" unit

[PATCH] D92221: Don't delete default constructor of PathDiagnosticConsumerOptions

MoritzS created this revision. MoritzS added a reviewer: dergachev.a. Herald added subscribers: cfe-commits, Charusso. Herald added a project: clang. MoritzS requested review of this revision. This type is used as an aggregate, i.e. it has no member functions. Starting with C++20 types with delete

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev updated this revision to Diff 308008. kbobyrev added a comment. Add comments and a check to ensure proper behavior. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92220/new/ https://reviews.llvm.org/D92220 Files: clang-tools-extra/clangd

[PATCH] D89869: [OpenCL] Define OpenCL feature macros for all versions

Anastasia added inline comments. Comment at: clang/include/clang/Basic/OpenCLOptions.h:37 + // OpenCL Version + unsigned CLVer = 120; + bool IsOpenCLCPlusPlus = false; Anastasia wrote: > Anastasia wrote: > > azabaznov wrote: > > > Anastasia wrote: > > > > Ok,

[PATCH] D92220: [clangd] Add support for static fields in rename

kbobyrev created this revision. kbobyrev added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Follow-up on D91952

[PATCH] D92133: [clangd] Cache .clang-tidy files again.

sammccall updated this revision to Diff 308004. sammccall marked 3 inline comments as done. sammccall added a comment. Replace dynamic check with assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92133/new/ https://reviews.llvm.org/D92133 File

[PATCH] D92201: [clangd] Make sure project-aware index is up-to-date for estimateMemoryUsage()

sammccall added a comment. Why do we want to do this? The existing estimate covers the existing loaded data. This change prompts it to load data that we think we might need soon before estimating, but I'm not sure why that's a good thing. (actually I don't think it'll work as if it causes new in

[PATCH] D92202: [clangd] Add symbol origin for remote index

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:164 Result.References = Message.references(); - Result.Origin = static_cast(Messa

[PATCH] D92106: [ASTImporter] Import the default argument of NonTypeTemplateParmDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rG89c1a7a67d69: [ASTImporter] Import the default argument of NonTypeTemplateParmDecl (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] 89c1a7a - [ASTImporter] Import the default argument of NonTypeTemplateParmDecl

Author: Raphael Isemann Date: 2020-11-27T11:40:07+01:00 New Revision: 89c1a7a67d6947f56dc2db189d3872626f5a8609 URL: https://github.com/llvm/llvm-project/commit/89c1a7a67d6947f56dc2db189d3872626f5a8609 DIFF: https://github.com/llvm/llvm-project/commit/89c1a7a67d6947f56dc2db189d3872626f5a8609.dif

[PATCH] D62962: Clang implementation of sizeless types

rsandifo-arm abandoned this revision. rsandifo-arm added a comment. Was superceded by later revisions, but I forgot to close this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62962/new/ https://reviews.llvm.org/D62962 ___

[PATCH] D62961: [AST] Add new Type queries for sizeless types

rsandifo-arm abandoned this revision. rsandifo-arm added a comment. Was superceded by later revisions, but I forgot to close this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62961/new/ https://reviews.llvm.org/D62961 ___

[clang] a2d561f - [SVE] Add a couple of extra sizeless type tests

Author: Richard Sandiford Date: 2020-11-27T10:33:47Z New Revision: a2d561f1a33694a44451b5e0fe2d534522a4ee1d URL: https://github.com/llvm/llvm-project/commit/a2d561f1a33694a44451b5e0fe2d534522a4ee1d DIFF: https://github.com/llvm/llvm-project/commit/a2d561f1a33694a44451b5e0fe2d534522a4ee1d.diff

[PATCH] D79584: [SVE] Add a couple of extra sizeless type tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2d561f1a336: [SVE] Add a couple of extra sizeless type tests (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79584/new/ https://r

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

anastasiia_lukianenko added a comment. Nothing will happen with your examples, because the line length is less than column limit. But if I make parameters longer results will be: BreakBeforeInlineASMColon = false; asm volatile("rbit %[aVal], %[aVal]" : [aVal] "+r"(val)

[PATCH] D92191: [clang-scan-deps] Add support for clang-cl

hans added a comment. Seems reasonable to me, but someone who actually knows clang-scan-deps should take a look too. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:471 +#ifdef _WIN32 +const char *NullFile = "nul"; +#else these string constan

[PATCH] D92211: [clang] Improve diagnostics for auto-return-type function if the return expr contains expr.

hokein added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:3306 StmtResult Sema::ActOnCapScopeReturnStmt(SourceLocation ReturnLoc, Expr *RetValExp) { // If this is the first return we've seen, infer the return type. sammccall wrote: > This seems t

[PATCH] D92211: [clang] Improve diagnostics for auto-return-type function if the return expr contains expr.

hokein updated this revision to Diff 307993. hokein marked 2 inline comments as done. hokein added a comment. address comments and add the missing fix for C++14 `auto func`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92211/new/ https://reviews.l

[PATCH] D84846: [MC] Add support for generating missing GNU build notes

tbaeder added a comment. In D84846#2396303 , @MaskRay wrote: > https://fedoraproject.org/wiki/Toolchain/Watermark Seems that > `.gnu.build.attributes` is used with a GCC plugin (annobin?). The feature on > its own is probably not that useful. `.gnu.linko

[PATCH] D90457: [clang][driver] Set LTO mode based on input files

tbaeder added a comment. In D90457#2390519 , @MaskRay wrote: > Is the motivation just to avoid -flto or -flto=lto at link time? Essentially, yes. Lots of projects seem to depend on this behavior of GCC. I.e. the pass -flto when compiling but not when lin

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5900 + ASSERT_TRUE(ToD); + EXPECT_EQ(FromD->isCopyDeductionCandidate(), ToD->isCopyDeductionCandidate()); + // Check that the deduced class template is also imported. teemperor

[PATCH] D92109: [ASTImporter] Support import of CXXDeductionGuideDecl

martong updated this revision to Diff 307988. martong marked 2 inline comments as done. martong added a comment. - Update test to match the copy deduction guide Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92109/new/ https://reviews.llvm.org/D9210

[PATCH] D82284: [AST][RecoveryAST] Preseve invalid return stmt, and suppress the diagnostics for missing return stmt in constexpr func.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG once D92211 lands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82284/new/ https://reviews.llvm.org/

[PATCH] D92211: [clang] Improve diagnostics for auto-return-type function if the return expr contains expr.

sammccall added a comment. This approach isn't the most obvious one, to me. In the test, the lambda is invalid with `auto` return type, where it seems that valid with `int` return type and a body that contains-errors would be better. I'm guessing this comes down to what fits most naturally in th

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. > - code completion: this shouldn't run plugins I believe: latency is critical > and we don't emit any diagnostics Totally agree. > - main file AST build: Important to run plugins here but it's critical they > don't traverse the whole preamble (can degrade latency by

[PATCH] D82284: [AST][RecoveryAST] Preseve invalid return stmt, and suppress the diagnostics for missing return stmt in constexpr func.

hokein added a comment. sorry for the long delay, picking it up. Comment at: clang/test/SemaCXX/constant-expression-cxx11.cpp:1798 + constexpr int error() { // expected-error {{constexpr function never produces a constant expression}} +return foobar; // expected-error {{u

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon added a comment. In D90944#2419420 , @lebedev.ri wrote: > Please upload all patches with full context (`-U`) Done. > I'm guessing you'll need help committing this, in which case please specify > `Author ` to be used for `git commit --author="

[PATCH] D90944: [clang-tidy] implement concurrency-mt-unsafe

segoon updated this revision to Diff 307981. segoon added a comment. - git diff -U CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90944/new/ https://reviews.llvm.org/D90944 Files: clang-tools-extra/clang-tidy/concurrency/CMakeLists.txt clang-tools-extra/clang-tidy/concurrency/Co

[PATCH] D82284: [AST][RecoveryAST] Preseve invalid return stmt, and suppress the diagnostics for missing return stmt in constexpr func.

hokein updated this revision to Diff 307980. hokein added a comment. rebase and update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82284/new/ https://reviews.llvm.org/D82284 Files: clang/lib/Sema/SemaStmt.cpp clang/test/SemaCXX/constant-expr

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

psionic12 added a comment. > This is exactly the problem, filenames specified in *clang* flags are > *supposed* to be read from the VFS. (In practice this probably just means > we'd need to disable this feature in environments where VFS is used) I don't thinks so, plugins are loaded by using `-

[PATCH] D91656: [clang-tidy] add concurrency module

segoon updated this revision to Diff 307979. segoon added a comment. - git dif -U CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91656/new/ https://reviews.llvm.org/D91656 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangTidyForceLinker.h cl

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

sammccall added a comment. Another consideration I haven't mentioned: clangd parses files in a few different modes. - code completion: this shouldn't run plugins I believe: latency is critical and we don't emit any diagnostics - main file AST build: Important to run plugins here but it's critic

[PATCH] D92211: [clang] Improve diagnostics for auto-return-type function if the return expr contains expr.

hokein added a comment. context: this would fix an issue in https://reviews.llvm.org/D82284. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92211/new/ https://reviews.llvm.org/D92211 ___ cfe-commits maili

[PATCH] D92211: [clang] Improve diagnostics for auto-return-type function if the return expr contains expr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. hokein requested review of this revision. Given the following case: auto k() { return undef(); return 1; } Prior to the patch, clang emits an `cannot initialize return object of type 'aut

[PATCH] D92155: Load plugins when creating a CompilerInvocation.

sammccall added a comment. In D92155#2419346 , @psionic12 wrote: >> clangd (and other clang tools) get deployed in environments where all access >> to the filesystem goes through a llvm::vfs::Filesystem, and all filenames >> referred to in the compile co

[PATCH] D92209: [ASTImporter] Support CXXDeductionGuideDecl with local typedef

martong created this revision. martong added reviewers: teemperor, balazske. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. martong requested review of this revision.