hans added a comment.
Seems reasonable to me, but someone who actually knows clang-scan-deps should
take a look too.
================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:471
+#ifdef _WIN32
+ const char *NullFile = "nul";
+#else
----------------
these string constants should be `const char NullFile[] = ....`
but since it seems you're only using NullFile for the /Fo or -o options below,
I'd suggest just folding it into those options instead. Then you could also
avoid having to do the `(Twine("/Fo") + NullFile).str()` dance and could just
do `push_back ("/Fonul");`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92191/new/
https://reviews.llvm.org/D92191
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
