[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

asbirlea added a comment. I checked in a fix in https://reviews.llvm.org/rGfc8200633122, but I haven't yet verified it addresses all the failures reported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87163/new/ https://reviews.llvm.org/D87163 _

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

ArcsinX updated this revision to Diff 292116. ArcsinX added a comment. Remove {} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87673/new/ https://reviews.llvm.org/D87673 Files: clang-tools-extra/clangd/index/Serialization.cpp Index: clang-tool

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a reviewer: jyknight. sepavloff added a comment. This change is similar to D82782 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 _

[PATCH] D78899: [Driver] Add callback to Command execution

sepavloff updated this revision to Diff 292113. sepavloff added a comment. Rebased patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 Files: clang/include/clang/Driver/Compilation.h clang/lib/Driver/

[clang] 8ea7ef8 - [ThinLTO] Relax thinlto_embed_bitcode.ll check

Author: Mircea Trofin Date: 2020-09-15T22:42:22-07:00 New Revision: 8ea7ef8eda93aa144c339275fc6d9db2615a0118 URL: https://github.com/llvm/llvm-project/commit/8ea7ef8eda93aa144c339275fc6d9db2615a0118 DIFF: https://github.com/llvm/llvm-project/commit/8ea7ef8eda93aa144c339275fc6d9db2615a0118.diff

[libclc] 291bfff - libclc: Add a __builtin to let SPIRV targets select between SW and HW FMA

Author: Daniel Stone Date: 2020-09-16T01:37:22-04:00 New Revision: 291bfff5dbb70360730e91b4019f8080e4e3d7f5 URL: https://github.com/llvm/llvm-project/commit/291bfff5dbb70360730e91b4019f8080e4e3d7f5 DIFF: https://github.com/llvm/llvm-project/commit/291bfff5dbb70360730e91b4019f8080e4e3d7f5.diff

[PATCH] D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class

This revision was automatically updated to reflect the committed changes. Closed by commit rG96c6d012dfe2: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class (authored by zinovy.nis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang-tools-extra] 96c6d01 - [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class

Author: Zinovy Nis Date: 2020-09-16T08:13:00+03:00 New Revision: 96c6d012dfe2492891d0f0450dd7cd5f3c1ca88c URL: https://github.com/llvm/llvm-project/commit/96c6d012dfe2492891d0f0450dd7cd5f3c1ca88c DIFF: https://github.com/llvm/llvm-project/commit/96c6d012dfe2492891d0f0450dd7cd5f3c1ca88c.diff LO

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

Szelethus added a comment. Post-commit LGTM on the post-commit changes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87081/new/ https://reviews.llvm.org/D87081 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D87081: [analyzer][StdLibraryFunctionsChecker] Elaborate the summary of fread and fwrite

martong added a comment. > Actually, the test added here could have catched that regression. Correction: It is the new BufferSize argument constraint in `fread`'s summary and the existing test `test_fread_uninitialized` in `std-c-library-functions.c` that could have catched that regression. (No

[PATCH] D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults

wenlei added subscribers: asbirlea, modimo. wenlei added a comment. Just saw this. Thanks @Alina Sbirlea for fixing the tests, much appreciated! On 9/15/20, 6:44 PM, "Nico Weber via Phabricator" wrote: thakis added a comment. Looks like this breaks tests: https://urldefense.proofpoint

[PATCH] D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM

Conanap accepted this revision. Conanap added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87729/new/ https://reviews.llvm.org/D87729 ___

[PATCH] D87737: Add -fprofile-update={atomic,prefer-atomic,single}

MaskRay created this revision. MaskRay added reviewers: davidxl, vsk, xur. Herald added subscribers: cfe-commits, dang, jfb. Herald added a project: clang. MaskRay requested review of this revision. GCC 7 introduced -fprofile-update={atomic,prefer-atomic} (prefer-atomic is for best efforts (some t

[PATCH] D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM

Conanap requested changes to this revision. Conanap added a comment. This revision now requires changes to proceed. Looks like there's some unit test failures; could you double check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87729/new/ https:/

[PATCH] D87352: Fix typo

YangZhihui updated this revision to Diff 292076. YangZhihui retitled this revision from "Fix typo in Format.h" to "Fix typo". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87352/new/ https://reviews.llvm.org/D87352 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/For

[PATCH] D87629: Thread safety analysis: Improve documentation for ASSERT_CAPABILITY

ryanofsky added a comment. Great feedback! I need to absorb it all then I'll fix the changeset. The mistakes about exceptions came from me taking "(no return)" in the previous documentation too literally thinking it was referring to https://en.cppreference.com/w/cpp/language/attributes/noreturn

[PATCH] D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults

thakis added a comment. Looks like this breaks tests: http://45.33.8.238/linux/27942/step_12.txt Ptal, and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 ___

[PATCH] D85685: Support dwarf fission for wasm object files

sbc100 added a comment. Seems reasonable. Do you think this way is cleaner than the way elf does it? Looks like ELF creates two different ELFWriter inside the ELFDwoObjectWriter subclass right? Are we going need to wasm-ld tests to followup or is this really independent of the linker? =

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); phosek wrote: > andrewjcg wrote

[PATCH] D31413: [libc++] Use __attribute__((init_priority(101))) to ensure streams get initialized early

sbc100 added a comment. This came up again in wasi-sdk: https://github.com/WebAssembly/wasi-sdk/issues/153 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31413/new/ https://reviews.llvm.org/D31413 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D85685: Support dwarf fission for wasm object files

dschuff added a comment. OK, I think this is ready to review for real. Can you take another look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 ___ cfe-commits

[PATCH] D82118: [clang][module] Improve incomplete-umbrella warning

zixuw updated this revision to Diff 292058. zixuw added a comment. Address review: - Use explicit type name `Module::Header` instead of `auto` since it's a short typename and using `auto` does not improve readability; - Change variable `EndLoc` to `ExpectedHeadersLoc` so it's self-explanatory.

[PATCH] D85685: [WIP] Support dwarf fission for wasm object files

dschuff updated this revision to Diff 292056. dschuff added a comment. Herald added subscribers: sstefan1, ormris, jgravelle-google. Herald added a reviewer: jdoerfert. upload the correct diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/

[PATCH] D87394: [PowerPC][Power10] Implementation of 128-bit Binary Vector Mod and Sign Extend builtins

amyk requested changes to this revision. amyk added a comment. This revision now requires changes to proceed. A question I have is, is it possible for the 128-bit vector modulo instructions be open coded? Comment at: clang/lib/Headers/altivec.h:17394 +static __inline__ vector

[PATCH] D85685: [WIP] Support dwarf fission for wasm object files

dschuff updated this revision to Diff 292055. dschuff added a comment. Get the right sections in the objects, add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85685/new/ https://reviews.llvm.org/D85685 Files: llvm/lib/MC/WasmObjectWriter.

[PATCH] D87729: [PowerPC] Implement the 128-bit Vector Divide Extended Builtins in Clang/LLVM

amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, Conanap, nemanjai. amyk added projects: LLVM, PowerPC. Herald added subscribers: shchenz, hiraditya. Herald added a project: clang. amyk requested review of this revision. This patch implements the 128-bit vector divide ex

[PATCH] D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults

wenlei added a comment. Committed on behalf of @modimo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ea4c2c598b7: [BFI] Make BFI information available through loop passes inside… (authored by wenlei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/

[PATCH] D86156: [BFI] Make BFI information available through loop passes inside LoopStandardAnalysisResults

modimo updated this revision to Diff 292044. modimo added a comment. Rebase #2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86156/new/ https://reviews.llvm.org/D86156 Files: llvm/include/llvm/Analysis/LoopAnalysisManager.h llvm/include/llvm/Transforms/Scalar/LoopPassManager.h ll

[PATCH] D87636: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61fc10d6a520: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode (authored by mtrofin). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 61fc10d - [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

Author: Mircea Trofin Date: 2020-09-15T15:56:11-07:00 New Revision: 61fc10d6a520f267e11009ce8fce88d73615796b URL: https://github.com/llvm/llvm-project/commit/61fc10d6a520f267e11009ce8fce88d73615796b DIFF: https://github.com/llvm/llvm-project/commit/61fc10d6a520f267e11009ce8fce88d73615796b.diff

[clang] ae726fe - [SourceManager] Explicitly check for potential iterator underflow

Author: Jan Korous Date: 2020-09-15T15:54:16-07:00 New Revision: ae726fecae9a1cc9c50de5a9f6e860056f82c556 URL: https://github.com/llvm/llvm-project/commit/ae726fecae9a1cc9c50de5a9f6e860056f82c556 DIFF: https://github.com/llvm/llvm-project/commit/ae726fecae9a1cc9c50de5a9f6e860056f82c556.diff LO

[PATCH] D86231: [SourceManager] Explicitly check for potential iterator underflow

This revision was automatically updated to reflect the committed changes. Closed by commit rGae726fecae9a: [SourceManager] Explicitly check for potential iterator underflow (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github M

[PATCH] D87636: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

mtrofin updated this revision to Diff 292041. mtrofin marked 3 inline comments as done. mtrofin added a comment. comment update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87636/new/ https://reviews.llvm.org/D87636 Files: clang/lib/CodeGen/Bac

[PATCH] D87636: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

mtrofin added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:368 + LLVM_DEBUG( + dbgs() << "Post-ThinLTO merge bitcode embedding was requested, but " +"command line arguments are not available"); tejohnson wrote: > Upda

[PATCH] D87636: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. LGTM, just needs a comment update as noted below and also an update to the patch title. Comment at: llvm/lib/LTO/LTOBackend.cpp:368 + LLVM_DEBUG( + dbgs(

[PATCH] D87636: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

mtrofin updated this revision to Diff 292040. mtrofin added a comment. feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87636/new/ https://reviews.llvm.org/D87636 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/Inputs/start-l

[PATCH] D87636: [ThinLTO] add post-thinlto-merge option to -lto-embed-bitcode

tejohnson added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:621 +"command line arguments are not available"); +llvm::EmbedBitcodeInModule(Mod, llvm::MemoryBufferRef(), + /*EmbedBitcode*/ true, How

[PATCH] D84887: [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3842d60351: [OPENMP]Fix codegen for is_device_ptr component, captured by reference. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84

[clang] 9e3842d - [OPENMP]Fix codegen for is_device_ptr component, captured by reference.

Author: Alexey Bataev Date: 2020-09-15T17:21:38-04:00 New Revision: 9e3842d60351f986d77dfe0a94f76e4fd895f188 URL: https://github.com/llvm/llvm-project/commit/9e3842d60351f986d77dfe0a94f76e4fd895f188 DIFF: https://github.com/llvm/llvm-project/commit/9e3842d60351f986d77dfe0a94f76e4fd895f188.diff

[PATCH] D87710: [clangd] Actually parse Index section of the YAML file.

kadircet added a comment. oh shoot, thanks for catching this. i'll leave the stamp to sam, just came here to remind that this needs to be cherry-picked into release branch :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87710/new/ https://reviews

[PATCH] D87450: [clangd] Implement hot index reloading for clangd-index-server

kadircet added a comment. oops, looks like i forgot to hit submit in the morning.. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:228 + auto Status = FS->status(IndexPath); + if (!Status || Status->equivalent(LastStatus)) +return; i b

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Basic/Attr.td:2134 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; + let Args = [StringArgument<"Swif

[PATCH] D87534: Sema: introduce `__attribute__((__swift_name__))`

compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2173 + SubjectList<[Enum, EnumConstant, Field, Function, GlobalVar, Struct, TypedefName, + ObjCInterface, ObjCClassMethod, ObjCInstanceMethod, ObjCProperty, ObjCProtocol], +

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd updated this revision to Diff 292018. compnerd added a comment. Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87532/new/ https://reviews.llvm.org/D87532 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Bas

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

tra added a comment. In D84362#2275029 , @yaxunl wrote: > Perhaps we could inherit `PartialDiagnostic` from `DiagnosticBuilder` base class. This would probably be the least invasive approach as it would preserve existing uses while allowing reuse of co

[PATCH] D86369: [Sema][MSVC] warn at dynamic_cast when /GR- is given

zequanwu updated this revision to Diff 292017. zequanwu added a comment. reopen the diff and update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86369/new/ https://reviews.llvm.org/D86369 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

asbirlea added a comment. Right! I believe the solution is to set the location size to unknown after a phi translation with the same ptr, but I need to properly verify that. // include/llvm/Analysis/MemorySSA.h:1233 CurrentPair.second = Location.getWithNewSize(LocationSize::unknown()); ret

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2134 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; + let Args = [StringArgument<"SwiftType">]; aaron.ballman wrote: > I

[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: clang. compnerd requested review of this revision. This attribute allows declarations to be restricted to the framework itself, enabling Swift to remove the declarations when importing libraries. Thi

[PATCH] D87396: Sema: add support for `__attribute__((__swift_bridged_typedef__))`

This revision was automatically updated to reflect the committed changes. Closed by commit rG7d26d6a1b062: Sema: add support for `__attribute__((__swift_bridged_typedef__))` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D87396?vs=291687&id=292009#toc Repository: r

[clang] 7d26d6a - Sema: add support for `__attribute__((__swift_bridged_typedef__))`

Author: Saleem Abdulrasool Date: 2020-09-15T20:15:34Z New Revision: 7d26d6a1b062f7ce820b02b39d102d5f8f15fa5f URL: https://github.com/llvm/llvm-project/commit/7d26d6a1b062f7ce820b02b39d102d5f8f15fa5f DIFF: https://github.com/llvm/llvm-project/commit/7d26d6a1b062f7ce820b02b39d102d5f8f15fa5f.diff

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2275058 , @asbirlea wrote: > Yes, the load should have the Phi as the defining access. I'm still looking > into where this information should come from, but it's not hitting the phi > translation. > Thank you for the reve

[PATCH] D87717: [docs] Update ControlFlowIntegrity.rst.

eugenis created this revision. eugenis added a reviewer: pcc. Herald added a subscriber: dexonsmith. Herald added a project: clang. eugenis requested review of this revision. Herald added a subscriber: aheejin. Expand the list of targets that support cfi-icall. Add ThinLTO everywhere LTO is mentio

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

asbirlea added a comment. Yes, the load should have the Phi as the defining access. I'm still looking into where this information should come from, but it's not hitting the phi translation. Thank you for the revert, I'll update with the fix once I have it available. Repository: rG LLVM Githu

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1a3ab904439: [clang] Add a command line flag for the Machine Function Splitter. (authored by snehasish). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87047

[clang] f1a3ab9 - [clang] Add a command line flag for the Machine Function Splitter.

Author: Snehasish Kumar Date: 2020-09-15T12:41:58-07:00 New Revision: f1a3ab904439a63b21ba1c4521765c46630687c6 URL: https://github.com/llvm/llvm-project/commit/f1a3ab904439a63b21ba1c4521765c46630687c6 DIFF: https://github.com/llvm/llvm-project/commit/f1a3ab904439a63b21ba1c4521765c46630687c6.dif

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

efriedma added a comment. Also, it would be nice to have some regression test coverage; add a Solaris RUN line to llvm/test/CodeGen/X86/stack-align2.ll ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87615/new/ https://reviews.llvm.org/D87615 ___

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

yaxunl added a comment. In D84362#2274884 , @tra wrote: > In D84362#2274790 , @yaxunl wrote: > >> There are use patterns expecting `PartialDiagnosticInst << X << Y` to >> continue to be a `PartialDiagnostic&`, e.g.

[PATCH] D87615: [X86] Fix stack alignment on 32-bit Solaris/x86

efriedma added inline comments. Comment at: llvm/lib/Target/X86/X86Subtarget.cpp:270 + else if (isTargetSolaris() && !In64BitMode) +stackAlignment = Align(4); stackAlignment is initialized to 4 in the header, so `stackAlignment = Align(4)` here is a no-op

[clang] 05aa997 - [PowerPC] Implement __int128 vector divide operations

Author: Albion Fung Date: 2020-09-15T15:19:35-04:00 New Revision: 05aa997d511eed530305e2f3aa401584d0691186 URL: https://github.com/llvm/llvm-project/commit/05aa997d511eed530305e2f3aa401584d0691186 DIFF: https://github.com/llvm/llvm-project/commit/05aa997d511eed530305e2f3aa401584d0691186.diff L

[PATCH] D85453: [PowerPC] Implement __int128 vector divide operations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05aa997d511e: [PowerPC] Implement __int128 vector divide operations (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D8545

[PATCH] D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. zequanwu marked an inline comment as done. Closed by commit rGf975ae4867d1: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time (authored by zequa

[clang] f975ae4 - [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

Author: Zequan Wu Date: 2020-09-15T12:15:47-07:00 New Revision: f975ae4867d1fdfaba11a3ec7e479da8fbfd82d8 URL: https://github.com/llvm/llvm-project/commit/f975ae4867d1fdfaba11a3ec7e479da8fbfd82d8 DIFF: https://github.com/llvm/llvm-project/commit/f975ae4867d1fdfaba11a3ec7e479da8fbfd82d8.diff LOG

[PATCH] D87588: [ASTMatchers] extract public matchers from const-analysis into own patch

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG69f98311ca42: [ASTMatchers] extract public matchers from const-ana

[clang] 69f9831 - [ASTMatchers] extract public matchers from const-analysis into own patch

Author: Jonas Toth Date: 2020-09-15T21:07:30+02:00 New Revision: 69f98311ca42127df92527b6fc3be99841a15f12 URL: https://github.com/llvm/llvm-project/commit/69f98311ca42127df92527b6fc3be99841a15f12 DIFF: https://github.com/llvm/llvm-project/commit/69f98311ca42127df92527b6fc3be99841a15f12.diff LO

[PATCH] D87588: [ASTMatchers] extract public matchers from const-analysis into own patch

JonasToth updated this revision to Diff 291996. JonasToth added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87588/new/ https://reviews.llvm.org/D87588 Files: clang/docs/LibASTMatchersReference.html clang/include/clang/AST

[PATCH] D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/SemaCXX/constant-expression-cxx2a.cpp:312 // expected-note@+1 {{typeid applied to object 'extern_b2' whose dynamic type is not constant}} - stati

[PATCH] D87607: [clang][aarch64] Support implicit casts between GNU and SVE vectors

efriedma added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8522 + return VT->getElementType().getCanonicalType() == + getBuiltinVectorTypeInfo(BT).ElementType; } c-rhodes wrote: > efriedma wrote: > > We allow casting

[PATCH] D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87627/new/ https://reviews.llvm.org/D87627 ___ cfe-commits mailing list

[PATCH] D87532: Sema: add support for `__attribute__((__swift_bridge__))`

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:2134 +def SwiftBridge : Attr { + let Spellings = [GNU<"swift_bridge">]; + let Args = [StringArgument<"SwiftType">]; Is it intentional that this is `swift_bridge` but we just adde

[PATCH] D87561: [Sema] List conversion validate character array

Mordante marked 2 inline comments as done. Mordante added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:4989 +if (ToType->isArrayType() && ToType->isCharType() && +isa(From->getInit(0))) { InitializedEntity Entity = rsmith wrote:

[PATCH] D83154: clang: Add -fcoverage-prefix-map

phosek added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); andrewjcg wrote: > keith wrote

[PATCH] D87321: Fix -gz=zlib options for linker

yaxunl added a comment. In D87321#2274731 , @nemanjai wrote: > This broke the PPC LLD bot and the failure has been ignored for 4 days. I > believe it should be fixed with 3bc3983f229 >

[PATCH] D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

gribozavr2 added a comment. In D87683#2274883 , @martong wrote: > In D87683#2274663 , > @baloghadamsoftware wrote: > >> In D87683#2274569 , @njames93 wrote: >> >>> Please fi

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

tra added a comment. In D84362#2274790 , @yaxunl wrote: > There are use patterns expecting `PartialDiagnosticInst << X << Y` to > continue to be a `PartialDiagnostic&`, e.g. > > PartialDiagnosticAt PDAt(SourceLoc, PartialDiagnosticInst << X << Y); > > H

[PATCH] D87683: [clang-tidy] Crash fix for bugprone-misplaced-pointer-arithmetic-in-alloc

martong added a comment. In D87683#2274663 , @baloghadamsoftware wrote: > In D87683#2274569 , @njames93 wrote: > >> Please fix the test case first, can't call `operator new(unsigned long, >> void*)` with an argume

[PATCH] D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

zequanwu marked 4 inline comments as done. zequanwu added inline comments. Comment at: clang/test/SemaCXX/constant-expression-cxx2a.cpp:312 // expected-note@+1 {{typeid applied to object 'extern_b2' whose dynamic type is not constant}} - static_assert(&typeid(extern_b2) == &

[PATCH] D87425: [CodeGen][typeid] Emit typeinfo directly if type is known at compile-time

zequanwu updated this revision to Diff 291988. zequanwu added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87425/new/ https://reviews.llvm.org/D87425 Files: clang/include/clang/AST/ExprCXX.h clang/lib/AST/ExprCXX.c

[PATCH] D83154: clang: Add -fcoverage-prefix-map

andrewjcg added inline comments. Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:1334 + llvm::SmallString<256> Path(Filename); + llvm::sys::fs::make_absolute(Path); + llvm::sys::path::remove_dots(Path, /*remove_dot_dot=*/true); keith wrote: > rnk wrote: >

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish added a comment. Thanks for the review. Comment at: clang/include/clang/Driver/Options.td:2000 +defm split_machine_functions: OptInFFlag<"split-machine-functions", + "Enable", "Disable", " late function splitting using profile information (x86-elf only)">; + ---

[PATCH] D87047: [clang] Add command line options for the Machine Function Splitter.

snehasish updated this revision to Diff 291986. snehasish marked 2 inline comments as done. snehasish added a comment. Update the test. - Added "warning: " prefix to be checked. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87047/new/ https://revi

[PATCH] D87701: Do not apply calling conventions to MSVC entry points

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87701/new/ https://reviews.llvm.org/D87701 ___ cfe-commits mailing list cfe-commits@

[PATCH] D86048: [AST][RecoveryExpr] Popagate the error-bit from a VarDecl's initializer to DeclRefExpr.

hokein added a comment. In D86048#2270400 , @rsmith wrote: > In D86048#2254607 , @sammccall wrote: > >> The crux is we're forcing `decltype(N)` to be a (unique) dependent type, >> which feels wrong. >> [...] >> The

[PATCH] D87710: [clangd] Actually parse Index section of the YAML file.

adamcz created this revision. adamcz added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. adamcz requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This fixes a bug in dbf486c0de

[PATCH] D87470: [Coroutine][Sema] Tighten the lifetime of symmetric transfer returned handle

lxfind added a comment. In D87470#2273310 , @junparser wrote: > @lxfind , could you backport this to branch 11? I am actually seeing some problems with this change. Still investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

yaxunl added a comment. In D84362#2274315 , @aaron.ballman wrote: > In D84362#2271585 , @tra wrote: > >> So, the idea here is to do some sort of duck-typing and allow DiagBuilder to >> work with both `DiagnosticBu

[PATCH] D86558: [OPENMP]Add support for allocate vars in untied tasks.

This revision was automatically updated to reflect the committed changes. Closed by commit rG738bab743b5c: [OPENMP]Add support for allocate vars in untied tasks. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86558/new/ https:/

[clang] 738bab7 - [OPENMP]Add support for allocate vars in untied tasks.

Author: Alexey Bataev Date: 2020-09-15T13:39:14-04:00 New Revision: 738bab743b5c6cfcf1a1feb116de9e35a3f1e326 URL: https://github.com/llvm/llvm-project/commit/738bab743b5c6cfcf1a1feb116de9e35a3f1e326 DIFF: https://github.com/llvm/llvm-project/commit/738bab743b5c6cfcf1a1feb116de9e35a3f1e326.diff

[PATCH] D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class

zinovy.nis added a comment. Done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87627/new/ https://reviews.llvm.org/D87627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D87627: [clang-tidy] Fix crash in modernize-use-noexcept on uninstantiated throw class

zinovy.nis updated this revision to Diff 291971. zinovy.nis marked 2 inline comments as done. zinovy.nis added a comment. - Fixed the test. - Fixed clang-format issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87627/new/ https://reviews.llvm.org/D87627 Files: clang-tools-extra/c

[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

adamcz accepted this revision. adamcz added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/index/Serialization.cpp:209 Uncompressed = UncompressedStorage; + } else { +return error("Compressed string table, but zlib

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

nemanjai added a comment. Yes, this definitely needs a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84962/new/ https://reviews.llvm.org/D84962 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D87321: Fix -gz=zlib options for linker

nemanjai added a comment. This broke the PPC LLD bot and the failure has been ignored for 4 days. I believe it should be fixed with 3bc3983f229 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[clang] 3bc3983 - Fix bot failure after ccb4124a4172

Author: Nemanja Ivanovic Date: 2020-09-15T12:36:47-05:00 New Revision: 3bc3983f229f9277d5bea3692b691f72ab8740dd URL: https://github.com/llvm/llvm-project/commit/3bc3983f229f9277d5bea3692b691f72ab8740dd DIFF: https://github.com/llvm/llvm-project/commit/3bc3983f229f9277d5bea3692b691f72ab8740dd.di

[PATCH] D87451: add new clang option -mignore-xcoff-visibility

DiggerLin updated this revision to Diff 291962. DiggerLin retitled this revision from "add new clang option -fnovisibility." to "add new clang option -mignore-xcoff-visibility". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87451/new/ https://review

[PATCH] D87163: [DSE] Switch to MemorySSA-backed DSE by default.

fhahn added a comment. In D87163#2274549 , @dmajor wrote: > Reduced a bit more: https://godbolt.org/z/j59evK (C++) and > https://godbolt.org/z/8xG688 (IR) -- the store at line 43 of `while.end` has > been removed. Thanks! I reverted the change for now i

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. In D83004#2274573 , @greened wrote: > In D83004#2168427 , @jdoerfert wrote: > >> Due to D82995 I realized we should have a >> test of this in `llvm/test/

[PATCH] D86694: [scudo] Allow -fsanitize=scudo on Linux and Windows (WIP, don't land as is)

cryptoad added a comment. In D86694#2274548 , @russell.gallop wrote: > I guess using scudo as a general purpose allocator that could set a limit on > the number of cores that can be used at once as @aganea found. Would there be > any problem with making

[clang] 3a59628 - Revert "[DSE] Switch to MemorySSA-backed DSE by default."

Author: Florian Hahn Date: 2020-09-15T18:07:56+01:00 New Revision: 3a59628f3cc26eb085acfc9cbdc97243ef71a6c5 URL: https://github.com/llvm/llvm-project/commit/3a59628f3cc26eb085acfc9cbdc97243ef71a6c5 DIFF: https://github.com/llvm/llvm-project/commit/3a59628f3cc26eb085acfc9cbdc97243ef71a6c5.diff

  1   2   3   >