[clang] fcf8ada - [Driver] Render -e for Gnu.cpp

Author: Fangrui Song Date: 2020-07-30T23:49:32-07:00 New Revision: fcf8ada18f9cfb1261262e4b0399ae9ab40451f8 URL: https://github.com/llvm/llvm-project/commit/fcf8ada18f9cfb1261262e4b0399ae9ab40451f8 DIFF: https://github.com/llvm/llvm-project/commit/fcf8ada18f9cfb1261262e4b0399ae9ab40451f8.diff

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 282145. TaWeiTu added a comment. Fix LoopRotate/pr35210.ll (sync with commit b36c39260edcded47436f344e48f78cfbedac494 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84987: Pass bugreport URL to standalone clang build

mgorny added a comment. In D84987#2186113 , @MaskRay wrote: > I am not familiar with the standalone clang build. Can you share a command? You install LLVM first, then run `cmake /clang` and build it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] c03d3ac - [test] Fix thinlto-distributed-newpm.ll

Author: Arthur Eubanks Date: 2020-07-30T20:09:34-07:00 New Revision: c03d3aca7d00db61eece554b7c4a9d921c1aff05 URL: https://github.com/llvm/llvm-project/commit/c03d3aca7d00db61eece554b7c4a9d921c1aff05 DIFF: https://github.com/llvm/llvm-project/commit/c03d3aca7d00db61eece554b7c4a9d921c1aff05.diff

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

tlively added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsWebAssembly.td:198 +[LLVMPointerType], +[IntrReadMem, IntrArgMemOnly, IntrSpeculatable], + "", [SDNPMemOperand]>; aheejin wrote: > Can memory accesses be

[PATCH] D84992: [clang codegen] Use IR "align" attribute for static array arguments.

efriedma created this revision. efriedma added a reviewer: rjmccall. Herald added a project: clang. efriedma requested review of this revision. Without the "align" attribute, marking the argument dereferenceable is basically useless. See also D80166 . Fixes http

[PATCH] D84414: [RISCV] Support Shadow Call Stack

jrtc27 added a comment. There is a possibly-compelling argument against using x18: RV32E only gives x0-x15, so would not be able to support the current implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84414/new/ https://reviews.llvm.o

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane marked 2 inline comments as done. erichkeane added a comment. Thanks! I'm done for the day, so I'll push in the morning when I'll have a few hours to respond to build bots. Thanks again! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84048/new/ https://reviews.llvm.org/D840

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith added a comment. In D84637#2175681 , @erichkeane wrote: > Based on richard's suggestions, that seems about right. However I believe > all the asserts should have a message to go along with them as we typicaly do. In this case, the asserts are enf

[PATCH] D84637: [AST] Enhance the const expression evaluator to support error-dependent exprs.

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4876 +assert(E->containsErrors()); +return ESR_Failed; + } This should not result in failure when checking for a potential constant expression; if an expression contain

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, looks nice =) Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:1205 +/// Attempt to deduce the template arguments by checking the base types +/// according to (

[PATCH] D84987: Pass bugreport URL to standalone clang build

MaskRay added a comment. I am not familiar with the standalone clang build. Can you share a command? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84987/new/ https://reviews.llvm.org/D84987 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D84988: WIP [Coverage] Add empty line regions to SkippedRegions

zequanwu created this revision. zequanwu added a reviewer: vsk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. zequanwu requested review of this revision. Add a hook to track empty line regions when lexing. But the performance is slowed down by

[PATCH] D84703: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dfb5d767e70: [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary (authored by efriedma). Changed prior to commit: https:

[clang] 8dfb5d7 - [clang codegen][AArch64] Use llvm.aarch64.neon.fcvtzs/u where it's necessary

Author: Eli Friedman Date: 2020-07-30T15:41:54-07:00 New Revision: 8dfb5d767e70dd862096c8872fd3e3bead99741d URL: https://github.com/llvm/llvm-project/commit/8dfb5d767e70dd862096c8872fd3e3bead99741d DIFF: https://github.com/llvm/llvm-project/commit/8dfb5d767e70dd862096c8872fd3e3bead99741d.diff

[PATCH] D84987: Pass bugreport URL to standalone clang build

mgorny created this revision. mgorny added reviewers: john.brawn, MaskRay, chapuni. Herald added a project: LLVM. mgorny requested review of this revision. BUG_REPORT_URL is currently used both in LLVM and in Clang but declared only in the latter. This means that it's missing in standalone clang

[PATCH] D66564: [clang-tidy] new altera struct pack align check

njames93 added a comment. In D66564#2185335 , @ffrankies wrote: > Is there a way around this? And if not, do we ignore it? Lastly, do I need to > do anything else since this check has been accepted? There is a "Close > Revision" action in the comments, b

[PATCH] D84926: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap

This revision was automatically updated to reflect the committed changes. Closed by commit rGc23ae3f18ee3: [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84

[clang-tools-extra] c23ae3f - [clang-tidy][NFC] Use StringMap for ClangTidyCheckFactories::FacoryMap

Author: Nathan James Date: 2020-07-30T22:57:33+01:00 New Revision: c23ae3f18ee3ff11671f4c62ffc66d150b1bcdc2 URL: https://github.com/llvm/llvm-project/commit/c23ae3f18ee3ff11671f4c62ffc66d150b1bcdc2 DIFF: https://github.com/llvm/llvm-project/commit/c23ae3f18ee3ff11671f4c62ffc66d150b1bcdc2.diff

[clang] 1e7f026 - PR46908: Emit undef destroying_delete_t as an aggregate RValue.

Author: Richard Smith Date: 2020-07-30T14:50:01-07:00 New Revision: 1e7f026c3b59bea22491819f86d8388d0c3e0c07 URL: https://github.com/llvm/llvm-project/commit/1e7f026c3b59bea22491819f86d8388d0c3e0c07 DIFF: https://github.com/llvm/llvm-project/commit/1e7f026c3b59bea22491819f86d8388d0c3e0c07.diff

[PATCH] D84929: [analyzer] Fix out-of-tree only clang build by not relaying on private header

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Seems to work fine for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84929/new/ https://reviews.llvm.org/D84929 ___

[PATCH] D84975: [clangd][WIP] Make use of SyntaxTrees for SemanticSelection

gribozavr2 added inline comments. Comment at: clang-tools-extra/clangd/SemanticSelection.cpp:51 +syntax::Leaf *leafContaining(const syntax::Token *Tok, syntax::Tree *Root, + syntax::Arena &A, const SourceManager &SM) { + if (!Tok) It

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai updated this revision to Diff 282035. vsapsai added a comment. Rebased the change to make sure it still works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263 Files: clang/lib/Lex/HeaderSearch.cpp

[PATCH] D68997: Allow searching for prebuilt implicit modules.

Bigcheese added inline comments. Comment at: clang/docs/Modules.rst:231 + prebuilt modules paths (specified via ``-fprebuilt-module-path``), we will + look for a matching implicit modules in the prebuilt modules paths. + Comment at: clang/do

[PATCH] D83999: [CMake][Fuchsia] Include additional tools in the toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff7dcded213: [CMake][Fuchsia] Include additional tools in the toolchain (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 3ff7dcd - [CMake][Fuchsia] Include additional tools in the toolchain

Author: Petr Hosek Date: 2020-07-30T13:08:02-07:00 New Revision: 3ff7dcded213844bcb0c1d55a1a66ad8fd9b483b URL: https://github.com/llvm/llvm-project/commit/3ff7dcded213844bcb0c1d55a1a66ad8fd9b483b DIFF: https://github.com/llvm/llvm-project/commit/3ff7dcded213844bcb0c1d55a1a66ad8fd9b483b.diff LO

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CStringChecker/CStringLength.h:43 + ProgramStateRef &State, const Expr *Ex, + SVal Buf, bool Hypothetical = false); +

[PATCH] D84979: [analyzer][NFC] Refine CStringLength modeling API

steakhal created this revision. steakhal added reviewers: NoQ, Szelethus, xazax.hun, baloghadamsoftware, vsavchenko, martong, gamesh411. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Herald added a pro

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1865 +if (isSpecialLLVMGlobalArrayForStaticInit(&G)) { + if (GlobalUniqueModuleId.empty()) { +GlobalUniqueModuleId = getUniqueModuleId(&M); We will need to move

[PATCH] D84975: [clangd][WIP] Make use of SyntaxTrees for SemanticSelection

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kadircet requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This patch is not intended for production, it is merely an experiment to

[PATCH] D84973: [clang][Syntax] syntax::Arena doesnt own TokenBuffer

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95. Herald added a project: clang. kadircet requested review of this revision. Herald added a subscriber: ilya-biryukov. Currently an Arena can only be built while consuming a TokenBuffer, some users (like clangd) might

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

jasonliu added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:24 #include "llvm/Support/Path.h" #include "llvm/Transforms/Utils/ModuleUtils.h" We are removing the usage of "getUniqueModuleId" in this file, So I assume this include could get rem

[PATCH] D84820: [WebAssembly] Implement prototype v128.load{32,64}_zero instructions

tlively updated this revision to Diff 282017. tlively added a comment. - Remove IntrSpeculatable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84820/new/ https://reviews.llvm.org/D84820 Files: clang/include/clang/Basic/BuiltinsWebAssembly.def

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. looks great, I'll complete libbpf support for all these ASAP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm

[PATCH] D84970: Adjust all existing tests.

hokein created this revision. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. hokein requested review of this revision. Herald added a subscriber: wuzish. DO NOT SUBMIT, enable the recovery-ast for C by default. Repository: rG LLVM Github Mono

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 ___ c

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 282010. saiislam added a comment. Changes as requested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CGOpe

[PATCH] D84968: [PowerPC] Legalize v256i1 and v512i1 and implement load and store of these types

bsaleil created this revision. bsaleil added reviewers: PowerPC, nemanjai, lei, hfinkel. bsaleil added projects: PowerPC, LLVM. Herald added subscribers: llvm-commits, cfe-commits, shchenz, kbarton, hiraditya. Herald added a project: clang. bsaleil requested review of this revision. Herald added a

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeAMDGCN.h:30-31 + + /// Declare AMDGCN specific specialization of functions which + /// have been generalized as virtual functions in CGOpenMPRuntimeGPU + These 2 lines can be removed, t

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

riccibruno updated this revision to Diff 281999. riccibruno edited the summary of this revision. riccibruno added a comment. Rebased with a few clang-format fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81003/new/ https://reviews.llvm.org/D8

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 282002. saiislam added a comment. Improved comment placement. Corrected check lines. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeGe

[PATCH] D84962: [PowerPC] Correct cpsgn's behaviour on PowerPC to match that of the ABI

Conanap created this revision. Conanap added reviewers: PowerPC, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, clang, PowerPC. Herald added subscribers: cfe-commits, shchenz. Conanap requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8496

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

NeHuang added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:13422 + return DAG.getMemIntrinsicNode(PPCISD::LXVRZX, dl, +DAG.getVTList(MVT::v1i128, MVT::Other), +LoadOps, MemoryType, LD->get

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281985. TaWeiTu removed reviewers: jdoerfert, sstefan1, DavidTruby, aartbik, ftynse, baziotis, libc++. TaWeiTu removed projects: MLIR, libc-project, OpenMP, libc++, LLDB, Sanitizers. TaWeiTu added a comment. Propagate the requirement of MemorySSA from loop pa

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies added a comment. Posted this as an inline comment, copying here: I tried to move this into the matcher like this: Finder->addMatcher(recordDecl(isStruct(), isDefinition(), unless(isExpansionInSystemHeader()), unless(isTe

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 281974. Conanap marked 2 inline comments as done. Conanap removed a reviewer: power-llvm-team. Conanap added a comment. Herald added a subscriber: kbarton. Some updates on formatting and updated to match an updated test file. Repository: rG LLVM Github Mon

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

yamauchi added a comment. Yup, -pgo-instr-old-cfg-hashing=true to revert back to the old hashing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84782/new/ https://reviews.llvm.org/D84782 ___ cfe-commits

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay added a comment. It is also a convention to explain what has changed compared with the initial land. As a hindsight, the option `-pgo-instr-old-cfg-hashing` should probably have been mentioned in the description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D84782: [PGO] Include the mem ops into the function hash.

MaskRay closed this revision. MaskRay added a comment. Relanded as 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d @yamauchi For a reland, you still need to include `Differential Revision: ` so that the differential can be closed au

[PATCH] D84774: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG555cf42f380d: [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations (authored by ychen). Repository: rG LLVM Github Monorepo

[clang] 555cf42 - [NewPM][PassInstrument] Add PrintPass callback to StandardInstrumentations

Author: Yuanfang Chen Date: 2020-07-30T10:07:57-07:00 New Revision: 555cf42f380d86f35e761c3a2179c761356ab152 URL: https://github.com/llvm/llvm-project/commit/555cf42f380d86f35e761c3a2179c761356ab152 DIFF: https://github.com/llvm/llvm-project/commit/555cf42f380d86f35e761c3a2179c761356ab152.diff

[PATCH] D82317: [Clang/Test]: Update tests where `noundef` attribute is necessary

guiand added a comment. @jdoerfert what would the procedure be for reviewing these test changes / getting this landed with the noundef patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82317/new/ https://reviews.llvm.org/D82317 ___

[PATCH] D84908: [darwin][compiler-rt] build libclang_rt.sim.a Apple Silicon slice, if SDK supports it

arphaman updated this revision to Diff 281963. arphaman added a comment. don't check if the SDK isn't present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84908/new/ https://reviews.llvm.org/D84908 Files: compiler-rt/cmake/builtin-config-ix.cmake Index: compiler-rt/cmake/builtin-

[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:109 SourceMgr(Diags, Files), Context(Context), ApplyFixes(ApplyFixes), -TotalFixes(0), AppliedFixes(0), WarningsAsErrors(0) { +

[clang] 3d6f530 - [PGO] Include the mem ops into the function hash.

Author: Hiroshi Yamauchi Date: 2020-07-30T09:26:20-07:00 New Revision: 3d6f53018f845e893ad34f64ff2851a2e5c3ba1d URL: https://github.com/llvm/llvm-project/commit/3d6f53018f845e893ad34f64ff2851a2e5c3ba1d DIFF: https://github.com/llvm/llvm-project/commit/3d6f53018f845e893ad34f64ff2851a2e5c3ba1d.di

[clang] 3d06fc0 - [OpenMP][Docs] Mark `present` motion modifier as done

Author: Joel E. Denny Date: 2020-07-30T12:21:37-04:00 New Revision: 3d06fc0049c6bb94e6efd77388453206037f43ad URL: https://github.com/llvm/llvm-project/commit/3d06fc0049c6bb94e6efd77388453206037f43ad DIFF: https://github.com/llvm/llvm-project/commit/3d06fc0049c6bb94e6efd77388453206037f43ad.diff

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281954. TaWeiTu added a comment. Fix loop deletion and rotation tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files: clang/lib/CodeGen/BackendUtil.cpp llvm

[PATCH] D84924: [clang-tidy][WIP] Added command line option `fix-notes`

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:109 SourceMgr(Diags, Files), Context(Context), ApplyFixes(ApplyFixes), -TotalFixes(0), AppliedFixes(0), WarningsAsErrors(0) { +ApplyAnyFix(ApplyAnyFix), TotalFixe

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny marked an inline comment as done. jdenny added a comment. Thanks for the review. As discussed during the 7/29 call, I'll wait to push until we're sure about what the OpenMP committee intended here. I'm pursuing this and will report back when I have more information. CHANGES SINCE LAST

[PATCH] D84902: [clang-tidy] Fix ODR violation in unittests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a043ecc0cf4: [clang-tidy] Fix ODR violation in unittests. (authored by dergachev.a). Herald added a subscriber: steakhal. Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang-tools-extra] 6a043ec - [clang-tidy] Fix ODR violation in unittests.

Author: Artem Dergachev Date: 2020-07-30T08:52:47-07:00 New Revision: 6a043ecc0cf4d257d06c4fe0c3d5e1d9a8c7ea94 URL: https://github.com/llvm/llvm-project/commit/6a043ecc0cf4d257d06c4fe0c3d5e1d9a8c7ea94 DIFF: https://github.com/llvm/llvm-project/commit/6a043ecc0cf4d257d06c4fe0c3d5e1d9a8c7ea94.dif

[PATCH] D84232: [clangd] Set minimum gRPC version to 1.27

kbobyrev added a comment. This patch is not ready for review yet; planned changes: check if the version is between 1.25.0 and 1.26.0-4 and bail out in such cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84232/new/ https://reviews.llvm.org/D8

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:313 RelativePath, llvm::sys::path::Style::posix)); - if (RelativePath.empty()) { -return llvm::None; - } - if (llvm::sys::path::is_a

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 281946. kbobyrev marked 12 inline comments as done. kbobyrev added a comment. Resolve most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.org/D84939 Files: cl

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers marked 2 inline comments as done. vabridgers added a comment. Thanks Eugene, I think the backtick issue has been addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898 ___

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers updated this revision to Diff 281943. vabridgers added a comment. Address backticks in rst files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898 Files: clang-tools-extra/clang-tidy/bugprone/Bug

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84422/new/ https://reviews.llvm.org/D84422 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:75 + + Finds complex conditions using `<`, `>`, `<=`, and `>=` that could be + interpreted ambiguously. Double back-ticks, not single ones. Comment at:

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.h:201-205 /// Declare generalized virtual functions which need to be defined - /// by all specializations of OpenMPGPURuntime Targets. + /// by all specializations of OpenMPGPURuntime Targets lik

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L updated this revision to Diff 281938. Xiangling_L added a comment. Removed the disablement in IncrementalProcessingTest.cpp cross-target test; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84534/new/ https://reviews.llvm.org/D84534 Files: clang/lib/CodeGen/CGDeclCXX.cpp

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebad64dfe133: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 19756ef - [OpenMP][IRBuilder] Support allocas in nested parallel regions

Author: Johannes Doerfert Date: 2020-07-30T10:19:39-05:00 New Revision: 19756ef53a498b7aa1fbac9e3a7cd3aa8e110fad URL: https://github.com/llvm/llvm-project/commit/19756ef53a498b7aa1fbac9e3a7cd3aa8e110fad DIFF: https://github.com/llvm/llvm-project/commit/19756ef53a498b7aa1fbac9e3a7cd3aa8e110fad.d

[clang] ebad64d - [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

Author: Johannes Doerfert Date: 2020-07-30T10:19:40-05:00 New Revision: ebad64dfe133e64d1df6b82e6ef2fb031d635b08 URL: https://github.com/llvm/llvm-project/commit/ebad64dfe133e64d1df6b82e6ef2fb031d635b08 DIFF: https://github.com/llvm/llvm-project/commit/ebad64dfe133e64d1df6b82e6ef2fb031d635b08.d

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers added a comment. I believe all review comments have been address, except for the discussion on implementing this in the CFE or as a tidy check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898 __

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19756ef53a49: [OpenMP][IRBuilder] Support allocas in nested parallel regions (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84898: [clang-tidy] Add new checker for complex conditions with no meaning

vabridgers updated this revision to Diff 281937. vabridgers marked 6 inline comments as done. vabridgers added a comment. Address most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84898/new/ https://reviews.llvm.org/D84898 Files:

[clang] 622e461 - [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

Author: Alexey Bataev Date: 2020-07-30T11:18:33-04:00 New Revision: 622e46156d9a91206c877a604d069bb3e2dbf294 URL: https://github.com/llvm/llvm-project/commit/622e46156d9a91206c877a604d069bb3e2dbf294 DIFF: https://github.com/llvm/llvm-project/commit/622e46156d9a91206c877a604d069bb3e2dbf294.diff

[PATCH] D83242: [clang][BPF] support type exist/size and enum exist/value relocations

yonghong-song updated this revision to Diff 281933. yonghong-song retitled this revision from "[clang][BPF] support type existence/size and enum value relocations" to "[clang][BPF] support type exist/size and enum exist/value relocations". yonghong-song edited the summary of this revision. yongho

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 281932. saiislam added a comment. Moved comments to header files. Used regexps for test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeG

[clang-tools-extra] c4b7bfd - [clangd] NFC: Spell out types in index callback arguments

Author: Kirill Bobyrev Date: 2020-07-30T17:12:29+02:00 New Revision: c4b7bfdff65e5883bfe64248ac244b9fadf531ee URL: https://github.com/llvm/llvm-project/commit/c4b7bfdff65e5883bfe64248ac244b9fadf531ee DIFF: https://github.com/llvm/llvm-project/commit/c4b7bfdff65e5883bfe64248ac244b9fadf531ee.diff

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev added a comment. In D84939#2184836 , @kadircet wrote: > i think you might want to have an helper for creating stringerrors and use it > in all places Haha, yeah I thought about that but then looked at other examples and saw that in some cases t

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster added a comment. For context, this is the backported change, to be applied downstream before landing this review: https://github.com/apple/llvm-project/pull/1565 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llv

[clang] b69357c - Revert "[OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region."

Author: Alexey Bataev Date: 2020-07-30T10:57:56-04:00 New Revision: b69357c2f4f2aa0c4999d6827a40fe748641fdb1 URL: https://github.com/llvm/llvm-project/commit/b69357c2f4f2aa0c4999d6827a40fe748641fdb1 DIFF: https://github.com/llvm/llvm-project/commit/b69357c2f4f2aa0c4999d6827a40fe748641fdb1.diff

[PATCH] D84880: [AIX] Temporarily disable IncrementalProcessingTest partially

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e6176fd912a: [AIX] Temporarily disable IncrementalProcessingTest partially (authored by Xiangling_L). Repository: rG LLVM Github Monorepo CHANGE

[clang] 4e6176f - [AIX] Temporarily disable IncrementalProcessingTest partially

Author: Xiangling Liao Date: 2020-07-30T10:41:52-04:00 New Revision: 4e6176fd912a68de0764fff43a129a73f5cab800 URL: https://github.com/llvm/llvm-project/commit/4e6176fd912a68de0764fff43a129a73f5cab800 DIFF: https://github.com/llvm/llvm-project/commit/4e6176fd912a68de0764fff43a129a73f5cab800.diff

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281928. MForster marked 5 inline comments as done. MForster added a comment. Fix patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Bas

[PATCH] D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84919/new/ https://reviews.llvm.org/D84919

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster marked an inline comment as done. MForster added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident)); aaron.ballman wrote: > MForster wro

[PATCH] D84005: Introduce ns_error_domain attribute.

MForster updated this revision to Diff 281927. MForster added a comment. Simplify code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84005/new/ https://reviews.llvm.org/D84005 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kadircet added a comment. i think you might want to have an helper for creating stringerrors and use it in all places Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:60 + Response.takeError()); +llvm::consumeError(Response.takeError());

[PATCH] D84176: [CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool

whisperity updated this revision to Diff 281922. whisperity retitled this revision from "[CMake][CTE] Add "check-clang-tools-..." targets to test only a particular Clang extra tool" to "[CMake][CTE] Add "check-clang-extra-..." targets to test only a particular Clang extra tool". whisperity added

[clang] 142d0d3 - [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

Author: Alexey Bataev Date: 2020-07-30T09:40:05-04:00 New Revision: 142d0d3ed8e07aca2476bc4ecc1a12d15577a84a URL: https://github.com/llvm/llvm-project/commit/142d0d3ed8e07aca2476bc4ecc1a12d15577a84a DIFF: https://github.com/llvm/llvm-project/commit/142d0d3ed8e07aca2476bc4ecc1a12d15577a84a.diff

[PATCH] D84767: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target region.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG142d0d3ed8e0: [OPENMP]Fix PR46824: Global declare target pointer cannot be accessed in target… (authored by ABataev). Repository: rG LLVM Github M

[PATCH] D84678: [clang] False line number in a function definition with "void" parameter

Jac1494 updated this revision to Diff 281911. Jac1494 added a comment. Hi @aaron.ballman , Address your review comments. Thank you for accepting this. I don't have commit access please commit this. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84678/new/ https://reviews.llvm.or

[PATCH] D84005: Introduce ns_error_domain attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from an almost NFC simplification. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5350 + + D->addAttr(::new (S.Context) + NSErrorDomainAttr(S.Context, AL, IdentLoc->Ident)); --

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281907. TaWeiTu added a comment. Fix LOOP_NEST_ANALYSIS macro, clang-tidy warnings. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files: clang/lib/CodeGen/B

[PATCH] D84919: [clangd] Be more explicit on testing the optional DefLoc in LocatedSymbol.

hokein updated this revision to Diff 281904. hokein added a comment. remove the 2-arg Sym matcher. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84919/new/ https://reviews.llvm.org/D84919 Files: clang-tools-extra/clangd/XRefs.cpp clang-tools-e

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev updated this revision to Diff 281897. kbobyrev added a comment. Client: print debug string for the stream_result, not the ReplyT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84939/new/ https://reviews.llvm.org/D84939 Files: clang-tool

[PATCH] D84939: [clangd] Propagate remote index errors via Expected

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous. Herald added a project: clang. kbobyrev requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. This is a refactoring: errors shoul

[PATCH] D84886: Create LoopNestPass

TaWeiTu updated this revision to Diff 281881. TaWeiTu added a comment. Herald added a reviewer: bollu. Fix several pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84886/new/ https://reviews.llvm.org/D84886 Files: clang/lib/CodeGe

  1   2   >