[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. In D79279#2168533 , @jfb wrote: > In D79279#2168479 , @rjmccall wrote: > > > Is there a need for an atomic memcpy at all? Why is it useful to allow > > this operation to take on "atomic"

[PATCH] D84341: Implement __builtin_eh_return_data_regno for SystemZ

slavek-kucera updated this revision to Diff 280030. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84341/new/ https://reviews.llvm.org/D84341 Files: clang/lib/Basic/Targets/SystemZ.h clang/test/CodeGen/builtins-systemz.c Index: clang/test/CodeGen/builtins-systemz.c =

[PATCH] D83772: [Windows] Fix limit on command line size

This revision was automatically updated to reflect the committed changes. Closed by commit rGdab898f9ab62: [Windows] Fix limit on command line size (authored by sepavloff). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llv

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for TYPE_EXISTENCE reloc

yonghong-song added a comment. @anakryiko Please rebase on top of latest clang. There is a recent core change which touches BPF code which I am also modifying. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D8324

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for TYPE_EXISTENCE reloc

yonghong-song updated this revision to Diff 280027. yonghong-song retitled this revision from "[clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc" to "[clang][BPF] support expr with typedef/record type for TYPE_EXISTENCE reloc". yonghong-song edited the summary of this r

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu added a comment. Just tried the cmake option `-DLLVM_BUILD_INSTRUMENTED_COVERAGE=On`, the result still shows count for comments... but it pass the `coverage_comments.cpp` test case, need more investigation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://revi

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

jdoerfert added a comment. FWIW, OpenMP does also defer some diagnostics. It feels like a mess we can't avoid. That means, I think there is merit in generalizing this. I haven't reviewed this in any detail though. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84364/new/ https://review

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

yaxunl added a comment. Another thing we can do is to limit the diagnostic messages that can be deferred. For example, we only defer semantic diagnostics, or overloading resolution related diagnostics. According to previous experience, what bothers us most are the diagnostics triggered by the d

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

yaxunl added a comment. I'd like to clarify a little bit about `deferring` an error. First it is localized to a function. If an error causes a function not parsed completely, it will be emitted immediately. So if an error is deferred, it means clang at least parses that function containing it.

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added a comment. In D79279#2168479 , @rjmccall wrote: > Is there a need for an atomic memcpy at all? Why is it useful to allow this > operation to take on "atomic" semantics — which aren't actually atomic > because the loads and stores to elements a

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

yaxunl added a comment. In D84364#2168036 , @tra wrote: > One side effect of this change is that we'll probably stop producing > diagnostics for the code that is known to be wrong, but happens to be unused. > > E.g. > > __host__ __device__ static void h

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

yaxunl updated this revision to Diff 280013. yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: dang. Added option -fgpu-defer-diag to control this new behavior. By default it is off. Added test for syntax error. CHANGES SINCE LAST ACTION https://re

[PATCH] D83997: [os_log] Improve the way we extend the lifetime of objects passed to __builtin_os_log_format

rjmccall added a comment. Why is the lifetime extended to the enclosing block scope anyway? I understand why we need a clang.arc.use — the optimizer can't reasonably understand that the object has to live within the buffer — but isn't the buffer only used for the duration of the call? Why is

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. Is there a need for an atomic memcpy at all? Why is it useful to allow this operation to take on "atomic" semantics — which aren't actually atomic because the loads and stores to elements are torn — with hardcoded memory ordering and somewhat arbitrary rules about wha

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu updated this revision to Diff 280005. zequanwu added a comment. Fix the bug about merging skipped regions. Simple don't merge, because `adjustSkippedRange` will handle those cases if `NextTokLoc` is invalid, which will just skip the next if condition. CHANGES SINCE LAST ACTION https

[PATCH] D84316: [analyzer][NFC] Split CStringChecker to modeling and reporting

NoQ added a comment. Shared accessors look amazing. If i understood correctly, you're splitting up the part which performs boring bookkeeping for the state trait from the part which models `strlen()` and other various functions. Such separation also looks amazing because ultimately the first p

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added a comment. Due to D82995 I realized we should have a test of this in `llvm/test/tools/UpdateTestChecks` as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83004/new/ https://reviews.llvm.org/D8

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

jdoerfert added a comment. In D84364#2168036 , @tra wrote: > E.g. > > __host__ __device__ static void hd() { > no_such_type_t t; > } > > > We obviously can never compile this function on either side of the > compilation and clang currently does d

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:1281 + "Base class that isn't a record?"); + ToVisit.push_back(Base.getType()->getAs()); +} erichkeane wrote: > rsmith wrote: > > It would be better to add the

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 279991. Xiangling_L added a comment. - Simplified the test command line; - Split the `typedef` related tests into two to address the LIT testcase failure on windows platform; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://revi

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus added a project: clang-format. roligugus marked an inline comment as done. roligugus added inline comments. Comment at: clang/tools/clang-format/git-clang-format:101 help='print a diff instead of applying the changes') + p.add_argument('--diffstat', a

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8917 + +def err_atomic_type_must_be_lock_free : Error<"_Atomic type must always be lock-free, %0 isn't">; + rjmccall wrote: > I don't know why you're adding a bunch of new di

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 279984. jfb marked 7 inline comments as done. jfb added a comment. Address all but one of John's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/doc

[PATCH] D80858: [CUDA][HIP] Support accessing static device variable in host code

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80858/new/ https://reviews.llvm.org/D80858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs marked 2 inline comments as done. dokyungs added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:86 +s2++; + } + return 0; morehouse wrote: > Lot's of common code with `internal_strncmp`. Let's factor it out into a > he

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse accepted this revision. morehouse added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 279982. dokyungs added a comment. Introduced a helper function to reduce duplicated code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llvm.org/D83494 Files: clang/include/clang/

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

roligugus created this revision. roligugus added reviewers: klimek, aheejin. Herald added a project: clang. Herald added a subscriber: cfe-commits. [git-clang-format][PR46815] Add diffstat functionality Adding a --diffstat parameter to git-clang-format that essentially uses git diff --stat, i.e.

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the generalization. We'll add update_test support next for the opt case, e.g., for D83635 . Comment at: llvm/utils/up

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

erichkeane marked 5 inline comments as done. erichkeane added a comment. Thanks for the review! I'll get this updated in the morning. I DO have a question on your suggestion for the ToVisit/Visited example, so if you could explain a little better, I'd be grateful. Comment a

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu added a comment. I found the problem is that I was trying to merge two skipped regions when they are adjacent. So, the following code will fail at assertion, because the skipped regions are in different files, but are merged. $ cat a.h // comment $ cat a.c #include "a.h" // c

[PATCH] D84048: DR2303: Prefer 'nearer' base classes during template deduction.

rsmith added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:1204-1205 +// Attempt to deduce the template arguments by checking the base types according +// to (C++ [temp.deduct.call] p4b3. +/// Missing `///` Comment at

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/lib/fuzzer/FuzzerInterceptors.cpp:86 +s2++; + } + return 0; Lot's of common code with `internal_strncmp`. Let's factor it out into a helper function. Repository: rG LLVM Github Monorepo CHANGES

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5f11027 - [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments.

Author: Amy Kwan Date: 2020-07-22T17:58:14-05:00 New Revision: 5f110273954ac152c9690b6cdf2a2e46f8908f0a URL: https://github.com/llvm/llvm-project/commit/5f110273954ac152c9690b6cdf2a2e46f8908f0a DIFF: https://github.com/llvm/llvm-project/commit/5f110273954ac152c9690b6cdf2a2e46f8908f0a.diff LOG:

[PATCH] D84277: [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f110273954a: [PowerPC][Power10] Fix vins*vlx instructions to have i32 arguments. (authored by amyk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84277/new

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Looks like there is an indentation issue in the test. See inline comments. Comment at: lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py:55-61 +

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

tra added a subscriber: rsmith. tra added a comment. It's an interesting idea and it may be needed to handle wider range of implicitly-HD functions. However it's likely to have interesting consequences, not all of them desirable. It may be worth considering hiding the new behavior behind a flag

[clang] 50da55a - [PGO] Supporting code for always instrumenting entry block

Author: Rong Xu Date: 2020-07-22T15:01:53-07:00 New Revision: 50da55a58534e9207d8d5e31c8b4b5cf0c624175 URL: https://github.com/llvm/llvm-project/commit/50da55a58534e9207d8d5e31c8b4b5cf0c624175 DIFF: https://github.com/llvm/llvm-project/commit/50da55a58534e9207d8d5e31c8b4b5cf0c624175.diff LOG:

[PATCH] D84261: [PGO] Supporting code for always instrumenting entry block

This revision was automatically updated to reflect the committed changes. Closed by commit rG50da55a58534: [PGO] Supporting code for always instrumenting entry block (authored by xur). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://review

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

yaxunl updated this revision to Diff 279951. yaxunl added a comment. fix build failure CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84362/new/ https://reviews.llvm.org/D84362 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Attr.h clang/include/clang/AST/Canon

[clang] e0ee228 - [clang][test] Fix test for external assemblers

Author: Douglas Yung Date: 2020-07-22T14:50:20-07:00 New Revision: e0ee2288424952e0445f096ae7800472eac11249 URL: https://github.com/llvm/llvm-project/commit/e0ee2288424952e0445f096ae7800472eac11249 DIFF: https://github.com/llvm/llvm-project/commit/e0ee2288424952e0445f096ae7800472eac11249.diff

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

yaxunl updated this revision to Diff 279950. yaxunl added a comment. update for depending patch change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84364/new/ https://reviews.llvm.org/D84364 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/AnalysisBasedWarnings.cpp clang/li

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu added a comment. In D83592#2167926 , @vsk wrote: > @zequanwu I'm not sure whether this is something you've already tried, but > for frontend changes, it can be helpful to verify that a stage2 clang > self-host with assertions enabled completes

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs marked 4 inline comments as done. dokyungs added inline comments. Comment at: compiler-rt/test/fuzzer/custom-allocator.test:2 +UNSUPPORTED: freebsd +RUN: %cpp_compiler -fno-sanitize=all -fno-builtin %S/CustomAllocator.cpp -fPIC %ld_flags_rpath_so1 -O0 -shared -o %dynami

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

protze.joachim added a comment. I'm executing: $ /usr/bin/python bin/llvm-lit -vv -a projects/openmp/libomptarget/test/offloading/target_depend_nowait.cpp which executes: "/dev/shm/jprotze/build-tsan-fiber-as/./bin/clang++" "-fopenmp" "-pthread" "-fno-experimental-isel" "-I" "/dev/shm/jp

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs updated this revision to Diff 279946. dokyungs marked an inline comment as done. dokyungs added a comment. Introduce internal_strcmp and update tests accordingly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83494/new/ https://reviews.llv

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

tra added a comment. FYI, the patch does not compile: In file included from llvm/repo/clang/lib/Parse/ParseStmtAsm.cpp:13: In file included from /llvm/repo/clang/include/clang/Parse/Parser.h:24: llvm/repo/clang/include/clang/Sema/Sema.h:1833:10: error: use of overloaded operator '<<' is am

[PATCH] D84364: [CUDA][HIP] Defer all diagnostics for host device functions

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added subscribers: sstefan1, kristof.beyls. Herald added a reviewer: jdoerfert. In CUDA/HIP a function may become implicit host device function by pragma or constexpr. A host device function is checked in both host and device compi

[PATCH] D83592: [Coverage] Add comment to skipped regions

vsk added a comment. @zequanwu I'm not sure whether this is something you've already tried, but for frontend changes, it can be helpful to verify that a stage2 clang self-host with assertions enabled completes successfully. For coverage specifically, it's possible to do that by setting '-DLLVM

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

logan-5 added a comment. In D84244#2167663 , @dblaikie wrote: > Sometimes it's OK to commit stuff an see how it goes on the buildbots - doing > so out of peak times and with the intention of rolling back > quickly/immediately if the buildbots report brea

[clang] 388c9fb - Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories.

Author: Logan Smith Date: 2020-07-22T14:19:34-07:00 New Revision: 388c9fb1af48b059d8b65cb2e002e0992d147aa5 URL: https://github.com/llvm/llvm-project/commit/388c9fb1af48b059d8b65cb2e002e0992d147aa5 DIFF: https://github.com/llvm/llvm-project/commit/388c9fb1af48b059d8b65cb2e002e0992d147aa5.diff L

[clang-tools-extra] 388c9fb - Try enabling -Wsuggest-override again, using add_compile_options instead of add_compile_definitions for disabling it in unittests/ directories.

Author: Logan Smith Date: 2020-07-22T14:19:34-07:00 New Revision: 388c9fb1af48b059d8b65cb2e002e0992d147aa5 URL: https://github.com/llvm/llvm-project/commit/388c9fb1af48b059d8b65cb2e002e0992d147aa5 DIFF: https://github.com/llvm/llvm-project/commit/388c9fb1af48b059d8b65cb2e002e0992d147aa5.diff L

[PATCH] D83296: [clang-format] Add a MacroExpander.

curdeius added inline comments. Comment at: clang/lib/Format/MacroExpander.cpp:46 + + // Parse the token stream and return the corresonding Defintion object. + // Returns an empty definition object with a null-Name on error. Nit: typo "corresponding Definition"

[PATCH] D84362: [NFC] Add missing functions to PartialDiagnostic

yaxunl created this revision. yaxunl added a reviewer: tra. PartialDiagnostic misses some functions compared to DiagnosticBuilder. This patch adds missing functions to PartialDiagnostic so that can emit all diagnostics that can be emitted by DiagnosticBuilder. https://reviews.llvm.org/D84362 F

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

yonghong-song added a comment. In D83242#2167721 , @anakryiko wrote: > After thinking about this a bit more, I think adding a new TYPE_EXISTENCE > (instead of FIELD_EXISTENCE) relocation type is the better way to handle > this. It would allow Clang to be

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao added a comment. Hi @rsmith, @rjmccall and @tra what's your suggestion to make progress on this review? In D71227#2167596 , @tra wrote: > Is this patch still actual? I need to rebase this to the latest trunk. Interrupt with other heavy loads. R

[clang] 6c18f7d - For PR46800, implement the GCC __builtin_complex builtin.

Author: Richard Smith Date: 2020-07-22T13:43:10-07:00 New Revision: 6c18f7db73a08f1ae39a76a86b414c5b0c24ee86 URL: https://github.com/llvm/llvm-project/commit/6c18f7db73a08f1ae39a76a86b414c5b0c24ee86 DIFF: https://github.com/llvm/llvm-project/commit/6c18f7db73a08f1ae39a76a86b414c5b0c24ee86.diff

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279936. aelitashen added a comment. Fix the accidentally removed test contents Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

jasonliu added a comment. Thanks. No further comments from me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.llvm.org/D79719 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D84356: [AIX] remote -u from the clang when invoke aix as assembler

MaskRay added a comment. remote -> remove Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84356/new/ https://reviews.llvm.org/D84356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened updated this revision to Diff 279932. greened added a comment. Updated to move the option into `common.py`. Also had to rework the output loop to account for differences between python 2 and 3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L updated this revision to Diff 279930. Xiangling_L marked 3 inline comments as done. Xiangling_L added a comment. Add one more testcase; Addressed other comments; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79719/new/ https://reviews.l

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

bsaleil marked an inline comment as done. bsaleil added inline comments. Comment at: llvm/lib/Target/PowerPC/PPC.td:243 + "32Byte load and store instructions", + [FeatureISA3_0]>; amyk wrote: > Is this supposed to be `Feature

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L marked 13 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2418 + if (!Target->allowsLargerPreferedTypeAlignment()) return ABIAlign; jasonliu wrote: > Should this if statement go above the `i

[PATCH] D79279: Add overloaded versions of builtin mem* functions

rjmccall added a comment. You need to add user docs for these builtins. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8917 + +def err_atomic_type_must_be_lock_free : Error<"_Atomic type must always be lock-free, %0 isn't">; + I don't know why yo

[PATCH] D84356: [AIX] remote -u from the clang when invoke aix as assembler

DiggerLin created this revision. DiggerLin added reviewers: jasonliu, yuanwu, hubert.reinterpretcast. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84356 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/

[PATCH] D83242: [clang][BPF] support expr with typedef/record type for FIELD_EXISTENCE reloc

anakryiko added a comment. After thinking about this a bit more, I think adding a new TYPE_EXISTENCE (instead of FIELD_EXISTENCE) relocation type is the better way to handle this. It would allow Clang to be stricter as to what is passed into FIELD_EXISTENCE (only fields, not types) vs TYPE_EXIS

[clang] b198de6 - Merge some of the PCH object support with modular codegen

Author: David Blaikie Date: 2020-07-22T12:46:12-07:00 New Revision: b198de67e0bab462217db50814b1434796fa7caf URL: https://github.com/llvm/llvm-project/commit/b198de67e0bab462217db50814b1434796fa7caf DIFF: https://github.com/llvm/llvm-project/commit/b198de67e0bab462217db50814b1434796fa7caf.diff

[PATCH] D83652: Merge some of the PCH object support with modular codegen

This revision was automatically updated to reflect the committed changes. Closed by commit rGb198de67e0ba: Merge some of the PCH object support with modular codegen (authored by dblaikie). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83652/new/ htt

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

dblaikie added a comment. In D84244#2167661 , @logan-5 wrote: > In D84244#2167625 , @hans wrote: > > > I don't really know why this doesn't happen with other warning flags, but I > > think it would be better to add

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

logan-5 added a comment. In D84244#2167625 , @hans wrote: > I don't really know why this doesn't happen with other warning flags, but I > think it would be better to add flags like this with add_compile_options > rather than add_compile_definitions. I im

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2167649 , @ABataev wrote: > In D84192#2167636 , @cchen wrote: > > > In D84192#2165522 , @ABataev wrote: > > > > > In D84192#2165517

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2167636 , @cchen wrote: > In D84192#2165522 , @ABataev wrote: > > > In D84192#2165517 , @cchen wrote: > > > > > In D84192#2165438

[PATCH] D83645: Bump the default target CPU for i386-freebsd to i686

MaskRay added a comment. llvm/utils/git/pre-push.py is recommended for your future commits. I guess `arc land` is a bad choice because llvm/llvm-project uses the github community version which can't set a pre-receive hook. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D84192#2165522 , @ABataev wrote: > In D84192#2165517 , @cchen wrote: > > > In D84192#2165438 , @ABataev wrote: > > > > > In D84192#2165396

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

hans added a comment. In D84244#2167602 , @logan-5 wrote: > Thanks for reverting--I agree that that's the right move at this point. > > Pretty much totally out my depth here, and I don't have a way of debugging > the Windows issue, so I'm not sure how to

[PATCH] D83592: [Coverage] Add comment to skipped regions

MaskRay added a comment. (This was committed within 10 minutes after it was approved. As a large change with updates to some sensitive places like clang/Lex/Preprocessor.h, this probably should have been waited a bit longer.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ ht

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

akhuang added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empty() ? std::string("G1") : (DL + "-G1").str(); arichardson wrote: > arsenm

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

logan-5 added a comment. Thanks for reverting--I agree that that's the right move at this point. Pretty much totally out my depth here, and I don't have a way of debugging the Windows issue, so I'm not sure how to proceed. I'm tempted to just let this whole thing rest for now and maybe try agai

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

tra added a comment. Is this patch still actual? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh added a comment. I couldn't reproduce this problem because all commands are ignored on my machine. Could you send the exact compiling and running commands? In the IR files you sent me before, any idea where segfault happens? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Differential] D78648: [CMake] Bump CMake minimum version to 3.13.4

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGafa1afd4108d: [CMake] Bump CMake minimum version to 3.13.4 (authored by ldionne). Herald added subscribers: llvm-commits, msifontes, sstefan1, jurahu

[PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

ldionne added a comment. Herald added subscribers: llvm-commits, msifontes, sstefan1, jurahul, stephenneuendorffer, aartbik. Herald added projects: MLIR, LLVM. Okay, the previous patch has landed and no issues have come up, so I'm going to move forward with this patch now. Repository: rG LLV

[PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

This revision was automatically updated to reflect the committed changes. Closed by commit rGafa1afd4108d: [CMake] Bump CMake minimum version to 3.13.4 (authored by ldionne). Changed prior to commit: https://reviews.llvm.org/D78648?vs=259300&id=279895#toc Repository: rG LLVM Github Monorepo

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source') parser

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

jasonliu added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2418 + if (!Target->allowsLargerPreferedTypeAlignment()) return ABIAlign; Should this if statement go above the `if (const auto *RT = T->getAs()) ` ? When Target does not allow larg

[PATCH] D83772: [Windows] Fix limit on command line size

max-kudr accepted this revision. max-kudr added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83772/new/ https://reviews.llvm.org/D83772 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] 08b4a50 - [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation

Author: Amy Kwan Date: 2020-07-22T13:27:05-05:00 New Revision: 08b4a50e39d8b8db17b8eddacba795e99304e418 URL: https://github.com/llvm/llvm-project/commit/08b4a50e39d8b8db17b8eddacba795e99304e418 DIFF: https://github.com/llvm/llvm-project/commit/08b4a50e39d8b8db17b8eddacba795e99304e418.diff LOG:

[PATCH] D84291: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG08b4a50e39d8: [PowerPC][Power10] Fix the Test LSB by Byte (xvtlsbb) Builtins Implementation (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D84291?vs=279698&id=279897#toc Reposito

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas added a reviewer: gribozavr2. eduucaldas marked 6 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:101-106 + UnknownNameSpecifier, + GlobalNameSpecifier, + NamespaceNameSpecifier, + TypeNameSpecifier,

[PATCH] D79279: Add overloaded versions of builtin mem* functions

jfb updated this revision to Diff 279896. jfb added a comment. Follow John's suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79279/new/ https://reviews.llvm.org/D79279 Files: clang/include/clang/Basic/Builtins.def clang/include/clang

[PATCH] D84244: [clang] Disable -Wsuggest-override for unittests/

hans added inline comments. Comment at: clang/unittests/CMakeLists.txt:14 +if (CXX_SUPPORTS_SUGGEST_OVERRIDE_FLAG) + add_definitions("-Wno-suggest-override") +endif() Because it's added as a define, this gets passed to rc.exe in Windows builds, which is used fo

[clang-tools-extra] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

[clang] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

[PATCH] D83660: [analyzer] Fix a crash for dereferencing an empty llvm::Optional variable in SMTConstraintManager.h.

vsavchenko added a comment. In D83660#2167391 , @NoQ wrote: > In D83660#2166917 , @steakhal wrote: > > > Although I'm not the most experienced one here, I think it's good to go. > > > Let's wait for the test to be a

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84348 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/Syntax/BuildTree.cpp clang/lib/Tooling/Syntax/N

[clang-tools-extra] 1c7037a - [clangd] Disable -Wsuggest-override for unittests/

Author: Logan Smith Date: 2020-07-22T10:49:09-07:00 New Revision: 1c7037a2a5576d0bb083db10ad947a8308e61f65 URL: https://github.com/llvm/llvm-project/commit/1c7037a2a5576d0bb083db10ad947a8308e61f65 DIFF: https://github.com/llvm/llvm-project/commit/1c7037a2a5576d0bb083db10ad947a8308e61f65.diff L

[PATCH] D84345: [AMDGPU] Set the default globals address space to 1

arichardson marked an inline comment as done. arichardson added a subscriber: akhuang. arichardson added inline comments. Comment at: llvm/lib/IR/AutoUpgrade.cpp:4297 + // address space of 1. + if (T.isAMDGPU() && !DL.contains("-G") && !DL.startswith("G")) { +return DL.empt

  1   2   >