[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rjmccall added a comment. In D79744#2047482 , @arsenm wrote: > In D79744#2040731 , @rjmccall wrote: > > > In D79744#2040434 , @jdoerfert > > wrote: > > > > > In D79744#20403

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

rjmccall added inline comments. Comment at: clang/test/CXX/drs/dr7xx.cpp:225 template void f(int i = 0, T ...args) {} void ff() { f(); } Quuxplusone wrote: > Is this even supposed to compile? The only valid specializations of `f` > require `T...` to be an em

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

fghanim added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:244 -// TODO: Replace this with the real size_t type -#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, Type::getInt64Ty(Ctx)) +#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, M.getDataLayout().g

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

rjmccall added a comment. I wrote this comment but apparently never submitted it on Phabricator, sorry. Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1987 + +if (Function->getNumParams() >= NumTemplatedParams) { + unsigned FirstDefault = 0; ---

[PATCH] D72959: Relative VTables ABI on Fuchsia

rjmccall added a comment. Otherwise LGTM. Comment at: clang/lib/CodeGen/CGVTables.cpp:633 + llvm::Module &module = CGM.getModule(); + llvm::SmallString<16> componentName(globalVal->getName()); + `componentName` seems to no longer be used meaningfully. in this

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

Quuxplusone added inline comments. Comment at: clang/test/CXX/drs/dr7xx.cpp:225 template void f(int i = 0, T ...args) {} void ff() { f(); } Is this even supposed to compile? The only valid specializations of `f` require `T...` to be an empty pack, which viol

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:552 + + Index = StackFrame->getIndex(); + Szelethus wrote: > This mustn't be serious. `StackFrameContext::getIn

[PATCH] D79800: [Sema] Remove default values for arguments prior to a parameter pack if the pack is used

tambre added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79800/new/ https://reviews.llvm.org/D79800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] 4cd696f - [X86] Allow avx512vp2intersect to be used with __builtin_cpu_supports.

Author: Craig Topper Date: 2020-05-21T21:54:54-07:00 New Revision: 4cd696f92fde5fa0bc570ca059e0f1ce7344c807 URL: https://github.com/llvm/llvm-project/commit/4cd696f92fde5fa0bc570ca059e0f1ce7344c807 DIFF: https://github.com/llvm/llvm-project/commit/4cd696f92fde5fa0bc570ca059e0f1ce7344c807.diff

[PATCH] D79921: [OPENMP] Fix mixture of omp and clang pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rGac2c5af67f03: [OPENMP] Fix mixture of omp and clang pragmas (authored by hishiguro, committed by kawashima-fj). Changed prior to commit: https://reviews.llvm.org/D79921?vs=265450&id=265667#toc Reposito

[clang] ac2c5af - [OPENMP] Fix mixture of omp and clang pragmas

Author: ISHIGURO, Hiroshi Date: 2020-05-22T12:53:37+09:00 New Revision: ac2c5af67f036ec810556372b16548ae9b663f36 URL: https://github.com/llvm/llvm-project/commit/ac2c5af67f036ec810556372b16548ae9b663f36 DIFF: https://github.com/llvm/llvm-project/commit/ac2c5af67f036ec810556372b16548ae9b663f36.d

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jdoerfert added a subscriber: fghanim. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:244 -// TODO: Replace this with the real size_t type -#define __OMP_SIZE_TYPE(NAME) OMP_TYPE(NAME, Type::getInt64Ty(Ctx)) +#define __OMP_SIZE_TYPE(

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

joewholden created this revision. Herald added subscribers: cfe-commits, atanasyan, arichardson, sdardis. Herald added a project: clang. This patch attempts to fix the dynamic linker path for mips64-sf, I'm not entirely familiar with the llvm structure so I am unsure if this is the best way but

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

This revision was automatically updated to reflect the committed changes. Closed by commit rG48acac362938: [WebAssembly] Warn on exception spec only when Wasm EH is used (authored by aheejin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/

[PATCH] D79121: Add nomerge statement attribute to clang

zequanwu updated this revision to Diff 265648. zequanwu retitled this revision from "Add nomerge function attribute to clang" to "Add nomerge statement attribute to clang". zequanwu edited the summary of this revision. zequanwu added a comment. update test case. CHANGES SINCE LAST ACTION http

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM, but the comments at the start of each run are confusing - they describe the desired, not the current state. Maybe move FIXME on the same line? Repository: rG LLVM Github Monorepo C

[clang] 48acac3 - [WebAssembly] Warn on exception spec only when Wasm EH is used

Author: Heejin Ahn Date: 2020-05-21T17:08:35-07:00 New Revision: 48acac36293805cef10b448d49d336da7db7bfa9 URL: https://github.com/llvm/llvm-project/commit/48acac36293805cef10b448d49d336da7db7bfa9 DIFF: https://github.com/llvm/llvm-project/commit/48acac36293805cef10b448d49d336da7db7bfa9.diff LO

[clang] e36076e - [clang] Add nomerge function attribute to clang

Author: Zequan Wu Date: 2020-05-21T17:07:39-07:00 New Revision: e36076ee3a2ebc6013372d9b71e6bb09e8612366 URL: https://github.com/llvm/llvm-project/commit/e36076ee3a2ebc6013372d9b71e6bb09e8612366 DIFF: https://github.com/llvm/llvm-project/commit/e36076ee3a2ebc6013372d9b71e6bb09e8612366.diff LOG

[PATCH] D80294: Add support for vmsumudm

saghir marked an inline comment as done. saghir added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1365 +// Vector Multiply-Sum +def VMSUMUDM : VA1a_Int_Ty3<35, "vmsumudm", int_ppc_altivec_vmsumudm, amyk wrote: > Maybe we can put this

[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

aheejin updated this revision to Diff 265645. aheejin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80362/new/ https://reviews.llvm.org/D80362 Files: clang/lib/CodeGen/CGException.cpp clang/test/CodeGenCXX/was

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

srj added a comment. I think the new formatting is unquestionably better than the old formatting. But... This change means that the output from clang-format-11 can't be made compatible with older versions of clang-format, which is also unfortunate. IMHO it should be a goal to have "breaking" f

[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.

jyknight created this revision. jyknight added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Unlike other platforms using ItaniumCXXABI, Darwin does not allow the creation of a thread-wrapper function for a variable in the TU of users. Because of this

[clang] 54e91a3 - Reland "[Analyzer][WebKit] RefCntblBaseVirtualDtorChecker"

Author: Jan Korous Date: 2020-05-21T16:41:00-07:00 New Revision: 54e91a3c701040d9d2e467bd483c197073b2c5e4 URL: https://github.com/llvm/llvm-project/commit/54e91a3c701040d9d2e467bd483c197073b2c5e4 DIFF: https://github.com/llvm/llvm-project/commit/54e91a3c701040d9d2e467bd483c197073b2c5e4.diff LO

[clang] b0a0f01 - Revert "Add nomerge function attribute to clang"

Author: Zequan Wu Date: 2020-05-21T16:13:18-07:00 New Revision: b0a0f01bc175b4c444052f871a89421889f8b5ce URL: https://github.com/llvm/llvm-project/commit/b0a0f01bc175b4c444052f871a89421889f8b5ce DIFF: https://github.com/llvm/llvm-project/commit/b0a0f01bc175b4c444052f871a89421889f8b5ce.diff LOG

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

arsenm added a comment. The langref wording makes me think this isn't quite right. This depends on your definition of floating point contraction. I've always assumed it meant allow FMA, potentially increasing precision. Is contracting into something less precise allowed? If not, that's stricter

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:21 +float fused_mad(float a, float b, float c) { + // NORMAL: @llvm.fmuladd.f32 + // FAST: fmul fast float I don't find this beha

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

steveire added a comment. I like the approach of using clang-format to implement this. It's much faster than a `clang-tidy` approach. The broader C++ community has already chosen `East`/`West` and it has momentum. If you choose `Left`/`Right` now, you will get pressure to add `East`/`West` in

[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

stevewan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. stevewan added reviewers: hubert.reinterpretcast, Xiangling_L, ZarkoCA, daltenty. On AIX, add '-bcdtors:all:0:s' to linker implicitly through driver, so that we can collect all static construct

[PATCH] D80416: [RFC][OpenCL] Set fp contract flag on -cl-mad-enable

Anastasia created this revision. Anastasia added reviewers: rjmccall, arsenm. Herald added subscribers: ebevhan, yaxunl, wdng. Anastasia marked an inline comment as done. Anastasia added inline comments. Anastasia retitled this revision from "[RCF][OpenCL] Set fp contract flag on -cl-mad-enable" t

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

steveire updated this revision to Diff 265626. steveire added a comment. Touch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72534/new/ https://reviews.llvm.org/D72534 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/ParentMapContext

[PATCH] D80294: Add support for vmsumudm

amyk added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstrAltivec.td:1365 +// Vector Multiply-Sum +def VMSUMUDM : VA1a_Int_Ty3<35, "vmsumudm", int_ppc_altivec_vmsumudm, Maybe we can put this definition near the other VMSUM instructions? Since it's

[clang] 307e853 - Add nomerge function attribute to clang

Author: Zequan Wu Date: 2020-05-21T15:28:27-07:00 New Revision: 307e85395485e1eff9533b2d7952b16f33ceae38 URL: https://github.com/llvm/llvm-project/commit/307e85395485e1eff9533b2d7952b16f33ceae38 DIFF: https://github.com/llvm/llvm-project/commit/307e85395485e1eff9533b2d7952b16f33ceae38.diff LOG

[PATCH] D79980: [PS4] Enable relaxed relocations by default

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d23b5025d5f: [PS4] Enable relaxed relocations by default (authored by Ben Dunbobbin ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to c

[PATCH] D72531: Set traversal explicitly where needed in tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGa30d411629d5: Set traversal explicitly where needed in tests (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72531/new/ https://re

[PATCH] D72532: Make the ExprMutationAnalyzer explicit about how it traverses the AST

This revision was automatically updated to reflect the committed changes. Closed by commit rGf85aedc167cd: Make the ExprMutationAnalyzer explicit about how it traverses the AST (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D80412: Summary: [Lexer] Fix invalid suffix diagnostic for fixed-point literals

nagart created this revision. nagart added a reviewer: ebevhan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80412 Files: clang/include/clang/Basic/DiagnosticLexKinds.td clang/include/clang/Lex/LiteralS

[PATCH] D80409: [MS ABI] Add mangled type for template integer argument

zequanwu created this revision. zequanwu added a reviewer: thakis. zequanwu added a project: clang. Herald added a subscriber: cfe-commits. To differentiate different types of template integer arguments, as MSVC does. Bug filed here: https://bugs.llvm.org/show_bug.cgi?id=45969 which is caused by

[clang] 9d23b50 - [PS4] Enable relaxed relocations by default

Author: Ben Dunbobbin Date: 2020-05-21T23:05:44+01:00 New Revision: 9d23b5025d5f6614a2b2b1b6fc19997f0fb69138 URL: https://github.com/llvm/llvm-project/commit/9d23b5025d5f6614a2b2b1b6fc19997f0fb69138 DIFF: https://github.com/llvm/llvm-project/commit/9d23b5025d5f6614a2b2b1b6fc19997f0fb69138.diff

[clang] f85aedc - Make the ExprMutationAnalyzer explicit about how it traverses the AST

Author: Stephen Kelly Date: 2020-05-21T22:34:38+01:00 New Revision: f85aedc167cde76bdb47b7814f873cfb40ad3ed8 URL: https://github.com/llvm/llvm-project/commit/f85aedc167cde76bdb47b7814f873cfb40ad3ed8 DIFF: https://github.com/llvm/llvm-project/commit/f85aedc167cde76bdb47b7814f873cfb40ad3ed8.diff

[clang] a30d411 - Set traversal explicitly where needed in tests

Author: Stephen Kelly Date: 2020-05-21T22:34:38+01:00 New Revision: a30d411629d5425dedb0dadd616d0faabb611798 URL: https://github.com/llvm/llvm-project/commit/a30d411629d5425dedb0dadd616d0faabb611798 DIFF: https://github.com/llvm/llvm-project/commit/a30d411629d5425dedb0dadd616d0faabb611798.diff

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

jkorous added a comment. In D77177#2049805 , @thakis wrote: > This breaks the build everywhere (e.g. > http://45.33.8.238/linux/18283/step_4.txt) and has been in for over an hour. > Please watch bots after landing. (I think changes that are created more

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl updated this revision to Diff 265606. yaxunl marked 2 inline comments as done. yaxunl edited the summary of this revision. yaxunl added a reviewer: tra. yaxunl added a comment. check supported fp atomics by bits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71726/new/ https://re

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1590-1600 +// flush all const reference uses diags +for (const auto &P : constRefUses) { + const VarDecl *vd = P.first; + const MappedType &V = P.second; + + UsesVec *vec =

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu updated this revision to Diff 265605. zequanwu marked 2 inline comments as done. zequanwu added a comment. rename parameter `uses` to `um` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.org/D79895 Files: clang/include/clang/Analysis/Analyses/Un

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl marked 3 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1418 + /// Whether floating point atomic fetch add/sub is supported. + virtual bool isFPAtomicFetchAddSubSupported() const { return false; } + -

[PATCH] D66564: [clang-tidy] new altera struct pack align check

Eugene.Zelenko added a comment. In D66564#2049664 , @ffrankies wrote: > @Eugene.Zelenko Just checking in, is there anything I missed regarding what > we need to do for these checks? It'll be good idea to ping reviewers. Repository: rG LLVM Github Mo

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 8 inline comments as done. LukeZhuang added a comment. In D79830#2049582 , @erichkeane wrote: > FYI: I'm more of a clang contributor, so I'm unable to review the LLVM code, > hopefully someone will come along who can check on that. Tha

[PATCH] D80369: WIP: [DebugInfo] Remove decl subprograms from 'retainedTypes:'

dblaikie added a comment. In D80369#2048932 , @djtodoro wrote: > Still have test failing: > > Clang :: Modules/DebugInfoTransitiveImport.m > Clang :: Modules/ModuleDebugInfo.cpp > Clang :: Modules/ModuleDebugInfo.m > > > I haven't looked into the

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang updated this revision to Diff 265598. LukeZhuang added a comment. **Updated: 05/21/2020** 1. add assertion after evaluate probability 2. remove value dependent check in SemaChecking 3. add test case handling value-dependent template CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D80404: [OPENMP50]Initial support for use_device_addr clause.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: llvm-commits, sstefan1, arphaman, guansong, yaxunl. Herald added projects: clang, LLVM. Added parsing/sema analysis/serialization support for use_device_addr clauses. Repository: rG LLVM Github Monore

[PATCH] D76420: Prevent IR-gen from emitting consteval declarations

rsmith accepted this revision. rsmith marked an inline comment as done. rsmith added a comment. This revision is now accepted and ready to land. Thanks! Looks good. I'd like to eventually get to a point where every `ConstantExpr` that reaches code generation has `hasAPValueResult()` return `true

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

craig.topper added a comment. In D80251#2049418 , @RKSimon wrote: > Can we add -Wsign-conversion checks to the tests? That was mentioned on > PR45931 I can. Will that do anything other than show that my test_* functions were updated to match the new ty

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

mgehre added a comment. Thanks for doing this! I didn't work on the YAML parser before, so I cannot give formal approval. Comment at: llvm/lib/Support/YAMLTraits.cpp:904 + std::string &Val) { + Val.clear(); + size_t CurrentPos = 0; -

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

owenv marked an inline comment as done. owenv added inline comments. Comment at: clang/lib/Frontend/SerializedDiagnosticReader.cpp:323 + // A documentation URL has an ID and path size. + if (Record.size() != 2) +return SDError::MalformedDiagnosticRecord; ---

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

owenv marked an inline comment as done. owenv added a comment. @jkorous I'd like to add support for urls in clang-emitted diagnostics too, but I can't really commit to a timeframe for getting that done atm. I'm hoping to have some time to work on it in the next few weeks. Com

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

owenv updated this revision to Diff 265592. owenv added a comment. - Update a few comments - Simplify test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80126/new/ https://reviews.llvm.org/D80126 Files: clang/include/clang-c/Index.h clang

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. One last nit, otherwise lgtm. But I'm not super familiar with this area, it'd be good to get another review from somebody more familiar. Comment at: clang/lib/Sema/Analy

[PATCH] D79842: [clang][Driver] Correct tool search path priority

nickdesaulniers added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4730 + return std::string(P.str()); + } } else { style nit: are the `{}` on the `for` necessary? Comment at: clang/test/Driver/program-path-priori

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

NoQ added a comment. > Reverted in 1108f5c737dbdab0277874a7e5b237491839c43a > for now. Uh-oh. Thank you for reverting! > Project-specific checks like this usually go in clang-tidy, not in the static > analyzer (which ships w

[PATCH] D80315: Fix CC1 command line options mapping into fast-math flags.

Anastasia added inline comments. Comment at: clang/test/CodeGenOpenCL/relaxed-fpmath.cl:14 // FINITE: fdiv nnan ninf float - // UNSAFE: fdiv nnan nsz float + // UNSAFE: fdiv reassoc nsz arcp afn float // MAD: fdiv float michele.scandale wrote: > This chan

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. How are you going to pass this non-contiguous data in the runtime? Are you going to map it in a loop or convert this non-contiguous data into the contiguous and map it as a contiguous chunk of data? Your presentation provides interface only interface changes but has not

[PATCH] D47092: downgrade strong type info names to weak_odr linkage

efriedma added a comment. I think the preferred solution is something like https://bugs.llvm.org/show_bug.cgi?id=37545#c4, which is slightly different from both this patch and D46665 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast added a comment. In D80300#2049679 , @joerg wrote: > So the general idea is that for turnkey toolchains, > we want to allow customizing the "default" target of the toolchain to > hard-code options like --sysroot, --target, -Wl,-rpa

[clang] 396bbae - [libTooling][NFC]Fix typo in comment in RangeSelectors

Author: Yitzhak Mandelbaum Date: 2020-05-21T16:13:02-04:00 New Revision: 396bbae41604637008bd5102e1d02d4543f1c3c9 URL: https://github.com/llvm/llvm-project/commit/396bbae41604637008bd5102e1d02d4543f1c3c9 DIFF: https://github.com/llvm/llvm-project/commit/396bbae41604637008bd5102e1d02d4543f1c3c9.

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

thakis added a comment. About the patch itself: Project-specific checks like this usually go in clang-tidy, not in the static analyzer (which ships with the compiler binary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77177/new/ https://reviews

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

thakis added a comment. This breaks the build everywhere (e.g. http://45.33.8.238/linux/18283/step_4.txt) and has been in for over an hour. Please watch bots after landing. (I think changes that are created more recently automatically get presubmit compile testing on phab.) Reverted in 1108f5c

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader updated this revision to Diff 265579. bader marked an inline comment as done. bader added a comment. Fix formatting in clang/test/Sema/address_spaces.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80317/new/ https://reviews.llvm.org/D80317

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

danalbert added a comment. The NDK still supports linkers other than LLD, but we are changing the default to LLD in the next release. I'd prefer to keep this for the time being, but don't feel strongly about it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56456

[clang] 1108f5c - Revert "[Analyzer][WebKit] RefCntblBaseVirtualDtorChecker"

Author: Nico Weber Date: 2020-05-21T15:49:46-04:00 New Revision: 1108f5c737dbdab0277874a7e5b237491839c43a URL: https://github.com/llvm/llvm-project/commit/1108f5c737dbdab0277874a7e5b237491839c43a DIFF: https://github.com/llvm/llvm-project/commit/1108f5c737dbdab0277874a7e5b237491839c43a.diff LO

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

thakis added a comment. Do we still need this? I was surprised by clang not using faddrsing on Andriod by default. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56456/new/ https://reviews.llvm.org/D56456 ___ cfe-comm

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

joerg added a comment. I see that more as a short-coming in the existing DEFAULT_SYSROOT behavior and less an argument for making more cases like it. So the general idea is that for turnkey toolchains, we want to allow customizing the "default" target of the toolchain to hard-code options like

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

LukeGeeson added inline comments. Comment at: clang/test/CodeGen/arm-mangle-16bit-float.cpp:4 + +// CHECK64: define {{.*}}void @_Z3foou6__bf16(half %b) +// CHECK32: define {{.*}}void @_Z3foou6__bf16(i32 %b.coerce) SjoerdMeijer wrote: > LukeGeeson wrote: > > craig

[clang] f7c7e8a - [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker

Author: Jan Korous Date: 2020-05-21T11:54:49-07:00 New Revision: f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2 URL: https://github.com/llvm/llvm-project/commit/f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2 DIFF: https://github.com/llvm/llvm-project/commit/f7c7e8a523f56b0ed1b14c0756ba4e5d1ccb48d2.diff LO

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies added a comment. @Eugene.Zelenko Just checking in, is there anything I missed regarding what we need to do for these checks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564

[PATCH] D77177: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker & shared utils

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7c7e8a523f5: [Analyzer][WebKit] RefCntblBaseVirtualDtorChecker (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llv

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked 2 inline comments as done. jhuber6 added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:203 + static Function *getOrCreateRuntimeFunction(Module &Md, + omp::RuntimeFunction FnID); --

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/AST/Type.h:1069 + /// qualifiers. + bool isAddressSpaceOverlapping(const QualType &T) const { +Qualifiers Q = getQualifiers();

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

ldionne added inline comments. Comment at: clang/test/CodeGen/atomic-ops.c:296 + // CHECK: fsub + return __atomic_sub_fetch(p, 1.0, memory_order_relaxed); +} yaxunl wrote: > ldionne wrote: > > Sorry if that's a dumb question, but I'm a bit confused: `p` is a

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 265562. cchen added a comment. Herald added a subscriber: sstefan1. Remove redundant code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. FYI: I'm more of a clang contributor, so I'm unable to review the LLVM code, hopefully someone will come along who can check on that. Comment at: clang/lib/Sema/SemaChecking.cpp:1805 +const Expr *ProbArg = TheCall->getArg(2); +if (ProbArg->i

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

dblaikie added a comment. I think it's probably best to keep this subject on the cfe-dev thread until there's agreement there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80391/new/ https://reviews.llvm.org/D80391

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang marked 6 inline comments as done. LukeZhuang added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1805 +const Expr *ProbArg = TheCall->getArg(2); +if (ProbArg->isValueDependent()) + return ExprError(); erichkeane wrote: > Luk

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

rjmccall requested changes to this revision. rjmccall added a comment. This revision now requires changes to proceed. I've responded to the llvmdev thread, which I missed before. I would like us to hold off on this line or work until we come to a resolution there. Repository: rG LLVM Github

[PATCH] D80391: [Driver] Don't make -gsplit-dwarf imply -g2

MaskRay created this revision. MaskRay added reviewers: aprantl, dblaikie, echristo, JDevlieghere, jhenderson, probinson, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. RFC: http://lists.llvm.org/pipermail/cfe-dev/2020-May/065430.html Agreement from GCC: https://s

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/include/clang/AST/Type.h:1069 + /// qualifiers. + bool isAddressSpaceOverlapping(const QualType &T) const { +Qualifiers Q = getQualifiers(); rjmccall wrote: > It's idioma

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

bader updated this revision to Diff 265547. bader added a comment. - Added C test case with address_space attribute. - Move isAddressSpaceOverlapping from PointerType to QualType. - Move C++ test case to clang/test/SemaCXX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

rjmccall added a comment. In D80323#2049374 , @ctetreau wrote: > In D80323#2048457 , @rjmccall wrote: > > > I'm sympathetic to wanting to get rid of the boolean flag, but this is a > > really invasive change for pr

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau updated this revision to Diff 265542. ctetreau added a comment. address code review issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80323/new/ https://reviews.llvm.org/D80323 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/CodeG

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

tra added inline comments. Comment at: clang/include/clang/Basic/TargetInfo.h:1418 + /// Whether floating point atomic fetch add/sub is supported. + virtual bool isFPAtomicFetchAddSubSupported() const { return false; } + I think it should be predicated on speci

[PATCH] D80225: [Driver] Recognize -fuse-ld={bfd, gold, lld} but don't prepend "ld." or "ld64." for other values

jyknight added a comment. It's worrying to me that there number of places in LLVM that at the exact argument value of "-fuse-ld=". E.g. in the windows and PS4 toolchains. We already claim to support arbitrary values and full paths, but if you specify "-fuse-ld=/path/to/lld-link" on Windows toda

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. I feel like there might something of a concencus forming.. If I take the time to redo following the suggestions @sammccall do you think you could live with it? Comment at: clang/include/clang/For

[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

hubert.reinterpretcast added a comment. In D80300#2049181 , @joerg wrote: > It doesn't seem to work well with the cross-compiling support in the driver > as clearly shown by the amount of tests that need patching. I don't see the test changes as reflect

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2202 +// won't use it for anything. +// Note, we still IRGen ExpectedValue because it could have side-effects. +if (CGM.getCodeGenOpts().OptimizationLevel == 0) erichkeane w

[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

jkorous added a comment. Hi Owen, Do you plan to land the functionality for emitting documentation URLs in clang too? Comment at: clang/lib/Frontend/SerializedDiagnosticReader.cpp:323 + // A documentation URL has an ID and path size. + if (Record.size() != 2) +

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

RKSimon added a comment. Can we add -Wsign-conversion checks to the tests? That was mentioned on PR45931 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80251/new/ https://reviews.llvm.org/D80251 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 265535. dang added a comment. Accidently deleted a line in the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ https://reviews.llvm.org/D80383 Files: clang/include/clang/Serialization/A

[PATCH] D80079: [clang-format] [NFC] isCpp() is inconsistently used to mean both C++ and Objective C, add language specific isXXX() functions

Quuxplusone added inline comments. Comment at: clang/include/clang/Format/Format.h:1632 + bool isCppOnly() const { return Language == LK_Cpp; } + bool isObjectiveC() const { return Language == LK_ObjC; } + bool isCpp() const { return isCppOnly() || isObjectiveC(); } --

[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

rjmccall added a comment. Please add a C test case just using the address_space attribute. Comment at: clang/include/clang/AST/Type.h:1069 + /// qualifiers. + bool isAddressSpaceOverlapping(const QualType &T) const { +Qualifiers Q = getQualifiers(); It's

[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

ctetreau added a comment. In D80323#2048457 , @rjmccall wrote: > I'm sympathetic to wanting to get rid of the boolean flag, but this is a > really invasive change for pretty minimal benefit. Why not leave > `VectorType::get` as meaning a non-scalable ve

  1   2   >