[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

[Matthias Gehre via Phabricator via cfe-commits]

mgehre added a comment.

Thanks for doing this! I didn't work on the YAML parser before, so I cannot 
give formal approval.



================
Comment at: llvm/lib/Support/YAMLTraits.cpp:904
+                                           std::string &Val) {
+  Val.clear();
+  size_t CurrentPos = 0;
----------------
I wonder whether using StringRef::split() would lead to an easier 
implementation 
(https://llvm.org/doxygen/classllvm_1_1StringRef.html#af0284e4c41c0e09c0bc4767bc77a899d)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80301/new/

https://reviews.llvm.org/D80301



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits