[PATCH] D77194: [clang] Persist Attr::IsPackExpansion into the serialized AST

nridge updated this revision to Diff 254712. nridge added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77194/new/ https://reviews.llvm.org/D77194 Files: clang/test/PCH/cxx-attrs-packexpansion.cpp clang/utils/TableGen/Clang

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing updated this revision to Diff 254693. tianqing added a comment. Updated to resolve conflicts with https://reviews.llvm.org/D77193. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 Files: clang/docs/ClangCommandLineReference.rst clang

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

tianqing updated this revision to Diff 254694. tianqing added a comment. Removed extra "//". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205 Files: clang/docs/ClangCommandLineReference.rst clang/include/clang/Basic/BuiltinsX86.def clang/in

[clang] be0a4fe - [X86] Add -flax-vector-conversions=none to more of the clang CodeGen tests

Author: Craig Topper Date: 2020-04-02T20:39:18-07:00 New Revision: be0a4fef6e789a8f25316af988b2d312d83d0d1c URL: https://github.com/llvm/llvm-project/commit/be0a4fef6e789a8f25316af988b2d312d83d0d1c DIFF: https://github.com/llvm/llvm-project/commit/be0a4fef6e789a8f25316af988b2d312d83d0d1c.diff

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

aeubanks added a comment. In D66490#1638708 , @hfinkel wrote: > In D66490#1638162 , @rupprecht wrote: > > > We already know that we don't want this enabled for tsan builds due to > > https://bugs.llvm.org/show_bug.

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

kuhar added inline comments. Comment at: llvm/include/llvm/Support/GenericDomTreeConstruction.h:186 + for (auto &Pair : children(GDNodePair)) { +const NodePtr Succ = Pair.second; const auto SIT = NodeToInfo.find(Succ); kuhar wrote: > Could t

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

kuhar added inline comments. Comment at: llvm/include/llvm/IR/CFGDiff.h:199 +namespace { +template struct reverse_if_helper; +template <> struct reverse_if_helper { You can use two helper functions taking `integral_constant` tags -- should be less verbose ===

[PATCH] D70555: [coroutines] Don't build promise init with no args

This revision was automatically updated to reflect the committed changes. Closed by commit rG627e01feb718: [coroutines] Don't build promise init with no args (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://r

[clang] 627e01f - [coroutines] Don't build promise init with no args

Author: Brian Gesiak Date: 2020-04-02T21:44:54-04:00 New Revision: 627e01feb718dd1aa8e184545976b7229de312a2 URL: https://github.com/llvm/llvm-project/commit/627e01feb718dd1aa8e184545976b7229de312a2 DIFF: https://github.com/llvm/llvm-project/commit/627e01feb718dd1aa8e184545976b7229de312a2.diff

[PATCH] D77329: [AMDGPU] Allow AGPR in inline asm

yaxunl updated this revision to Diff 254668. yaxunl added a comment. fix test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77329/new/ https://reviews.llvm.org/D77329 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Targets/AMDGPU.h clang/test/CodeGenOpenCL/inline-asm-am

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

manojgupta added a comment. Yes, it'd be nice if all of the FORTIFY handling can be improved. For a simple call like memcpy of 8 bytes in the example, there is no reason to emit all these stack/range checks since they'd degrade memcpy performance. I still think this change should be reverted if

[PATCH] D77355: [clangd] show layout info when hovering on a class/field definition.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This triggers only on the definition itself, not on references (probably too noisy). Inspecting the de

[PATCH] D77342: Sema: check for null TInfo in ActOnBaseSpecifier

rsmith added a comment. I think the problem this aims to address was fixed by rG330873230071ffc2aebc0fe74db55e7a530c2f1b . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77342/new

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77335/new/ https://reviews.llvm.org/D77335 ___

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

zbrid accepted this revision. zbrid added a subscriber: jyknight. zbrid added a comment. This revision is now accepted and ready to land. LGTM. I would prefer if an actual LLVM maintainer also gave LGTM. @jyknight, @george.burgess.iv, @craig.topper? CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D77342: Sema: check for null TInfo in ActOnBaseSpecifier

MaskRay added a comment. This needs a reduced test case to demonstrate the problem and ensure clang will not regress in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77342/new/ https://reviews.llvm.org/D77342 ___

[PATCH] D77246: Instead of scream, why not roll?

rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. I'm sorry, but I can't accept this patch as-is because it removes the `u` suffix from the literal. We're never gonna give `u` up. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

sammccall added a comment. In D77335#1958106 , @efriedma wrote: > If you're going to add code to check for it, we might as well add testcases > for ridiculous sizes, like `(__int128_t)1 << 100`. Done. Looks like this was previously an assertion failure.

[PATCH] D77348: [clangd] Enable some nice clang-tidy checks by default.

sammccall updated this revision to Diff 254650. sammccall added a comment. revert debugging noise Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77348/new/ https://reviews.llvm.org/D77348 Files: clang-tools-extra/clangd/tool/ClangdMain.cpp Inde

[clang] e875ba1 - Try again to get tests passing again on Windows.

Author: Nico Weber Date: 2020-04-02T20:00:38-04:00 New Revision: e875ba1509955dc4b3512d820edecc0da26fa38d URL: https://github.com/llvm/llvm-project/commit/e875ba1509955dc4b3512d820edecc0da26fa38d DIFF: https://github.com/llvm/llvm-project/commit/e875ba1509955dc4b3512d820edecc0da26fa38d.diff LO

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

sammccall updated this revision to Diff 254646. sammccall added a comment. Add 1<<100 testcase, and clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77335/new/ https://reviews.llvm.org/D77335 Files: clang/include/clang/AST/Type.h cla

[PATCH] D77348: [clangd] Enable some nice clang-tidy checks by default.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77348 Files: clang-tools-e

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

dblaikie added a comment. Couple of small nits, but I'll leave most of the review to someoen else here - I /think/ it's beyond my context/experience (but if necessary, poke me and I can look more/ask more questions/etc) Comment at: llvm/include/llvm/Support/GenericDomTreeCons

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

sammccall added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;" aaron.b

[PATCH] D77342: Sema: check for null TInfo in ActOnBaseSpecifier

zarko created this revision. zarko added a project: clang. Herald added a subscriber: cfe-commits. zarko added a reviewer: rsmith. In certain cases (particularly when some input files are missing), GetTypeFromParser will set TInfo to nullptr in ActOnBaseSpecifier. Repository: rG LLVM Github M

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea added a comment. I sent this out to get some general feedback, but I'd like to be able to simplify the fact that this is replacing a `for` over `ChildrenGetter` with a `for` over `children(pair)`, plus 5 lines to set up the type and pair; one simplification is around getting the type i

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea created this revision. asbirlea added reviewers: kuhar, dblaikie, NutshellySima. Herald added subscribers: cfe-commits, hiraditya. Herald added a project: clang. asbirlea added a comment. asbirlea added a parent revision: D77167: [GraphDiff] Extend GraphDiff to track a list of updates..

[PATCH] D77112: [OpenMP][NFCI] Move OpenMP clause information to `lib/Frontend/OpenMP`

fghanim accepted this revision. fghanim added a comment. This revision is now accepted and ready to land. OK, As I said a few days ago, I went over the patch, and I didn't see any functional changes. I am accepting this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D77329: [AMDGPU] Allow AGPR in inline asm

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/inline-asm-amdgcn.cl:16 + float reg_b; + float reg_c; + // CHECK: call <32 x float> asm "v_mfma_f32_32x32x1f32 $0, $1, $2, $3", "=a,v,v,a,~{a0},~{a1},~{a2},~{a3},~{a4},~{a5},~{a6},~{a7},~{a8},~{a9},~{a10},~

[PATCH] D77329: [AMDGPU] Allow AGPR in inline asm

yaxunl updated this revision to Diff 254619. yaxunl added a comment. added agprs to GCCRegNames and fixed types in test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77329/new/ https://reviews.llvm.org/D77329 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Targets/AMDGPU.

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

efriedma added a comment. If you're going to add code to check for it, we might as well add testcases for ridiculous sizes, like `(__int128_t)1 << 100`. I think this makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77335/new/ https://re

[PATCH] D77234: clang/AMDGPU: Stop setting old denormal subtarget features

arsenm closed this revision. arsenm added a comment. ce2258c1cd5dc9cf20040d1b1e540d80250c1435 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77234/new/ https://reviews.llvm.org/D77234 __

[clang] ce2258c - clang/AMDGPU: Stop setting old denormal subtarget features

Author: Matt Arsenault Date: 2020-04-02T17:17:12-04:00 New Revision: ce2258c1cd5dc9cf20040d1b1e540d80250c1435 URL: https://github.com/llvm/llvm-project/commit/ce2258c1cd5dc9cf20040d1b1e540d80250c1435 DIFF: https://github.com/llvm/llvm-project/commit/ce2258c1cd5dc9cf20040d1b1e540d80250c1435.diff

[PATCH] D77313: [AST] Allow VectorTypes of 1-256 elements, and powers of two up to 2**31.

sammccall added a comment. In D77313#1957970 , @sammccall wrote: > In D77313#1957690 , @efriedma wrote: > > > I think I would rather just pay the extra 8 bytes per VectorType, and > > expand this to support all vec

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

dnsampaio added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8486-8492 + return Builder.CreateConstrainedFPCall( + F, + {EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), Ops[0]}); +} else { + Function *F = CGM.getIntrins

[PATCH] D77335: [AST] clang::VectorType supports any size (that fits in unsigned)

sammccall created this revision. sammccall added reviewers: efriedma, hokein. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches llvm::VectorType. It moves the size from the type bitfield into VectorType, increasing size by 8 bytes (including padding of 4). This is

[PATCH] D77334: [AVR] Remove duplicate specification of lib directory

dennisschagt created this revision. dennisschagt added a reviewer: dylanmckay. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77334 Files: clang/lib/Driver/ToolChains/AVR.cpp Index: clang/lib/Driver/T

[PATCH] D76949: Replace subtract-from-zero float in version with fneg in PowerPC special fma compiler builtins

ajwock updated this revision to Diff 254609. ajwock added a comment. Rebased for harbormaster. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76949/new/ https://reviews.llvm.org/D76949 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/builtins-ppc-fma.c Index: clang/test/C

[PATCH] D77313: [AST] Allow VectorTypes of 1-256 elements, and powers of two up to 2**31.

sammccall added a comment. In D77313#1957690 , @efriedma wrote: > I think I would rather just pay the extra 8 bytes per VectorType, and expand > this to support all vector types supported by LLVM. It's not like we > allocate enough VectorTypes for it to

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

rnk added a comment. In D76184#1956352 , @jdoerfert wrote: > @rnk What is the plan for this one now? Should I abandon it? Sorry, I got distracted. I tried reapplying it but it didn't apply cleanly. It's possible I hadn't locally applied your patch serie

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

dexonsmith resigned from this revision. dexonsmith added a reviewer: Bigcheese. dexonsmith added a subscriber: Bigcheese. dexonsmith added a comment. Herald added a subscriber: dexonsmith. In D76594#1957452 , @DmitryPolukhin wrote: > @rsmith, @dexonsmit

[clang] a16ba6f - Reland "Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang"

Author: Nico Weber Date: 2020-04-02T16:12:03-04:00 New Revision: a16ba6fea2e554fae465dcaaca1d687d8e83a62e URL: https://github.com/llvm/llvm-project/commit/a16ba6fea2e554fae465dcaaca1d687d8e83a62e DIFF: https://github.com/llvm/llvm-project/commit/a16ba6fea2e554fae465dcaaca1d687d8e83a62e.diff LO

[PATCH] D77062: [analyzer] Added check for unaccaptable equality operation between Loc and NonLoc types

ASDenysPetrov updated this revision to Diff 254605. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77062/new/ https://reviews.llvm.org/D77062 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp clang/test/Analysis/string.c Index: clang/test/Analysis/string.c

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn updated this revision to Diff 254601. fhahn added a comment. Implement conversion for matrix/scalar variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76794/new/ https://reviews.llvm.org/D76794 Files: clang/include/clang/Sema/Sema.h

[PATCH] D76794: [Matrix] Implement * binary operator for MatrixType.

fhahn updated this revision to Diff 254602. fhahn added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76794/new/ https://reviews.llvm.org/D76794 Files: clang/include/clang/Sema/Sema.h clang/lib/CodeGen/CGExprScalar.cpp

[PATCH] D76793: [Matrix] Implement + and - operators for MatrixType.

fhahn updated this revision to Diff 254598. fhahn added a comment. Implement conversions for matrix/scalar variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76793/new/ https://reviews.llvm.org/D76793 Files: clang/include/clang/Sema/Sema.h

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 254591. arsenm added a comment. Correct group CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Dr

[PATCH] D77329: [AMDGPU] Allow AGPR in inline asm

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. Thanks. Could you also update AMDGPUTargetInfo::GCCRegNames[] (in a separate change)? It is used in clobber constraints. JBTW, it does not support register tuples even for V and S now. C

[PATCH] D77329: [AMDGPU] Allow AGPR in inline asm

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/inline-asm-amdgcn.cl:11-14 + float acc_c; + float reg_a; + float reg_b; + float reg_c; These mostly aren't the right types? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77329/new/

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 254584. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td clang/lib/Driver/Dr

[PATCH] D77329: [AMDGPU] Allow AGPR in inline asm

yaxunl created this revision. yaxunl added reviewers: rampitec, arsenm. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. Thanks. Could you also

[clang] ab11b9e - Revert "Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang"

Author: Nico Weber Date: 2020-04-02T15:00:09-04:00 New Revision: ab11b9eefa16661017c2c7b3b34c46b069f43fb7 URL: https://github.com/llvm/llvm-project/commit/ab11b9eefa16661017c2c7b3b34c46b069f43fb7 DIFF: https://github.com/llvm/llvm-project/commit/ab11b9eefa16661017c2c7b3b34c46b069f43fb7.diff LO

[PATCH] D77054: [AArch64][SVE] Add SVE intrinsics for saturating add & subtract

efriedma added a comment. You should be able to refactor the patterns into the definitions of the multiclasses sve_int_bin_cons_arit_0 and sve_int_arith_imm0, to avoid repeating them four times. (You might want to look at other places using null_frag in SVEInstrFormats.td for inspiration.) C

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay in reviewing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72872/new/ https://reviews.llvm.org

[PATCH] D72959: Relative VTables ABI on Fuchsia

mcgrathr added inline comments. Comment at: libcxxabi/src/private_typeinfo.cpp:617 // Get (dynamic_ptr, dynamic_type) from static_ptr +#ifndef __Fuchsia__ void **vtable = *static_cast(static_ptr); ldionne wrote: > Please introduce a macro that generical

[PATCH] D76140: [InlineFunction] update attributes during inlining

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf7a16a76871: [InlineFunction] Update valid return attributes at callsite within callee body (authored by anna). Changed prior to commit: https://reviews.llvm.org/D76140?vs=254222&id=254573#toc Reposit

[PATCH] D77184: Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb80b6b2d58c: Make it possible for lit.site.cfg to contain relative paths, and use it for… (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to com

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 254570. ctetreau added a comment. Note that this is NFC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGB

[PATCH] D77313: [AST] Allow VectorTypes of 1-256 elements, and powers of two up to 2**31.

efriedma added a comment. I think I would rather just pay the extra 8 bytes per VectorType, and expand this to support all vector types supported by LLVM. It's not like we allocate enough VectorTypes for it to matter, anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fb80b6b - Make it possible for lit.site.cfg to contain relative paths, and use it for llvm and clang

Author: Nico Weber Date: 2020-04-02T13:53:16-04:00 New Revision: fb80b6b2d58c476747a3206bd4371b787108591b URL: https://github.com/llvm/llvm-project/commit/fb80b6b2d58c476747a3206bd4371b787108591b DIFF: https://github.com/llvm/llvm-project/commit/fb80b6b2d58c476747a3206bd4371b787108591b.diff LO

[libunwind] 71fbd6e - Exit unwinding early when at the top of the stack and additional info won't be found.

Author: Sterling Augustine Date: 2020-04-02T10:52:25-07:00 New Revision: 71fbd6e40632f437049215904c28ad9d63cff4bc URL: https://github.com/llvm/llvm-project/commit/71fbd6e40632f437049215904c28ad9d63cff4bc DIFF: https://github.com/llvm/llvm-project/commit/71fbd6e40632f437049215904c28ad9d63cff4bc.

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

ye-luo added a comment. My RHEL issue was caused by a CPLUS_INCLUDE_PATH environment variable. So this is feature not a bug. After removing it, everything works smoothly for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75788/new/ https://revi

[PATCH] D70555: [coroutines] Don't build promise init with no args

modocache added a comment. Of course, your approval is very welcome! 😄 I'll go ahead and land this today, thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70555/new/ https://reviews.llvm.org/D70555 __

[PATCH] D77054: [AArch64][SVE] Add SVE intrinsics for saturating add & subtract

kmclaughlin updated this revision to Diff 254558. kmclaughlin added a comment. Added patterns to AArch64SVEInstrInfo.td to support llvm.[s|u]add & llvm.[s|u]sub again, which was removed by my previous patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77054/new/ https://reviews.llvm.o

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

krasimir added a comment. In D77311#1957367 , @jfb wrote: > Some of these are technically "future reserved keywords": > https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#Keywords > > Wouldn't it be better to list all of JS'

[PATCH] D76140: [InlineFunction] update attributes during inlining

anna added a comment. In D76140#1957416 , @reames wrote: > LGTM again, with minor change. will update it. > p.s. Sorry for missing the functional issue the first time. All of the test > changes should have made the issue obvious, but despite reading t

[PATCH] D77085: [clang-tidy] Added support for validating configuration options

njames93 updated this revision to Diff 254552. njames93 added a comment. - Small refactor Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77085/new/ https://reviews.llvm.org/D77085 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp clang-too

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); yaxunl wrote

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert abandoned this revision. jdoerfert added a comment. In D77240#1957468 , @tra wrote: > In D77240#1957386 , @jdoerfert wrote: > > > I just noticed those as well. I forgot to put the new definitions into the

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. In D77240#1957386 , @jdoerfert wrote: > I just noticed those as well. I forgot to put the new definitions into the > forward declare header. Will do it in a second. The OpenMP math overlay > doesn't have one so I forgot :( I'm not

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added a comment. @rsmith, @dexonsmith, @jdoerfert could you please take a look to this diff? If you think that there are other reviewers who might have more context AST persistence, please add them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh friendly ping I implemented solution with priorities to resolve your concerns about `get()` vs `getLocalOrGlobal()` Could you please take another look to this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

xbolva00 added a comment. Fix is easy, can you commit it as obvious? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

b-sumner added a comment. Please go ahead and update to a string for the scope. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

ye-luo accepted this revision. ye-luo added a comment. This revision is now accepted and ready to land. Good work. I verified that PR42798 and PR42799 are fixed by this. Tests are completed on Ubuntu 18.04. Clang now becomes usable for application developers. There are still issues on RHEL that o

[PATCH] D76140: [InlineFunction] update attributes during inlining

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM again, with minor change. p.s. Sorry for missing the functional issue the first time. All of the test changes should have made the issue obvious, but despite reading the LangRef descrip

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + sepavloff wrote: > erichkeane wrote: > > rjmccall wrote: > > > erichkeane wrote: > > > > rjmccall wrote: > > > > > rjmccall wrote: > > > > > > erichk

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl updated this revision to Diff 254537. yaxunl marked 2 inline comments as done. yaxunl added a comment. Herald added a reviewer: jdoerfert. added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77028/new/ https://reviews.llvm.org/D77028 Files: clang/include/clang/Sema/Se

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); rjmccall wrote

[PATCH] D76679: [SveEmitter] Add more immediate operand checks.

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. I think the float16 discussion is an interesting one, but doesn't necessarily need to be done here. I am asking some questions offline, but if we ever come to a different opinion o

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert added a comment. I just noticed those as well. I forgot to put the new definitions into the forward declare header. Will do it in a second. The OpenMP math overlay doesn't have one so I forgot :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D77206: [clangd] Don't send semanticHighlights to clients that support semanticTokens.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc830106e155: [clangd] Don't send semanticHighlights to clients that support semanticTokens. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D77225: [clangd] Support textDocument/semanticTokens/edits

This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3063eaceec: [clangd] Support textDocument/semanticTokens/edits (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77225?vs=254226&id=254536#toc Repository: rG LLVM Github M

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

This revision was automatically updated to reflect the committed changes. Closed by commit rG24bb2d1e7768: [clangd] Add a tweak for adding "using" statement. (authored by adamcz, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang-tools-extra] 9e3063e - [clangd] Support textDocument/semanticTokens/edits

Author: Sam McCall Date: 2020-04-02T17:38:29+02:00 New Revision: 9e3063eaceec5054684a77acf5281772df2a7f73 URL: https://github.com/llvm/llvm-project/commit/9e3063eaceec5054684a77acf5281772df2a7f73 DIFF: https://github.com/llvm/llvm-project/commit/9e3063eaceec5054684a77acf5281772df2a7f73.diff LO

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

aykevl added a comment. I have the same issue as @wenju. The second time I call `ExecuteCompilerInvocation` it will give the error above, leading me to believe some memory isn't properly cleared. Note: the `--pgo-warn-misexpect` option is not passed in the compiler invocation. Repository:

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

jfb added a comment. Some of these are technically "future reserved keywords": https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Lexical_grammar#Keywords Wouldn't it be better to list all of JS's keywords at this point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77313: [AST] Allow VectorTypes of 1-256 elements, and powers of two up to 2**31.

sammccall created this revision. sammccall added reviewers: hokein, rjmccall, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to be 1-2043 elements, and recently regressed to a limit of 1023. The new behavior is an almost-superset of GCC, which accepts

[clang-tools-extra] fc83010 - [clangd] Don't send semanticHighlights to clients that support semanticTokens.

Author: Sam McCall Date: 2020-04-02T17:38:02+02:00 New Revision: fc830106e15553fcca3fc80066fe5a988e16dfec URL: https://github.com/llvm/llvm-project/commit/fc830106e15553fcca3fc80066fe5a988e16dfec DIFF: https://github.com/llvm/llvm-project/commit/fc830106e15553fcca3fc80066fe5a988e16dfec.diff LO

[clang-tools-extra] 24bb2d1 - [clangd] Add a tweak for adding "using" statement.

Author: Adam Czachorowski Date: 2020-04-02T17:37:38+02:00 New Revision: 24bb2d1e776897c3a93856d2ca76decb4cfd0562 URL: https://github.com/llvm/llvm-project/commit/24bb2d1e776897c3a93856d2ca76decb4cfd0562 DIFF: https://github.com/llvm/llvm-project/commit/24bb2d1e776897c3a93856d2ca76decb4cfd0562.d

[PATCH] D76790: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rG1525232e2761: [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints (authored by martong). Changed prior to commit: https://reviews.llvm.org/D76790?vs=253595&id=254530#toc Repository: r

[PATCH] D77311: clang-format: [JS] detect C++ keywords.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. C++ defines a number of keywords that are regular identifiers in JavaScript, e.g. `concept`: const concept = 1; // legit JS This change expands the exis

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:407 case GlobalValue::WeakAnyLinkage: case GlobalValue::WeakODRLinkage: if (MAI->hasWeakDefDirective()) { Could we verify if these Linkage should also always emit .w

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein updated this revision to Diff 254525. hokein added a comment. remove accident change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77041/new/ https://reviews.llvm.org/D77041 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/inva

[PATCH] D77309: [clangd] Get rid of ASTWorker::getCurrentFileInputs

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D76725: [clangd] Build ASTs only with fresh preambles or

[clang] 1525232 - [analyzer] StdLibraryFunctionsChecker: fix bug with arg constraints

Author: Gabor Marton Date: 2020-04-02T17:00:11+02:00 New Revision: 1525232e276153e325a49372894ae52ed07351a5 URL: https://github.com/llvm/llvm-project/commit/1525232e276153e325a49372894ae52ed07351a5 DIFF: https://github.com/llvm/llvm-project/commit/1525232e276153e325a49372894ae52ed07351a5.diff

[clang-tools-extra] da8eda1 - [clangd] Get rid of redundant make_uniques

Author: Kadir Cetinkaya Date: 2020-04-02T16:52:13+02:00 New Revision: da8eda1ab1ae97115f9ed170216ed89b69662578 URL: https://github.com/llvm/llvm-project/commit/da8eda1ab1ae97115f9ed170216ed89b69662578 DIFF: https://github.com/llvm/llvm-project/commit/da8eda1ab1ae97115f9ed170216ed89b69662578.dif

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

hliao added a comment. In D59321#1955646 , @arsenm wrote: > In D59321#1955405 , @hliao wrote: > > > Do we have a better way to avoid adding those empty bitcode files? > > > No, we need the files to exist for tests.

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

kadircet updated this revision to Diff 254520. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76725/new/ https://reviews.llvm.org/D76725 Files: clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Pr

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet updated this revision to Diff 254519. kadircet added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76304/new/ https://reviews.llvm.org/D76304 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-tools-extra/cl

  1   2   >