anna added a comment. In D76140#1957416 <https://reviews.llvm.org/D76140#1957416>, @reames wrote:
> LGTM again, with minor change. will update it. > p.s. Sorry for missing the functional issue the first time. All of the test > changes should have made the issue obvious, but despite reading the LangRef > description of signext, I somehow managed to miss the separation between ABI > and optimization attributes. thanks for the review Philip and pointing out the problem. All of us had missed the functional issue the first time around. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76140/new/ https://reviews.llvm.org/D76140 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
