[PATCH] D76119: [Coroutines] Insert lifetime intrinsics even O0 is used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd0f4af8f3088: [Coroutines] Insert lifetime intrinsics even O0 is used (authored by junparser). Herald added a project: cla

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d0f4af8 - [Coroutines] Insert lifetime intrinsics even O0 is used

Author: Jun Ma Date: 2020-03-24T13:41:55+08:00 New Revision: d0f4af8f3088f72df7fea9983127cbeeebbef6a1 URL: https://github.com/llvm/llvm-project/commit/d0f4af8f3088f72df7fea9983127cbeeebbef6a1 DIFF: https://github.com/llvm/llvm-project/commit/d0f4af8f3088f72df7fea9983127cbeeebbef6a1.diff LOG: [

[PATCH] D76643: [objc_direct] also go through implementations when looking for clashes

This revision was automatically updated to reflect the committed changes. Closed by commit rG20d704a75ed5: [objc_direct] also go through implementations when looking for clashes (authored by MadCoder). Changed prior to commit: https://reviews.llvm.org/D76643?vs=252162&id=252214#toc Repository:

[clang] 20d704a - [objc_direct] also go through implementations when looking for clashes

Author: Pierre Habouzit Date: 2020-03-23T20:49:09-07:00 New Revision: 20d704a75ed51c7a9a155aa3978d0c02671c3f69 URL: https://github.com/llvm/llvm-project/commit/20d704a75ed51c7a9a155aa3978d0c02671c3f69 DIFF: https://github.com/llvm/llvm-project/commit/20d704a75ed51c7a9a155aa3978d0c02671c3f69.dif

[PATCH] D76229: [clang-tidy] Added PlacementNewStorageCheck

NoQ added a comment. In D76229#1929453 , @martong wrote: > Please note about the alignment requirements that they are not checked in the > static analyzer for a reason. To track the alignment data across the data > flow, probably we should modify the ana

[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL, error if an output loc is missing for PathDiagConsumers that need it

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:209 AnalysisConstraints AnalysisConstraintsOpt = RangeConstraintsModel; - AnalysisDiagClients AnalysisDiagOpt = PD_HTML; + AnalysisDiagClients AnalysisDiagOpt = PD_TEXT_MINIMAL;

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252205. oontvoo added a comment. Fix build errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252206. oontvoo added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/clang/Lex/

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252203. oontvoo added a comment. (hopefully) Final revision ... running out of idea for edit comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/incl

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso marked 5 inline comments as done. Charusso added a comment. Thanks for the feedback! Given that it will remain an `alpha` checker for a long time (~1 year), no one really should use it. Comment at: clang/docs/analyzer/checkers.rst:1935 + +alpha.security.cert.str.31c +

[PATCH] D75677: [Analyzer] Only add iterator note tags to the operations of the affected iterators

NoQ added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:541-542 +BR.markInteresting(It1); +if (const auto &LCV1 = It1.getAs()) { + BR.markInteresting(LCV1->getRegion()); +

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name = DRE->getDecl()->getName(); NoQ wrote: > baloghadamsoftware wrote: > >

[PATCH] D74615: [Analyzer] Add visitor to track iterator invalidation

NoQ added a comment. Herald added a subscriber: ASDenysPetrov. > However, if //something// happens to the value in a transition which is done > by another checker (or the core engine) then ... then //that// checker (or the engine) adds a tag in order to explain itself, because from its point of

[PATCH] D74541: [Analyzer] Use note tags to track iterator increments and decrements

NoQ added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:489-490 +StringRef ChangeText = + ((Op == OO_Plus || Op == OO_PlusEqual) != (ChangeVal <= 0)) ? + "incremented" : "decremented"; +

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

NoQ added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:713 + StringRef Name; + if (const auto *DRE = dyn_cast(ContE->IgnoreParenCasts())) { +Name = DRE->getDecl()->getName();

[PATCH] D76592: [Parser] Fix the assertion crash in ActOnStartOfSwitch stmt.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaStmt.cpp:709 } SwitchDiagnoser(Cond); + // The TypoExpr might be corrected to a non-intergral-or-enum type in the + // later stage without the proper type check, which is invalid for switch How

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76528/new/ https://reviews.llvm.org/D76528 ___ cf

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a simpler request/response protocol. Reference: https://github.com/microsoft/vscode-

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

phosek added inline comments. Comment at: clang/lib/Driver/Driver.cpp:140 + if (llvm::sys::path::is_relative(SysRoot)) { +SysRoot = GetResourcesPath(ClangExecutable, SysRoot); + } I don't think this is an intended use for `GetResourcesPath` since this is no

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 added a comment. I have no idea how to write a test for this, but I tested it locally with wasi SDK. Hopefully fucia will find this useful too as a generic version of https://reviews.llvm.org/D42019 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D76643: [objc_direct] also go through implementations when looking for clashes

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Sema/SemaDeclObjC.cpp:4621 + // - when we do not find a match in a given @interface container, + // we need to attempt lookin

[PATCH] D60748: Adds an option "malign-pass-aggregate" to make the alignment of the struct and union parameters compatible with the default gcc

LiuChen3 marked an inline comment as done. LiuChen3 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:1570 +return 4; +} else if (Align < 16) + return MinABIStackAlignInBytes; LiuChen3 wrote: > jyknight wrote: > > If I understoo

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, mgorny, dschuff. Herald added a project: clang. sbc100 retitled this revision from "Allow -DDEFAULT_SYSROOT to be a relative path" to "[clang] Allow -DDEFAULT_SYSROOT to be a relative path". sbc100 added reviewe

[PATCH] D76605: [analyzer] Display the checker name in the text output

NoQ added a comment. Sounds great! Does the checker name get printed on the final note as well in text output? We should probably test it. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:313-316 +ANALYZER_OPTION(bool, ShouldDisplayCheckerNameForText, "

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

NoQ added a comment. In D76379#1930917 , @baloghadamsoftware wrote: > In D76379#1929698 , @Szelethus wrote: > > > The patch looks great, though I'd kindly ask you to wait a bit for someone > > with a bit more expe

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

NoQ added a comment. Sounds good but eventually i hope we re-enable this assert in release+assert builds (D57062 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76622/new/ https://reviews.llvm.org/D76622 __

[clang-tools-extra] edf6a19 - [clangd] Rename theia-derived semantic highlighting protocol. NFC

Author: Sam McCall Date: 2020-03-24T00:39:47+01:00 New Revision: edf6a19adf7acf54f96e78718fb2339e5fcbc444 URL: https://github.com/llvm/llvm-project/commit/edf6a19adf7acf54f96e78718fb2339e5fcbc444 DIFF: https://github.com/llvm/llvm-project/commit/edf6a19adf7acf54f96e78718fb2339e5fcbc444.diff LO

[clang] 5bd0611 - Update documentation for __builtin_operator_new and

Author: Richard Smith Date: 2020-03-23T16:31:10-07:00 New Revision: 5bd06118c2a798f1f87b9251953bae8a27f21e5f URL: https://github.com/llvm/llvm-project/commit/5bd06118c2a798f1f87b9251953bae8a27f21e5f DIFF: https://github.com/llvm/llvm-project/commit/5bd06118c2a798f1f87b9251953bae8a27f21e5f.diff

[PATCH] D76547: [WebAssembly] Add wasm-exported function attribute

kripken accepted this revision. kripken added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Basic/AttrDocs.td:4173 +attribute for the WebAssembly target. This attribute may be attached to a +function declaration, where it causes

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

efriedma added a comment. Actually looking again, I'm not sure there's any way to make clang generate a bool vector at the moment. Added tests for the rest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76528/new/ https://reviews.llvm.org/D76528

[PATCH] D76323: [AST] Fix handling of long double and bool in __builtin_bit_cast

rsmith added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:6364-6371 +const llvm::fltSemantics &Semantics = Info.Ctx.getFloatTypeSemantics(Ty); +unsigned NumBits = APFloat::semanticsSizeInBits(Semantics); +assert(NumBits % 8 == 0); +CharUnits Width =

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

efriedma updated this revision to Diff 252169. efriedma edited the summary of this revision. efriedma added a comment. Add testcase to show missing vector handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76528/new/ https://reviews.llvm.org/D

[clang] 2b4027f - [analyzer] Delete unneeded headers and using after D76509 for layering check

Author: Fangrui Song Date: 2020-03-23T16:11:15-07:00 New Revision: 2b4027f2b8d8224266cc2a423d9ccd74f6800711 URL: https://github.com/llvm/llvm-project/commit/2b4027f2b8d8224266cc2a423d9ccd74f6800711 DIFF: https://github.com/llvm/llvm-project/commit/2b4027f2b8d8224266cc2a423d9ccd74f6800711.diff

[PATCH] D76643: [objc_direct] also go through implementations when looking for clashes

MadCoder updated this revision to Diff 252162. MadCoder edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76643/new/ https://reviews.llvm.org/D76643 Files: clang/lib/Sema/SemaDeclObjC.cpp clang/test/SemaObjC/method-direct-one-definition.m clang/test

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert added a comment. In D76184#1927159 , @rnk wrote: > I patched this in with it's dependency, and to compile just Attr.h by itself, > it reduces the time from ~2.420s to ~1.920s, so it is worth pushing this > through. :) > > However, I noticed tha

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. Rebased on Master again, recompiling and re-running all the tests. I'll update this comment when it passes, or create a new diff if it doesn't but nothing had to be changed so it'll probably work. @krasimir I noticed that you've been active recently, can you rev

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

dblaikie created this revision. dblaikie added a reviewer: rsmith. Herald added subscribers: cfe-commits, jfb. Herald added a reviewer: jdoerfert. Herald added a project: clang. There is a version that just tests (also called isIntegerConstantExpression) & whereas this version is specifically used

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

jfb added a comment. The test files I added checked initialization had stores to each padding location, I think that's what would be needed here as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76528/new/ https://reviews.llvm.org/D76528 _

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252159. lolleko added a comment. Final Cleanup Removed markdown linebreak parsing for now. No I don't have commit rights yet. Feel fre to merge this for me. Thanks for the thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Sent https://reviews.llvm.org/D76646 to hopefully make this a bit more legible On Mon, Mar 23, 2020 at 2:38 PM David Blaikie wrote: > Ah, thanks. (I'm going to see about renaming/restructuring that API - to > return Optional and be called 'get' rather than 'is' to make this > more clear) > > On

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Mon, Mar 23, 2020 at 5:24 AM Aaron Ballman wrote: > On Sun, Mar 22, 2020 at 3:31 PM David Blaikie wrote: > > > > On Sun, Mar 22, 2020 at 9:34 AM Aaron Ballman > wrote: > >> > >> On Sun, Mar 22, 2020 at 12:19 PM David Blaikie > wrote: > >> > > >> > On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballm

[clang] 1236eb6 - [OPENMP50]Add 'default' modifier in reduction clauses.

Author: Alexey Bataev Date: 2020-03-23T18:18:08-04:00 New Revision: 1236eb6c31ff0c1c9b69c544d735a3de4e0fc687 URL: https://github.com/llvm/llvm-project/commit/1236eb6c31ff0c1c9b69c544d735a3de4e0fc687 DIFF: https://github.com/llvm/llvm-project/commit/1236eb6c31ff0c1c9b69c544d735a3de4e0fc687.diff

[PATCH] D76643: [objc_direct] also go through implementations when looking for clashes

MadCoder created this revision. MadCoder added reviewers: erik.pilkington, ahatanak, dexonsmith, arphaman. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some methods are sometimes declared in the @implementation blocks which can cause undiagnosed clashes. Just write a ch

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252153. lolleko added a comment. typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76094/new/ https://reviews.llvm.org/D76094 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Hover.h c

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252151. lolleko added a comment. Final Cleanup Removed markdown linebreak parsing for now. No I don't have commit rights yet. Feel fre to merge this for me. Thanks for the thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. @craig.topper that would mean that it couldn't be constexpr though, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 ___ cfe-co

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 252147. ZarkoCA added a comment. Simplified testcases. Added testcases for variadic arguments being passed directly to the stack when all registers are used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

efriedma added a comment. Not sure what sort of test would catch this; it's not crashing, and the types with the tail padding issue are not naturally exposed by target intrinsic headers (so it would only show up for code using ext_vector_type, or maybe OpenCL code). I only tripped over the iss

[clang] 502915c - PR45142: 'template ~X' is ill-formed; reject it rather than crashing.

Author: Richard Smith Date: 2020-03-23T15:07:06-07:00 New Revision: 502915c619a32972ddc525be585794371bfbd27b URL: https://github.com/llvm/llvm-project/commit/502915c619a32972ddc525be585794371bfbd27b DIFF: https://github.com/llvm/llvm-project/commit/502915c619a32972ddc525be585794371bfbd27b.diff

[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

zhizhouy updated this revision to Diff 252143. zhizhouy marked 4 inline comments as done. zhizhouy retitled this revision from "[NFC] Do not run CGProfilePass when -fno-integrated-as is on" to "[NFC] Do not run CGProfilePass when not using integrated assembler". zhizhouy added a comment. Thanks

[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

xur added a comment. look good to me with the fix of comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:110 + /// Tuning option to enable/disable call graph profile. Its default value is + /// true. + bool CallGrpahProfile; The default value is spe

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Ah, thanks. (I'm going to see about renaming/restructuring that API - to return Optional and be called 'get' rather than 'is' to make this more clear) On Mon, Mar 23, 2020 at 5:04 AM Mikhail Maltsev wrote: > Yes, it does. isIntegerConstantExpr assigns a value to CoprocNoAP. > > -- > Regards, >

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a4421a5e860: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific)… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

This revision was automatically updated to reflect the committed changes. Closed by commit rG5896e2df45da: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain is in the… (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

This revision was automatically updated to reflect the committed changes. Szelethus marked 6 inline comments as done. Closed by commit rG7bf871c39f73: [analyzer][NFC] Move the text output type to its own file, move code to… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

yaxunl added a comment. In D76631#1937681 , @aganea wrote: > In D76631#1937428 , @yaxunl wrote: > > > I am curious why opt and llc is not affected > > > In one case (opt, llc, clang-offload-bundler) it finds those p

[PATCH] D76472: AMDGPU: Emit llvm.fshr for __builtin_amdgcn_alignbit

arsenm closed this revision. arsenm added a comment. 3f533006ba8c8ae6f3596f49f480aa794ed4e347 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76472/new/ https://reviews.llvm.org/D76472 __

[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

manojgupta added a comment. Thanks, Noticed a few typos. Rest lgtm but deferring to other reviewers for now for approval. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1110 PTO.SLPVectorization = CodeGenOpts.VectorizeSLP; + PTO.CallGrpahProfile = CodeGenOpts.CallGraphProf

[clang] 1a4421a - [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

Author: Simon Pilgrim Date: 2020-03-23T21:03:14Z New Revision: 1a4421a5e860ffc63c77594c9fb40787f84241aa URL: https://github.com/llvm/llvm-project/commit/1a4421a5e860ffc63c77594c9fb40787f84241aa DIFF: https://github.com/llvm/llvm-project/commit/1a4421a5e860ffc63c77594c9fb40787f84241aa.diff LOG:

[clang] 5896e2d - [Clang] Fix HIP tests when running on Windows with the LLVM toolchain is in the path

Author: Alexandre Ganea Date: 2020-03-23T16:54:48-04:00 New Revision: 5896e2df45dab7680be321ee63903431a673817b URL: https://github.com/llvm/llvm-project/commit/5896e2df45dab7680be321ee63903431a673817b DIFF: https://github.com/llvm/llvm-project/commit/5896e2df45dab7680be321ee63903431a673817b.dif

[clang] 3f53300 - AMDGPU: Emit llvm.fshr for __builtin_amdgcn_alignbit

Author: Matt Arsenault Date: 2020-03-23T16:51:25-04:00 New Revision: 3f533006ba8c8ae6f3596f49f480aa794ed4e347 URL: https://github.com/llvm/llvm-project/commit/3f533006ba8c8ae6f3596f49f480aa794ed4e347 DIFF: https://github.com/llvm/llvm-project/commit/3f533006ba8c8ae6f3596f49f480aa794ed4e347.diff

[clang] 7bf871c - [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

Author: Kirstóf Umann Date: 2020-03-23T21:50:40+01:00 New Revision: 7bf871c39f739a7382ba89c97f50fd047f36f894 URL: https://github.com/llvm/llvm-project/commit/7bf871c39f739a7382ba89c97f50fd047f36f894 DIFF: https://github.com/llvm/llvm-project/commit/7bf871c39f739a7382ba89c97f50fd047f36f894.diff

[PATCH] D76472: AMDGPU: Emit llvm.fshr for __builtin_amdgcn_alignbit

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76472/new/ https://reviews.llvm.org/D76472 ___ cfe-commits mailing list cfe-commi

[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

zhizhouy updated this revision to Diff 252129. zhizhouy marked 2 inline comments as done. zhizhouy edited the summary of this revision. zhizhouy added a reviewer: manojgupta. zhizhouy removed a subscriber: manojgupta. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repositor

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

rsmith added a comment. In D76572#1937641 , @Quuxplusone wrote: > [...] take my word for it, you **don't** want to start with the code I wrote > the other day. :) Understood, thanks :) (FWIW, I had a stab at implementing essentially this last year and

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/switch-implicit-fallthrough.cpp:110-114 +case 26: + return 0; +__attribute__((fallthrough)); // expected-warning{{fallthrough annotation in unreachable code}} +case 27: + break; ---

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7727 +// Move function type attribute to the declarator. +case ParsedAttr::AT_LifetimeContract: xazax.hun wrote: > aaron.ballman wrote: > > xazax.hun wrote: > > > aaron.ballman

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

aganea added a comment. In D76631#1937428 , @yaxunl wrote: > I am curious why opt and llc is not affected In one case (opt, llc, clang-offload-bundler) it finds those programs in the "program paths", ie. the build folder: https://github.com/llvm/llvm-p

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

leonardchan added a comment. In D74619#1936336 , @pratlucas wrote: > Hi @leonardchan , > > I've double-checked the Neon intrinsics reference and it indeed confirms that > the only allowed value for the lane argument for `vdupq_lane_f64` is `0`: > > Argu

[clang] cfaa84e - Fix "previously declared as a struct" warning

Author: Vitaly Buka Date: 2020-03-23T12:59:16-07:00 New Revision: cfaa84e1a679b2e2eb409eb57292f7caecb642d4 URL: https://github.com/llvm/llvm-project/commit/cfaa84e1a679b2e2eb409eb57292f7caecb642d4 DIFF: https://github.com/llvm/llvm-project/commit/cfaa84e1a679b2e2eb409eb57292f7caecb642d4.diff L

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D75360#1937557 , @JDevlieghere wrote: > Oh, I'm sorry, I just reverted it like a minute ago. Its fine, I'll recommit when I have a fix as we

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

rjmccall added a comment. In D74183#1937426 , @efriedma wrote: > I think we should remove the LangRef rule that says "sret" pointers have to > be dereferenceable/naturally aligned, and let the frontend add explicit > aligned/dereferenceable markings wher

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone added a comment. In D76572#1937558 , @rsmith wrote: > In D76572#1935791 , @lebedev.ri > wrote: > > > Passing-by remark: > > > > > I wrote a Clang warning [not pictured] to diagnose any use of `T(x)` >

[PATCH] D31343: Add an attribute plugin example

erichkeane added a comment. In D31343#1937588 , @aaron.ballman wrote: > In D31343#1936810 , @Jasmin wrote: > > > Hello John! > > > > I was encouraged by Erich after a talk I had with him and Aaron on IRC to > > co

[PATCH] D76527: Don't export symbols from clang/opt/llc if plugins are disabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rG896335bfb8ea: Don't export symbols from clang/opt/llc if plugins are disabled. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76527/ne

[PATCH] D76173: [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s

This revision was automatically updated to reflect the committed changes. Closed by commit rG55eca2853e4f: [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D76173?vs=250347&id=252123#toc Repository:

[PATCH] D31343: Add an attribute plugin example

aaron.ballman added a comment. In D31343#1936810 , @Jasmin wrote: > Hello John! > > I was encouraged by Erich after a talk I had with him and Aaron on IRC to > contact you about an use case for this plugin. > > I wanted to use user-specified/unknown attri

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252118. oontvoo added a comment. Clear pending action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h clang/include/c

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252117. oontvoo marked an inline comment as done. oontvoo added a comment. Add a PendingHeaderSearch set Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76631/new/ https://reviews.llvm.org/D76631 __

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Changes LGTM on the Clang side. In D76572#1935791 , @lebedev.ri wrote: > Passing-by remark: > > > I wrote a Clang warning [not pictured] to diagnose an

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

JDevlieghere added a comment. In D75360#1937556 , @Szelethus wrote: > In D75360#1937415 , @JDevlieghere > wrote: > > > It appears this broke the modules build: > > http://green.lab.llvm.org/green/view/LLDB/job/lld

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus added a comment. In D75360#1937415 , @JDevlieghere wrote: > It appears this broke the modules build: > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12905/console > > Can you please take a look? Yup, on it. Repository: rG LLVM

[clang] 55eca28 - [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s

Author: Johannes Doerfert Date: 2020-03-23T14:23:46-05:00 New Revision: 55eca2853e4f096be189208770034a8a4fb72666 URL: https://github.com/llvm/llvm-project/commit/55eca2853e4f096be189208770034a8a4fb72666 DIFF: https://github.com/llvm/llvm-project/commit/55eca2853e4f096be189208770034a8a4fb72666.d

[clang] 896335b - Don't export symbols from clang/opt/llc if plugins are disabled.

Author: Eli Friedman Date: 2020-03-23T12:17:09-07:00 New Revision: 896335bfb8ea2c09c361c4f1e5a9aa6fb78caf88 URL: https://github.com/llvm/llvm-project/commit/896335bfb8ea2c09c361c4f1e5a9aa6fb78caf88 DIFF: https://github.com/llvm/llvm-project/commit/896335bfb8ea2c09c361c4f1e5a9aa6fb78caf88.diff

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Mon, Mar 23, 2020 at 1:41 PM Craig Topper wrote: > > If its relatively common for someone making a plugin to mess this up, maybe > it should be report_fatal_error instead of only catching it in asserts build? I think that would also be a reasonable solution if that's the preference. ~Aaron

[clang] 56abcfa - Revert "[analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes"

Author: Jonas Devlieghere Date: 2020-03-23T12:09:24-07:00 New Revision: 56abcfad70ee679ad95ab41d934491ebcaebdf7d URL: https://github.com/llvm/llvm-project/commit/56abcfad70ee679ad95ab41d934491ebcaebdf7d DIFF: https://github.com/llvm/llvm-project/commit/56abcfad70ee679ad95ab41d934491ebcaebdf7d.d

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl updated this revision to Diff 252105. yaxunl added a comment. add TODO for fixing space separated arguments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76520/new/ https://reviews.llvm.org/D76520 Files: clang/include/clang/Driver/Options.td clang/include/clang/Driver/ToolCh

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252110. oontvoo added a comment. Updated the reader to read the UIDs first, then we'll build up the Importers list at the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert added a comment. In D76184#1927159 , @rnk wrote: > I patched this in with it's dependency, and to compile just Attr.h by itself, > it reduces the time from ~2.420s to ~1.920s, so it is worth pushing this > through. :) > > However, I noticed tha

[PATCH] D76594: [clang][AST] User relative offsets inside AST file

DmitryPolukhin added a comment. In D76594#1937289 , @sammccall wrote: > This looks reasonable to me, though I'm not familiar enough with the code to > do a good review. > > Just wanted to confirm my understanding: the problematic offsets that are now > s

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

efriedma added a comment. I think we should remove the LangRef rule that says "sret" pointers have to be dereferenceable/naturally aligned, and let the frontend add explicit aligned/dereferenceable markings where appropriate. (At that point, sret has no target-independent meaning; it's just to

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

yaxunl added a comment. I am curious why opt and llc is not affected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76631/new/ https://reviews.llvm.org/D76631 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wuzish. I'm just going to assume the test changes look good; thank you for taking the time to do this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D741

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

JDevlieghere added a comment. It appears this broke the modules build: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12905/console Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llv

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. In D76384#1936769 , @mibintc wrote: > In D76384#1934785 , @rjmccall wrote: > > > Let's make this patch be purely a representation change. I wouldn't expect > > *any* test changes from tha

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added a comment. In D74918#1937291 , @lebedev.ri wrote: > In D74918#1937237 , @zoecarver wrote: > > > @lebedev.ri Where should I put this? Could you maybe point me to another > > LLVM target API that c

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

tra added a comment. In D76520#1937294 , @yaxunl wrote: > -Xarch_ does not work for passing -cc1 options in the beginning. This patch > does not change that. > > This requires some further changes about how the options after -Xarch_ are > handled. I woul

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

rjmccall added a comment. Sure. I'm not asking you to fix this, I'm just asking your opinion about the right thing to do. Is the Sphinx warning reasonable, such that we should fix our (autogenerated, IIRC) input to avoid the "redundant" spellings, or should we ask Sphinx to handle it more gra

  1   2   3   >