[PATCH] D74564: libclang: Add static build support for Windows

yvvan added a comment. Please, upload patches with context (-U). Comment at: clang/include/clang-c/Platform.h:31 +#elif defined(CINDEX_EXPORTS) + #define CINDEX_LINKAGE __attribute__((visibility("default"))) +#endif Is it different from just leaving CINDEX

[PATCH] D74698: [CodeGen] -pg shouldn't add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 244916. nickdesaulniers added a comment. - add test line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/

[PATCH] D74698: [CodeGen] -pg shouldn't add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers created this revision. nickdesaulniers added reviewers: void, manojgupta, dberris. Herald added a project: clang. Herald added a subscriber: cfe-commits. $ clang -O2 -pg -mfentry foo.c was adding frame pointers to all functions. This was exposed via compiling the Linux kernel for

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nathanchance added a comment. There appear to a be semantic difference between GCC and clang with the current version of this patch which results in a lot of additional warnings in the Linux kernel: https://godbolt.org/z/eHFJd8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

RE: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

[AMD Official Use Only - Internal Distribution Only] Thanks a lot for fixing it. Sam -Original Message- From: Fangrui Song via Phabricator Sent: Sunday, February 16, 2020 8:41 PM To: Liu, Yaxun (Sam) ; t...@google.com; rjmcc...@gmail.com; rich...@metafoo.co.uk; jdoerf...@anl.gov; a.ba

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

MaskRay added inline comments. Comment at: clang/lib/Sema/Sema.cpp:14 +#include "UsedDeclVisitor.h" #include "clang/AST/ASTContext.h" hliao wrote: > this file is missing and breaks the build Fixed by c7fa409bcadaf4ddba1862b2e52349e0ab03d1b4 Repository: rG

[clang] c7fa409 - [CUDA][HIP][OpenMP] Add lib/Sema/UsedDeclVisitor.h after D70172

Author: Fangrui Song Date: 2020-02-16T20:33:07-08:00 New Revision: c7fa409bcadaf4ddba1862b2e52349e0ab03d1b4 URL: https://github.com/llvm/llvm-project/commit/c7fa409bcadaf4ddba1862b2e52349e0ab03d1b4 DIFF: https://github.com/llvm/llvm-project/commit/c7fa409bcadaf4ddba1862b2e52349e0ab03d1b4.diff

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

hliao added a comment. one header is missing and breaks the build Comment at: clang/lib/Sema/Sema.cpp:14 +#include "UsedDeclVisitor.h" #include "clang/AST/ASTContext.h" this file is missing and breaks the build Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG1b978ddba05c: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST

[clang] 1b978dd - [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

Author: Yaxun (Sam) Liu Date: 2020-02-16T22:44:33-05:00 New Revision: 1b978ddba05cb15e22b4e75adb5e7362ad861987 URL: https://github.com/llvm/llvm-project/commit/1b978ddba05cb15e22b4e75adb5e7362ad861987 DIFF: https://github.com/llvm/llvm-project/commit/1b978ddba05cb15e22b4e75adb5e7362ad861987.dif

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGfb44b9db95a3: [OpenCL][CUDA][HIP][SYCL] Add norecurse (authored by yaxunl). Herald added subscribers: kerbowa, nhaehnle, j

[clang] fb44b9d - [OpenCL][CUDA][HIP][SYCL] Add norecurse

Author: Yaxun (Sam) Liu Date: 2020-02-16T20:41:00-05:00 New Revision: fb44b9db95a333efdfa9a33ddc1778f97428f5f5 URL: https://github.com/llvm/llvm-project/commit/fb44b9db95a333efdfa9a33ddc1778f97428f5f5 DIFF: https://github.com/llvm/llvm-project/commit/fb44b9db95a333efdfa9a33ddc1778f97428f5f5.dif

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3adcc78a8071: [objc_direct] Small updates to help with adoption. (authored by MadCoder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73755/new/ https://re

[clang] 3adcc78 - [objc_direct] Small updates to help with adoption.

Author: Pierre Habouzit Date: 2020-02-16T16:32:41-08:00 New Revision: 3adcc78a8071e7d6dd9aa34979f9842a72a2d91b URL: https://github.com/llvm/llvm-project/commit/3adcc78a8071e7d6dd9aa34979f9842a72a2d91b DIFF: https://github.com/llvm/llvm-project/commit/3adcc78a8071e7d6dd9aa34979f9842a72a2d91b.dif

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 244894. mibintc added a comment. I found the problem in the #pragma float_control (push/pop) stack, it was just a dumb bug. I also added -include-pch test cases, and added code to ASTWriter ASTReader to preserve the floatcontrol pragma stack For 2 of the n

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

njames93 added a comment. In D74463#1878290 , @vingeldal wrote: > I am pretty sure that an option to allow short names would cause a > relatively big hit on performance (relative to how it runs without the > option) for this check while also potentially

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Oh interesting! Yes, it looks like you are right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

miscco added a comment. I believe this is superseded by the implementation of P1976R2 in D74577 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mail

[clang] af20211 - [Sema] Fix pointer-to-int-cast for MSVC build bot

Author: Mark de Wever Date: 2020-02-16T19:09:59+01:00 New Revision: af202119443bf8759fb6ca9fd8d0282f27001cec URL: https://github.com/llvm/llvm-project/commit/af202119443bf8759fb6ca9fd8d0282f27001cec DIFF: https://github.com/llvm/llvm-project/commit/af202119443bf8759fb6ca9fd8d0282f27001cec.diff

[PATCH] D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf202119443b: [Sema] Fix pointer-to-int-cast for MSVC build bot (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74694/new/ https://rev

[PATCH] D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot

Mordante added a comment. Thanks for the quick review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74694/new/ https://reviews.llvm.org/D74694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. Ok, please commit to fix the bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74694/new/ https://reviews.llvm.org/D74694 __

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Friendly Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

xbolva00 added a comment. @nikic: Can you please do compile-time benchmarks w/o this patch with e.g. php ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73835/new/ https://reviews.llvm.org/D73835 ___ c

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante added a comment. This revision caused issue for the MSVC build bot. I created a followup patch D74694 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72231/new/ https://reviews.llvm.org/D72231 _

[PATCH] D74694: [Sema] Fix pointer-to-int-cast for MSVC build bot

Mordante created this revision. Mordante added reviewers: rsmith, dblaikie, rjmccall. Mordante added a project: clang. Herald added a subscriber: martong. Revision 9658d895c81a breaks the clang-x64-windows-msvc build bot [1].

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

vingeldal marked 2 inline comments as done. vingeldal added a comment. In D74463#1878144 , @njames93 wrote: > I have a feeling this check is going to throw so many false positives that > it'll be too noisy to run on any real codebase. > There should be

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

Mordante planned changes to this revision. Mordante marked an inline comment as done. Mordante added inline comments. Comment at: clang/lib/AST/CommentSema.cpp:1121 + if (isFunctionOrMethodVariadic() && + Typo.find_first_not_of('.') == StringRef::npos) +return ParamComm

[clang] 7c362b2 - [IRBuilder] Fix unnecessary IRBuilder copies; NFC

Author: Nikita Popov Date: 2020-02-16T17:57:18+01:00 New Revision: 7c362b25d7a9093d7d38171f2684876b63bb5a57 URL: https://github.com/llvm/llvm-project/commit/7c362b25d7a9093d7d38171f2684876b63bb5a57 DIFF: https://github.com/llvm/llvm-project/commit/7c362b25d7a9093d7d38171f2684876b63bb5a57.diff

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

nikic added a comment. Tried what happens if the copy constructor is deleted: https://gist.github.com/nikic/1e6ab5bbf42cfe48e7b848e60a2df180 It looks like the referenced occurrence in DIBuilder was the only place that was using the copy constructor "for good reason", most of the other uses eith

Re: [PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

I see your point about how users who care should always be passing this check alongside "performance-move-const-arg"; but IMVHO it still makes sense for clang-tidy to warn unconditionally about code of the form x = std::move(y); use(y); regardless of the incidental type of `y`. Sure, it's

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.cpp:59 +Optional File = PP->LookupFile( +HashLoc /* FIXME: lies */, (FileName + RE).str(), IsAngled, nullptr, +

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 244884. jroelofs added a comment. git format-patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.cpp clang-tools-extra/clang-tidy/bugpro

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.h:26 +/// For the user-facing documentation see: +/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-include.htm

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked 4 inline comments as done and an inline comment as not done. jroelofs added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/NoIncludeCPPCheck.cpp:62 + Check.diag(HashLoc, "suspicious #include") + << FixItHint::CreateReplacement(Filenam

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs updated this revision to Diff 244883. jroelofs marked an inline comment as done. jroelofs added a comment. - Renamed to bugprone-suspicious-include - Removed FixIts in favor of `note:` suggestions, iff the suggested file exists on the header search path. - Removed unnecessary unused para

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

nikic reopened this revision. nikic added a comment. This revision is now accepted and ready to land. Reverted because of failures on http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/22164. Not sure why this is the only builder that's failing, but I believe the pr

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

zinovy.nis updated this revision to Diff 244878. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp Index:

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/NoIncludeCPPCheck.cpp:11-13 +#include "clang/ASTMatchers/ASTMatchFinder.h" + +using namespace clang::ast_matchers; You don't need to include or use the AST matchers in a preprocessor on

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

zinovy.nis updated this revision to Diff 244876. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp Index:

[PATCH] D74692: [clang-tidy] Make bugprone-use-after-move ignore std::move for const values

zinovy.nis created this revision. zinovy.nis added reviewers: mboehme, alexfh. zinovy.nis added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, xazax.hun. Herald added a project: clang. std::move for const values is NO-OP, so it has no sense to report it in bugprone-u

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

jroelofs marked an inline comment as done. jroelofs added a comment. In D74669#1878168 , @njames93 wrote: > I have a feeling this check should be called something along the lines of > bugprone-suspicous-include. That's a much better name, I like it.

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rG9658d895c81a: [Sema] Adds the pointer-to-int-cast diagnostic (authored by Mordante). Changed prior to commit: https://reviews.llvm.org/D72231?vs=242393&id=2448

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

Mordante marked 2 inline comments as done. Mordante added a comment. Herald added a subscriber: martong. Thanks for the review. I'll have a look at your suggestion for a follow-up patch. Comment at: clang/test/Sema/cast.c:1 -// RUN: %clang_cc1 -fsyntax-only -triple x86_64-unkn

[clang] 9658d89 - [Sema] Adds the pointer-to-int-cast diagnostic

Author: Mark de Wever Date: 2020-02-16T15:38:25+01:00 New Revision: 9658d895c81aeb849b412b9332c88769588c7660 URL: https://github.com/llvm/llvm-project/commit/9658d895c81aeb849b412b9332c88769588c7660 DIFF: https://github.com/llvm/llvm-project/commit/9658d895c81aeb849b412b9332c88769588c7660.diff

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

thakis added a comment. This causes this build warning: ../../llvm/include/llvm/IR/IRBuilder.h:77:16: warning: 'anchor' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] virtual void anchor(); ^ ../../llvm/include/llvm/IR/IRBuilde

[PATCH] D73834: Update for Clang 10 release notes

Mordante closed this revision. Mordante added a comment. Phab registered the commit, but didn't close this review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73834/new/ https://reviews.llvm.org/D73834 _

[PATCH] D74669: [clang-tidy] New check: misc-no-include-cpp

njames93 added a comment. I have a feeling this check should be called something along the lines of bugprone-suspicous-include. Comment at: clang-tools-extra/clang-tidy/misc/NoIncludeCPPCheck.cpp:62 + Check.diag(HashLoc, "suspicious #include") + << FixItHint::Cre

[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

This revision was automatically updated to reflect the committed changes. Closed by commit rG0765d3824d06: [IRBuilder] Virtualize IRBuilder (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0765d38 - [IRBuilder] Virtualize IRBuilder

Author: Nikita Popov Date: 2020-02-16T13:48:55+01:00 New Revision: 0765d3824d069f37596bc5a890399099b776c2a0 URL: https://github.com/llvm/llvm-project/commit/0765d3824d069f37596bc5a890399099b776c2a0 DIFF: https://github.com/llvm/llvm-project/commit/0765d3824d069f37596bc5a890399099b776c2a0.diff

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidAdjacentParametersOfTheSameTypeCheck.cpp:18 +namespace cppcoreguidelines { +// FIXME: Make sure this matcher only accepts functions with minimum 2 +// parameters njam

[PATCH] D74463: [clang-tidy] Add new check avoid-adjacent-unrelated-parameters-of-the-same-type

njames93 added a comment. I have a feeling this check is going to throw so many false positives that it'll be too noisy to run on any real codebase. There should be a way to silence this when it is undesired like in the example for `int max(int a, int b);`. A possible solution could be based o

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 updated this revision to Diff 244867. njames93 added a comment. - New line and undo clang format artefact Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74689/new/ https://reviews.llvm.org/D74689 Files: clang-tools-extra/clang-tidy/perfo

[PATCH] D74689: [clang-tidy] Better custom class support for performance-inefficient-vector-operation

njames93 created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74689 Files: clang-tools-extra/clang-tidy/performance/InefficientVectorOperationCheck.cpp clang-tools-extra/clang-t

[PATCH] D74684: [Sema][C++] Adopt DR2171 relaxed triviality requirements

comex created this revision. comex added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. When defining a copy constructor or assignment operator as either explicitly defaulted (`= default`) or deleted (`= delete`), it's possible to give it a different p

[PATCH] D73865: [CodeGenModule] Assume dso_local for -fpic -fno-semantic-interposition

MaskRay planned changes to this revision. MaskRay added a comment. I am thinking whether we may need fine-grained `-fno-semantic-interposition-{data,function}`. I've noticed one problem with an internal target `_multiarray_umath.so` `npy_ma_str_array_finalize`. I need to make more investigation