jroelofs marked an inline comment as done. jroelofs added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/bugprone/SuspiciousIncludeCheck.h:26 +/// For the user-facing documentation see: +/// http://clang.llvm.org/extra/clang-tidy/checks/bugprone-suspicious-include.html +class SuspiciousIncludeCheck : public ClangTidyCheck { ---------------- FIXME: still need to write docs for this. ================ Comment at: clang-tools-extra/clang-tidy/misc/NoIncludeCPPCheck.cpp:50 + + (void)FilenameRange; + (void)File; ---------------- njames93 wrote: > I have a feeling this is to suppress some unused parameter linting check. If > it is then it should be removed as unused parameters in an overridden > function shouldn't emit a warning. > Same for below. > > Side note: File a bug with whichever linter tool gave you that warning (if > there was one). > Sorry, did this out of habit. Indeed it isn't actually needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74669/new/ https://reviews.llvm.org/D74669 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
