[PATCH] D72901: [OpenMP] [DOCS] Update OMP5.0 feature status table [NFC]

kkwli0 created this revision. kkwli0 added reviewers: ABataev, RaviNarayanaswamy, jdoerfert. Herald added a subscriber: guansong. Add missing OMP5.0 features. https://reviews.llvm.org/D72901 Files: clang/docs/OpenMPSupport.rst Index: clang/docs/OpenMPSupport.rst

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

kadircet added a comment. Hi @jkorous, reverting this as d54d71b67e60 should've fixed this. Please let us know if that's not the case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang-tools-extra] 4df94d5 - Revert "[clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS"

Author: Kadir Cetinkaya Date: 2020-01-17T08:51:13+01:00 New Revision: 4df94d5b513c20842f5eeeb1e0d059bfa6741d91 URL: https://github.com/llvm/llvm-project/commit/4df94d5b513c20842f5eeeb1e0d059bfa6741d91 DIFF: https://github.com/llvm/llvm-project/commit/4df94d5b513c20842f5eeeb1e0d059bfa6741d91.dif

[PATCH] D72747: [objc_direct] Allow for direct messages be sent to `self` when it is a Class

MadCoder updated this revision to Diff 238698. MadCoder added a comment. Added some more tests to make sure it works along inheritance chains as expected CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72747/new/ https://reviews.llvm.org/D72747 Files: clang/lib/Sema/SemaExprObjC.cpp

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

sepavloff added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3031 +The ``#pragma float_control`` pragma allows floating-point precision and +floating-point exception behavior to be specified Floating-point precision refers to the number of bit

[PATCH] D71566: New checks for fortified sprintf

erik.pilkington added reviewers: aaron.ballman, rsmith. erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:422 + size_t StrLen = + std::min(std::max(TypeSize, size_t(1)) - 1, FormatStrRef.size()); + if (!analyze_format_string::Pa

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rjmccall added a comment. I see two reasonable approaches here: we can rely on the implicit members being added in the right order by Sema, as this patch seems to do, or we can broaden the special treatment of implicit virtual functions in the v-table layout code. The latter is more complex (w

[PATCH] D69740: [profile] Support counter relocation at runtime

phosek updated this revision to Diff 238689. phosek marked an inline comment as done. phosek added a comment. Addressed the comment and also added a test for Linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D

[PATCH] D50360: [Concepts] Requires Expressions

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Parse/Parser.h:804-807 + bool TryAnnotateTypeOrScopeToken(bool ClassTemplateDeductionContext = true); + bool TryAnnotateTypeOrScopeToken

[clang] 01a6cd4 - Don't dump IR output from this test to stdout.

Author: Richard Smith Date: 2020-01-16T19:19:45-08:00 New Revision: 01a6cd471f019cfeda057c3b1b6fc6213575217c URL: https://github.com/llvm/llvm-project/commit/01a6cd471f019cfeda057c3b1b6fc6213575217c DIFF: https://github.com/llvm/llvm-project/commit/01a6cd471f019cfeda057c3b1b6fc6213575217c.diff

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM Do you mind adding x86 tests too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72890/new/ https://reviews.llvm.org/D72890 __

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. We previously listed first declared members, then implicit operator=, then implicit operator==, then implicit destructors. Per discussion on https://github.com/it

[clang] b78e8e0 - Add extra test file forgotten in 45d7080.

Author: Richard Smith Date: 2020-01-16T18:13:49-08:00 New Revision: b78e8e0d79c47a6698a0abc10a37b8a253cb6064 URL: https://github.com/llvm/llvm-project/commit/b78e8e0d79c47a6698a0abc10a37b8a253cb6064 DIFF: https://github.com/llvm/llvm-project/commit/b78e8e0d79c47a6698a0abc10a37b8a253cb6064.diff

Re: [clang] 45d7080 - PR42694 Support explicit(bool) in older language modes as an extension.

Also b78e8e0d79c47a6698a0abc10a37b8a253cb6064 which has an extra test file that I forgot to git add. On Wed, 15 Jan 2020 at 18:52, Richard Smith wrote: > Hans, could this change be ported to the Clang 10 branch? In PR42694 the > MSVC stdlib developers requested that Clang support this because th

[PATCH] D72825: [NFC] Fix options name typo

MaskRay added a comment. > These three options may be used in other projects compiled by gcc. We can add them on demand. I don't see a rationale to add them preemptively. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/ https://reviews.llv

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2757 // subsequent options conflict then emit warning diagnostic. + // TODO: How should this interact with DenormalFP32Math? if (HonorINFs &

[PATCH] D72825: [NFC] Fix options name typo

Jim added a comment. It should be kept for compatibility. These three options may be used in other projects compiled by gcc. Clang should ignore it. https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm updated this revision to Diff 238670. arsenm added a comment. Forgot clang parts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D69878 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/in

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

This revision was automatically updated to reflect the committed changes. Closed by commit rG83f4c3af021c: [modules] Do not cache invalid state for modules that we attempted to load. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D72860?vs=238562&id=238668#toc Reposit

[clang] 83f4c3a - [modules] Do not cache invalid state for modules that we attempted to load.

Author: Volodymyr Sapsai Date: 2020-01-16T17:12:41-08:00 New Revision: 83f4c3af021cd5322ea10fd1c4e839874c1dae49 URL: https://github.com/llvm/llvm-project/commit/83f4c3af021cd5322ea10fd1c4e839874c1dae49 DIFF: https://github.com/llvm/llvm-project/commit/83f4c3af021cd5322ea10fd1c4e839874c1dae49.di

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

uweigand added a comment. > What are the semantics of vfnmadb with respect to when it rounds vs the > negation? Hmm, interesting. The z/Architecture Principles of Operation states: > The results for each element of VECTOR FP NEGA- > TIVE MULTIPLY AND ADD and VECTOR FP NEGA- > TIVE MULTIPLY A

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma added a comment. We currently don't have any mechanism for restricting builtins to specific operating systems. I guess we could add one, but this change doesn't seem like a compelling argument to add that capability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72890: [xray] Allow instrumenting only function entry and/or only function exit

ianlevesque created this revision. ianlevesque added a reviewer: dberris. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Extend -fxray-instrumentation-bundle to split function-entry and function-exit into two separate options, so that it is poss

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert added a comment. The commit title has a stray `{` instead of `[` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72304/new/ https://reviews.llvm.org/D72304 ___ cfe-commits mailing list cfe-comm

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

joerg added a comment. Can this be restricted to Linux? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

jdoerfert added a comment. Phab is not involved in the merge process, it just is a normal git push on top of the llmv-project. Do you have commit rights already? If not I can commit this for you in a few days. Comment at: llvm/lib/Frontend/OpenMP/OMPConstants.cpp:45 ///{ -

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb5fafb23cc2: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well. (authored by thakis). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fb5fafb - Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

Author: Nico Weber Date: 2020-01-16T19:04:08-05:00 New Revision: fb5fafb23cc2d8613f8be2487afe94d8594a88ce URL: https://github.com/llvm/llvm-project/commit/fb5fafb23cc2d8613f8be2487afe94d8594a88ce DIFF: https://github.com/llvm/llvm-project/commit/fb5fafb23cc2d8613f8be2487afe94d8594a88ce.diff LO

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. In D72806#1825400 , @DieGoldeneEnte wrote: > > Even in case we don't add the extra directories for llvm and lld, it would be > a good idea to use the getProgramPath function instead of building it > manually (so only the changes

[PATCH] D71469: [AArch64] Add sq(r)dmulh_lane(q) LLVM IR intrinsics

efriedma added a comment. > This makes it impossible to do a neat trick when using NEON intrinsics: one > can load a number of constants using a single vector load, which are then > repeatedly used to multiply whole vectors by one of the constants. This trick > is used for a nice performance up

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte added a comment. In D72806#1825362 , @tra wrote: > In D72806#1825333 , @DieGoldeneEnte > wrote: > > > In D72806#1824560 , @yaxunl wrote: > > > > > What's the

[PATCH] D72855: Make LLVM_APPEND_VC_REV=OFF affect clang, lld, and lldb as well.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: llvm/cmake/modules/LLVMConfig.cmake.in:81 +set(LLVM_APPEND_VC_REV "@LLVM_APPEND_VC_REV@") + This here should make the standalone build configs w

[clang] 65eb74e - PointerLikeTypeTraits: Standardize NumLowBitsAvailable on static constexpr rather than anonymous enum

Author: David Blaikie Date: 2020-01-16T15:30:50-08:00 New Revision: 65eb74e94b414fcde6bfa810d1c30c7fcb136b77 URL: https://github.com/llvm/llvm-project/commit/65eb74e94b414fcde6bfa810d1c30c7fcb136b77 DIFF: https://github.com/llvm/llvm-project/commit/65eb74e94b414fcde6bfa810d1c30c7fcb136b77.diff

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

sammccall added a comment. Please revert this, it was already fixed by d54d71b67e60 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72883/new/ https://reviews.llvm.org/D72883 _

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

tra added a comment. In D72806#1825333 , @DieGoldeneEnte wrote: > In D72806#1824560 , @yaxunl wrote: > > > What's the use case of this change? > > > > Normally clang needs to call opt/llc/lld from the same director

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte updated this revision to Diff 238645. DieGoldeneEnte added a comment. The build doesn't fail anymore if lld is not present, also one can set LLD_BINARY_DIR manually. I also exchanged TOOLS_BINARY_DIR with LLVM_TOOLS_BINARY_DIR, since it is better readable and if compiled with llvm

[clang] 25b542c - [OPENMP]Do not emit RTTI descriptor for NVPTX devices.

Author: Alexey Bataev Date: 2020-01-16T18:12:50-05:00 New Revision: 25b542c61fe364fa86163723b9e35cb7db28bcb4 URL: https://github.com/llvm/llvm-project/commit/25b542c61fe364fa86163723b9e35cb7db28bcb4 DIFF: https://github.com/llvm/llvm-project/commit/25b542c61fe364fa86163723b9e35cb7db28bcb4.diff

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

sammccall added a comment. kadir has a pending (or landed?) fix for this. It's just a usual fragile test - it's asserting the order, but findExplicitReferences just returns the order given by targetDecls which isn't stable. We settled on defining a stable (but arbitrary) order for targetDecl a

[PATCH] D72806: [HIP] fix paths for executables not in clang bin directory

DieGoldeneEnte added a comment. In D72806#1824560 , @yaxunl wrote: > What's the use case of this change? > > Normally clang needs to call opt/llc/lld from the same directory of clang. > Why do we need to find them in other directories? My motivation is

[PATCH] D72883: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG42b3c38903c9: [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when… (authored by jkorous). Hera

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

logan-5 updated this revision to Diff 238640. logan-5 added a comment. Should be good now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72378/new/ https://reviews.llvm.org/D72378 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule.c

[clang] 9b549f2 - AMDGPU: Update clang test

Author: Matt Arsenault Date: 2020-01-16T18:10:29-05:00 New Revision: 9b549f26fab6900b5328c0c6239fd77c7527159c URL: https://github.com/llvm/llvm-project/commit/9b549f26fab6900b5328c0c6239fd77c7527159c DIFF: https://github.com/llvm/llvm-project/commit/9b549f26fab6900b5328c0c6239fd77c7527159c.diff

[clang-tools-extra] 42b3c38 - [clangd][test] Disable a particular testcase in FindExplicitReferencesTest when LLVM_ENABLE_EXPENSIVE_CHECKS

Author: Jan Korous Date: 2020-01-16T15:07:08-08:00 New Revision: 42b3c38903c9c80e129ce678db7f522967e91eeb URL: https://github.com/llvm/llvm-project/commit/42b3c38903c9c80e129ce678db7f522967e91eeb DIFF: https://github.com/llvm/llvm-project/commit/42b3c38903c9c80e129ce678db7f522967e91eeb.diff LO

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

ABataev added a comment. In D69585#1825252 , @llunak wrote: > In D69585#1825133 , @ABataev wrote: > > > I thought you were going to add an option or a flag to control the > > behavior? If so, just provide an option

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. In D69585#1825133 , @ABataev wrote: > I thought you were going to add an option or a flag to control the behavior? > If so, just provide an option in tests to avoid triggering of the new > behavior (except for declare_target... te

[PATCH] D72635: Add "context" capability to Thread Safety Analysis

aaronpuchert added a comment. Hmm, I have been wondering about this as well. The way I see it, all of these things are what we call //capabilities//, and we treat them all the same. The names are just meant to make warning messages more readable, because what the analysis considers a capability

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61934 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72722: [FPEnv] [SystemZ] Platform-specific builtin constrained FP enablement

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13347 case SystemZ::BI__builtin_s390_vfnmadb: { llvm::Type *ResultType = ConvertType(E->getType()); Value *X = EmitScalarExpr(E->getArg(0)); What are the semantics of vfn

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman updated this revision to Diff 238621. mwyman added a comment. Fixed missing end quote pointed out in review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72876/new/ https://reviews.llvm.org/D72876 Files: clang-tools-extra/clang-tidy/objc/CMakeLists.txt clang-tools-e

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 238620. tmsriram added a comment. clang-formatted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/CodeGenOptions.h clang/

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

akhuang added a comment. In D72869#1824927 , @serge-sans-paille wrote: > @akhuang can you confirm this fixes your issue? I've tested locally and it > works fine on my side. Yes, this fixes the __warn_memset_zero_len issue, thanks! Repository: rG LL

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + cameron.mcinally wrote: > cameron.mcinally wrote: > > cameron.mcinally wrote: > > > I don't think it's safe to fuse a FMUL and FADD if the intermediate > > >

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 ___

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

dmaclach requested changes to this revision. dmaclach added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/docs/clang-tidy/checks/objc-dealloc-in-categories.rst:10 + +Classes implement ``-dealloc` to perform important actions just b

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

ABataev added a comment. In D69585#1823969 , @llunak wrote: > In D69585#1821831 , @aganea wrote: > > > What is the error? > > > I take that part back, actually. I don't quite remember anymore what exactly > I did i

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille updated this revision to Diff 238614. serge-sans-paille added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 Files: clang/include/clang/Basic/Builtins.def cla

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille added a comment. In D72869#1824951 , @efriedma wrote: > This is very hacky, Yeah, I know... > but it might be the least-bad alternative. I mean, we could change D71082 > so it doesn't allow system he

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

mwyman created this revision. mwyman added reviewers: stephanemoore, benhamilton. mwyman added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, mgehre, mgorny. Such implementations may override the class's own implementation, and even be a danger in case someone later co

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61925 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61850 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

cameron.mcinally added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + cameron.mcinally wrote: > cameron.mcinally wrote: > > I don't think it's safe to fuse a FMUL and FADD if the intermediate > > rounding isn't exactly the sam

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

cameron.mcinally added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + cameron.mcinally wrote: > I don't think it's safe to fuse a FMUL and FADD if the intermediate rounding > isn't exactly the same as those individual operatio

[clang] 202446c - Add BuiltinsHexagonDep.def to clang module map

Author: Krzysztof Parzyszek Date: 2020-01-16T15:54:24-06:00 New Revision: 202446c639fdd27a54c3be268154a7c66af4f36d URL: https://github.com/llvm/llvm-project/commit/202446c639fdd27a54c3be268154a7c66af4f36d DIFF: https://github.com/llvm/llvm-project/commit/202446c639fdd27a54c3be268154a7c66af4f36d

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

cameron.mcinally added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3436 +} + } + I don't think it's safe to fuse a FMUL and FADD if the intermediate rounding isn't exactly the same as those individual operations. FMULADD doesn't guarant

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61930 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by runnin

[PATCH] D72875: [clang][cmake] Include generated rst files in html built by docs-clang-html target

tstellar created this revision. tstellar added reviewers: rsmith, aaron.ballman, beanz, smeenai, phosek, compnerd. Herald added subscribers: llvm-commits, mgorny. Herald added projects: clang, LLVM. This is an attempt to simply the process of building the clang documentation, which should help av

[PATCH] D69878: Consoldiate internal denormal flushing controls

andrew.w.kaylor added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2311 + bool TrappingMath = true; // overriden by ffp-exception-behavior? bool RoundingFPMath = false; arsenm wrote: > cameron.mcinall

[clang] 8b32192 - [OPENMP]Avoid string concat where possible and use standard name

Author: Alexey Bataev Date: 2020-01-16T16:39:45-05:00 New Revision: 8b321929483ee3c4070a10c457733c1bddd10b51 URL: https://github.com/llvm/llvm-project/commit/8b321929483ee3c4070a10c457733c1bddd10b51 DIFF: https://github.com/llvm/llvm-project/commit/8b321929483ee3c4070a10c457733c1bddd10b51.diff

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

ianlevesque created this revision. ianlevesque added a reviewer: dberris. Herald added a project: clang. Herald added a subscriber: cfe-commits. ianlevesque updated this revision to Diff 238600. ianlevesque added a comment. fix clang-format XRay allows tuning by minimum function size, but also a

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

nridge created this revision. nridge added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This facilitates performing go-to-definition inside comments, strings, invalid code, and dependen

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the patch, I've commit on your behalf in d5c6b8407c12d39a78f42a216369407cb2d7b511 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D72378: [clang-tidy] Add `bugprone-reserved-identifier`

aaron.ballman added a comment. In D72378#1824586 , @logan-5 wrote: > Great! In that case, I'll need help committing this, as well as the thing it > depends on, https://reviews.llvm.org/D72284 (which has also been LGTM'd). Great, can you rebase this patc

[PATCH] D72873: [clang][xray] Add -fxray-ignore-loops option

ianlevesque updated this revision to Diff 238600. ianlevesque added a comment. fix clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72873/new/ https://reviews.llvm.org/D72873 Files: clang/include/clang/Basic/CodeGenOptions.def clang/

[clang-tools-extra] d5c6b84 - Factor out renaming logic from readability-identifier-naming

Author: Logan Smith Date: 2020-01-16T16:34:56-05:00 New Revision: d5c6b8407c12d39a78f42a216369407cb2d7b511 URL: https://github.com/llvm/llvm-project/commit/d5c6b8407c12d39a78f42a216369407cb2d7b511 DIFF: https://github.com/llvm/llvm-project/commit/d5c6b8407c12d39a78f42a216369407cb2d7b511.diff L

[PATCH] D72675: [Clang][Driver] Fix -ffast-math/-ffp-contract interaction

wristow updated this revision to Diff 238595. wristow retitled this revision from "Fix -ffast-math/-ffp-contract interaction" to "[Clang][Driver] Fix -ffast-math/-ffp-contract interaction". wristow added a comment. Changing this to address only the Clang driver aspect, as discussed in the commen

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61933 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai created this revision. vsapsai added reviewers: erik.pilkington, ahatanak. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. When a category/extension doesn't repeat a type bound, corresponding type parameter is substituted with `id` when used as a typ

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

efriedma added a comment. This is very hacky, but it might be the least-bad alternative. I mean, we could change D71082 so it doesn't allow system headers to define memset, but that seems worse. Please add a testcase. Repository: rG LLVM Github Monorepo C

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61929 tests passed, 0 failed and 783 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72867: [clangd] Support renaming designated initializers

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61928 tests passed, 1 failed and 783 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_sharedtimedmutex_requirements/thread_sharedtimedmutex_class/try_lock.pass.cpp {icon que

[PATCH] D72380: [DataFlow] Factor two worklist implementations out

xazax.hun updated this revision to Diff 238592. xazax.hun added a comment. - Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72380/new/ https://reviews.llvm.org/D72380 Files: clang/include/clang/Analysis/FlowSensitive/DataflowValues.h clang/include/clang/Analysis/FlowSensit

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille created this revision. serge-sans-paille added reviewers: rnk, george.burgess.iv, akhuang. Herald added a project: clang. Herald added a subscriber: cfe-commits. serge-sans-paille added a comment. @akhuang can you confirm this fixes your issue? I've tested locally and it works f

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim marked an inline comment as done and an inline comment as not done. fghanim added a comment. Thanks for reviewing this. After I address the last two comments below, How do I merge with llvm using phab? I'd appreciate an llvm specific link if possible. Comment at: llvm

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille added a comment. >> The simplest one I can think of is to make `__warn_memset_zero_len` a >> recognized builtin that generates no code. > > +1, simple and easy. See https://reviews.llvm.org/D72869 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added a comment. Hmm, we still need to find some basic decl to remap it successfully at the codegen. Not sure that we'll be able to support it in full. It would be good to investigate how we can handle them at the codegen. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D72304: [OpenMP]{OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim updated this revision to Diff 238591. fghanim marked 9 inline comments as done. fghanim added a comment. Addressing reviewer's comments - fixed styling and naming according to llvm conventions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D72869: Add __warn_memset_zero_len builtin as a workaround for glibc issue

serge-sans-paille added a comment. @akhuang can you confirm this fixes your issue? I've tested locally and it works fine on my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72869/new/ https://reviews.llvm.org/D72869 __

[clang-tools-extra] 40514a7 - [clangd] Add workaround for GCC5 host compilers. NFC.

Author: Michael Liao Date: 2020-01-16T16:05:22-05:00 New Revision: 40514a7d7a3b745ba43c2d014e54a0d78d65d957 URL: https://github.com/llvm/llvm-project/commit/40514a7d7a3b745ba43c2d014e54a0d78d65d957 DIFF: https://github.com/llvm/llvm-project/commit/40514a7d7a3b745ba43c2d014e54a0d78d65d957.diff

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

wristow added a comment. > One commit for the clang changes should be ok; it's a very small diff. But > I'm still not sure if the driver change induces frontend diffs that we should > make visible via tests. The only thing I can think of is that it changes whether/when `__FAST_MATH__` is defin

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev updated this revision to Diff 238586. kbobyrev added a comment. Remove duplicated testt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72867/new/ https://reviews.llvm.org/D72867 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tool

[PATCH] D72867: [clangd] Support renaming designated initializers

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kbobyrev updated this revision to Diff 238586. kbobyrev added a comment. Remove duplicated testt Clangd

[PATCH] D72850: [CMake] Use LinuxRemoteTI instead of LinuxLocalTI in CrossWinToARMLinux cmake cache

vvereschaka accepted this revision. vvereschaka added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72850/new/ https://reviews.llvm.org/D72850 _

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. May be just keep a note in the comments that this lit parameter is required for the remote libcxx tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72717/new/ https://reviews.llvm.org/D72717 _

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

vvereschaka added a comment. Hi Sergej, as far as I understood '--param enable_filesystem=False' argument is libc++ specific, but we pass those parameters to all the library tests. I think it is optimal to pass this parameter directly in the builder configuration only for libcxx as '-DLLVM_LIT_

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Serialization/ModuleManager.cpp:183 // Get a buffer of the file and close the file descriptor when done. - Buf = FileMgr.getBu

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61863 tests passed, 0 failed and 781 were skipped. {icon question-circle color=gray} clang-tidy: unknown. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72675: Fix -ffast-math/-ffp-contract interaction

spatel added a comment. In D72675#1824659 , @wristow wrote: > This all sounds good to me. > > So to make sure we're all on the same page, my understanding is that the plan > forward is: > > 1. Make the Clang change first (including adding another pair of

[PATCH] D72860: [modules] Do not cache invalid state for modules that we attempted to load.

vsapsai marked an inline comment as done. vsapsai added a comment. Anecdotal build time measurements before and after the change. First row is a clean build, subsequent rows are incremental builds. | Revision | Before change | After change | Change (after - before) | Relative change | | ---

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson updated this revision to Diff 238569. tejohnson added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71913/new/ https://reviews.llvm.org/D71913 Files: clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CGClass.cpp

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

andrew.w.kaylor added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3381 + Addend->getType()), +{MulOp0, MulOp1, Addend, MulOp->getOperand(2), MulOp->getOperand(3)}); + else You shouldn't just assume that Mul

  1   2   3   >