wristow added a comment. > One commit for the clang changes should be ok; it's a very small diff. But > I'm still not sure if the driver change induces frontend diffs that we should > make visible via tests.
The only thing I can think of is that it changes whether/when `__FAST_MATH__` is defined. But that'll be indirectly tested, via the updated tests in "Driver/fast-math.c", which will verify that "-ffast-math" is passed appropriately (and the `__FAST_MATH__` dependency on "-ffast-math" is already tested in "Preprocessor/predefined-macros.c"). In addition to adding the second pair of driver tests you suggested for `-ffp-contract=on`, I'll also add another pair for `-ffp-contract=fast` to verify that "-ffast-math" is passed in that case (no change in behavior for that pair, but just confirming it continues to work correctly). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72675/new/ https://reviews.llvm.org/D72675 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
