[PATCH] D71827: [clang] avoid strict aliasing violation in assert

rlibby created this revision. rlibby added reviewers: akyrtzi, rsmith. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. StoredDeclsList::setOnlyValue wants to assert that the binary value actually stored in the member PointerUnion Data is the same as the raw NamedD

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

rjmccall added a comment. In D69272#1794630 , @sepavloff wrote: > In D69272#1793234 , @rjmccall wrote: > > > In D69272#1792928 , @sepavloff > > wrote: > > > > > @hfinkel pro

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

sepavloff added a comment. In D69272#1793234 , @rjmccall wrote: > In D69272#1792928 , @sepavloff wrote: > > > @hfinkel proposed to use outlining to extract a block with the #pragma to > > separate function. It coul

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc marked 4 inline comments as done. poelmanc added a comment. In D68682#1754798 , @kadircet wrote: > `ToolingTests/ApplyAtomicChangesTest.FormatsCorrectLineWhenHeaderIsRemoved` > also seems to be failing, you can run it with `ninja ToolingTests &&

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc marked an inline comment as done. poelmanc added inline comments. Comment at: clang/include/clang/Basic/CharInfo.h:94 +LLVM_READONLY inline bool isWhitespace(llvm::StringRef S) { + for (StringRef::const_iterator I = S.begin(), E = S.end(); I != E; ++I) { +if (!isWhi

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc marked 13 inline comments as done. poelmanc added inline comments. Comment at: clang/lib/Format/Format.cpp:2385 + const char *FileText = Code.data(); + StringRef FilePath; // Must be the same for every Replacement + for (const auto &R : Replaces) { ka

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

yonghong-song added a comment. @rnk Great to know the reason. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71818/new/ https://reviews.llvm.org/D71818 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 235090. poelmanc marked 2 inline comments as done. poelmanc added a comment. Fix algorithm to fix failing `ToolingTests/ApplyAtomicChangesTest.FormatsCorrectLineWhenHeaderIsRemoved`. That test revealed a very specific but real failure case: if existing Remo

[PATCH] D71716: [ItaniumCXXABI] Don't mark an extern_weak init function as dso_local on windows

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm TLS thread wrappers seem to reimplement a lot of the logic that would happen naturally for a regular function declaration. I wonder if there is some way to restructure the code to have less du

[PATCH] D45677: [libcxx] [test] Fix typo in filesystem test

Jim added a comment. This is fixed by https://reviews.llvm.org/rG437e0e5191ca255db27e86d232020844c1fd08c8. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45677/new/ https://reviews.llvm.org/D45677 ___ cfe-commits

[clang] 5128026 - [AST] Add missing MultiplexConsumer::CompleteExternalDeclaration

Author: Reid Kleckner Date: 2019-12-22T19:00:48-08:00 New Revision: 5128026467cbc17bfc796d94bc8e40e52a9b0752 URL: https://github.com/llvm/llvm-project/commit/5128026467cbc17bfc796d94bc8e40e52a9b0752 DIFF: https://github.com/llvm/llvm-project/commit/5128026467cbc17bfc796d94bc8e40e52a9b0752.diff

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

rnk added a comment. Ah, I see, these tests will fail if you link in some clang plugins, which I do for Chrome. So, this only affects me. Anyway, I'll fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71818/new/ https://reviews.llvm.org/D71818

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

rnk added a comment. You forgot to update MultiplexConsumer: diff --git a/clang/include/clang/Frontend/MultiplexConsumer.h b/clang/include/clang/Frontend/MultiplexConsumer.h index ca6ed8310ae..3054e184281 100644 --- a/clang/include/clang/Frontend/MultiplexConsumer.h +++ b/clang/include/c

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

yonghong-song added a comment. @rnk I somehow cannot reproduce the issue locally. If you can let me know how to exactly reproduce the issue, I might be able to also help with some kind of solution, although frankly speaking, I am not a clang expert. Repository: rG LLVM Github Monorepo CHANG

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

rnk added subscribers: rjmccall, rsmith. rnk added a comment. +@rsmith @rjmccall For more meaningful feedback on the code structure. Comment at: clang/include/clang/Sema/Sema.h:671-672 + /// All the external declarations encoutered and used in the TU. + SmallVector Externa

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

rnk added a comment. I patched this in, and the tests don't pass for me locally, so we're back to where we started. Go ahead and land it, I guess. I'm kind of not happy that we had to poke another virtual method through the ASTConsumer interface to make this happen. Repository: rG LLVM Gith

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3d8ee35e4ad: reland "[DebugInfo] Support to emit debugInfo for extern variables" (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] e3d8ee3 - reland "[DebugInfo] Support to emit debugInfo for extern variables"

Author: Yonghong Song Date: 2019-12-22T18:28:50-08:00 New Revision: e3d8ee35e4adca664a9149536e0f0b3b0ceaeaeb URL: https://github.com/llvm/llvm-project/commit/e3d8ee35e4adca664a9149536e0f0b3b0ceaeaeb DIFF: https://github.com/llvm/llvm-project/commit/e3d8ee35e4adca664a9149536e0f0b3b0ceaeaeb.diff

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun updated this revision to Diff 235085. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71823/new/ https://reviews.llvm.org/D71823 Files: clang/lib/Basic/

[PATCH] D71823: Support Swift calling convention for WebAssembly targets

kateinoigakukun created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google, sbc100, dschuff. Herald added a project: clang. Support Swift calling convention for WebAssembly targets This adds basic support for the Swift calling convention with WebAssembly ta

[PATCH] D71709: Give frontend dump flags consistent names (*-dump instead of dump-*)

modocache added a subscriber: mehdi_amini. modocache added a comment. Ah, I'm sorry I wasn't clear -- instead of changing a lot of tests to use the new names exclusively, my suggestion was to change one or two tests to use the new canonical name, and have the remaining tests keep using the alias

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

yonghong-song updated this revision to Diff 235078. yonghong-song added a comment. Removed `REQUIRES: bpf-registered-target`. This is not needed any more if using `%clang_cc1`. Tested by build clang with and without BPF target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

yonghong-song marked an inline comment as done. yonghong-song added inline comments. Comment at: clang/test/CodeGen/debug-info-extern-basic.c:1 +// REQUIRES: bpf-registered-target +// RUN: %clang_cc1 -x c -debug-info-kind=limited -triple bpf-linux-gnu -emit-llvm %s -o - | FileCh

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

rnk added inline comments. Comment at: clang/test/CodeGen/debug-info-extern-basic.c:1 +// REQUIRES: bpf-registered-target +// RUN: %clang_cc1 -x c -debug-info-kind=limited -triple bpf-linux-gnu -emit-llvm %s -o - | FileCheck %s Clang does not require a registere

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. @rnk I just submitted a patch https://reviews.llvm.org/D71818 to use `%clang_cc1` instead of `%clang` in the test. Could you check whether this fixed your issue or not? I cannot remove BPF target requirement as only BPF target can trigger debug info generation fo

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

yonghong-song added a comment. I cannot remove BPF target requirement as only BPF target can trigger debug info generation for extern variables. This is by design as discussed in D70696 due to concerns it may blow up debug info binary size for existing applicat

[PATCH] D71818: reland "[DebugInfo] Support to emit debugInfo for extern variables"

yonghong-song created this revision. yonghong-song added a reviewer: rnk. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Commit d77ae1552fc21a9f3877f3ed7e13d631f517c825 ("[D

[PATCH] D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71805/new/ https://reviews.llvm.org/D71805 __

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

rnk added a comment. I wasn't able to fix forward because the functionality you added doesn't seem to work, at least not for me, so I went ahead and reverted the change. I considered XFAILing the test, but I am concerned that may cause it to pass unexpectedly on some bot somewhere. In any case,

[clang] 891e25b - Revert "[DebugInfo] Support to emit debugInfo for extern variables"

Author: Reid Kleckner Date: 2019-12-22T12:54:06-08:00 New Revision: 891e25b02d760d0de18c7d46947913b3166047e7 URL: https://github.com/llvm/llvm-project/commit/891e25b02d760d0de18c7d46947913b3166047e7 DIFF: https://github.com/llvm/llvm-project/commit/891e25b02d760d0de18c7d46947913b3166047e7.diff

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

rnk added a comment. Three of these tests have been failing for me locally since this patch landed: Failing Tests (3): Clang :: CodeGen/debug-info-extern-basic.c Clang :: CodeGen/debug-info-extern-duplicate.c Clang :: CodeGen/debug-info-extern-multi.c I suspect bots do not s

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

rnk added a comment. This was relanded and reverted again today (d3f5769d5e93b30d4a8b4696381d5e4a304992fa & 79cc9e9b304a90598e8def4c8b5354d1f99186eb ). I g

[PATCH] D71809: [Analyzer] Fixes -Wrange-loop-analysis warnings

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d9e976629a: [Analyzer] Fixes -Wrange-loop-analysis warnings (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71809/new/ https://revie

[clang] b6d9e97 - [Analyzer] Fixes -Wrange-loop-analysis warnings

Author: Mark de Wever Date: 2019-12-22T19:13:34+01:00 New Revision: b6d9e976629ac655e0ed2655289e90357107793f URL: https://github.com/llvm/llvm-project/commit/b6d9e976629ac655e0ed2655289e90357107793f DIFF: https://github.com/llvm/llvm-project/commit/b6d9e976629ac655e0ed2655289e90357107793f.diff

[PATCH] D71686: Fix false positive in magic number checker

0x8000- added a comment. @aaron.ballman updated as suggested; please commit/integrate when you have a moment. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 ___ cfe-commits mailing l

[PATCH] D71686: Fix false positive in magic number checker

0x8000- marked 2 inline comments as done. 0x8000- added a comment. In D71686#1794366 , @aaron.ballman wrote: > In D71686#1794360 , @0x8000- > wrote: > > > In D71686#1794330

[PATCH] D71686: Fix false positive in magic number checker

0x8000- updated this revision to Diff 235060. 0x8000- added a comment. Minor comment fixes; capitalization, full stop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71686/new/ https://reviews.llvm.org/D71686 Files: clang-tools-extra/clang-tidy/readability/MagicNumbersCheck.cp

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-magic-numbers-todo.cpp:2 +// RUN: %check_clang_tidy %s read

[PATCH] D70689: [analyzer] Fix SARIF column locations

aaron.ballman added reviewers: dblaikie, echristo, xbolva00. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. Mostly LG aside from a question about an assertion. Adding other reviewers outside of GrammaTech in case there are other concerns we've missed. ==

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman added a comment. In D71686#1794360 , @0x8000- wrote: > In D71686#1794330 , @aaron.ballman > wrote: > > > In D71686#1794053 , @0x8000- > > wrote: > > >

[PATCH] D71686: Fix false positive in magic number checker

0x8000- added a comment. In D71686#1794330 , @aaron.ballman wrote: > In D71686#1794053 , @0x8000- > wrote: > > > My take: this change fixes a user-reported bug, and does not cause any > > known regression

[PATCH] D71809: [Analyzer] Fixes -Wrange-loop-analysis warnings

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71809/new/ https://reviews.llvm.org/D71809

[PATCH] D71686: Fix false positive in magic number checker

aaron.ballman added a comment. In D71686#1794053 , @0x8000- wrote: > My take: this change fixes a user-reported bug, and does not cause any known > regressions. I think we should integrate this. I sort of wonder whether we want to document this as a

[PATCH] D71806: Improve Wrange-loop-analyses for rvalue reference

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71806/new/ https://reviews.llvm.org/D71806 _

[PATCH] D71809: [Analyzer] Fixes -Wrange-loop-analysis warnings

Mordante created this revision. Mordante added reviewers: dcoughlin, aaron.ballman, xbolva00, Szelethus. Mordante added a project: clang. Herald added subscribers: Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This avoids new warnings due to D689

[PATCH] D71806: Improve Wrange-loop-analyses for rvalue reference

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. The Wrange-loop-analyses warns if a copy is made. Suppress this warning when a temporary is bound to a rvalue reference. While fixing this issue also found a copy-paste err

[PATCH] D71677: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc5b614fa9a1: [ms] [X86] Use "P" modifier on operands to call instructions in inline X86… (authored by epastor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[clang] dc5b614 - [ms] [X86] Use "P" modifier on operands to call instructions in inline X86 assembly.

Author: Eric Astor Date: 2019-12-22T09:16:34-05:00 New Revision: dc5b614fa9a1c83e8275fcb9c3f78444d0a30514 URL: https://github.com/llvm/llvm-project/commit/dc5b614fa9a1c83e8275fcb9c3f78444d0a30514 DIFF: https://github.com/llvm/llvm-project/commit/dc5b614fa9a1c83e8275fcb9c3f78444d0a30514.diff LO

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. In D68912#1794138 , @xbolva00 wrote: > All is fixed now? Not yet :-( I ran into a false positive with rvalue references, will post a code fix for it and then I'll look into posting more error fixes. CHANGES SINCE LAST ACTION

[PATCH] D71791: [CFG] Fix an assertion failure with static initializers

NoQ added a comment. Wait, i didn't real @Szelethus's reply :) In any case, i'd love to see an example of such CFG and whether //control dependency tracking// can expose the crash. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71791/new/ https://

[PATCH] D71802: [NFC] Move OptionUtils from Basic to Driver

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71802/new/ https://reviews.llvm.org/D71802 ___ cfe-commits mailing list cfe-com

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

thakis added a comment. (The follow-up is at D71802 . Thanks!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71080/new/ https://reviews.llvm.org/D71080 ___ cfe-commits

[PATCH] D71805: [clang] [ast] CXXRecordDecl::getVisibleConversionFunctions() could be const

whisperity created this revision. whisperity added reviewers: rsmith, rjmccall. whisperity added a project: clang. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. The function and its called static helpers don't modify the received `CXXRecordDecl` arguments at all a

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

This revision was automatically updated to reflect the committed changes. Closed by commit rG7394c15178ed: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, . (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 7394c15 - [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

Author: Bruno Ricci Date: 2019-12-22T12:41:14Z New Revision: 7394c15178ed9cb7bd04585526a1e73396e60e17 URL: https://github.com/llvm/llvm-project/commit/7394c15178ed9cb7bd04585526a1e73396e60e17 DIFF: https://github.com/llvm/llvm-project/commit/7394c15178ed9cb7bd04585526a1e73396e60e17.diff LOG: [

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a571538dff6: [Sema] SequenceChecker: Fix handling of operator ||, && and ?: (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/ne

[clang] 8a57153 - [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

Author: Bruno Ricci Date: 2019-12-22T12:27:31Z New Revision: 8a571538dff6dbc1b7f4fed6aed8be7ec1a00a8d URL: https://github.com/llvm/llvm-project/commit/8a571538dff6dbc1b7f4fed6aed8be7ec1a00a8d DIFF: https://github.com/llvm/llvm-project/commit/8a571538dff6dbc1b7f4fed6aed8be7ec1a00a8d.diff LOG: [

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

xbolva00 added a comment. All is fixed now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6eba3129291: [Sema] SequenceChecker: Add some comments + related small NFCs (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/ne

[clang] b6eba31 - [Sema] SequenceChecker: Add some comments + related small NFCs

Author: Bruno Ricci Date: 2019-12-22T12:07:26Z New Revision: b6eba3129291639dcd72ba31ed4b6f0b4dbe09e7 URL: https://github.com/llvm/llvm-project/commit/b6eba3129291639dcd72ba31ed4b6f0b4dbe09e7 DIFF: https://github.com/llvm/llvm-project/commit/b6eba3129291639dcd72ba31ed4b6f0b4dbe09e7.diff LOG: [

[clang] 527b0f8 - [Driver] Allow -mnop-mcount for SystemZ and -mfentry for X86 and SystemZ

Author: Fangrui Song Date: 2019-12-22T00:01:42-08:00 New Revision: 527b0f8c7448707aa6b8159e6e4707a49f1dcb87 URL: https://github.com/llvm/llvm-project/commit/527b0f8c7448707aa6b8159e6e4707a49f1dcb87 DIFF: https://github.com/llvm/llvm-project/commit/527b0f8c7448707aa6b8159e6e4707a49f1dcb87.diff