aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some minor nits.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability-magic-numbers-todo.cpp:2
+// RUN: %check_clang_tidy %s readability-magic-numbers %t
+// RUN: --
+// XFAIL: *
----------------
You might as well move this onto the previous line; it just looks strange here.
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability-magic-numbers.cpp:219
+
+// prove that using enumerations values don't produce warnings
+enum class Letter : unsigned {
----------------
prove -> Prove
and add a full stop to the end of the comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71686/new/
https://reviews.llvm.org/D71686
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
