[PATCH] D69754: [hurd] Add --build-id option when enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rG79c89033fdf1: [Clang] Add ENABLE_LINKER_BUILD_ID to Hurd driver. (authored by kristina). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69754/new/ https://re

[clang] 79c8903 - [Clang] Add ENABLE_LINKER_BUILD_ID to Hurd driver.

Author: kristina Date: 2019-11-07T06:10:14Z New Revision: 79c89033fdf1bfb840744a35d32e7583580b6572 URL: https://github.com/llvm/llvm-project/commit/79c89033fdf1bfb840744a35d32e7583580b6572 DIFF: https://github.com/llvm/llvm-project/commit/79c89033fdf1bfb840744a35d32e7583580b6572.diff LOG: [Cla

[PATCH] D69754: [hurd] Add --build-id option when enabled

kristina accepted this revision. kristina added a comment. This revision is now accepted and ready to land. LGTM, at least following the same reasoning as in rC271692 (http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20160530/160984.html). I presume yo

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. clangd should retain comments from system headers. fixes

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. Yes, Tested All tests passes. Testing Time: 0.95s Expected Passes: 4 Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 ___ cfe-commi

[PATCH] D69909: [OPENMP] [DOCS] fix section formatting issues [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f10cc2d124c: [OPENMP] [DOCS] fix section formatting issues [NFC] (authored by kkwli0). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGE

[clang] 9f10cc2 - [OPENMP] [DOCS] fix section formatting issues [NFC]

Author: Kelvin Li Date: 2019-11-06T22:03:09-05:00 New Revision: 9f10cc2d124c275f2e7a6764e168f6b75527e78f URL: https://github.com/llvm/llvm-project/commit/9f10cc2d124c275f2e7a6764e168f6b75527e78f DIFF: https://github.com/llvm/llvm-project/commit/9f10cc2d124c275f2e7a6764e168f6b75527e78f.diff LOG

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

compnerd added a comment. I agree with @efriedma that it sounds odd, could you explain that please? It took about 3 reads before I saw the OUT in the WITHOUT, and then realized that this was just: `NOT (HAVE_CXX_ATOMICS_WITHOUT_LIB AND HAVE_CXX_ATOMICS64_WITHOUT_LIB)`. I don't know if there is

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

srhines added a comment. In D69925#1736434 , @efriedma wrote: > I think the reason it's written this way is that CLANG_VERSION_STRING might > not correspond to an LLVM version? For example, Apple has its own versioning > scheme. Line 128 is already pr

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

efriedma added a reviewer: rjmccall. efriedma added a comment. I think the reason it's written this way is that CLANG_VERSION_STRING might not correspond to an LLVM version? For example, Apple has its own versioning scheme. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm updated this revision to Diff 228168. arsenm added a comment. Missed a spot to rename CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69598/new/ https://reviews.llvm.org/D69598 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/CGCall.cpp clang/lib/Frontend/

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm updated this revision to Diff 228167. arsenm added a comment. Rename subnormal to denormal. Will defer splitting input and output setting into a future patch before switching default behavior CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69878/new/ https://reviews.llvm.org/D6987

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

NoQ added a comment. I suspect that it's not just the source range, but the whole AST for the initializer is different, due to C++17 mandatory copy elision in the equals-initializer syntax. Like, before C++17 it was a temporary constructor, a temporary materialization (ironic!), and a copy cons

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added a comment. Sigh, one last typo. I'm happy otherwise. Comment at: clang/test/Driver/debug-default-version.c:11 +// environment, we should use codeview. You can enable dwarf, which implicitly +// disables codeview, of you can explicitly ask for both if you don't

[libunwind] e74e61f - unwind: restore the LINKER_LANGUAGE

Author: Saleem Abdulrasool Date: 2019-11-06T15:42:09-08:00 New Revision: e74e61ff297e81c0a9bda54037033fc40fc76e1d URL: https://github.com/llvm/llvm-project/commit/e74e61ff297e81c0a9bda54037033fc40fc76e1d DIFF: https://github.com/llvm/llvm-project/commit/e74e61ff297e81c0a9bda54037033fc40fc76e1d.

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers created this revision. nickdesaulniers added reviewers: jyknight, eli.friedman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. nickdesaulniers marked an inline co

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Version.cpp:132 -#ifdef CLANG_VENDOR - OS << " (based on " << BACKEND_PACKAGE_STRING << ")"; -#endif Looks like this is the sole use of `BACKEND_

[libunwind] aa582e3 - unwind: reflow some of the build rules (NFC)

Author: Saleem Abdulrasool Date: 2019-11-06T15:42:09-08:00 New Revision: aa582e3648cc4036aec3b9302ab93bfe9929d19c URL: https://github.com/llvm/llvm-project/commit/aa582e3648cc4036aec3b9302ab93bfe9929d19c DIFF: https://github.com/llvm/llvm-project/commit/aa582e3648cc4036aec3b9302ab93bfe9929d19c.

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Version.cpp:132 -#ifdef CLANG_VENDOR - OS << " (based on " << BACKEND_PACKAGE_STRING << ")"; -#endif nickdesaulniers wrote: > Looks like this is

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::s

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm updated this revision to Diff 228161. arsenm added a comment. Rename to denormal CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69598/new/ https://reviews.llvm.org/D69598 Files: clang/include/clang/Basic/CodeGenOptions.h clang/lib/CodeGen/CGCall.cpp clang/lib/Frontend/Compi

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. `I do not have a test related to libunwind ,but I do simulated this behavior in c and got segfault. --- int main(){ int stack[10]={0}; int* sp=stack; *(

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1828-1831 + be flushed to zero by standard floating point operations. It is not + mandated that flushing to zero occurs, but if a subnormal output is + flushed to zero,

[PATCH] D68578: [HIP] Fix device stub name

tra added a comment. Apologies for the delay with my response. In D68578#1700819 , @t-tye wrote: > In D68578#1700652 , @tra wrote: > > > In D68578#1698864 , @t-tye wrote: >

[PATCH] D69923: [OPENMP][DOCS] Update OpenMP status (NFC)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69923/new/ https://reviews.llvm.org/D69923 ___ cfe-commits ma

[PATCH] D69923: [OPENMP][DOCS] Update OpenMP status (NFC)

dreachem created this revision. dreachem added reviewers: ABataev, hfinkel, jdoerfert, kkwli0. Herald added subscribers: cfe-commits, guansong. Herald added a project: clang. This is updating the OpenMP status table. Cray has volunteered for `defaultmap` and supporting `in_reduction` on the `targ

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228144. cmtice added a comment. Remove quotes from -NOT tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/li

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added a project: clang. This is the initial patch to use the OpenMP-IR-Builder, as discussed on the mailing list ([1] a

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert updated this revision to Diff 228134. jdoerfert marked 3 inline comments as done. jdoerfert added a comment. LLVM code only, added unit test and fix issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

MaskRay accepted this revision. MaskRay added a comment. LG after `// NOCODEVIEW-NOT: "-gcodeview"` and `// NODWARF4-NOT: "-dwarf-version=4"` are fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 _

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

MyDeveloperDay added a comment. > But I can still land it if you think it still relevant on its own. I think the design of working through the vector of files is more elegant, especially if we want to consider looking for other files in the future. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay updated this revision to Diff 228133. MyDeveloperDay added a comment. Remove unused `Ranges` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69921/new/ https://reviews.llvm.org/D69921 Files: clang/tools/clang-format/ClangFormat.cpp Index: clang/tools/clang-format/Clang

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, klimek, mitchell-stellar, vlad.tsyrklevich. MyDeveloperDay added projects: clang-format, clang. Review comments in D69854: [clang-format] [RELAND] Remove the dependency on frontend rec

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

wanders added a comment. In D68568#1735741 , @MyDeveloperDay wrote: > Do you need help landing this? Sorry that I havn't gotten back to this. I started looking into the "PathMatch" idea I floated in D68569 ([clang-for

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228130. cmtice added a comment. Fix NODEBUGINFO-NOT test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/lib/Dri

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374 + case DMIB_unspecified: +return OMPC_MAP_tofrom; + } cchen wrote: > ABataev wrote: > > cchen wrote: > > > ABataev wrote: > > > > cchen wrote: > > > > > ABataev wrote: > > > > > >

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374 + case DMIB_unspecified: +return OMPC_MAP_tofrom; + } ABataev wrote: > cchen wrote: > > ABataev wrote: > > > cchen wrote: > > > > ABataev wro

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 228126. jdoerfert marked an inline comment as done. jdoerfert added a comment. working version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files: clang/include/

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added inline comments. Comment at: clang/test/Driver/debug-default-version.c:37 + +// NODEBUGINFO-NOT: "-debug-info-kind=" + Same issue as with the dwarf-version below. It's probably easier to remove the "" (FileCheck arguments aren't quoted - these qu

[PATCH] D69498: IR: Invert convergent attribute handling

mehdi_amini added a comment. In D69498#1735763 , @arsenm wrote: > In D69498#1731265 , @mehdi_amini > wrote: > > > Just thought about a slight variation on this: what about adding a flag on > > the datalayout (or a

[PATCH] D69897: Add #pragma clang loop aligned

Meinersbur added a comment. In D69897#1735983 , @lebedev.ri wrote: > It would be really best if this could just make use of > `CodeGenFunction::EmitAlignmentAssumption()`, > else this is a heavy hammer with loose handle. Since it is a property of the d

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added a comment. In D69813#1735988 , @aaron.ballman wrote: > I'm not @NoQ, but I do agree that there should be a separate check per rule > in terms of the UI presented to the user. The name should follow the rule ID > like they do in clang-tidy

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 6 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:215 LANGOPT(OpenMPCUDAMode, 1, 0, "Generate code for OpenMP pragmas in SIMT/SPMD mode") +LANGOPT(OpenMPNewCodegen , 1, 0, "Use the experimenta

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rGeadb65f273c0: [clang-format] [NFC] update the documentation in Format.h to allow… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] eadb65f - [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

Author: paulhoad Date: 2019-11-06T20:03:05Z New Revision: eadb65f273c076c4997b28a51f086eea505c3e78 URL: https://github.com/llvm/llvm-project/commit/eadb65f273c076c4997b28a51f086eea505c3e78 DIFF: https://github.com/llvm/llvm-project/commit/eadb65f273c076c4997b28a51f086eea505c3e78.diff LOG: [cla

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228115. cmtice added a comment. Remove period from help text. Fix tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D69564: Include the mangled name in -ast-dump=json

aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. Thank you for your patience with my delayed review, I've been at standards meetings for C and C++ and I'm a bit behind schedule. > The AST dump tests were updated using the following script: One of the things @rsmith and I

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

aaron.ballman added a comment. In D69813#1735804 , @Szelethus wrote: > In D69813#1734272 , @Charusso wrote: > > > In D69813#1734193 , @Szelethus > > wrote: > > > > > Hmm, so

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6740a88dc18d: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable() (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/ https://re

[clang] 6740a88 - [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

Author: David Tenty Date: 2019-11-06T14:32:35-05:00 New Revision: 6740a88dc18d0be14926a5e709bd5062e31ee81c URL: https://github.com/llvm/llvm-project/commit/6740a88dc18d0be14926a5e709bd5062e31ee81c DIFF: https://github.com/llvm/llvm-project/commit/6740a88dc18d0be14926a5e709bd5062e31ee81c.diff L

[PATCH] D69897: Add #pragma clang loop aligned

lebedev.ri added a comment. In D69897#1735961 , @Meinersbur wrote: > Please see my comments in D69900 as well. > > For the font-end side, I suggest the syntax `vectorize_assume_alignment(32)` > instead. We also need to de

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

probinson added a comment. Is it tested? Intuitively I would expect DW_OP_pick to be kind of an unusual operator, unlikely to be seen in the wild. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893

[PATCH] D69897: Add #pragma clang loop aligned

Meinersbur added a comment. Please see my comments in D69900 as well. For the font-end side, I suggest the syntax `vectorize_assume_alignment(32)` instead. We also need to define what this assumes to be aligned. The first element of the array? Every array eleme

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::subnormalModeName(CodeGenOpts.FPSubnormalM

[PATCH] D69897: Add #pragma clang loop aligned

hfinkel added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3135 + +This predicates all the array references inside the loop to be aligned. The aligned access to them can increase fetch time and increase the performance. + hfinkel wrote: > lebe

[libunwind] cbc872a - unwind: disable RTTI during the build of libunwind

Author: Saleem Abdulrasool Date: 2019-11-06T10:51:42-08:00 New Revision: cbc872a63f81ad9482bb288165af63d7444fa3ed URL: https://github.com/llvm/llvm-project/commit/cbc872a63f81ad9482bb288165af63d7444fa3ed DIFF: https://github.com/llvm/llvm-project/commit/cbc872a63f81ad9482bb288165af63d7444fa3ed.

[clang] a8ccb48 - [X86] Add 'fxsr' feature to -march=pentium2 to match X86.td and gcc.

Author: Craig Topper Date: 2019-11-06T10:27:53-08:00 New Revision: a8ccb48f697d3fbe85c593248ff1053fdf522a6e URL: https://github.com/llvm/llvm-project/commit/a8ccb48f697d3fbe85c593248ff1053fdf522a6e DIFF: https://github.com/llvm/llvm-project/commit/a8ccb48f697d3fbe85c593248ff1053fdf522a6e.diff

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1828-1831 + be flushed to zero by standard floating point operations. It is not + mandated that flushing to zero occurs, but if a subnormal output is + flushed to zero,

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 5 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector + FoundNameModifiers(unsigned(OMPD_unknow

[PATCH] D69866: [clang-tools-extra] [cmake] Add install target for clangd-indexer

mmpozulp abandoned this revision. mmpozulp added a comment. I'm switching to using the background index, so I no longer need to run clangd-indexer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69866/new/ https://reviews.llvm.org/D69866 ___

[PATCH] D69872: Improve modernize-avoid-bind to support more types of expressions

zturner updated this revision to Diff 228093. zturner added a comment. Minor cleanup -- moved `isFixitSupported` logic to its own function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69872/new/ https://reviews.llvm.org/D69872 Files: clang-tools-extra/clang-tidy/modernize/AvoidBind

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Szelethus added a comment. In D69813#1734272 , @Charusso wrote: > In D69813#1734193 , @Szelethus wrote: > > > Hmm, so this checker is rather a collection of CERT rule checkers, right? > > Shouldn't the checker name

[PATCH] D69908: [OpenCL] Add geometric and relational builtin functions

svenvh created this revision. svenvh added reviewers: Anastasia, Nicola, Pierre. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a reviewer: rengolin. Herald added a project: clang. Adds the geometric and relational builtin functions from the OpenCL C specification. Patch by

[clang] ba73aad - [X86] Add 'mmx' to all CPUs that have a version of 'sse' and weren't already enabling '3dnow'

Author: Craig Topper Date: 2019-11-06T10:02:40-08:00 New Revision: ba73aad4f64f52f2acb5394210ed829355b44383 URL: https://github.com/llvm/llvm-project/commit/ba73aad4f64f52f2acb5394210ed829355b44383 DIFF: https://github.com/llvm/llvm-project/commit/ba73aad4f64f52f2acb5394210ed829355b44383.diff

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374 + case DMIB_unspecified: +return OMPC_MAP_tofrom; + } cchen wrote: > ABataev wrote: > > cchen wrote: > > > ABataev wrote: > > > > `OMPC_MAP_tofrom` must be returned only for `DMIB

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm updated this revision to Diff 228088. twardakm added a comment. Remove unnecessary line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69855/new/ https://reviews.llvm.org/D69855 Files: clang-tools-extra/clang-tidy/readability/NamespaceCo

[PATCH] D69498: IR: Invert convergent attribute handling

arsenm added a comment. In D69498#1731265 , @mehdi_amini wrote: > In D69498#1727650 , @dexonsmith > wrote: > > > In D69498#1723606 , @rjmccall > > wrote: > > > > > Perhaps

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked 2 inline comments as done. Closed by commit rG3ddac7e56363: [clang-format] [RELAND] Remove the dependency on frontend (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374 + case DMIB_unspecified: +return OMPC_MAP_tofrom; + } ABataev wrote: > cchen wrote: > > ABataev wrote: > > > `OMPC_MAP_tofrom` must be return

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

MyDeveloperDay marked 5 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/tools/clang-format/ClangFormat.cpp:310 SourceManager Sources(*Diags, Files); FileID FileID = createInMemoryFile(AssumedFileName, Code.get(), Sources,

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

MyDeveloperDay added a comment. Do you need help landing this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68568/new/ https://reviews.llvm.org/D68568 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

MyDeveloperDay added a comment. Do you need help landing this? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/ https://reviews.llvm.org/D38446 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] 3ddac7e - [clang-format] [RELAND] Remove the dependency on frontend

Author: paulhoad Date: 2019-11-06T17:33:37Z New Revision: 3ddac7e563633632d4a3e673f3224ee66e1a717e URL: https://github.com/llvm/llvm-project/commit/3ddac7e563633632d4a3e673f3224ee66e1a717e DIFF: https://github.com/llvm/llvm-project/commit/3ddac7e563633632d4a3e673f3224ee66e1a717e.diff LOG: [cla

[PATCH] D56345: [clang-format] Assert that filenames are not empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7681435de148: [clang-format] Assert that filenames are not empty (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56345/new/ http

[PATCH] D69598: Work on cleaning up denormal mode handling

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::s

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

MaskRay added inline comments. Comment at: clang/test/Driver/debug-default-version.c:66 +// NOCODEVIEW-NOT: "-gcodeview" +// NODWARF-NOT: "-dwarf-version=" +// NODWARF-NOT: "-dwarf-version=" This is not correct. I suppose this to be `"-dwarf-version=`. The patte

[clang] 7681435 - [clang-format] Assert that filenames are not empty

Author: paulhoad Date: 2019-11-06T17:25:17Z New Revision: 7681435de148cf7a1c7db1b0daba0497630989d2 URL: https://github.com/llvm/llvm-project/commit/7681435de148cf7a1c7db1b0daba0497630989d2 DIFF: https://github.com/llvm/llvm-project/commit/7681435de148cf7a1c7db1b0daba0497630989d2.diff LOG: [cla

[PATCH] D69903: [Basic] Introduce PODSourceLocation, NFCI

miyuki created this revision. miyuki added reviewers: faisalv, rsmith, aprantl, JDevlieghere. Herald added subscribers: cfe-commits, jfb, arphaman. Herald added a project: clang. miyuki added a parent revision: D69840: [Basic] Make SourceLocation usable as key in hash maps, NFCI. miyuki edited par

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

probinson added a comment. Just a couple of typos, and I'm happy. I agree with the other reviewers on the last needed test tweaks. Comment at: clang/include/clang/Driver/Options.td:1955 Flags<[CC1Option]>; +def fdebug_default_version: Joined<["-"], "fdebug-default-version=

[PATCH] D69901: [OpenCL] Add integer functions to builtin functions

svenvh created this revision. svenvh added reviewers: Anastasia, Nicola, Pierre. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a project: clang. This patch adds the integer builtin functions from the OpenCL C specification. Repository: rC Clang https://reviews.llvm.org

[PATCH] D69897: Add #pragma clang loop aligned

hfinkel added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3135 + +This predicates all the array references inside the loop to be aligned. The aligned access to them can increase fetch time and increase the performance. + lebedev.ri wrote: > W

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374 + case DMIB_unspecified: +return OMPC_MAP_tofrom; + } cchen wrote: > ABataev wrote: > > `OMPC_MAP_tofrom` must be returned only for `DMIB_tofrom`, for others, it > > must be `llv

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1967 (DSAStack->isForceCaptureByReferenceInTargetExecutable() && !Ty->isAnyPointerType()) || !Ty->isScalarType() || AB

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4091 +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg)); + else @Anastasia

[PATCH] D69781: [analyzer] Add test directory for scan-build

thakis added a comment. Also, you probably need to make clang/test/CMakeLists.txt depend on the install target, to make sure scan-build is in bin/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69781/new/ https://reviews.llvm.org/D69781 ___

[PATCH] D69896: [libTooling] Small changes in Transformer API.

ymandel added a comment. Build breakage fixed in commit "6c683aa8d7d [libTooling] Fix breakage from change #84922" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69896/new/ htt

[PATCH] D69897: Add #pragma clang loop aligned

lebedev.ri added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3135 + +This predicates all the array references inside the loop to be aligned. The aligned access to them can increase fetch time and increase the performance. + What does this act

[libunwind] 049f94a - Revert "build: explicitly set the linker language for unwind"

Author: Saleem Abdulrasool Date: 2019-11-06T08:34:13-08:00 New Revision: 049f94af487fc8be704f8740e2d2946ac5c6efc9 URL: https://github.com/llvm/llvm-project/commit/049f94af487fc8be704f8740e2d2946ac5c6efc9 DIFF: https://github.com/llvm/llvm-project/commit/049f94af487fc8be704f8740e2d2946ac5c6efc9.

[clang] 6c683aa - [libTooling] Fix breakage from change #84922

Author: Yitzhak Mandelbaum Date: 2019-11-06T11:31:35-05:00 New Revision: 6c683aa8d7d9dcda30b2a9eb42b43cbce5c645b8 URL: https://github.com/llvm/llvm-project/commit/6c683aa8d7d9dcda30b2a9eb42b43cbce5c645b8 DIFF: https://github.com/llvm/llvm-project/commit/6c683aa8d7d9dcda30b2a9eb42b43cbce5c645b8.

[PATCH] D69897: Add #pragma clang loop aligned

m-happy created this revision. m-happy added reviewers: hfinkel, DTharun, rscottmanley, Meinersbur. m-happy added a project: clang. Herald added subscribers: cfe-commits, zzheng. This patch adds functionality '#pragma clang loop aligned'. The load/store access in for loop following the '#pragma c

[clang] 9f97480 - [libTooling] Small changes in Transformer API.

Author: Yitzhak Mandelbaum Date: 2019-11-06T11:16:50-05:00 New Revision: 9f97480cddd77bd2d169131a290cc996fc78df0f URL: https://github.com/llvm/llvm-project/commit/9f97480cddd77bd2d169131a290cc996fc78df0f DIFF: https://github.com/llvm/llvm-project/commit/9f97480cddd77bd2d169131a290cc996fc78df0f.

[PATCH] D69896: [libTooling] Small changes in Transformer API.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f97480cddd7: [libTooling] Small changes in Transformer API. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69896/new/ https://reviews

[PATCH] D69896: [libTooling] Small changes in Transformer API.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69896/new/ https://reviews.llvm.org/D69896 _

[PATCH] D69896: [libTooling] Small changes in Transformer API.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. - Rename `transformer::change` to `transformer::changeTo`, make `change` forward to `changeTo` and mark it deprecated. - Mark `transformer::text` and `transformer::selection` deprecated and mig

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

This revision was automatically updated to reflect the committed changes. Closed by commit rGce2b5cb6decb: [libTooling] Simplify type structure of `Stencil`s. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69613/new/ https://re

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

ldionne added a reviewer: kledzik. ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This looks good to me, but I must admit I'm surprised this problem has never come up before (this code is very old), and also I don't know what the code is

[clang] ce2b5cb - [libTooling] Simplify type structure of `Stencil`s.

Author: Yitzhak Mandelbaum Date: 2019-11-06T10:28:34-05:00 New Revision: ce2b5cb6decb5cce32adde0d23bdea521da0908b URL: https://github.com/llvm/llvm-project/commit/ce2b5cb6decb5cce32adde0d23bdea521da0908b DIFF: https://github.com/llvm/llvm-project/commit/ce2b5cb6decb5cce32adde0d23bdea521da0908b.

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", + llvm::subnormalModeName(CodeGenOpts.FPSubnormalM

[PATCH] D69804: [clang-tidy] Update TransformerClangTidyCheck to use new Transformer bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde32933027a: [clang-tidy] Update TransformerClangTidyCheck to use new Transformer bindings. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] bde3293 - [clang-tidy] Update TransformerClangTidyCheck to use new Transformer bindings.

Author: Yitzhak Mandelbaum Date: 2019-11-06T10:13:33-05:00 New Revision: bde32933027a096b6cfe14b0e9385ac1005fc28a URL: https://github.com/llvm/llvm-project/commit/bde32933027a096b6cfe14b0e9385ac1005fc28a DIFF: https://github.com/llvm/llvm-project/commit/bde32933027a096b6cfe14b0e9385ac1005fc28a.

  1   2   >