cchen marked 2 inline comments as done.
cchen added inline comments.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:1967
(DSAStack->isForceCaptureByReferenceInTargetExecutable() &&
!Ty->isAnyPointerType()) ||
!Ty->isScalarType() ||
----------------
ABataev wrote:
> ABataev wrote:
> > Seems to me, you're missing additional checks for pointers here.
> Not done
I think I check for `pointer` in line 1897-1898 or I could just misunderstand
what you are saying.
================
Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374
+ case DMIB_unspecified:
+ return OMPC_MAP_tofrom;
+ }
----------------
ABataev wrote:
> `OMPC_MAP_tofrom` must be returned only for `DMIB_tofrom`, for others, it
> must be `llvm_unreachable(....)`
For DMIB_firstprivate, I think you are right, it should be unreachable,
however, for DMIB_default and DMIB_unspecified, they are definitely reachable
in `ActOnOpenMPExecutableDirective`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69204/new/
https://reviews.llvm.org/D69204
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
