[PATCH] D66873: [Test][Time profiler] Fix test for python3

This revision was automatically updated to reflect the committed changes. Closed by commit rL370300: [Test][Time profiler] Fix test for python3 (authored by anton-afanasyev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r370300 - [Test][Time profiler] Fix test for python3

Author: anton-afanasyev Date: Wed Aug 28 23:49:05 2019 New Revision: 370300 URL: http://llvm.org/viewvc/llvm-project?rev=370300&view=rev Log: [Test][Time profiler] Fix test for python3 Summary: Fix test checking time profiler generates correct tracing json-file. `filter` works differently for pyt

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

sylvestre.ledru added a comment. @ziangwan maybe you should add this improvement to the release notes, wdyt? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mai

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

sylvestre.ledru added a comment. FYI, it found a bunch of new warnings in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1577236 https://bugzilla.mozilla.org/show_bug.cgi?id=1577051 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.ll

[PATCH] D66884: Removed dead code from clang/AST/NSAPI.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL370298: Removed dead code from clang/AST/NSAPI.h (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

r370298 - Removed dead code from clang/AST/NSAPI.h

Author: gribozavr Date: Wed Aug 28 23:30:12 2019 New Revision: 370298 URL: http://llvm.org/viewvc/llvm-project?rev=370298&view=rev Log: Removed dead code from clang/AST/NSAPI.h Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66884 Modified: cfe/trunk/

r370297 - [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32

Author: pengfei Date: Wed Aug 28 23:18:34 2019 New Revision: 370297 URL: http://llvm.org/viewvc/llvm-project?rev=370297&view=rev Log: [x86] Adding support for some missing intrinsics: _mm512_cvtsi512_si32 Summary: Adding support for some missing intrinsics: _mm512_cvtsi512_si32 Reviewers: craig.

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaronpuchert added a comment. Note that I'm just copying GCC, which seems the be the original intent behind the warning (https://bugs.llvm.org/show_bug.cgi?id=20796). So people who use both compilers will have seen that warning already. Note also that there is no warning if any declaration prov

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

thakis added a comment. Yes, that makes sense, thanks. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66831/new/ https://reviews.llvm.org/D66831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert updated this revision to Diff 217757. aaronpuchert added a comment. Herald added a subscriber: kbarton. Added a test case, verified that it fails before the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://revie

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

dexonsmith added a reviewer: erik.pilkington. dexonsmith added a comment. This could cause a lot of churn in existing projects (especially with `static void foo()`), without giving Clang any new information. I'm wary of this. > Zero-parameter K&R definitions specify that the function has no >

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Ok, thanks for the iteration on code review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org

[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

dexonsmith marked 2 inline comments as done. dexonsmith added inline comments. Comment at: clang/include/clang/Basic/FileManager.h:320 + /// twice, you get two new file entries. + const FileEntry *getBypassFile(const FileEntry &VFE); + bruno wrote: > Does it ma

[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

dexonsmith updated this revision to Diff 217754. dexonsmith added a comment. Added a FileManagerTest and changed FileManager::getBypassFile to use FileEntryRef. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66710/new/ https://reviews.llvm.org/D66710 Files: clang/include/clang/Basic/

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked 2 inline comments as done. paulkirth added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:157-158 +// In these cases we should not emit any diagnostic related to misexpect. +if (NOps < 3) + return; + nickdesauln

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaronpuchert created this revision. aaronpuchert added reviewers: arphaman, bruno, rsmith. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Zero-parameter K&R definitions specify that the function has no parameters, but they are still not prototypes, so calling the

[PATCH] D52524: Add -Wpoison-system-directories warning

denik added a comment. Hi Aaron, Thank you for your review. I updated the diff with suggested changes. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1072 +// cross-compiling. +def PoisonSystemDirectories : DiagGroup<"poison-system-directories">; +

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

majnemer added inline comments. Comment at: test/libcxx/numerics/truncating_cast.pass.cpp:12 +// Test the conversion function that truncates floating point types to the +// closes representable value for the specified integer type, or +// numeric_limits::max()/min() if the value

[PATCH] D52524: Add -Wpoison-system-directories warning

denik updated this revision to Diff 217746. denik marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/lib/Frontend/InitHeaderSearch.cpp clang/test/

[PATCH] D66873: [Test][Time profiler] Fix test for python3

nathanchance accepted this revision. nathanchance added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66873/new/ https://reviews.llvm.org/D66873 __

[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

bruno added a comment. Nice! Is this something that can be tested for in `unittests/Basic/FileManagerTest.cpp`? Comment at: clang/include/clang/Basic/FileManager.h:320 + /// twice, you get two new file entries. + const FileEntry *getBypassFile(const FileEntry &VFE); + --

[PATCH] D66907: [Modules] Fix rebuilding an updated module for each of its consumers.

vsapsai marked an inline comment as done. vsapsai added inline comments. Comment at: clang/lib/Serialization/ModuleManager.cpp:211 -if (!getModuleCache().tryToDropPCM(NewModule->FileName)) - FileMgr.invalidateCache(NewModule->File); return OutOfDate; ---

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

vsapsai added a comment. In D66831#1650015 , @thakis wrote: > We're getting a bunch of errors looking like > `../../AppsListViewController.m:11:37: error: incompatible block pointer > types assigning to 'void (^)(__strong id)' from 'void > (^)(AppCollec

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added a comment. Looks good, will likely approve after these 2 questions. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:157-158 +// In these cases we should not emit any diagnostic related to misexpect. +if (NOps < 3) + return; + -

[PATCH] D66907: [Modules] Fix rebuilding an updated module for each of its consumers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370274: [Modules] Fix rebuilding an updated module for each of its consumers. (authored by vsapsai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66831: [ObjC] Fix type checking for qualified id block parameters.

thakis added a comment. We're getting a bunch of errors looking like `../../AppsListViewController.m:11:37: error: incompatible block pointer types assigning to 'void (^)(__strong id)' from 'void (^)(AppCollectionViewCell *__strong)'` on code that looks fairly harmless to me. It looks somethin

r370274 - [Modules] Fix rebuilding an updated module for each of its consumers.

Author: vsapsai Date: Wed Aug 28 16:31:32 2019 New Revision: 370274 URL: http://llvm.org/viewvc/llvm-project?rev=370274&view=rev Log: [Modules] Fix rebuilding an updated module for each of its consumers. Marking a module for a rebuild when its signature differs from the expected one causes redund

[PATCH] D66910: [clangd] Fix ExtractFunction dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit rL370273: [clangd] Fix ExtractFunction dependencies (authored by aheejin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[clang-tools-extra] r370273 - [clangd] Fix ExtractFunction dependencies

Author: aheejin Date: Wed Aug 28 16:17:38 2019 New Revision: 370273 URL: http://llvm.org/viewvc/llvm-project?rev=370273&view=rev Log: [clangd] Fix ExtractFunction dependencies Summary: Without these dependencies, builds with `-DBUILD_SHARED_LIBS=ON` fail. Reviewers: SureYeaah Subscribers: mgorn

[PATCH] D66907: [Modules] Fix rebuilding an updated module for each of its consumers.

bruno accepted this revision. bruno added a comment. Thanks for fixing this, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66907/new/ https://reviews.llvm.org/D66907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D66907: [Modules] Fix rebuilding an updated module for each of its consumers.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. This LGTM. The key insight you're making is that when you're importing B into A and B's signature doesn't match what A expects, that does not mean that B is out-of-date. B may have j

[PATCH] D66910: [clangd] Fix ExtractFunction dependencies

aheejin created this revision. aheejin added a reviewer: SureYeaah. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Without these dependencies, builds with `-DBUILD_SHARED_LIBS=ON` fail. Repository: rG LLVM Git

r370270 - Fix a passing XFAIL test

Author: epilk Date: Wed Aug 28 15:38:36 2019 New Revision: 370270 URL: http://llvm.org/viewvc/llvm-project?rev=370270&view=rev Log: Fix a passing XFAIL test Now that we can gracefully handle stack exhaustion, this test was passing in darwin && asan. Instead, just unsupport it when threading is un

[PATCH] D66907: [Modules] Fix rebuilding an updated module for each of its consumers.

vsapsai added a comment. Earlier `tryToDropPCM` was called `tryToRemoveBuffer` and it was added in r298278

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus updated this revision to Diff 217730. piscisaureus added a comment. Add missing CHECK_NEXT line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850 Files: clang/lib/AST/JSONNodeDumper.cpp clang

[PATCH] D66907: [Modules] Fix rebuilding an updated module for each of its consumers.

vsapsai created this revision. vsapsai added reviewers: dexonsmith, bruno, rsmith. Herald added subscribers: ributzka, jkorous. Marking a module for a rebuild when its signature differs from the expected one causes redundant module rebuilds for incremental builds. When a module is updated, its sig

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus added a comment. In D66850#1649865 , @aaron.ballman wrote: > In D66850#1649708 , @piscisaureus > wrote: > > > In D66850#1648776 , @aaron.ballman > > wrote: >

[PATCH] D66873: [Test][Time profiler] Fix test for python3

anton-afanasyev added a comment. Could you please give LGTM? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66873/new/ https://reviews.llvm.org/D66873 ___ cfe-commits mailing list cfe-commits@lists.llvm

r370263 - [analyzer] Fix more analyzer warnings on analyzer and libAnalysis.

Author: dergachev Date: Wed Aug 28 14:19:58 2019 New Revision: 370263 URL: http://llvm.org/viewvc/llvm-project?rev=370263&view=rev Log: [analyzer] Fix more analyzer warnings on analyzer and libAnalysis. Modified: cfe/trunk/lib/Analysis/BodyFarm.cpp cfe/trunk/lib/Analysis/CFG.cpp cfe/t

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

zoecarver added a comment. Yes, that sounds right. I can't think of any reason that the condition couldn't be `if (__r > static_cast(numeric_limits::max()))`. The information lost from shifting the value around is never more than the information lost from static_casting the value (as far as I

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon added a comment. In D66836#1649846 , @zoecarver wrote: > > Dead link. > > Here: https://godbolt.org/z/AjBHYq Yes, conversion of `numeric_limits::max` to `double` rounds to a value out of range for `long long`. That's not what I'm talking about. V

[clang-tools-extra] r370262 - Revert "[clangd] Migrate last tweak tests to TweakTesting.h and remove old helpers. NFC"

Author: sammccall Date: Wed Aug 28 14:05:49 2019 New Revision: 370262 URL: http://llvm.org/viewvc/llvm-project?rev=370262&view=rev Log: Revert "[clangd] Migrate last tweak tests to TweakTesting.h and remove old helpers. NFC" This reverts commit 8f85685b5cf57eddea11fa444503ade220c724e4, which bre

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D66850#1649708 , @piscisaureus wrote: > In D66850#1648776 , @aaron.ballman > wrote: > > > LG

r370261 - Fix always_inline 'target' compatibility check code for Lambdas

Author: erichkeane Date: Wed Aug 28 13:59:25 2019 New Revision: 370261 URL: http://llvm.org/viewvc/llvm-project?rev=370261&view=rev Log: Fix always_inline 'target' compatibility check code for Lambdas The previous version of this used CurFuncDecl in CodeGenFunction, however this doesn't include l

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

zoecarver added a comment. > Dead link. Here: https://godbolt.org/z/AjBHYq CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66836/new/ https://reviews.llvm.org/D66836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon added a comment. > Eric showed me this link https://godbolt.org/z/AjBHYqv Dead link. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66836/new/ https://reviews.llvm.org/D66836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

zoecarver added inline comments. Comment at: include/math.h:1582 + const _RealT __trunc_r = __builtin_trunc(__r); + if (__trunc_r >= ::nextafter(static_cast<_RealT>(_MaxVal), INFINITY)) { +return _Lim::max(); scanon wrote: > EricWF wrote: > > scanon wrote:

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus updated this revision to Diff 217713. piscisaureus added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66850/new/ https://reviews.llvm.org/D66850 Files: clang/lib/AST/JSONNodeDumper.cpp clang/test/AST/ast-dump-

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. @ABataev thanks so much for your instruction, I'll look into that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 ___ cfe-commits mailin

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev added a comment. In D66559#1649775 , @cchen wrote: > Haven't updated the lit test for OpenMP 5.0 yet since I'm not able to check > OPENMP version by using _OPENMP with preprocessor condition checking. You don't need `_OPENMP` macro for this. The

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

ABataev added a comment. What about the check for `!=`? it would be good to allow it only for OpenMP 5.0. Also, add/update the tests. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9027-9032 +def err_omp_before_50_loop_not_canonical_cond : Error< "condition of

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. Haven't updated the lit test for OpenMP 5.0 yet since I'm not able to check OPENMP version by using _OPENMP with preprocessor condition checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

lebedev.ri added a comment. `!=` is still not being diagnosed in pre-5.0 mode though? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 ___ cfe-commits mailing li

[PATCH] D66559: [OPENMP] Update the diagnosis message for canonical loop form

cchen updated this revision to Diff 217710. cchen added a comment. Update the diagnosis message for canonical loop form based on OpenMP version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66559/new/ https://reviews.llvm.org/D66559 Files: clang

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: include/math.h:1573 + enum { _Bits = numeric_limits<_IntT>::digits - numeric_limits<_FloatT>::digits }; + static const _IntT value = numeric_limits<_IntT>::max() >> _Bits << _Bits; +}; -

[PATCH] D66903: [OPENMP] Update the diagnosis message for canonical loop form

cchen added a comment. I should update a revision instead of creating this new one, so I'll just remove the subscriber. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66903/new/ https://reviews.llvm.org/D66903 ___

[PATCH] D66903: [OPENMP] Update the diagnosis message for canonical loop form

cchen created this revision. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. The previous patch (https://reviews.llvm.org/D54441) support the relational-op != very well for openmp canonical loop form, however, it didn't update the

[PATCH] D66856: [Sema] Suppress -Wformat diagnostics for bool types when printed using %hhd

erik.pilkington added a comment. In D66856#1648809 , @aaron.ballman wrote: > I'm wondering whether this should even warn pedantically. There are no format > specifiers that apply directly to a `_Bool` datatype, so the user is left > making a choice as t

[PATCH] D66850: [AST][JSON] Avoid crash when dumping NULL Type as JSON

piscisaureus added a comment. In D66850#1648776 , @aaron.ballman wrote: > LGTM, but missing a test case. > > In D66850#1648557 , @sidorovd wrote: > > > LGTM. I'm not an expert in JSON, but may be it makes sense to

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon requested changes to this revision. scanon added inline comments. This revision now requires changes to proceed. Comment at: include/math.h:1586 +return _Lim::min(); + } + return static_cast<_IntT>(__trunc_r); EricWF wrote: > scanon wrote: > > If I'm

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon added inline comments. Comment at: include/math.h:1582 + const _RealT __trunc_r = __builtin_trunc(__r); + if (__trunc_r >= ::nextafter(static_cast<_RealT>(_MaxVal), INFINITY)) { +return _Lim::max(); EricWF wrote: > scanon wrote: > > zoecarver wrote:

[PATCH] D65526: [Clangd] First version of ExtractFunction

This revision was automatically updated to reflect the committed changes. Closed by commit rL370249: [Clangd] Initial version of ExtractFunction (authored by SureYeaah, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:119 + case SelectionTree::Selection::Partial: +// Treat Partially selected VarDecl as completely selected since +// SelectionTree doesn't always select VarDecls corr

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217701. SureYeaah marked 14 inline comments as done. SureYeaah added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: cla

[clang-tools-extra] r370249 - [Clangd] Initial version of ExtractFunction

Author: sureyeaah Date: Wed Aug 28 12:34:17 2019 New Revision: 370249 URL: http://llvm.org/viewvc/llvm-project?rev=370249&view=rev Log: [Clangd] Initial version of ExtractFunction Summary: - Only works for extraction from free functions - Basic analysis of the code being extracted. - Extract to v

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

jkorous added inline comments. Comment at: clang/include/clang/Index/IndexingAction.h:60 + +inline std::unique_ptr createIndexingASTConsumer( +std::shared_ptr DataConsumer, gribozavr wrote: > jkorous wrote: > > Why not use default argument instead of overload

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

EricWF updated this revision to Diff 217700. EricWF added a comment. Address review comments. I think this is good to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66836/new/ https://reviews.llvm.org/D66836 Files: include/math.h test/libcxx/numerics/clamp_to_integral.pass.cpp

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

EricWF marked 10 inline comments as done. EricWF added inline comments. Comment at: include/math.h:1556 +_LIBCPP_BEGIN_NAMESPACE_STD +template Seems odd this is the only thing in this file inside the standard namespace. > Are we moving towards writing `std::__helper` instead

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ added a comment. Np, post-commit review is always welcome (: Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65361/new/ https://reviews.llvm.org/D65361 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

Szelethus added a comment. Sorry for not accepting this -- I actually read the code multiple times and didn't see anything that stood out! I didn't have the time to dig too deep, but if the tests are anything to go by, its gotta be alright. Repository: rL LLVM CHANGES SINCE LAST ACTION ht

[PATCH] D66873: [Test][Time profiler] Fix test for python3

nathanchance added a comment. The test case passes for me after this, thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66873/new/ https://reviews.llvm.org/D66873 ___ cfe-commits mailin

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

gribozavr added inline comments. Comment at: clang/include/clang/Index/IndexingAction.h:60 + +inline std::unique_ptr createIndexingASTConsumer( +std::shared_ptr DataConsumer, jkorous wrote: > Why not use default argument instead of overloading? Writing a whol

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

aaron.ballman added a comment. Aside from the few remaining nits, I think this is almost ready to go. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:32-33 +"llvm-prefer-register-over-unsigned"); +CheckFactories.registerCheck( +"llvm-namespa

[PATCH] D66404: [CFG] Make destructor calls more accurate

This revision was automatically updated to reflect the committed changes. Closed by commit rL370247: [CFG] Make representation of destructor calls more accurate. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66847: [analyzer] Fix analyzer warnings.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370246: [analyzer] Fix analyzer warnings on analyzer. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL370244: [analyzer] Trust global initializers when analyzing main(). (authored by dergachev, committed by ). Herald added a

[PATCH] D66565: [analyzer] pr43036: Fix support for operator `sizeof...'.

This revision was automatically updated to reflect the committed changes. Closed by commit rL370245: [analyzer] pr43036: Fix support for operator 'sizeof...'. (authored by dergachev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D52524: Add -Wpoison-system-directories warning

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1072 +// cross-compiling. +def PoisonSystemDirectories : DiagGroup<"poison-system-directories">; + Do you envision more warnings being added to this group? If not, I wo

r370247 - [CFG] Make representation of destructor calls more accurate.

Author: dergachev Date: Wed Aug 28 11:44:42 2019 New Revision: 370247 URL: http://llvm.org/viewvc/llvm-project?rev=370247&view=rev Log: [CFG] Make representation of destructor calls more accurate. Respect C++17 copy elision; previously it would generate destructor calls for elided temporaries, in

r370244 - [analyzer] Trust global initializers when analyzing main().

Author: dergachev Date: Wed Aug 28 11:44:32 2019 New Revision: 370244 URL: http://llvm.org/viewvc/llvm-project?rev=370244&view=rev Log: [analyzer] Trust global initializers when analyzing main(). If the global variable has an initializer, we'll ignore it because we're usually not analyzing the pr

r370245 - [analyzer] pr43036: Fix support for operator 'sizeof...'.

Author: dergachev Date: Wed Aug 28 11:44:35 2019 New Revision: 370245 URL: http://llvm.org/viewvc/llvm-project?rev=370245&view=rev Log: [analyzer] pr43036: Fix support for operator 'sizeof...'. It was known to be a compile-time constant so it wasn't evaluated during symbolic execution, but it was

r370246 - [analyzer] Fix analyzer warnings on analyzer.

Author: dergachev Date: Wed Aug 28 11:44:38 2019 New Revision: 370246 URL: http://llvm.org/viewvc/llvm-project?rev=370246&view=rev Log: [analyzer] Fix analyzer warnings on analyzer. Write tests for the actual crash that was found. Write comments and refactor code around 17 style bugs and suppress

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

aaron.ballman added a comment. In D66397#1649353 , @xbolva00 wrote: > In D66397#1647455 , @aaron.ballman > wrote: > > > Adding @rsmith to see if we can make forward progress on this patch again. > > > On the other

[PATCH] D63134: [clang] improving diagnotics for invalid constexpr defaulted special membres

Tyker updated this revision to Diff 217694. Tyker added a comment. Rebased on current master @rsmith Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63134/new/ https://reviews.llvm.org/D63134 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp

[PATCH] D66715: [CFG] Add dumps for CFGElement and CFGElementRef

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! In D66715#1644395 , @Szelethus wrote: > Mind that I'll probably commit without the unit test, last time I learned the > hard way that the AST's lif

[PATCH] D66460: [analyzer] Remove BugReporter.BugTypes.

NoQ closed this revision. NoQ added a comment. Committed as rC369451 but forgot to add a phabricator link. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66460/new/ https://reviews.llvm.org/D66460 ___

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

Szelethus accepted this revision. Szelethus added a comment. Excellent detective work! Thanks! I'll do the honors. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66733/new/ https://reviews.llvm.org/D66733 ___ cfe-commits mailing list cfe-com

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

jkorous added a comment. Otherwise LGTM. Thanks for refactoring this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66879/new/ https://reviews.llvm.org/D66879 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev updated this revision to Diff 217682. sdmitriev added a comment. Rebased and synced up changes with https://reviews.llvm.org/D64943 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 Files: clang/test/Driver/clang-offload-wrapper.c cl

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

jkorous added inline comments. Comment at: clang/include/clang/Index/IndexingAction.h:60 + +inline std::unique_ptr createIndexingASTConsumer( +std::shared_ptr DataConsumer, Why not use default argument instead of overloading? Repository: rG LLVM Github Mo

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Index/IndexingAction.cpp:77 +IndexCtx->getDataConsumer().setPreprocessor(PP); +

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

jkorous added inline comments. Comment at: clang/lib/Index/IndexingAction.cpp:77 +IndexCtx->getDataConsumer().setPreprocessor(PP); +PP->addPPCallbacks(std::make_unique(IndexCtx)); + } gribozavr wrote: > ilya-biryukov wrote: > > The fact that we call `add

[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217 std::unique_ptr Includes; + index::Index

[clang-tools-extra] r370229 - [clangd] Migrate last tweak tests to TweakTesting.h and remove old helpers. NFC

Author: sammccall Date: Wed Aug 28 09:41:22 2019 New Revision: 370229 URL: http://llvm.org/viewvc/llvm-project?rev=370229&view=rev Log: [clangd] Migrate last tweak tests to TweakTesting.h and remove old helpers. NFC Modified: clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp Modified:

[PATCH] D66397: [Diagnostics] Improve -Wxor-used-as-pow

xbolva00 added a comment. In D66397#1647455 , @aaron.ballman wrote: > Adding @rsmith to see if we can make forward progress on this patch again. On the other side, I don't want to waste Richard's time since I dont want to extend (variables and macros a

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Looks like there will be no more comments. If so, I will update the first part https://reviews.llvm.org/D65130 which adds clang-offload-wrapper tool with the latest changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D6

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal updated this revision to Diff 217665. steakhal added a comment. Changes: - Flag option marked as 'enabled by default'. - Reformat all the test cases for C, C++ and Obj C. - Now uses `-verify=tags` approach. - Fixes checker documentation. CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon added inline comments. Comment at: test/libcxx/numerics/truncating_cast.pass.cpp:36 + {static_cast(Lim::max()) + 1, Lim::max(), false}, + {static_cast(Lim::max()) + 1024, Lim::max(), false}, + }; Probably should test `nextafter(static_cast(Lim::

[PATCH] D66836: [libc++] Add `__truncating_cast` for safely casting float types to integers

scanon added a comment. I would tend to write this function in the following form: // set up lower bound and upper bound if (r > upperBound) r = upperBound; if (!(r >= lowerBound)) r = lowerBound; // NaN is mapped to l.b. return static_cast(r); I prefer to avoid the explicit trunc call,

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal marked 2 inline comments as done. steakhal added a comment. Fixes for @NoQ's comments. I will update the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66733/new/ https://reviews.llvm.org/D66733 ___ cfe-commits mailing list c

  1   2   >