vsapsai added a comment. Earlier `tryToDropPCM` was called <https://github.com/llvm/llvm-project/commit/0a2be46cfdb698fefcc860a56b47dde0884d5335#diff-8946affa0243ed8ee535c6ed0a102f21R208> `tryToRemoveBuffer` and it was added in r298278 <https://github.com/llvm/llvm-project/commit/030d7d6daa1e93685660c6c03667126e72518101#diff-8946affa0243ed8ee535c6ed0a102f21R174>. According to my investigation and understanding it was used to remove tentatively loaded dependencies. Otherwise we would finalize them <https://github.com/llvm/llvm-project/commit/030d7d6daa1e93685660c6c03667126e72518101#diff-a645a23d1a2c018230833e5a3d2a8bb6R66> before validating if they are up to date. But now we are tracking a state of each module (Unknown, Tentative, ToBuild, Final) individually and don't need `tryToDropPCM`.
CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66907/new/ https://reviews.llvm.org/D66907 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
