[clang-tools-extra] r370022 - Revert "[clangd] Release notes" (wrong branch)

Author: sammccall Date: Mon Aug 26 23:58:05 2019 New Revision: 370022 URL: http://llvm.org/viewvc/llvm-project?rev=370022&view=rev Log: Revert "[clangd] Release notes" (wrong branch) This reverts commit 51029e5c153bd33efa015e2ec35b60247d046ce4. Modified: clang-tools-extra/trunk/docs/ReleaseN

[PATCH] D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

owenpan added a comment. The patch would have no effect if the `using` statement is not in a block, but that would probably be against C# syntax. Please see my comments about the test cases. Otherwise, LGTM. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:168 +TEST_

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

Hi Vitaly, Thanks for fixing this! And I’m sorry about accidentally disabling the test entirely by adding “REQUIRES: assertions” instead of “REQUIRES: asserts”. Dave > On Aug 27, 2019, at 1:10 AM, Vitaly Buka wrote: > > fixed with r369992 > > On Mon, Aug 26, 2019 at 1:16 PM Vitaly Buka

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3451 +const std::vector &warnings = + Res.getDiagnosticOpts().Warnings; The indentation here looks funny. Can you please run `git-clang-format` and commit the cha

[PATCH] D66783: [clang-doc] Use llvm::createStringError and canonicalize error messages

MaskRay updated this revision to Diff 217310. MaskRay added a comment. Herald added subscribers: kadircet, arphaman. Fix a few other places Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66783/new/ https://reviews.llvm.org/D66783 Files: clang-doc/

[PATCH] D66783: [clang-doc] Use llvm::createStringError and canonicalize error messages

MaskRay created this revision. MaskRay added reviewers: DiegoAstiazaran, juliehockett, jakehehrlich. Herald added a project: clang. Herald added a subscriber: cfe-commits. MaskRay updated this revision to Diff 217310. MaskRay added a comment. Herald added subscribers: kadircet, arphaman. Fix a few

[PATCH] D66782: SourceManager: Prefer Optional over MemoryBuffer*

dexonsmith created this revision. dexonsmith added reviewers: arphaman, Bigcheese, rsmith. Herald added subscribers: llvm-commits, ributzka, kadircet, jkorous, hiraditya. Herald added a reviewer: martong. Herald added a reviewer: shafik. Herald added a project: LLVM. Change the APIs in SourceManag

[PATCH] D66360: Expose constructing a virtual method dispatch through the include/clang/CodeGen APIs.

rjmccall added inline comments. Comment at: include/clang/CodeGen/SwiftCallingConv.h:190 +llvm::FunctionType *type, +llvm::IRBuilderBase *builder); + This isn't the ri

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

rjmccall added inline comments. Comment at: clang/docs/UsersManual.rst:1299 +.. option:: -fp-model=[values] + This should be something like `-fp-model=`. Square brackets mean optional elements in these docs. Comment at: clang/docs/UsersManu

[PATCH] D59922: [Attributor] Deduce "no-capture" argument attribute

jdoerfert updated this revision to Diff 217306. jdoerfert added a comment. rebase and update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59922/new/ https://reviews.llvm.org/D59922 Files: llvm/include/llvm/Transforms/IPO/Attributor.h ll

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added a comment. In D65744#1629055 , @Anastasia wrote: > In D65744#1627589 , @rjmccall wrote: > > > I see. Is the deduction rule recursive or something, where a pointer to > > pointer is inferred to point

[PATCH] D64811: Warn when NumParams overflows

rjmccall added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6233 + + } else if (RequiresArg) Diag(Tok, diag::err_argument_required_after_attribute); The re-indentation here is wrong. Comment at: clang/lib/Sema/SemaDeclCXX.

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm updated this revision to Diff 217301. arsenm added a comment. Make lower bound 1, although this is a behavior change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 Files: lib/CodeGen/TargetInfo.cpp test/CodeGenOpenCL/amdgpu-attrs.cl

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea reopened this revision. aganea added a reviewer: hans. aganea added a comment. This revision is now accepted and ready to land. Re-opening this because the previous commit broke Chromium. - Added a new test `debug-info-dest

[PATCH] D66328: [DebugInfo] Add debug location to dynamic atexit destructor

aganea updated this revision to Diff 217298. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66328/new/ https://reviews.llvm.org/D66328 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDeclCXX.cpp test/CodeGenCXX/debug-info-atexit-stub.cpp test/CodeGenCXX/debug-info-destroy-helper.

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. I approve the patch and i don't see anything obvious that we're missing out (@Szelethus, your GSoC isn't on by default back in 9.0, only in master, right?). I guess we should really try harder to fi

[clang-tools-extra] r370004 - Fix clangd's IndexAction for FileSkipped API update

Author: arphaman Date: Mon Aug 26 18:36:00 2019 New Revision: 370004 URL: http://llvm.org/viewvc/llvm-project?rev=370004&view=rev Log: Fix clangd's IndexAction for FileSkipped API update Modified: clang-tools-extra/trunk/clangd/index/IndexAction.cpp Modified: clang-tools-extra/trunk/clangd/i

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

NoQ added inline comments. Comment at: clang/docs/ReleaseNotes.rst:237-238 + +- New package: 'apiModeling.llvm' contains modeling checkers to improve the + accuracy of reports on LLVM's codebase. + "On LLVM's **own** codebase" :) @Charusso: I think we need to c

RE: r369986 - [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

I’ve changed to using svn:eol-style instead. Could you please let me know if that sounds better? See: https://reviews.llvm.org/D66556 De : Richard Smith Envoyé : August 26, 2019 9:03 PM À : Alexandre Ganea Cc : cfe-commits Objet : Re: r369986 - [clang-scan-deps] Minimizer: Correctly handle mul

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 217292. aganea added a reviewer: rsmith. aganea added a comment. This failed the build - I've changed `unix2dos` to `svn:eol-style CRLF` instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 Files: lib/L

[PATCH] D62571: Implement codegen for MSVC unions with reference members

domdom updated this revision to Diff 217289. domdom added a comment. Rebased onto master, clang format the patch. Merge conflict resolve by having the bitcast of the field reference happening after recording access index. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62571/new/ https:

r369999 - Don't lose the FoundDecl and template arguments for a DeclRefExpr in

Author: rsmith Date: Mon Aug 26 18:06:21 2019 New Revision: 36 URL: http://llvm.org/viewvc/llvm-project?rev=36&view=rev Log: Don't lose the FoundDecl and template arguments for a DeclRefExpr in TreeTransform. Modified: cfe/trunk/lib/Sema/TreeTransform.h Modified: cfe/trunk/lib/Sema/T

r370000 - Revert "[clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings"

Author: rsmith Date: Mon Aug 26 18:06:23 2019 New Revision: 37 URL: http://llvm.org/viewvc/llvm-project?rev=37&view=rev Log: Revert "[clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings" This reverts commit r369986. This change added a dependency on t

r369998 - Use FileEntryRef for PPCallbacks::FileSkipped

Author: arphaman Date: Mon Aug 26 18:03:25 2019 New Revision: 369998 URL: http://llvm.org/viewvc/llvm-project?rev=369998&view=rev Log: Use FileEntryRef for PPCallbacks::FileSkipped This fixes the issue where a filename dependendency was missing if the file that was skipped was included through a

Re: r369986 - [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

On Mon, 26 Aug 2019 at 16:17, Alexandre Ganea via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: aganea > Date: Mon Aug 26 16:19:21 2019 > New Revision: 369986 > > URL: http://llvm.org/viewvc/llvm-project?rev=369986&view=rev > Log: > [clang-scan-deps] Minimizer: Correctly handle multi-

[clang-tools-extra] r369998 - Use FileEntryRef for PPCallbacks::FileSkipped

Author: arphaman Date: Mon Aug 26 18:03:25 2019 New Revision: 369998 URL: http://llvm.org/viewvc/llvm-project?rev=369998&view=rev Log: Use FileEntryRef for PPCallbacks::FileSkipped This fixes the issue where a filename dependendency was missing if the file that was skipped was included through a

[PATCH] D61098: [clang] [RISC-V] Add validation for inline assembly constraints

mhorne abandoned this revision. mhorne added a comment. Herald added subscribers: pzheng, s.egerton, lenary, MaskRay. This has been handled more correctly and completely with recent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61098/new/

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked 2 inline comments as done. paulkirth added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:123 + const uint64_t CaseTotal = std::accumulate( + Weights.begin(), Weights.end(), (uint64_t)0, std::plus()); + const int NumUnlike

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217285. paulkirth marked an inline comment as done. paulkirth added a comment. Revert to use of auto when extracting metadata Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:108 + // extract values from misexpect metadata + const ConstantInt *IndexCint = + mdconst::dyn_extract(MisExpectData->getOperand(1)); `const auto *Index

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth marked 5 inline comments as done. paulkirth added inline comments. Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:108 + auto *L = mdconst::dyn_extract(MisExpectData->getOperand(2)); + auto *U = mdconst::dyn_extract(MisExpectData->getOperand(3)); + -

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth updated this revision to Diff 217282. paulkirth marked 3 inline comments as done. paulkirth added a comment. Address Code Review - Give better names to extracted constants - Remove extraneous call to getValue() - Make integers const - Remove extra braces - Move NOps into branch - Use st

[PATCH] D66511: [clang-scan-deps] Skip UTF-8 BOM in source minimizer

This revision was automatically updated to reflect the committed changes. Closed by commit rL369993: [clang-scan-deps] Skip UTF-8 BOM in source minimizer (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

r369993 - [clang-scan-deps] Skip UTF-8 BOM in source minimizer

Author: aganea Date: Mon Aug 26 17:13:52 2019 New Revision: 369993 URL: http://llvm.org/viewvc/llvm-project?rev=369993&view=rev Log: [clang-scan-deps] Skip UTF-8 BOM in source minimizer Differential Revision: https://reviews.llvm.org/D66511 Added: cfe/trunk/test/Lexer/minimize_source_to_depe

Re: r369971 - Revert r369843 "[Testing] Unbreak r369830"

fixed with r369992 On Mon, Aug 26, 2019 at 2:27 PM Vitaly Buka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: vitalybuka > Date: Mon Aug 26 14:29:06 2019 > New Revision: 369971 > > URL: http://llvm.org/viewvc/llvm-project?rev=369971&view=rev > Log: > Revert r369843 "[Testing] Unbr

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

fixed with r369992 On Mon, Aug 26, 2019 at 1:16 PM Vitaly Buka wrote: > Thank for the try, but it's not the fix as it just disabled the test > everywhere as no one sets "assertions". > Also I am not sure how the patch can break the test, it just renamed the > files. Which bot was that? > Is it p

r369992 - NFC: Make test work with or without assertions

Author: vitalybuka Date: Mon Aug 26 17:11:33 2019 New Revision: 369992 URL: http://llvm.org/viewvc/llvm-project?rev=369992&view=rev Log: NFC: Make test work with or without assertions Modified: cfe/trunk/test/CodeGenCXX/lifetime-sanitizer.cpp Modified: cfe/trunk/test/CodeGenCXX/lifetime-sani

[PATCH] D66667: Debug Info: Support for DW_AT_export_symbols for anonymous structs

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: test/CodeGenCXX/debug-info-export_symbols.cpp:4 +// CHECK: [[SCOPE:![0-9]+]] = distinct !DICompositeType({{.*}}flags: DIFlagTypePassByValue +// CHECK: !DIC

[PATCH] D66667: Debug Info: Support for DW_AT_export_symbols for anonymous structs

shafik updated this revision to Diff 217271. shafik marked an inline comment as done. shafik added a comment. Updating test to be more specific CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org/D7 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGenCX

Re: r363820 - Add a script to help generate expected test output for dumping the AST to JSON.

Hi Aaron, I tried using this script to update a json dump test, and it seems to not really work very well: 1) it's really inconvenient to invoke; you need to pass in a --clang, copy some options out from two different places in the test file (from the RUN line and from a "--filters" line), and gu

[PATCH] D66550: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include

This revision was automatically updated to reflect the committed changes. Closed by commit rL369988: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle… (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r369988 - [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include

Author: aganea Date: Mon Aug 26 16:28:05 2019 New Revision: 369988 URL: http://llvm.org/viewvc/llvm-project?rev=369988&view=rev Log: [clang-scan-deps] Minimizer: Correctly skip over double slashes in angle bracket #include Previously, double slashes (//) occurring in angle brackets #include were

[PATCH] D66712: [Driver] Enable ShadowCallStack, not SafeStack, by default on AArch64 Fuchsia

jakehehrlich accepted this revision. jakehehrlich added a comment. This revision is now accepted and ready to land. Landing aside, this looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66712/new/ https://reviews.llvm.org/D66712 ___

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

This revision was automatically updated to reflect the committed changes. Closed by commit rL369986: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF… (authored by aganea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pri

[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

STL_MSFT added a comment. This will definitely help us clean up our code, since we run the MSVC STL test suite with `-fno-ms-compatibility -fno-delayed-template-parsing`. Other possible occurrences of ms-extensions that should be considered ms-compatibility: - ParseDeclCXX.cpp says "MSVC permi

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

rnk added a comment. I plan to take a look at this tomorrow, sorry for putting this off for a while. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65761/new/ https://reviews.llvm.org/D65761 ___ cfe

r369986 - [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

Author: aganea Date: Mon Aug 26 16:19:21 2019 New Revision: 369986 URL: http://llvm.org/viewvc/llvm-project?rev=369986&view=rev Log: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings Previously, an #error directive with quoted, multi-line content, along wit

[PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

shafik accepted this revision. shafik added a comment. Other than my two comment this LGTM Comment at: clang/lib/AST/ASTImporter.cpp:3452 << FoundField->getType(); - - return make_error(ImportError::NameConflict); + ConflictingDecls.push_back(FoundField);

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

akhuang added a comment. Pinging reviewers -- are there any other concerns on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https://reviews.llvm.org/D64931 ___ cfe-commits mailin

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D64931: Change X86 datalayout for three address spaces that specify pointer sizes.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. I think we're ready to proceed here, lgtm. Shout if I've misrepresented anything. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64931/new/ https:/

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev updated this revision to Diff 217259. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp Index: clang/tools/clang-offload-bundl

r369985 - PR42587: diagnose unexpanded uses of a pack parameter of a generic

Author: rsmith Date: Mon Aug 26 15:51:28 2019 New Revision: 369985 URL: http://llvm.org/viewvc/llvm-project?rev=369985&view=rev Log: PR42587: diagnose unexpanded uses of a pack parameter of a generic lambda from within the lambda-declarator. Instead of trying to reconstruct whether a parameter pa

[PATCH] D66770: Move EH spec mismatches under -fms-compatibility

rnk created this revision. rnk added a reviewer: hans. Herald added a project: clang. -fms-extensions is intended to enable conforming language extensions and -fms-compatibility is intended to language rule relaxations, so a user could plausibly compile with -fno-ms-compatibility on Windows while

[PATCH] D66697: hwasan, codegen: Keep more lifetime markers used for hwasan

This revision was automatically updated to reflect the committed changes. Closed by commit rL369980: hwasan, codegen: Keep more lifetime markers used for hwasan (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

rsmith added a comment. I think we're past the point of large-scale structural comments that are better addressed before the first commit, and it'd be much better to make incremental improvements from here. Please go ahead and commit this, and we can iterate in-tree from now on. Thanks!

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

This revision was automatically updated to reflect the committed changes. Closed by commit rL369979: msan, codegen, instcombine: Keep more lifetime markers used for msan (authored by vitalybuka, committed by ). Herald added a subscriber: delcypher. Changed prior to commit: https://reviews.llvm.

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

nickdesaulniers added a comment. Cool, I look forward to checking for outdated `__builtin_expects` in the Linux kernel, if they exist! Comment at: llvm/lib/Transforms/Utils/MisExpect.cpp:108 + auto *L = mdconst::dyn_extract(MisExpectData->getOperand(2)); + auto *U =

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

xazax.hun abandoned this revision. xazax.hun added a comment. It looks like this solution is not going to work in general. The problem is that it can be really hard to tell when it is valid to create a gsl::Pointer from an unannotated local type. For example the code below is definitely buggy:

r369980 - hwasan, codegen: Keep more lifetime markers used for hwasan

Author: vitalybuka Date: Mon Aug 26 15:16:05 2019 New Revision: 369980 URL: http://llvm.org/viewvc/llvm-project?rev=369980&view=rev Log: hwasan, codegen: Keep more lifetime markers used for hwasan Reviewers: eugenis Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.l

r369979 - msan, codegen, instcombine: Keep more lifetime markers used for msan

Author: vitalybuka Date: Mon Aug 26 15:15:50 2019 New Revision: 369979 URL: http://llvm.org/viewvc/llvm-project?rev=369979&view=rev Log: msan, codegen, instcombine: Keep more lifetime markers used for msan Reviewers: eugenis Subscribers: hiraditya, cfe-commits, #sanitizers, llvm-commits Tags: #

[PATCH] D14484: Formatting constructor initializer lists by putting them always on different lines

rfairliecuninghame added a comment. The excellent and extensive Poco library project (https://pocoproject.org/) is an open-source example which limits constructor initializers to one-per-line (StyleGuide here: http://www.appinf.com/download/CppCodingStyleGuide.pdf, random example: https://gith

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

paulkirth added a reviewer: nickdesaulniers. paulkirth added a comment. Add Nick Desaulniers as an additional reviewer Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66324/new/ https://reviews.llvm.org/D66324 _

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetNum != 1)) { Error = true; ---

r369971 - Revert r369843 "[Testing] Unbreak r369830"

Author: vitalybuka Date: Mon Aug 26 14:29:06 2019 New Revision: 369971 URL: http://llvm.org/viewvc/llvm-project?rev=369971&view=rev Log: Revert r369843 "[Testing] Unbreak r369830" That was not the fix. This reverts commit 8bcf690ae03db85608b2ea22eac7a91c84df4dc. Modified: cfe/trunk/test/Cod

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetN

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:888 + // treat missing host triple as error if we do unbundling. + if ((Unbundle && HostTargetNum > 1) || (!Unbundle && HostTargetNum != 1)) { Error = true; ---

[PATCH] D63325: [Support][Time profiler] Make FE codegen blocks to be inside frontend blocks

mgehre added a comment. I'm seeing the same issue `Not all CodeGen sections are inside any Frontend section!` with python 3.7.1. Json: F9863382: check-time-trace-sections.json Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63325

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +- New :doc:`bugprone-posix-return + ` check. Check is not new, just modified. Such check should be after new checks. Comment at: clang-tools-extra/

[PATCH] D66601: [Clang][Bundler] Do not require host triple for extracting device bundles

sdmitriev updated this revision to Diff 217234. sdmitriev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66601/new/ https://reviews.llvm.org/D66601 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp I

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

jcai19 updated this revision to Diff 217236. jcai19 added a comment. Update Release Notes and check documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66627/new/ https://reviews.llvm.org/D66627 Files: clang-tools-extra/clang-tidy/bugpr

r369968 - Updating a test case that was missed in r369957.

Author: aaronballman Date: Mon Aug 26 13:55:43 2019 New Revision: 369968 URL: http://llvm.org/viewvc/llvm-project?rev=369968&view=rev Log: Updating a test case that was missed in r369957. Modified: cfe/trunk/test/SemaOpenCLCXX/restricted.cl Modified: cfe/trunk/test/SemaOpenCLCXX/restricted.c

[PATCH] D66404: [CFG] Make destructor calls more accurate

Szelethus added a comment. In D66404#1645851 , @comex wrote: > Heh, I guess I'll request commit access, although I'm not sure if I have > enough of a 'track record of submitting high quality patches'. You really do :) Repository: rC Clang CHANGES S

r369964 - [DebugInfo] Add debug-entry-values test coverage, NFC

Author: vedantk Date: Mon Aug 26 13:50:54 2019 New Revision: 369964 URL: http://llvm.org/viewvc/llvm-project?rev=369964&view=rev Log: [DebugInfo] Add debug-entry-values test coverage, NFC Check that call site descriptions are emitted in dwarf4 + lldb + debug-entry-values mode. Modified: cfe/

r369965 - Remove unused variables.

Author: d0k Date: Mon Aug 26 13:51:23 2019 New Revision: 369965 URL: http://llvm.org/viewvc/llvm-project?rev=369965&view=rev Log: Remove unused variables. Modified: cfe/trunk/unittests/Tooling/CompilationDatabaseTest.cpp Modified: cfe/trunk/unittests/Tooling/CompilationDatabaseTest.cpp URL:

[PATCH] D66404: [CFG] Make destructor calls more accurate

comex added a comment. Heh, I guess I'll request commit access, although I'm not sure if I have enough of a 'track record of submitting high quality patches'. But for now, can you commit this? Thanks :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66404/new/

r369960 - Fixing a weird copy-pasta to get bots back to green.

Author: aaronballman Date: Mon Aug 26 13:46:20 2019 New Revision: 369960 URL: http://llvm.org/viewvc/llvm-project?rev=369960&view=rev Log: Fixing a weird copy-pasta to get bots back to green. Modified: cfe/trunk/test/Sema/thread-specifier.c Modified: cfe/trunk/test/Sema/thread-specifier.c UR

[PATCH] D66598: [Clang][Bundler] Fix for a hang when unbundling fat binary

sdmitriev updated this revision to Diff 217232. sdmitriev added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66598/new/ https://reviews.llvm.org/D66598 Files: clang/test/Driver/clang-offload-bundler.c clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp I

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

Eugene.Zelenko added a comment. It'll be reasonable to mention changes in Release Notes and check documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66627/new/ https://reviews.llvm.org/D66627 ___

[PATCH] D66627: [clang-tidy] new check: bugprone-pthread-return

jcai19 updated this revision to Diff 217231. jcai19 added a comment. Add pthread function calls return values check to bugprone-posix-return. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66627/new/ https://reviews.llvm.org/D66627 Files: clang-t

[PATCH] D66713: ContentCache: Drop getBuffer's dependency on SourceManager

dexonsmith closed this revision. dexonsmith added a comment. Committed in r369958. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66713/new/ https://reviews.llvm.org/D66713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

comex added inline comments. Comment at: clang/test/SemaTemplate/default-arguments-cxx0x.cpp:1 -// RUN: %clang_cc1 -fsyntax-only -std=c++11 -verify %s +// RUN: %clang_cc1 -fsyntax-only -std=c++14 -verify %s // expected-no-diagnostics lebedev.ri wrote: > Mordante

[PATCH] D66067: Push lambda scope earlier when transforming lambda expression

comex updated this revision to Diff 217230. comex marked 2 inline comments as done. comex added a comment. Addressed review comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66067/new/ https://reviews.llvm.org/D66067 Files: lib/Sema/TreeTransform.h tes

r369958 - ContentCache: Drop getBuffer's dependency on SourceManager

Author: dexonsmith Date: Mon Aug 26 13:32:05 2019 New Revision: 369958 URL: http://llvm.org/viewvc/llvm-project?rev=369958&view=rev Log: ContentCache: Drop getBuffer's dependency on SourceManager Refactor ContentCache::IsSystemFile to IsFileVolatile, checking SourceManager::userFilesAreVolatile a

r369957 - Reword the C11 extension diagnostic.

Author: aaronballman Date: Mon Aug 26 13:29:08 2019 New Revision: 369957 URL: http://llvm.org/viewvc/llvm-project?rev=369957&view=rev Log: Reword the C11 extension diagnostic. This makes it more consistent with other language extension diagnostics. Modified: cfe/trunk/include/clang/Basic/Dia

[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

dexonsmith updated this revision to Diff 217229. dexonsmith added a comment. New diff with full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66710/new/ https://reviews.llvm.org/D66710 Files: clang/include/clang/Basic/FileManager.h clang/include/clang/Basic/SourceManager.h

Re: r369830 - NFC: Rename some sanitizer related lifetime checks

Thank for the try, but it's not the fix as it just disabled the test everywhere as no one sets "assertions". Also I am not sure how the patch can break the test, it just renamed the files. Which bot was that? Is it possible that your local checkout just had the test disabled? On Sat, Aug 24, 2019

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:72 + + Contains lint checks related to OpenCL programming for FPGAs. + Just checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 __

[PATCH] D66694: [libclang][index][NFCi] Refactor machinery for skipping already parsed function bodies

jkorous marked 3 inline comments as done. jkorous added inline comments. Comment at: clang/tools/libclang/Indexing.cpp:371 - SessionSkipBodyData *SKData; - std::unique_ptr SKCtrl; + SharedParsedRegionsStorage *SKData; + std::unique_ptr ParsedLocsTracker; jk

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

This revision was automatically updated to reflect the committed changes. Closed by commit rGed153ef044fd: [Clang][Bundler] Use llvm-objcopy for creating fat object files (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66485/ne

r369956 - Fix gen-cdb-fragment test for Windows

Author: arphaman Date: Mon Aug 26 13:02:40 2019 New Revision: 369956 URL: http://llvm.org/viewvc/llvm-project?rev=369956&view=rev Log: Fix gen-cdb-fragment test for Windows Windows bots didn't seem to like the empty argument, so I rewrote the test. Modified: cfe/trunk/test/Driver/gen-cdb-fra

[PATCH] D66694: [libclang][index][NFCi] Refactor machinery for skipping already parsed function bodies

jkorous marked 4 inline comments as done. jkorous added a comment. Hmm, I already landed this - let's transfer the discussion to https://reviews.llvm.org/D66764. I'll make the changes to that patch. Is that ok? Comment at: clang/tools/libclang/Indexing.cpp:126 +/// Is thread-s

[PATCH] D66364: Diagnose use of _Thread_local as an extension when appropriate

aaron.ballman closed this revision. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Committed in r369954 Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:130 +def ext_c11_feature : Extension< "%0 is a C11-specific feature">, InGrou

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal added a comment. @Szelethus Your catch with the mispositioned report message

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

ffrankies updated this revision to Diff 217224. ffrankies added a comment. Added space after clang-tidy in header comments, updated check documentation to use link syntax. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66564/new/ https://reviews.llvm.org/D66564 Files: clang-tidy/fpga

r369955 - [Clang][Bundler] Use llvm-objcopy for creating fat object files

Author: sdmitriev Date: Mon Aug 26 12:48:43 2019 New Revision: 369955 URL: http://llvm.org/viewvc/llvm-project?rev=369955&view=rev Log: [Clang][Bundler] Use llvm-objcopy for creating fat object files clang-offload-bundler currently uses partial linking for creating fat object files, but such tec

r369954 - Diagnose use of _Thread_local as an extension when not in C11 mode.

Author: aaronballman Date: Mon Aug 26 12:44:07 2019 New Revision: 369954 URL: http://llvm.org/viewvc/llvm-project?rev=369954&view=rev Log: Diagnose use of _Thread_local as an extension when not in C11 mode. Modified: cfe/trunk/include/clang/Basic/DiagnosticParseKinds.td cfe/trunk/lib/Pars

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:251 + + - ``-analyzer-checker-help-alpha``: The list of incomplet and inkorrekt +checkers not yet advised to be turned on. Please fix this Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D66765: [analyzer] (Urgent!) Add 9.0.0. release notes.

xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:263 + + - ``-analyzer-checker-option-help-alpha``: The list of incomplet and inkorrekt +not yet advised to be specified. Detto Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

  1   2   3   >