[PATCH] D65854: [diagtool] Use `operator<<(Colors)` to print out colored output.

ruiu marked an inline comment as done. ruiu added inline comments. Comment at: clang/tools/diagtool/TreeView.cpp:167 + if (!hasColors(out)) +out.enable_colors(false); + MaskRay wrote: > `out.enable_colors(out.has_colors());` > > It looks the function `hasCo

[PATCH] D65925: Add SpaceInEmptyBlock option for WebKit

owenpan created this revision. owenpan added reviewers: sammccall, MyDeveloperDay, djasper, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. See PR40840 Repository: rC Clang https://reviews.llvm.org/D65925 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:16 +namespace { +const char *kCustomCategoryMethodIdentifier = "ThisIsACategoryMethod"; +} // anonymous namespace Please use static. See

r368251 - [Driver] Delete XFAIL: windows-msvc after D65880/r368245

Author: maskray Date: Wed Aug 7 21:56:21 2019 New Revision: 368251 URL: http://llvm.org/viewvc/llvm-project?rev=368251&view=rev Log: [Driver] Delete XFAIL: windows-msvc after D65880/r368245 `-target %itanium_abi_triple` fixed the problem. Modified: cfe/trunk/test/Driver/linker-opts.c Modif

[PATCH] D65915: [clang-doc] Protect Index with mutex during reducing and generation stage

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65915/new/ https://reviews.llvm.org/D65915 ___ cfe-commits mailing list c

[PATCH] D65880: [Driver] Move LIBRARY_PATH before user inputs

MaskRay added a comment. @hfinkel Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65880/new/ https://reviews.llvm.org/D65880 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D65880: [Driver] Move LIBRARY_PATH before user inputs

This revision was automatically updated to reflect the committed changes. Closed by commit rL368245: [Driver] Move LIBRARY_PATH before user inputs (authored by MaskRay, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore updated this revision to Diff 214053. stephanemoore added a comment. Add tests for `isDirectlyDerivedFrom`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60543/new/ https://reviews.llvm.org/D60543 Files: clang/docs/LibASTMatchersRe

r368245 - [Driver] Move LIBRARY_PATH before user inputs

Author: maskray Date: Wed Aug 7 18:55:27 2019 New Revision: 368245 URL: http://llvm.org/viewvc/llvm-project?rev=368245&view=rev Log: [Driver] Move LIBRARY_PATH before user inputs Fixes PR16786 Currently, library paths specified by LIBRARY_PATH are placed after inputs: `inputs LIBRARY_PATH stdl

r368244 - Inline diagnostic text into .td file. NFC.

Author: rtrieu Date: Wed Aug 7 18:45:31 2019 New Revision: 368244 URL: http://llvm.org/viewvc/llvm-project?rev=368244&view=rev Log: Inline diagnostic text into .td file. NFC. Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td cfe/trunk/lib/Sema/SemaExpr.cpp Modified: cfe/tr

[PATCH] D65918: [clang-doc] Generate an HTML index file

DiegoAstiazaran created this revision. DiegoAstiazaran added reviewers: juliehockett, jakehehrlich. DiegoAstiazaran added a project: clang-tools-extra. Herald added a subscriber: arphaman. clang-doc now generates a file that contains only an index to all the infos that can be used as the landing

[PATCH] D65917: Added clang-tidy module for the Google style guide's category method naming rule.

dgatwood created this revision. dgatwood added a reviewer: stephanemoore. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt clang-tools-

[PATCH] D65493: Modernize atomic detection and usage

Bigcheese added a comment. This looks like a good simplification, but I think `call_once` could be simplified more. Comment at: llvm/cmake/modules/CheckAtomic.cmake:46 + if (NOT HAVE_ATOMICS_WITH_LIB) + message(FATAL_ERROR "Host compiler must support atomic!")

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 marked an inline comment as done. jcai19 added a comment. In D65019#1619511 , @efriedma wrote: > This seems better. > > I'm not sure I follow why this needs special handling in > SelectionDAGBuilder::visitIntrinsicCall, as opposed to just using >

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore planned changes to this revision. stephanemoore added a comment. Whoops; forgot to add test cases for `isDirectlyDerivedFrom` 🤦 Will do that shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60543/new/ https://reviews.llvm.org/D

[PATCH] D65915: [clang-doc] Protect Index with mutex during reducing and generation stage

DiegoAstiazaran created this revision. DiegoAstiazaran added a reviewer: juliehockett. DiegoAstiazaran added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman, ilya-biryukov. Idx in ClangDocContext instance was being modified by multiple threads causing a seg fault. A mut

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

andrew.w.kaylor added a comment. I'm not entirely caught up on this review. I've only read the most recent comments, but I think I've got enough context to comment on the metadata arguments. Based only on the fp-model command line options, the front end should only ever use "round.dynamic" (fo

[PATCH] D65912: Add new check for math constants

Eugene.Zelenko added a comment. May be this check belongs to readability module? Comment at: clang-tools-extra/clang-tidy/misc/MathConstantsCheck.cpp:13 +#include "../../../clang/unittests/AST/Language.h" + +#include Unnecessary empty line.

[PATCH] D65912: Add new check for math constants

ZaMaZaN4iK updated this revision to Diff 214043. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65912/new/ https://reviews.llvm.org/D65912 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt clang-tools-extra/clang-tidy/misc/MathConstantsCheck.cpp clang-tools-extra/clang-tidy/mi

[PATCH] D65913: Fix segfault caused by the "libstdc++ eager exception spec hack"

bmoody created this revision. bmoody added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Segfault occurs when the hack is applied to a function decl containing an unparsed default argument. Parser::HandleMemberFunctionDeclDelays was assuming that if a d

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso updated this revision to Diff 214041. Charusso added a comment. - May it is better to also check for `getAsCXXRecordDecl()` for obtaining a class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.org/D65889 Files: clang/lib/StaticAnalyzer/Checke

[PATCH] D65912: Add new check for math constants

ZaMaZaN4iK created this revision. ZaMaZaN4iK added reviewers: JonasToth, Szelethus, aaron.ballman, lebedev.ri. ZaMaZaN4iK added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Hello. I found quite interesting and useful FMPOV check for C

[PATCH] D65212: [analyzer] Fix exporting SARIF files from scan-build on Windows

NoQ added inline comments. Comment at: clang/tools/scan-build/libexec/ccc-analyzer:121 END { - if (defined $ResultFile && -z $ResultFile) { unlink($ResultFile); Whoops. I suspect that we're now unconditionally deleting all plist output, which isn't exactl

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso updated this revision to Diff 214038. Charusso added a comment. - Fix a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.org/D65889 Files: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp clang/test/Analysis/cast-value.cpp Index

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:51 + + const CallDescriptionMap SugarCastCDM = { + {{{"clang", "castAs"}, 0}, &CastValueChecker::evalCastAs}, NoQ wrote: > I'd rather have only one map from c

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Charusso updated this revision to Diff 214037. Charusso marked 9 inline comments as done. Charusso added a comment. - Make it usable with references. - Test references. - Better messages on simple `cast<>`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.or

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore added a comment. I spent some time becoming familiar with how `isDerivedFrom` behaves for C++ classes. I //think// that I have managed to get the behavior for Objective-C classes to mirror that of C++ classes. Please let me know if I overlooked anything. Commen

r368237 - Update fix-it hints for std::move warnings.

Author: rtrieu Date: Wed Aug 7 17:12:51 2019 New Revision: 368237 URL: http://llvm.org/viewvc/llvm-project?rev=368237&view=rev Log: Update fix-it hints for std::move warnings. Fix -Wpessimizing-move and -Wredundant-move when warning on initializer lists. The new fix-it hints for removing the std

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore updated this revision to Diff 214035. stephanemoore marked 6 inline comments as done. stephanemoore edited the summary of this revision. stephanemoore added a comment. Update `isDerivedFrom` to match aliased types and compatibility aliases of derived Objective-C classes. Repository

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D59963: [clang-tidy] Add a module for the Linux kernel.

nickdesaulniers added inline comments. Comment at: clang-tools-extra/clang-tidy/linuxkernel/MustCheckErrsCheck.cpp:12 +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include + tmroeder wrote: > tmroeder wrote: > > nickdesaulniers wrote: > > > tmroeder wrote: >

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

arphaman added a comment. Thanks for figuring out these issues! It looks like you're fixing several edge cases, would you mind splitting the patch up for easier review? Regarding the invisible characters before `#ifdef`, are you sure that's the right behavior? If you run the preprocessor over y

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1753-1755 + // It so happens that CFGBlock::getTerminatorCondition returns 'A' for block + // B1, 'A && B' for B2, and 'A && B || C' for B3. Let's check whether we + // reached the end

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman updated this revision to Diff 214015. arphaman added a comment. Fix the FIXME. The patch is now ready for review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65907/new/ https://reviews.llvm.org/D65907 Files: clang/include/clang/Basic/FileManager.h clang/include/clang/Bas

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:192-194 + if (const auto *DRE = dyn_cast(CondVarExpr)) +if (const auto *VD = dyn_cast(DRE->getDecl())) + return State->getSVal(State->getLValue(VD, LCtx)); ---

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

compnerd added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:904 + case 'j': // An immediate integer between 0 and 65535 (valid for MOVW) +if (CPUAttr.equals("6T2") || +ArchVersion >= 7) // only available in ARMv6T2 and above I would h

[PATCH] D65578: [analyzer][NFC] Make sure that the BugReport is not modified during the construction of non-visitor pieces

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:108 SmallVector Ranges; + const SourceRange ErrorNodeRange; ExtraTextList ExtraText; -

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman planned changes to this revision. arphaman added a comment. I forgot I left a FIXME that I intended to fix in there, I need to resolve that first. I'll update the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65907/new/ https://rev

[PATCH] D65549: [Sema] Prevent -Wunused-lambda-capture from generating false positive warnings on templated member function

ziangwan updated this revision to Diff 214013. ziangwan added a comment. Fix style issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65549/new/ https://reviews.llvm.org/D65549 Files: clang/lib/Sema/SemaExpr.cpp clang/test/SemaCXX/warn-unused-lambda-capture-this.cpp Index: clang

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ on Linux and ‘atexit’ on Windows) whereas @llvm.global_ctors/dtors variables offer similar and platform neutral functionality (http://llvm.org/docs/LangRef.html#the-llvm-global-ctors-global-va

[PATCH] D65723: [analyzer][NFC] Add different interestingness kinds

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:92-101 /// Default tracking kind -- specifies that as much information should be //

[PATCH] D65725: [analyzer] Mention whether an event is about a condition in a bug report part 2

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Accept as long as we agree on the wording as part of D65575 . Comment at: clang/test/Analysis/track-control-dependency-conditions.cpp:465 void as

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

NoQ added a comment. Nice!! Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h:225-226 // FIXME: constexpr initialization isn't supported by MSVC2013. - static const char *const GenericTrueMessage; - static const char *const GenericFalse

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman updated this revision to Diff 214010. arphaman added a comment. Fix a bug with dereferencing `None` File value in one call. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65907/new/ https://reviews.llvm.org/D65907 Files: clang/include/cl

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1619908 , @lebedev.ri wrote: > In D62731#1619892 , @mibintc wrote: > > > Compared to the 2nd revision, this patch moves all the changes into clang, > > removing the FPState file.

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1603030 , @kpn wrote: > I actually don't have much of an opinion on what the command line argument > form should be. It may be helpful for it to be the same as one of the > commonly deployed compilers. The worst I think

[PATCH] D62960: Add SVE opaque built-in types

rjmccall added inline comments. Comment at: lib/AST/ASTContext.cpp:1974 + break; +#include "clang/Basic/AArch64SVEACLETypes.def" } Why do SVE predicates have 16-bit alignment? Should this be 128-bit (16-*byte*)? I guess these alignments are reasonabl

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. In D62731#1601408 , @kpn wrote: > In D62731#1601310 , @mibintc wrote: > > > I think it would be convenient to have an "unset" setting for the different > > constrained modes, otherwise you

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

lebedev.ri added a comment. In D62731#1619892 , @mibintc wrote: > Compared to the 2nd revision, this patch moves all the changes into clang, > removing the FPState file. > > In the summary, I've copied information from Microsoft about the fp-model > opti

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65838: [Driver] Use enumeration for quoting mode. NFC

rnk accepted this revision. rnk added a comment. lgtm+2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65838/new/ https://reviews.llvm.org/D65838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 214004. DiegoAstiazaran added a comment. Rebase to master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.llvm.org/D65483 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeW

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc updated this revision to Diff 214003. mibintc edited the summary of this revision. mibintc added a comment. Compared to the 2nd revision, this patch moves all the changes into clang, removing the FPState file. In the summary, I've copied information from Microsoft about the fp-model opt

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman created this revision. arphaman added reviewers: rsmith, bruno, Bigcheese, jkorous, harlanhaskins. Herald added subscribers: dexonsmith, mgorny. Herald added a project: clang. This patch introduces a parallel API to FileManager's `getFile`: `getFileEntryRef`, which returns a reference to

[PATCH] D65846: Improve error message from FrontendAction

akyrtzi added a comment. In D65846#1619752 , @bruno wrote: > > `clang -fmodules -fmodules-cache-path=...` is supposed to create the > > directory for the cache path, including the parent directories, AFAIK. If > > this doesn't happen it is a behavior cha

[PATCH] D65461: [OPENMP]Add support for analysis of linear variables and step.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx again! Comment at: lib/AST/OpenMPClause.cpp:473 + // (Step and CalcStep), list of used expression + step. + void *Mem = C.Allocate(totalSizeToAlloc(5 * NumVars + 2 + NumVars

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp targe

[PATCH] D65906: [clang-scan-deps] Fix edge cases in the minimizer

aganea created this revision. aganea added reviewers: arphaman, dexonsmith, Bigcheese. aganea added a project: clang. Herald added a subscriber: tschuett. This patch fixes: 1. Invisible characters that come just before #include, such as #ifndef. ( were hidden, depending on the display loca

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: clang/lib/Basic/Targets/ARM.cpp:325 + ? "llvm.arm.gnu.eabi.mcount" : "\01mcount"; Doesn't require changes,

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

DiegoAstiazaran updated this revision to Diff 214000. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Add comments. Move definition of ClangDocContext constructor to .cpp file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65483/new/ https://reviews.ll

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

This revision was automatically updated to reflect the committed changes. Closed by commit rL368209: [clang-doc] Add second index for sections within info's content (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior t

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

DiegoAstiazaran updated this revision to Diff 213991. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/Representation.h clang-tools-extra/unittests/clang-doc/HTM

[clang-tools-extra] r368209 - [clang-doc] Add second index for sections within info's content

Author: diegoastiazaran Date: Wed Aug 7 14:04:52 2019 New Revision: 368209 URL: http://llvm.org/viewvc/llvm-project?rev=368209&view=rev Log: [clang-doc] Add second index for sections within info's content This new index contains links to the main section of infos: Namespaces, Records, Functions

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. plotfi@grendel:/mnt/nvme0/llvm-project$ build/tools/clang/unittests/DirectoryWatcher/./DirectoryWatcherTests --gtest_filter=DirectoryWatcherTest.AddFilesNote: Google Test filter = DirectoryWatcherTest.AddFiles [==] Running 1 test from 1 test case. [

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65853/new/ https://reviews.llvm.org/D65853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D65853: Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit

plotfi added a comment. I tested this out. Seems to work fine, and print the Expected's Error. I am fine with it if @compnerd and @lhames and @jkorous are cool with it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65853/new/ https://reviews.llvm.

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CastValueChecker.cpp:51 + + const CallDescriptionMap SugarCastCDM = { + {{{"clang", "castAs"}, 0}, &CastValueChecker::evalCastAs}, I'd rather have only one map from call descriptions t

[PATCH] D65628: [clang-doc] Parallelize reducing phase

This revision was automatically updated to reflect the committed changes. Closed by commit rL368206: [clang-doc] Parallelize reducing phase (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[clang-tools-extra] r368206 - [clang-doc] Parallelize reducing phase

Author: diegoastiazaran Date: Wed Aug 7 13:54:26 2019 New Revision: 368206 URL: http://llvm.org/viewvc/llvm-project?rev=368206&view=rev Log: [clang-doc] Parallelize reducing phase Reduce phase has been parallelized and a execution time was reduced by 60% with this. The reading of bitcode (bitcod

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp targe

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213986. DiegoAstiazaran marked an inline comment as done. DiegoAstiazaran added a comment. Add comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/ https://reviews.llvm.org/D65628 Files: clang-tools-extra/clang-doc/tool/ClangD

[PATCH] D65846: Improve error message from FrontendAction

bruno added a comment. > Internal compiler error: LFS error for > "/Users/jfb/s/llvmm/debug/tools/clang/test/Index/Output/pch-from-libclang.c.tmp.mcp/14EC4PG1UTVLY/modules.idx"failed > to create unique file > /Users/jfb/s/llvmm/debug/tools/clang/test/Index/Output/pch-from-libclang.c.tmp.mcp

[PATCH] D65628: [clang-doc] Parallelize reducing phase

juliehockett accepted this revision. juliehockett added a comment. This revision is now accepted and ready to land. LGTM (after comment nit addressed) Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:249 + Error = false; + llvm::ThreadPool Pool(ExecutorConcurrenc

Re: [PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

On Wed, 2019-08-07 at 17:10 -0300, Adhemerval Zanella wrote: > On 05/06/2019 05:19, Michał Górny via Phabricator via llvm-commits wrote: > > This revision was automatically updated to reflect the committed changes. > > Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027 > >

[PATCH] D65483: [clang-doc] Add link to source code in file definitions

juliehockett added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:385 +SourceRoot(SourceRoot), UserStylesheets(UserStylesheets), +JsScripts(JsScripts) { +if (!RepositoryUrl.empty()) { Move to .cpp file (now that it h

Re: [PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

On Wed, 2019-08-07 at 17:10 -0300, Adhemerval Zanella wrote: > On 05/06/2019 05:19, Michał Górny via Phabricator via llvm-commits wrote: > > This revision was automatically updated to reflect the committed changes. > > Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027 > >

[PATCH] D65030: [clang-doc] Add second index for sections within info's content

juliehockett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65030/new/ https://reviews.llvm.org/D65030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D65545: Handle some fs::remove failures

jfb updated this revision to Diff 213980. jfb marked 3 inline comments as done. jfb added a comment. - Don't report_fatal_error in code that can be called from LLDB Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65545/new/ https://reviews.llvm.org/D

[PATCH] D65545: Handle some fs::remove failures

jfb added a comment. Updated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65545/new/ https://reviews.llvm.org/D65545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D65846: Improve error message from FrontendAction

akyrtzi added a comment. In D65846#1619645 , @jfb wrote: > My current guess is that this part of the test: > > c-index-test -write-pch %t.h.pch %s -fmodules -fmodules-cache-path=%t.mcp > -Xclang -triple -Xclang x86_64-apple-darwin > > > Is expected to g

Re: [PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

On 05/06/2019 05:19, Michał Górny via Phabricator via llvm-commits wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027 > (authored by mgorny, committed by ). > Herald added a project: LLVM.

[PATCH] D65878: [Refactor] Moving SourceExtraction header from lib to include

SureYeaah updated this revision to Diff 213973. SureYeaah added a comment. Added endif comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65878/new/ https://reviews.llvm.org/D65878 Files: clang/include/clang/Tooling/Refactoring/Extract/Source

[PATCH] D65846: Improve error message from FrontendAction

jfb added a comment. My current guess is that this part of the test: c-index-test -write-pch %t.h.pch %s -fmodules -fmodules-cache-path=%t.mcp -Xclang -triple -Xclang x86_64-apple-darwin Is expected to generate the `unknown type name` error, but when than happens it ignores `-fmodules-cache-

[PATCH] D65545: Handle some fs::remove failures

JDevlieghere added a comment. Thanks for looping me in, @vsapsai! Comment at: llvm/include/llvm/Support/FileUtilities.h:52-53 if (DeleteIt) { -// Ignore problems deleting the file. -sys::fs::remove(Filename); +if (std::error_code EC = sys::fs::rem

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

void added a comment. In D60943#1619579 , @JamesNagurne wrote: > In case you haven't seen, this commit breaks non-x86 build bots due to the > combination of '-triple x86_64*' and '-S'. Some tests that use this target > are only looking for AST dumps, an

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:72 +static llvm::cl::opt ThreadCount( +"thread-count", juliehockett wrote: > Can we use the pre-existing concurrency flag instead > (https://github.com/llv

[PATCH] D65628: [clang-doc] Parallelize reducing phase

DiegoAstiazaran updated this revision to Diff 213968. DiegoAstiazaran marked 2 inline comments as done. DiegoAstiazaran added a comment. Use pre-existing concurrency flag `--execute-concurrency` instead implementing a new one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65628/new/ ht

r368202 - Add target requirements for those bots which don't handle x86.

Author: void Date: Wed Aug 7 12:36:48 2019 New Revision: 368202 URL: http://llvm.org/viewvc/llvm-project?rev=368202&view=rev Log: Add target requirements for those bots which don't handle x86. Modified: cfe/trunk/test/CodeGen/pr41027.c Modified: cfe/trunk/test/CodeGen/pr41027.c URL: http:/

[PATCH] D62960: Add SVE opaque built-in types

rsandifo-arm added a comment. Ping. @rjmccall: thanks for the positive feedback. Is there a particular reviewer you'd like to hear from before the patch lands? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62960/new/ https://reviews.llvm.org/D62960

[PATCH] D65545: Handle some fs::remove failures

vsapsai added a comment. I have no other comments but for the fatal error in `FileRemover` I'd like to loop in Jonas as he was touching module cache in LLDB fairly recently. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1444-1445 // Remove the file. - llvm::s

[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

JamesNagurne added a comment. In case you haven't seen, this commit breaks non-x86 build bots due to the combination of '-triple x86_64*' and '-S'. Some tests that use this target are only looking for AST dumps, and do not actually require such a target. This is not one of those tests, as it's

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1619549 , @jdenny wrote: > In D65835#1619526 , @ABataev wrote: > > > > Maybe, but I haven't found any statement in either version that states > > > that map restrictions apply to

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1619526 , @ABataev wrote: > > Maybe, but I haven't found any statement in either version that states that > > map restrictions apply to is_device_ptr. > > `is_device_ptr` is a kind of mapping clause. I assume we can exten

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. > I should have reported that the current implementation isn't complete for > OpenMP 4.5. For example, on target teams, reduction(+:x) map(x) is an error > but not map(x) reduction(+:x). So there are bugs to fix, and maybe this will > evolve into multiple patches, but I

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. > Maybe, but I haven't found any statement in either version that states that > map restrictions apply to is_device_ptr. `is_device_ptr` is a kind of mapping clause. I assume we can extend the restrictions for `map` clause to this clause too. > Another question is whet

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdoerfert added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp targe

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

efriedma added a comment. This seems better. I'm not sure I follow why this needs special handling in SelectionDAGBuilder::visitIntrinsicCall, as opposed to just using ISD::INTRINSIC_VOID like other similar target-specific intrinsics. (You can custom-lower INTRINSIC_VOID in ARMTargetLowering:

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_is_device_ptr_messages.cpp:93 ; -#pragma omp target parallel for private(ps) is_device_ptr(ps) // expected-error{{private variable cannot be in a is_device_ptr clause in '#pragma omp target

[PATCH] D65889: [analyzer] CastValueChecker: Model castAs(), getAs()

Szelethus added a comment. Cheers! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65889/new/ https://reviews.llvm.org/D65889 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

  1   2   >