[PATCH] D62471: [clangd] SymbolCollector support for relations

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The only relation currently collected is RelationBaseOf, because this is all we need for type hierarchy subtypes. Addit

[PATCH] D62469: [Driver] Change layout of per-target runtimes to resemble multiarch

phosek created this revision. phosek added reviewers: jdenny, beanz, smeenai, mcgrathr, saugustine. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, cryptoad, javed.absar, mgorny, kubamracek. Herald added projects: clang, Sanitizers, LLVM. This is a follow up to r361432, changing

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 201471. plotfi added a comment. virtual function test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/include/clang/Driver/Options.td clang/include/clan

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert added a comment. Feel free to suggest better wording, I'm not a native speaker. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62470/new/ https://reviews.llvm.org/D62470 ___ cfe-commits mailing list cfe-c

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

aaronpuchert created this revision. aaronpuchert added reviewers: rsmith, aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is not a change in the rules, it's meant as a clarification about warnings. Since the recovery from warnings is a no-op, the fix-it h

[PATCH] D62376: [ASTImporter] Mark erroneous nodes in shared st

a_sidorin added a comment. Hi Gabor! I haven't find the import sequence examples we try to fix these ways in any of the three patches these change consists of. Could you please provide some (or point if I missed them)? Comment at: clang/include/clang/AST/ASTImporterSharedStat

[PATCH] D62375: [ASTImporter] Mark erroneous nodes in from ctx

a_sidorin added a comment. Hi Gabor, Could you please provide any test for the import itself? Comment at: clang/lib/AST/ASTImporter.cpp:8668 + +bool ASTImporter::ImportPathTy::hasCycleAtBack() { + return Aux[Nodes.back()] > 1; const? Repository: rG LLVM Gi

[PATCH] D62373: [ASTImporter] Store import errors for Decls

a_sidorin added a comment. Hi Gabor, The idea looks fine to me, but I have some questions inline. Comment at: clang/lib/AST/ASTImporter.cpp:5109 } else { // ODR violation. // FIXME HandleNameConflict + return make_error(ImportError::NameConflict); -

[PATCH] D62440: [analyzer] NFC: Change evalCall() to provide a CallEvent.

a_sidorin accepted this revision. a_sidorin added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:372 CheckerContext &C) const { - const Func

[PATCH] D62329: [ASTImporter] Structural eq: handle DependentScopeDeclRefExpr

a_sidorin added a comment. Hello Gabor, I have a few questions inline. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:124 + case DeclarationName::CXXConversionFunctionName: +return true; + Should we check the equivalence of getCXXNameType() in such

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

a_sidorin accepted this revision. a_sidorin added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4259 static const RecordDecl * getRecordDeclOfFriend(FriendDecl *FD) { QualType Ty = FD->getFriendType()->ge

[clang-tools-extra] r361735 - DeleteNullPointerCheck now deletes until the end brace of the condition.

Author: madsravn Date: Sun May 26 10:00:38 2019 New Revision: 361735 URL: http://llvm.org/viewvc/llvm-project?rev=361735&view=rev Log: DeleteNullPointerCheck now deletes until the end brace of the condition. Patch by Jonathan Camilleri Differential Revision https://reviews.llvm.org/D61861 Modif

[PATCH] D62131: [ASTImporter] Remove NonEquivalentDecls from ASTImporter

a_sidorin added a comment. Hi Gabor, Could you provide an example of an import sequence leading to this behavior? It's hard for me to imagine such a situation. Comment at: clang/test/ASTMerge/struct/test.c:37 // CHECK: struct2.c:53:37: note: field 'f' has type 'float' here -/

[PATCH] D62363: [X86] Enable intrinsics that convert float and bf16 data to each other

RKSimon added inline comments. Comment at: lib/Headers/avx512bf16intrin.h:52 +/// +/// \headerfile +/// \headerfile Comment at: lib/Headers/avx512bf16intrin.h:54 +/// +/// This intrinsic is lowered to LLVM IR. +/// Please can

[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files

JonasToth added a comment. Could you please run this check over LLVM and give a short report of your finding? I would imagine that there is a lot of duplication, given the include-heavy nature of big c++ code bases. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNe

r361710 - [Driver][RISCV] Simplify. NFC

Author: maskray Date: Sun May 26 00:43:45 2019 New Revision: 361710 URL: http://llvm.org/viewvc/llvm-project?rev=361710&view=rev Log: [Driver][RISCV] Simplify. NFC Modified: cfe/trunk/lib/Driver/ToolChains/Arch/RISCV.cpp Modified: cfe/trunk/lib/Driver/ToolChains/Arch/RISCV.cpp URL: http://l