a_sidorin accepted this revision.
a_sidorin added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:4259
static const RecordDecl * getRecordDeclOfFriend(FriendDecl *FD) {
QualType Ty = FD->getFriendType()->getType();
+ if (auto *Inner = dyn_cast<TypedefType>(Ty.getTypePtr())) {
----------------
martong wrote:
> a_sidorin wrote:
> > Will getCanonicalType() do the job?
> That's a good catch! Thank you for pointing out.
Can we replace the whole function with:
```
QualType Ty = FD->getFriendType()->getType().getCanonicalType();
return cast<RecordType>(Ty)->getDecl();
```
?
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:4249
static const RecordDecl * getRecordDeclOfFriend(FriendDecl *FD) {
QualType Ty = FD->getFriendType()->getType();
----------------
Redundant space after '*'.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62064/new/
https://reviews.llvm.org/D62064
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
