[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek created this revision. phosek added a reviewer: chandlerc. Herald added subscribers: cfe-commits, jdoerfert, kbarton, eraman, javed.absar, mgorny, nemanjai. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Not every pass has been ported to new PM which is breaking

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek created this revision. phosek added a reviewer: chandlerc. Herald added a project: clang. Herald added a subscriber: cfe-commits. This matches the behavior of the old pass manager. There are some targets that don't have target machine at all (e.g. le32, spir) which whose tests would never r

[PATCH] D58368: [analyzer] MIGChecker: Implement bug reporter visitors.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. This adds two visitors to the checker: - `trackExpressionValue()` in

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. As i mentioned in D58067#1393674

[PATCH] D58366: [analyzer] MIGChecker: Make use of the server routine annotation.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. The attribute that's added in D58365

[PATCH] D58365: [attributes] Add a MIG server routine attribute.

NoQ created this revision. NoQ added reviewers: aaron.ballman, dcoughlin, george.karpenkov. Herald added a project: clang. Herald added a subscriber: cfe-commits. Continuing the trend started in D54912 , i'd like to stuff one more XNU/Mach/Darwin-specific attribut

[PATCH] D55250: [clangd] Enhance macro hover to see full definition

malaperle added a comment. Ping? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55250/new/ https://reviews.llvm.org/D55250 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57540: [C++17] Don't crash while diagnosing different access specifier of a deduction guide.

Rakete abandoned this revision. Rakete added a comment. Herald added a subscriber: jdoerfert. This revision has been superseded :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57540/new/ https://reviews.llvm.org/D57540

[PATCH] D58065: [analyzer] Document the frontend library

george.karpenkov added a comment. High-level feedback: mixing of abstraction levels is wrong for the "bundled" documentation. This might also work better as a blogpost, if you want to jump from topic to topic. Comment at: docs/analyzer/developer-docs/FrontendLibrary.rst:11-13

r354296 - [clang][test] Fix FileManagerTest.getFileDontOpenRealPath for Windows

Author: jkorous Date: Mon Feb 18 15:12:29 2019 New Revision: 354296 URL: http://llvm.org/viewvc/llvm-project?rev=354296&view=rev Log: [clang][test] Fix FileManagerTest.getFileDontOpenRealPath for Windows Modified: cfe/trunk/unittests/Basic/FileManagerTest.cpp Modified: cfe/trunk/unittests/Ba

r354291 - Reland "[clang][FileManager] fillRealPathName even if we aren't opening the file"

Author: jkorous Date: Mon Feb 18 14:33:40 2019 New Revision: 354291 URL: http://llvm.org/viewvc/llvm-project?rev=354291&view=rev Log: Reland "[clang][FileManager] fillRealPathName even if we aren't opening the file" This reverts commit e2bb3121fd4ab5b01f9ec1d2e3e9877db9c6a54c. + fixed test for W

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Hi Nico, I didn't think it necessary as the change doesn't introduce any interaction with filesystem - it's just copying a string. Do you mean it causes a performance regression? Thanks. Jan > On Feb 15, 2019, at 6:15 AM, Nico Weber wrote: > > Did you do any performance testing to check if

Re: r354075 - [clang][FileManager] fillRealPathName even if we aren't opening the file

Hi all, Sorry, my bad, I was out on Friday. Will re-land patch with fixed test shortly. Jan > On Feb 15, 2019, at 12:47 PM, Reid Kleckner wrote: > > Reverted: > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/4351 >

[PATCH] D58291: [clangd] Include textual diagnostic ID as Diagnostic.code.

jkorous requested changes to this revision. jkorous added a comment. This revision now requires changes to proceed. Hi Sam, this looks good! I found just one small detail. Comment at: clangd/Diagnostics.cpp:281 +if (auto* Name = getDiagnosticCode(D.ID)) + Main.code =

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

jkorous added a comment. Hi Eric, I have just couple details. Comment at: clangd/IncludeFixer.cpp:188 +// first character after the unresolved name in \p Code. For the example below, +// this returns "::X::Y" that is qualfied by unresolved name "clangd": +// clang::clangd::

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: lib/Sema/SemaCast.cpp:2224 + } else if (IsLValueCast) { Kind = CK_LValueBitCast; } else if (DestType->isObjCObjectPointerType()) { ebevhan wrote: > This might not be

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler updated this revision to Diff 187260. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/FormatToken.h

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! The layering is *much* clearer now. I can still suggest a couple of tweaks, but they're pretty much cosmetic. Comment at: clangd/IncludeFixer.cpp:190 +// cl

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau marked an inline comment as done. pgousseau added inline comments. Comment at: include/clang/Basic/Sanitizers.h:43 + // Low bits of mask value. + uint64_t maskLo; + // High bits of mask value. riccibruno wrote: > Why not use a fixed size array of `ui

[PATCH] D58293: [clang][Index] Enable indexing of Template Type Parameters behind a flag

ilya-biryukov added inline comments. Comment at: lib/Index/IndexingContext.cpp:51 + bool IndexingContext::handleDecl(const Decl *D, SymbolRoleSet Roles, Do we call `handleDecl` for template parameters now too?

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added inline comments. Comment at: include/clang/Basic/Sanitizers.h:43 + // Low bits of mask value. + uint64_t maskLo; + // High bits of mask value. Why not use a fixed size array of `uint64_t`s, and then compute the index without any branch with `

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno added a comment. In D57914#1401367 , @pgousseau wrote: > Updated patch to not use APInt for representing the mask as it feels like a > hammer solution. Ah! I was going to say exactly this. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added a subscriber: arsenm. Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6996 + "|%diff{casting $ to type $|casting between types}0,1}2" + " changes address space of nested pointer">; def err_typecheck_incompatible_ownership

[PATCH] D58294: [clangd] Enable indexing of template type parameters

ilya-biryukov added a comment. It feels that storing template parameters in the index is a waste, one can only access them through the scope they are introduced in (there are out-of-line definitions of a function, but I think we treat every redeclaration of template headers separately). Can we

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau updated this revision to Diff 187258. pgousseau edited the summary of this revision. pgousseau added a comment. Updated patch to not use APInt for representing the mask as it feels like a hammer solution. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://review

[PATCH] D58341: [clangd] Index UsingDecls

ilya-biryukov added a comment. In D58341#1401295 , @hokein wrote: > std::strcmp is a fair case here. Sema seems not returning using-decls as part > of code completion results, it this an intended behavior? Yeah, I think it is. There's an explicit code p

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: lib/CodeGen/CGLoopInfo.cpp:107 + FollowupLoopProperties.push_back( + MDNode::get(Ctx, MDString::get(Ctx, "llvm.loop.unroll.disable"))); + Anastasia wrote: > Will this

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

MyDeveloperDay added a comment. @djasper and @klimek you both look relatively inactive in the last couple of weeks/month, is there anyone else who acts as a gate keeper for clang-format or can anyone add a LGTM? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28462/new/ https://reviews.

[PATCH] D58344: Enablement for AMD znver2 architecture - skeleton

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58344/new/ https://reviews.llvm.org/D58344 ___ cf

[PATCH] D57896: Variable names rule

michaelplatings marked an inline comment as done. michaelplatings added inline comments. Comment at: llvm/docs/CodingStandards.rst:1195 + be camel case, and start with a lower case letter (e.g. ``leader`` or + ``boats``). It is also acceptable to use ``UpperCamelCase`` for cons

[PATCH] D57896: Variable names rule

michaelplatings updated this revision to Diff 187252. michaelplatings added a comment. Update .clang-tidy files to use aNy_CasE until camelBackOrCase is available. Add more guidance around acronyms. Add more guidance around consistency with existing CamelCase variable names. Change other code exam

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: test/SemaOpenCL/address-spaces.cl:89 + __local int * __global * __private * lll; + lll = gg; // expected-warning {{incompatible pointer types assigning to '__local int *__global **' from '__gl

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan marked 5 inline comments as done. ebevhan added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6996 + "|%diff{casting $ to type $|casting between types}0,1}2" + " changes address space of nested pointer">; def err_typecheck_incompatible_ownersh

[PATCH] D58341: [clangd] Index UsingDecls

hokein added a comment. In D58341#1401212 , @ilya-biryukov wrote: > For context: @hokein mentioned problems in the clangd's code completion if we > would index these symbols. > This patch in itself does not hurt much, users of the indexing API can > de

[PATCH] D58278: Prepare ground for re-lexing modular headers.

usaxena95 added a comment. +cc myself Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58278/new/ https://reviews.llvm.org/D58278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

sammccall added inline comments. Comment at: clangd/index/CanonicalIncludes.cpp:123 static const std::vector> SystemHeaderMap = { hokein wrote: > ioeric wrote: > > Can we remove the suffix header mapping now? Is it for the `std::chrono::` > > symbols

[PATCH] D57978: [CodeGen] Generate follow-up metadata for loops with more than one transformation.

Anastasia resigned from this revision. Anastasia added a comment. This seems like an interesting change. So far in OpenCL we have actively used only unroll. I will let others to assess in more details. Comment at: lib/CodeGen/CGLoopInfo.cpp:107 + FollowupLoopProperties.push_b

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

ebevhan added inline comments. Comment at: lib/Sema/SemaCast.cpp:2224 + } else if (IsLValueCast) { Kind = CK_LValueBitCast; } else if (DestType->isObjCObjectPointerType()) { This might not be applicable to this patch, but just something I noticed. So `r

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein marked an inline comment as done. hokein added a comment. In D58345#1401040 , @ioeric wrote: > Looks great! Thanks for doing this. > > Could you also check in the tool that is used to generate the mapping? We > need a way to update the mapping when

[PATCH] D58341: [clangd] Index UsingDecls

ilya-biryukov added a comment. For context: @hokein mentioned problems in the clangd's code completion if we would index these symbols. This patch in itself does not hurt much, users of the indexing API can decide how to deal with `UsingDecl` on their own, clangd is just one of the clients. >

[PATCH] D58277: [OpenCL] Change type of block pointer for OpenCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! This totally makes sense! I think we inherited that from ObjC but never adapted fully. This change has low risk of breaking backwards compatibility but might need some mino

[PATCH] D58275: [clangd] Support utf-8 offsets (rather than utf-16) as a protocol extension

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I think we need to update the comment in the SymbolLocation::Column. Comment at: clangd/tool/ClangdMain.cpp:9 +#include "/usr/local/google/home/sammccall/src/llvm/tools/c

[PATCH] D58236: Make address space conversions a bit stricter.

Anastasia added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6996 + "|%diff{casting $ to type $|casting between types}0,1}2" + " changes address space of nested pointer">; def err_typecheck_incompatible_ownership : Error< I am wonder

[PATCH] D58341: [clangd] Index UsingDecls

hokein added a comment. I wonder how does merge work with Sema results? See the case below, IIUC our indexer has one symbol for this using decl, but the code completion result from Sema contains two symbols. The symbol ids of these 3 symbols are different, so we will end up with 3 completion r

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits, @kthomsen, it appears that current patchset has issues when handling && on me. I have it applied over llvm 8.0.0 rc2, and the following code returns 0 to me with -O2 and below: #include #define FEQUAL(x,y) (((x) - (y)) < 0.01) // could put fabs if

[PATCH] D53754: [Analyzer] Skip symbolic regions based on conjured symbols in comparison of the containers of iterators

baloghadamsoftware added a comment. Herald added a subscriber: jdoerfert. In D53754#1315247 , @NoQ wrote: > What makes you think that conjured symbols are special? > > Doesn't the same problem appear in the following example?: > > void foo(std::vector &v

[PATCH] D58190: [clangd] Add tests for template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rL354272: [clangd] Add tests for template specializations (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE L

[clang-tools-extra] r354272 - [clangd] Add tests for template specializations

Author: kadircet Date: Mon Feb 18 06:23:19 2019 New Revision: 354272 URL: http://llvm.org/viewvc/llvm-project?rev=354272&view=rev Log: [clangd] Add tests for template specializations Subscribers: ilya-biryukov, ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differential Revision:

[PATCH] D58190: [clangd] Add tests for template specializations

kadircet updated this revision to Diff 187237. kadircet marked an inline comment as done. kadircet added a comment. - Fix typo and make comments start with 2 slashes Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58190/new/ https://reviews.llvm.org/D

[PATCH] D55007: [Analyzer] Constraint Manager - Calculate Effective Range for Differences

baloghadamsoftware added a comment. In D55007#1322335 , @NoQ wrote: > I just generally wish for a function that would return the most specific > known range for the given arbitrary symbol. This is something we can put, for > example, into visitor path no

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 187236. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: lib/Index/IndexDecl.cpp lib/Index/USRGeneration.cpp test/Index/usrs.

[PATCH] D58341: [clangd] Index UsingDecls

ilya-biryukov added a comment. Could we also add a test for code completion to make sure we return the new decls there? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, but we need to make sure the variable is used in configs without assertions, otherwise we'll break buildbots. Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

ilya-biryukov added inline comments. Comment at: lib/Index/IndexDecl.cpp:586 +IndexCtx.handleDecl(D); IndexCtx.indexNestedNameSpecifierLoc(D->getQualifierLoc(), Parent, NIT: maybe put it at the very first line of the function, before the `DC` and `Par

[PATCH] D58190: [clangd] Add tests for template specializations

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM with a typo-nit :-) Comment at: unittests/clangd/XRefsTests.cpp:378 + + R"cpp(// partial tmeplate specialization +template s

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan marked 6 inline comments as done. ebevhan added inline comments. Comment at: lib/Sema/SemaCast.cpp:2295 + // FIXME: C++ might want to emit different errors here. if (Self.getLangOpts().OpenCL) { +const Type *DestPtr, *SrcPtr; I'd also like to peti

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan updated this revision to Diff 187230. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/ https://reviews.llvm.org/D58236 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCast.cpp lib/Sema/SemaExpr.cpp test/CodeGenOpenCL/numbered-address-space.cl test

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

Anastasia created this revision. Anastasia added reviewers: rjmccall, ebevhan. Herald added a subscriber: jdoerfert. This patch adds a new diagnostic for mismatching address spaces to be used for C++ casts (TODO: only enabled in C style cast for now, the rest will follow!). This change extends C

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354268: [clangd] Cache include fixes for diagnostics caused by the same unresolved name… (authored by ioeric, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposit

[clang-tools-extra] r354268 - [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

Author: ioeric Date: Mon Feb 18 05:12:10 2019 New Revision: 354268 URL: http://llvm.org/viewvc/llvm-project?rev=354268&view=rev Log: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type. Summary: Multiple diagnostics can be caused by the same unresol

[PATCH] D57910: [ASTImporter] Find previous friend function template

This revision was automatically updated to reflect the committed changes. Closed by commit rC354267: [ASTImporter] Find previous friend function template (authored by martong, committed by ). Changed prior to commit: https://reviews.llvm.org/D57910?vs=187212&id=187228#toc Repository: rC Clan

r354267 - [ASTImporter] Find previous friend function template

Author: martong Date: Mon Feb 18 05:09:27 2019 New Revision: 354267 URL: http://llvm.org/viewvc/llvm-project?rev=354267&view=rev Log: [ASTImporter] Find previous friend function template Reviewers: a_sidorin, shafik, a.sidorin Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits Tag

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

ioeric updated this revision to Diff 187226. ioeric marked 2 inline comments as done. ioeric added a comment. - pulled cached index queries into functions Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58239/new/ https://reviews.llvm.org/D58239 File

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

ioeric added a comment. Looks great! Thanks for doing this. Could you also check in the tool that is used to generate the mapping? We need a way to update the mapping when cppreference is updated. Comment at: clangd/index/CanonicalIncludes.cpp:123 static const std::vecto

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein updated this revision to Diff 187225. hokein added a comment. Fix style. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58345/new/ https://reviews.llvm.org/D58345 Files: clangd/StdSymbolMap.imp clangd/index/CanonicalIncludes.cpp clangd/

[PATCH] D58345: [clangd] Using symbol name to map includes for STL symbols.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a reviewer: jfb. Herald added subscribers: jdoerfert, jfb, kadircet, arphaman, mgrang, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Using suffix path mapping relies on the STL implementations

[clang-tools-extra] r354266 - [clang-tidy] Fix links in docs.

Author: alexfh Date: Mon Feb 18 04:50:35 2019 New Revision: 354266 URL: http://llvm.org/viewvc/llvm-project?rev=354266&view=rev Log: [clang-tidy] Fix links in docs. Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst Modified: clang-tools-extra/trunk/docs/clang-tidy/index.rst URL: h

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

ioeric updated this revision to Diff 187222. ioeric marked 9 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58185/new/ https://reviews.llvm.org/D58185 Files: clangd/Include

[PATCH] D23610: [ARM] Add pre-defined macros for ROPI and RWPI

This revision was automatically updated to reflect the committed changes. Closed by commit rL354265: [ARM] Add pre-defined macros for ROPI and RWPI (authored by olista01, committed by ). Changed prior to commit: https://reviews.llvm.org/D23610?vs=91990&id=187220#toc Repository: rL LLVM CHAN

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

ioeric added inline comments. Comment at: clangd/IncludeFixer.cpp:235 + std::string Spelling = (Code.substr(B, E - B) + "::").str(); + if (llvm::StringRef(SpecifiedNS).endswith(Spelling)) +SpecifiedScope = SpecifiedNS; sammccall wrot

[PATCH] D23610: [ARM] Add pre-defined macros for ROPI and RWPI

olista01 added a comment. Yes, the back-end work was all done years ago, I just also forgot about these while waiting for the ACLE to be published. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D23610/new/ https://reviews.llvm.org/D23610 ___

r354265 - [ARM] Add pre-defined macros for ROPI and RWPI

Author: olista01 Date: Mon Feb 18 04:39:47 2019 New Revision: 354265 URL: http://llvm.org/viewvc/llvm-project?rev=354265&view=rev Log: [ARM] Add pre-defined macros for ROPI and RWPI This adds ACLE-defined macros to test for code being compiled in the ROPI and RWPI position-independence modes. Di

[PATCH] D58344: Enablement for AMD znver2 architecture - skeleton

GGanesh created this revision. GGanesh added reviewers: RKSimon, craig.topper. GGanesh created this object with visibility "All Users". GGanesh added a project: clang. Herald added a subscriber: cfe-commits. This patch enables the following 1. AMD family 17h "znver2" tune flag (-march, -mcpu). 2.

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. SymbolSlab is much cleaner, nice! Comment at: clangd/IncludeFixer.cpp:122 - if (!Matched || Matched->IncludeHeaders.empty() || !Matched->Definition || - Matched

[PATCH] D58189: [clang][Index] Fix usage of IndexImplicitInstantiation

This revision was automatically updated to reflect the committed changes. Closed by commit rL354262: [clang][Index] Fix usage of IndexImplicitInstantiation (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

r354262 - [clang][Index] Fix usage of IndexImplicitInstantiation

Author: kadircet Date: Mon Feb 18 03:30:43 2019 New Revision: 354262 URL: http://llvm.org/viewvc/llvm-project?rev=354262&view=rev Log: [clang][Index] Fix usage of IndexImplicitInstantiation Summary: Indexing context was skipping explicit template instantiations as well. This patch makes sure it o

[PATCH] D58190: [clangd] Add tests for template specializations

kadircet updated this revision to Diff 187213. kadircet added a comment. - Add more testcases Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58190/new/ https://reviews.llvm.org/D58190 Files: unittests/clangd/XRefsTests.cpp Index: unittests/clang

[PATCH] D23610: [ARM] Add pre-defined macros for ROPI and RWPI

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. Sorry for the delay, this fell out of my radar and just saw the ping now. Given it's in ACLE and there are only mechanical (obvious) changes, LGTM. I'm assuming those two parameters are al

[PATCH] D57910: [ASTImporter] Find previous friend function template

martong updated this revision to Diff 187212. martong added a comment. Rebase to master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57910/new/ https://reviews.llvm.org/D57910 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittes

[PATCH] D57910: [ASTImporter] Find previous friend function template

martong updated this revision to Diff 187211. martong added a comment. - Add FIXME Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57910/new/ https://reviews.llvm.org/D57910 Files: lib/AST/ASTImporter.cpp unittests/AST/ASTImporterTest.cpp Index: unittests/AS

r354259 - [ASTImporter] Unify redecl chain tests as type parameterized tests

Author: martong Date: Mon Feb 18 03:09:56 2019 New Revision: 354259 URL: http://llvm.org/viewvc/llvm-project?rev=354259&view=rev Log: [ASTImporter] Unify redecl chain tests as type parameterized tests Summary: This patch unifies all those tests which check the correctness of the redecl chains. Pr

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL354259: [ASTImporter] Unify redecl chain tests as type parameterized tests (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLV

[PATCH] D23610: [ARM] Add pre-defined macros for ROPI and RWPI

olista01 added a comment. These macros have been in the published ACLE for a while now: https://developer.arm.com/products/software-development-tools/compilers/arm-compiler-5/docs/101028/latest/5-feature-test-macros#position-independent-code Repository: rL LLVM CHANGES SINCE LAST ACTION ht

[PATCH] D58341: [clangd] Index UsingDecls

kadircet updated this revision to Diff 187209. kadircet added a comment. - Update USR to include "UD" Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58341/new/ https://reviews.llvm.org/D58341 Files: unittests/clangd/SymbolCollectorTests.cpp unit

[PATCH] D57236: [ASTImporter] Unify redecl chain tests as type parameterized tests

martong updated this revision to Diff 187206. martong marked 2 inline comments as done. martong added a comment. Rebase to master Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57236/new/ https://reviews.llvm.org/D57236 Files: unittests/AST/ASTImporterTest.cpp

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 187208. kadircet marked 3 inline comments as done. kadircet added a comment. - Address comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/D58340 Files: lib/Index/IndexDecl.cpp lib

[PATCH] D58190: [clangd] Add tests for template specializations

ilya-biryukov added inline comments. Comment at: unittests/clangd/XRefsTests.cpp:376 +} + )cpp", }; While here, could wee add tests for a few more cases? They are all represented by different classes in a hierarchy in clang, so each could potenti

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

ioeric added inline comments. Comment at: clangd/IncludeFixer.h:85 + // name or incomplete type in one parse, especially when code is + // copy-and-pasted without #includes. As fixes are purely dependent on index + // requests and index results at this point, we can cache fixe

[PATCH] D58239: [clangd] Cache include fixes for diagnostics caused by the same unresolved name or incomplete type.

ioeric updated this revision to Diff 187205. ioeric marked 4 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58239/new/ https://reviews.llvm.org/D58239 Files: clangd/Include

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

ilya-biryukov added inline comments. Comment at: lib/Index/IndexDecl.cpp:588 D->getLexicalDeclContext()); +IndexCtx.handleDecl(D); for (const auto *I : D->shadows()) Any reason to add this to the middle of the fu

[PATCH] D58185: [clangd] Handle unresolved scope specifier when fixing includes.

sammccall added inline comments. Comment at: clangd/IncludeFixer.cpp:208 +SM.getBufferData(SM.getDecomposedLoc(Typo.getLoc()).first, &Invalid); +assert(!Invalid); // Extract the typed scope. This is not done lazily because `SS` can get No idea wh

[PATCH] D58341: [clangd] Index UsingDecls

kadircet created this revision. kadircet added a reviewer: hokein. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. D58340 enables indexing of USRs, this makes sure test in clangd

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet created this revision. kadircet added reviewers: ilya-biryukov, akyrtzi. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Add indexing of UsingDecl itself. Also enable generation of USRs for UsingDecls, using the qualified name of the decl. Repository: r

[PATCH] D57948: [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

hans removed a subscriber: hansw. hans added a comment. In D57948#1399683 , @riccibruno wrote: > Done, thanks! That was https://bugs.llvm.org/show_bug.cgi?id=40742 and it's now been merged. Repository: rC Clang CHANGES SINCE LAST ACTION https://re

Re: r354147 - Variable auto-init of blocks capturing self after init bugfix

Merged to release_80 in r354248. On Fri, Feb 15, 2019 at 6:25 PM JF Bastien via cfe-commits wrote: > > Author: jfb > Date: Fri Feb 15 09:26:29 2019 > New Revision: 354147 > > URL: http://llvm.org/viewvc/llvm-project?rev=354147&view=rev > Log: > Variable auto-init of blocks capturing self after in

Re: r354035 - [Sema] Fix a regression introduced in "[AST][Sema] Remove CallExpr::setNumArgs"

Merged to release_80 in r354247. On Thu, Feb 14, 2019 at 4:42 PM Bruno Ricci via cfe-commits wrote: > > Author: brunoricci > Date: Thu Feb 14 07:43:17 2019 > New Revision: 354035 > > URL: http://llvm.org/viewvc/llvm-project?rev=354035&view=rev > Log: > [Sema] Fix a regression introduced in "[AST]

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added a comment. In D57087#1400578 , @malcolm.parsons wrote: > Some Clang warnings use PP.getLastMacroWithSpelling() to determine the user's > macro automatically. This would be a neat trick, but mainly I think users would either be usin

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

whisperity added a comment. Yeah, it seems upstream has moved away due to @Szelethus' implementation of a much more manageable "checker dependency" system. You most likely will have to rebase your patch first, then check what you missed which got added to other merged, existing checkers. Repo