hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
I think we need to update the comment in the SymbolLocation::Column. ================ Comment at: clangd/tool/ClangdMain.cpp:9 +#include "/usr/local/google/home/sammccall/src/llvm/tools/clang/tools/extra/clangd/Protocol.h" #include "Features.inc" ---------------- the #include introduced by global code completion seems not get shortened. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58275/new/ https://reviews.llvm.org/D58275 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits