[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

leonardchan added a comment. I ended up adding a lot to this patch, so feel free to let me know if I should split this up if it's more difficult to review. Changes: - Remove default ctors for `APFixedPoint` and `FixedPointSemantics`. The main reason I had these was so in the `EvaluateAsFixedPo

[PATCH] D55868: [Fixed Point Arithmetic] Fixed Point Addition Constant Expression Evaluation

leonardchan updated this revision to Diff 181421. leonardchan marked 13 inline comments as done. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55868/new/ https://reviews.llvm.org/D55868 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/Expr.h

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. In D56554#1354885 , @ruiu wrote: > In D56554#1353572 , @krytarowski > wrote: > > > What do you think about this new logic: > > > > 1. specified `-z execstack` -> do not emit GNU STACK s

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert added a comment. Updated according to your comments. Comment at: lib/Sema/SemaDeclAttr.cpp:3481 + llvm::StringMap NameIdxMapping; + NameIdxMapping["__"] = -1; + aaron.ballman wrote: > This doesn't match the documentation -- I assume you switched fro

[PATCH] D55483: Introduce the callback attribute and emit !callback metadata

jdoerfert updated this revision to Diff 181420. jdoerfert marked 21 inline comments as done. jdoerfert added a comment. Style changes, clang-format, documentation improvements Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55483/new/ https://reviews.llvm.org/D5548

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ updated this revision to Diff 181419. NoQ marked an inline comment as done. NoQ added a comment. Prettify the unittest a bit, especially the `ASTMatcher` part of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56632/new/ https://reviews.llvm.org/D56632 Files: include/clang/Stat

[PATCH] D56632: [analyzer] Track region liveness only through base regions.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet, mgorny. This is a follow-up to D56042

[PATCH] D56631: [MSVC Compat] Fix typo correction for inclusion directives.

vsapsai created this revision. vsapsai added reviewers: christylee, compnerd. Herald added subscribers: dexonsmith, jkorous. In MSVC compatibility mode we were checking not the typo corrected filename but the original filename. https://reviews.llvm.org/D56631 Files: clang/lib/Lex/PPDirectives

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

thakis added a comment. Out of interest, what's the motivation for this? It seems to add way more code than it removes, so there must be some other advantage, but the patch description doesn't say. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55491/new/ https:

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from nits that aren't complete yet, LGTM. Comment at: include/clang/AST/TemplateArgumentVisitor.h:24 +/// A simple visitor class that helps create templat

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 marked 2 inline comments as done. jyu2 added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; jyu2 wrote: > efriedma wrote: > > j

Re: r350984 - NFC: Port loop to cxx_range_for

On Fri, Jan 11, 2019 at 7:46 PM Stephen Kelly via cfe-commits wrote: > > Author: steveire > Date: Fri Jan 11 16:42:59 2019 > New Revision: 350984 > > URL: http://llvm.org/viewvc/llvm-project?rev=350984&view=rev > Log: > NFC: Port loop to cxx_range_for Thanks for the cleanup! > > Modified: >

[PATCH] D56353: Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer' with'-mframe-pointer='

tabloid.adroit added a comment. gentle ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56353/new/ https://reviews.llvm.org/D56353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D55616: Emit ASM input in a constant context

void added a comment. > Apologies - the value seems to indeed overflow, but I'm still very confused > how this was affected by this change. What's different is that `setRequiresImmediate` is being set on the constraint where before it wasn't. If no range values are supplied (like in this patch)

[PATCH] D55616: Emit ASM input in a constant context

george.karpenkov added a comment. Apologies - the value seems to indeed overflow, but I'm still very confused how this was affected by this change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55616/new/ https://reviews.llvm.org/D55616 __

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 marked 3 inline comments as done. jyu2 added inline comments. Comment at: lib/Analysis/CFG.cpp:1474 + appendScopeBegin(JT.block, VD, G); + addSuccessor(B, JT.block); +} efriedma wrote: > Please don't copy-paste code. :-( changed

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 updated this revision to Diff 181403. jyu2 added a comment. Couple of change to respond Eli’s comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files: include/clang/AST/Expr.h include/clang/AST/ExprCXX.h include/clang/AST/Expr

[PATCH] D55616: Emit ASM input in a constant context

george.karpenkov added a comment. @void @efriedma I can't build XNU anymore after this commit, with an error message: osfmk/i386/genassym.c:298:2: error: value '18446743523953737728' out of range for constraint 'n' DECLAREULL("KERNEL_BASE", KERNEL_BASE); ^~

[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[ushort/ulong/uint64]

TomTan added a comment. We need full definition for __nop in intrin.h. Comment at: lib/Headers/intrin.h:569 +unsigned __int64 _byteswap_uint64 (unsigned __int64 val); +void __nop(); #endif efriedma wrote: > Isn't there already a declaration of __nop in intrin.

[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[ushort/ulong/uint64]

efriedma added inline comments. Comment at: lib/Headers/intrin.h:569 +unsigned __int64 _byteswap_uint64 (unsigned __int64 val); +void __nop(); #endif Isn't there already a declaration of __nop in intrin.h? (Line 100.) CHANGES SINCE LAST ACTION https://revie

r350984 - NFC: Port loop to cxx_range_for

Author: steveire Date: Fri Jan 11 16:42:59 2019 New Revision: 350984 URL: http://llvm.org/viewvc/llvm-project?rev=350984&view=rev Log: NFC: Port loop to cxx_range_for Modified: cfe/trunk/lib/AST/ASTDumper.cpp Modified: cfe/trunk/lib/AST/ASTDumper.cpp URL: http://llvm.org/viewvc/llvm-project

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire updated this revision to Diff 181395. steveire added a comment. Updates Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55491/new/ https://reviews.llvm.org/D55491 Files: include/clang/AST/TemplateArgumentVisitor.h include/clang/AST/TextNodeDumper.h

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

Eugene.Zelenko added a comment. I would suggest to rename //contribution// to //Contributing// (see LLVM documentation) and //integrations// to //Integrations//. Will be also good idea to fix D55523 script warnings. CHANGES SINCE LAST ACTION https://reviews

[PATCH] D56620: [COFF, ARM64] Declare intrinsics: __nop, _byteswap_[short/long/uint64]

mgrang updated this revision to Diff 181390. mgrang retitled this revision from "[COFF, ARM64] Include stdlib.h in arm64intr.h" to "[COFF, ARM64] Declare intrinsics: __nop, _byteswap_[short/long/uint64]". mgrang edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D56620: [COFF, ARM64] Include stdlib.h in arm64intr.h

mgrang added a comment. In D56620#1354979 , @efriedma wrote: > Have you verified this matches MSVC? (IIRC the only reason we include > stdlib.h on x86 is so we can define _mm_malloc.) I don't see MSVC intrin.h including stdlib.h. So I guess I will just

[PATCH] D56620: [COFF, ARM64] Include stdlib.h in arm64intr.h

efriedma added a comment. Have you verified this matches MSVC? (IIRC the only reason we include stdlib.h on x86 is so we can define _mm_malloc.) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56620/new/ https://reviews.llvm.org/D56620

[PATCH] D56620: [COFF, ARM64] Include stdlib.h in arm64intr.h

mgrang created this revision. mgrang added reviewers: rnk, efriedma, ssijaric, TomTan, haripul. Herald added subscribers: kristof.beyls, javed.absar. We mimic x86 behavior which includes stdlib.h in x86intr.h. Repository: rC Clang https://reviews.llvm.org/D56620 Files: lib/Headers/arm64int

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Lekensteyn added a comment. Except one thing, it looks reasonable to me. I'll try to run some tests and report back tomorrow. (Not very familiar with Phabricator either. I still see some comments, hopefully the "Collapse" function does something useful here.) Comment at: tes

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

efriedma added inline comments. Comment at: lib/Analysis/CFG.cpp:1474 + appendScopeBegin(JT.block, VD, G); + addSuccessor(B, JT.block); +} Please don't copy-paste code. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if

r350982 - [analyzer] Support for OSObjects out parameters in RetainCountChecker

Author: george.karpenkov Date: Fri Jan 11 15:35:17 2019 New Revision: 350982 URL: http://llvm.org/viewvc/llvm-project?rev=350982&view=rev Log: [analyzer] Support for OSObjects out parameters in RetainCountChecker rdar://46357478 rdar://47121327 Differential Revision: https://reviews.llvm.org/D56

r350981 - [analyzer] Introduce a convenience method for getting a CallEvent from an arbitrary Stmt

Author: george.karpenkov Date: Fri Jan 11 15:35:04 2019 New Revision: 350981 URL: http://llvm.org/viewvc/llvm-project?rev=350981&view=rev Log: [analyzer] Introduce a convenience method for getting a CallEvent from an arbitrary Stmt Differential Revision: https://reviews.llvm.org/D56300 Modified

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

ruiu added a comment. In D56554#1353572 , @krytarowski wrote: > What do you think about this new logic: > > 1. specified `-z execstack` -> do not emit GNU STACK segment > 2. specified `-z noexecstack` -> emit GNU STACK segment > 3. no option specified -> d

[PATCH] D54945: This commit adds a chapter about clang-tidy integrations

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thanks a lot ! LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54945/new/ https://reviews.llvm.org/D54945 ___ cfe-commits mail

[PATCH] D55500: [Builtins] Implement __builtin_is_constant_evaluated for use in C++2a

rsmith added a comment. In D55500#1347493 , @EricWF wrote: > @rsmith, what sorts of additional tests are needed? Let's see... - test that we use the constant initializer for suitably-constant-initialized locals even if we can't constant-fold the refere

[PATCH] D56555: Add Attribute to define nonlazy objc classes

joedaniels29 updated this revision to Diff 181371. joedaniels29 added a comment. Tried to fix Aaron Ballman's feedback. Thanks Aaron! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56555/new/ https://reviews.llvm.org/D56555 Files: clang/include/clang/Basic/Attr

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1350179 , @ruiu wrote: > To be honest, I don't think I would lgtm a patch that changes lld's default > behavior depending on host/target only for NetBSD, and it seems like a > NetBSD's issue rather than an lld's iss

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 marked an inline comment as done. jyu2 added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; efriedma wrote: > jyu2 wrote: > > e

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. Actually probably Linux MIPS used it and some proprietary OSes.. but we skip them for now. Only FreeBSD sets OSABI in lld and uses an emulation name detection hack. Once we will get merged TripleTarget detection we can switch it to use proper Triple check. CHANGES

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm marked 4 inline comments as done. dankm added a comment. In D49466#1354468 , @Lekensteyn wrote: > Could you add more tests to check the error message for bad options (missing > `=`): > > -fdebug-prefix-map=bad > -fmacro-prefix-map=bad > -ffile

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm updated this revision to Diff 181363. dankm added a comment. renamed err_drv_invalid_argument_to_prefix_map to err_drv_invalid_argument_to_option added more frontend tests for macro-prefix-map and file-prefix-map. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

joerg added a comment. Right, I'm not aware of anyone but FreeBSD really using the OSABI field. For FreeBSD it was a long standing hack around limitations in the ELF kernel loader. I'm not even sure if FreeBSD use(d) to set the OSABI field for the intermediate object files. CHANGES SINCE LAST

[PATCH] D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

This revision was automatically updated to reflect the committed changes. Closed by commit rC350970: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO (authored by steven_wu, committed by ). Changed prior to commit: https://reviews.llvm.org/D56608?vs=181325&id=181361#toc Rep

r350970 - [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

Author: steven_wu Date: Fri Jan 11 13:16:04 2019 New Revision: 350970 URL: http://llvm.org/viewvc/llvm-project?rev=350970&view=rev Log: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO Summary: After r327851, Driver::GetTemporaryPath will create the file rather than just creat

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added inline comments. Comment at: ELF/Driver.cpp:375 +switch (Config->EMachine) { + case EM_386: +Config->SearchPaths.push_back("=/usr/lib/i386"); As we have TargetTriple now, I would use it here instead of `Config->EMachine`, it wi

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. In D56215#1354603 , @krytarowski wrote: > @mgorny could you check if we can get crossbuilding functional for: > > - to !NetBSD from NetBSD > - from !NetBSD to NetBSD. > - from NetBSD/amd64 to NetBSD/aarch64 > > I wonder wheth

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

nickdesaulniers added inline comments. Comment at: lib/Parse/ParseStmtAsm.cpp:830-858 + if (AteExtraColon || Tok.is(tok::colon)) { +if (AteExtraColon) + AteExtraColon = false; +else + ConsumeToken(); + +if (!AteExtraColon && Tok.isNot(tok::identifier)) { --

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

mgorny updated this revision to Diff 181356. mgorny added a comment. Herald added a subscriber: cryptoad. Updated the tests to account for most of the known sanitizer types. Notes/TODO: 1. I wasn't able to get a sane match for `-fsanitize=undefined`, so I just check if it enables anything. 2. `

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

efriedma added inline comments. Comment at: lib/Sema/SemaStmtAsm.cpp:470 +if (NS->isGCCAsmGoto() && +Exprs[ConstraintIdx]->getStmtClass() == Stmt::AddrLabelExprClass) + break; jyu2 wrote: > efriedma wrote: > > This looks suspicious; an AddrLabelE

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 marked 7 inline comments as done. jyu2 added inline comments. Comment at: lib/CodeGen/CGStmt.cpp:2182 +} + } + nickdesaulniers wrote: > If this new block was moved closer to the new one on L2227, I assume they > could be combined and possibly `IsGCCAsm

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

jyu2 updated this revision to Diff 181342. jyu2 added a comment. 1> I add code for CFG.cpp and a test for that, as efriedman request. 2> changes are respond the comments I received CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56571/new/ https://reviews.llvm.org/D56571 Files:

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > >

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); ABataev wrote: > lildmh wrote: > > A

[PATCH] D56463: [SEH] Pass the frame pointer from SEH finally to finally functions

ssijaric updated this revision to Diff 181337. ssijaric added a comment. Address formatting comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56463/new/ https://reviews.llvm.org/D56463 Files: lib/CodeGen/CGException.cpp test/CodeGen/exceptions-seh-nest

[PATCH] D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56608/new/ https://reviews.llvm.org/D56608 ___ cfe-commit

[PATCH] D53541: [COFF, ARM64] Do not emit x86_seh_recoverfp intrinsic

mgrang updated this revision to Diff 181333. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53541/new/ https://reviews.llvm.org/D53541 Files: lib/CodeGen/CGException.cpp test/CodeGen/exceptions-seh.c Index: test/CodeGen/exceptions-seh.c ==

[PATCH] D55492: Implement Attr dumping in terms of visitors

This revision was automatically updated to reflect the committed changes. Closed by commit rC350958: Implement Attr dumping in terms of visitors (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55492?vs=181182&id=181334#toc Repository: rC Clang CHANG

r350958 - Implement Attr dumping in terms of visitors

Author: steveire Date: Fri Jan 11 11:16:01 2019 New Revision: 350958 URL: http://llvm.org/viewvc/llvm-project?rev=350958&view=rev Log: Implement Attr dumping in terms of visitors Remove now-vestigial dumpType and dumpBareDeclRef methods. The old tablegen generated code used to expect them to be p

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

ABataev added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); lildmh wrote: > ABataev wrote: > > lildmh wrote: > > > ABataev wrote: > > >

[PATCH] D55488: Add utility for dumping a label with child nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rC350957: [ASTDump] Add utility for dumping a label with child nodes (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55488?vs=180935&id=181331#toc Repository:

r350957 - [ASTDump] Add utility for dumping a label with child nodes

Author: steveire Date: Fri Jan 11 11:11:17 2019 New Revision: 350957 URL: http://llvm.org/viewvc/llvm-project?rev=350957&view=rev Log: [ASTDump] Add utility for dumping a label with child nodes Summary: Use it to add optional label nodes to Stmt dumps. This preserves behavior of InitExprList dum

[PATCH] D54071: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL350955: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py (authored by serge_sans_paille, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: ht

[PATCH] D56318: [HIP] Fix size_t for MSVC environment

yaxunl updated this revision to Diff 181326. yaxunl added a comment. Herald added a subscriber: jfb. Copy type information from AuxTarget. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56318/new/ https://reviews.llvm.org/D56318 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targ

[PATCH] D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

steven_wu updated this revision to Diff 181325. steven_wu added a comment. Fix the comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56608/new/ https://reviews.llvm.org/D56608 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp lib/Driver/ToolCh

r350955 - [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py

Author: serge_sans_paille Date: Fri Jan 11 11:04:48 2019 New Revision: 350955 URL: http://llvm.org/viewvc/llvm-project?rev=350955&view=rev Log: [Bug 39548][Clang] PGO bootstrap fails with python3: errors in perf-helper.py Current clang fail to bootstrap in PGO mode when only python3 is available,

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added a comment. @mgorny could you check if we can get crossbuilding functional for: - to !NetBSD from NetBSD - from !NetBSD to NetBSD. - from NetBSD/amd64 to NetBSD/aarch64 I wonder whether it can work if we will keep using 'ld' file name for a linker. Comment at

r350954 - [test] Update support for Exynos M4 (NFC)

Author: evandro Date: Fri Jan 11 10:54:41 2019 New Revision: 350954 URL: http://llvm.org/viewvc/llvm-project?rev=350954&view=rev Log: [test] Update support for Exynos M4 (NFC) Update test cases for Exynos M4. Modified: cfe/trunk/test/CodeGen/arm-target-features.c cfe/trunk/test/Driver/aa

[PATCH] D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

arphaman added inline comments. Comment at: include/clang/Driver/Driver.h:508 + /// GetTemporaryPath - Return the pathname of a temporary directory to use + /// as part of compilation; the directory will have the given prefix. Old function name in the comment

[PATCH] D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

steven_wu updated this revision to Diff 181324. steven_wu added a comment. I was planning to add a test but I am not sure how to check the file type of temporary files. I add a test to check for temp file names because I do create file and directory with different prefix. Repository: rC Cla

r350952 - [MergeFunc] Update clang test for r350939

Author: vedantk Date: Fri Jan 11 10:51:02 2019 New Revision: 350952 URL: http://llvm.org/viewvc/llvm-project?rev=350952&view=rev Log: [MergeFunc] Update clang test for r350939 In r350939, the MergeFunc pass learned to erase duplicate functions which are discardable if unused. Modified: cfe/t

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

krytarowski added a comment. @ruiu actually if we can get D56215 merged we will be able to tune it specifically for NetBSD (with `if (Config->TargetTriple.isOSNetBSD()) {`) and retain intact the current Linux-biased logic for everybody who deserves to use it.

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov added a comment. I've added a few sample actions, please take a look. The major thing that's missing from the design is how we can define an interface for actions to get the nodes they interested in from the AST without doing an AST traversal in each of the actions separately. I h

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 181321. ilya-biryukov added a comment. - Remove 'using namespace llvm' Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56267/new/ https://reviews.llvm.org/D56267 Files: clangd/CMakeLists.txt clangd/Clan

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added inline comments. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + krytarowski wrote: > arichardson wrote: > > arichardson wrote: > > > If I invoke an unp

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

This revision was automatically updated to reflect the committed changes. Closed by commit rL350949: [LTO] Add option to enable LTOUnit splitting, and disable unless needed (authored by tejohnson, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53891/n

r350949 - [LTO] Add option to enable LTOUnit splitting, and disable unless needed

Author: tejohnson Date: Fri Jan 11 10:32:07 2019 New Revision: 350949 URL: http://llvm.org/viewvc/llvm-project?rev=350949&view=rev Log: [LTO] Add option to enable LTOUnit splitting, and disable unless needed Summary: Adds a new -f[no]split-lto-unit flag that is disabled by default to control modu

Re: [PATCH] D56571: [RFC prototype] Implementation of asm-goto support in LLVM

On Thu, Jan 10, 2019 at 6:11 PM Yu, Jennifer wrote: > > Syntax for asm goto: > Syntax: > asm [volatile] goto ( AssemblerTemplate > : > : InputOperands > : Clobbers > : GotoLabels) > > Only input is allowed.

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. The most complicated of the sample actions, requires considerable work and thorough testing before it can be landed. Serves the purpose of illustrating how to write the two-stage actions. Repository: rCTE Clang Too

[PATCH] D53891: [LTO] Add option to enable LTOUnit splitting, and disable unless needed

tejohnson updated this revision to Diff 181317. tejohnson marked 4 inline comments as done. tejohnson added a comment. Address comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53891/new/ https://reviews.llvm.org/D53891 Files: include/clang/Basic/CodeGen

[PATCH] D56612: [clangd] A code action to remove 'using namespace'

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, jfb, arphaman, mgrang, jkorous, MaskRay, ioeric, mgorny. Only available in the source files to fit into the model of single-file actions. Doing the same in headers would require mor

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov added a comment. A deliberately simple syntactic transformation. Missing tests, but should work very reliably. To serve as an reference point for writing similar actions. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56611/new/ https:

[PATCH] D56463: [SEH] Pass the frame pointer from SEH finally to finally functions

mgrang added inline comments. Comment at: lib/CodeGen/CGException.cpp:1635 +else { + llvm::Value *LocalAddrFn = CGM.getIntrinsic(llvm::Intrinsic::localaddress); + FP = CGF.Builder.CreateCall(LocalAddrFn); 80 char limit. Repository: rC Clang CH

[PATCH] D56563: [clang-tidy] add options documentation to readability-identifier-naming checker

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/readability-identifier-naming.rst:34 + +When defined, the checker will ensure abstract class names conform to the +selected casing. MyDeveloperDay wrote: > Eugene.Zelenko wrote: > >

Re: r350768 - [ObjC] Allow the use of implemented unavailable methods from within

Thanks, we might have similar cases in our code base as well. We'll see if we can fix that too. On Fri, 11 Jan 2019 at 06:13, Nico Weber wrote: > Here's some user feedback on this new feature. > > It looks like the warning is only suppressed if `init` has a definition in > the @interface block.

[PATCH] D56611: [clangd] A code action to swap branches of an if statement

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56611 Files: clangd/CMakeLists.txt clangd/CodeActions.cpp clangd/re

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov added a comment. This is a somewhat simple action to illustrate the use of code action APIs. Still missing tests and trying to figure out what information we want to expose in order to avoid walking over ASTs in each of the actions, so this is not final. Should be a good reference

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 181312. ilya-biryukov added a comment. - Add some forgotten helpers Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clangd/CMakeLists.txt clangd/CodeAct

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov updated this revision to Diff 181311. ilya-biryukov added a comment. - Add the code to actually instantiate a code action Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56610/new/ https://reviews.llvm.org/D56610 Files: clangd/CMakeLi

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

krytarowski added a comment. Please check these options in regression test-suite. There are also some missing entries and please add them too. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56607/new/ https://reviews.llvm.org/D56607 ___

[PATCH] D56610: [clangd] A code action to qualify an unqualified name

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric, mgorny. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56610 Files: clangd/CMakeLists.txt clangd/refactor/actions/QualifyNam

[PATCH] D56267: [clangd] Interfaces for writing code actions

ilya-biryukov updated this revision to Diff 181309. ilya-biryukov added a comment. - Put more AST-centric information into ActionInputs - Restructure and refactor the code Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56267/new/ https://reviews.llvm

[PATCH] D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

dexonsmith added a comment. The code looks good. Can you add a test too? Might need to require “shell”. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56608/new/ https://reviews.llvm.org/D56608 ___ cfe-commits maili

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

krytarowski added inline comments. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + arichardson wrote: > arichardson wrote: > > If I invoke an unprefixed ld.lld on NetBSD

[PATCH] D56326: [OpenMP 5.0] Parsing/sema support for "omp declare mapper" directive

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/AST/DeclOpenMP.cpp:164 + if (NumClauses) { +Clauses = (OMPClause **)C.Allocate(sizeof(OMPClause *) * NumClauses); +setClauses(CL); ABataev wrote: > lildmh wrote: > > A

[PATCH] D56581: [ASTImporter] Set the described template if not set

shafik added a comment. Can you add a test? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56581/new/ https://reviews.llvm.org/D56581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

r350942 - [attributes] Extend os_returns_(not_?)_retained attributes to parameters

Author: george.karpenkov Date: Fri Jan 11 10:02:08 2019 New Revision: 350942 URL: http://llvm.org/viewvc/llvm-project?rev=350942&view=rev Log: [attributes] Extend os_returns_(not_?)_retained attributes to parameters When applied to out-parameters, the attributes specify the expected lifetime of

r350941 - Fix a pair of Wfallthrough warnings in ScanfFormatString.

Author: erichkeane Date: Fri Jan 11 10:01:40 2019 New Revision: 350941 URL: http://llvm.org/viewvc/llvm-project?rev=350941&view=rev Log: Fix a pair of Wfallthrough warnings in ScanfFormatString. Change-Id: Ia73a34fdd93fc974224583505f9e6432493cb0da Modified: cfe/trunk/lib/AST/ScanfFormatStrin

[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Thank you for adding the additional test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53699/new/ https://reviews.llvm.org/D53699 ___

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

Lekensteyn added a comment. Could you add more tests to check the error message for bad options (missing `=`): -fdebug-prefix-map=bad -fmacro-prefix-map=bad -ffile-prefix-map=bad FWIW, GCC emits two errors for `-ffile-prefix-map=bad`. Another edge case is `-ffile-prefix-map==foo/`, GCC c

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

arichardson requested changes to this revision. arichardson added inline comments. This revision now requires changes to proceed. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + -

[PATCH] D56608: [Darwin][Driver] Don't pass a file as object_path_lto during ThinLTO

steven_wu created this revision. steven_wu added reviewers: arphaman, dexonsmith. Herald added subscribers: jkorous, inglorion, mehdi_amini. After r327851, Driver::GetTemporaryPath will create the file rather than just create a potientially unqine filename. If clang driver pass the file as paramet

  1   2   >