[PATCH] D55662: [Sema][ObjC] Do not warn about repeated uses of weak variables when the variables are accessed in an unevaluated context.

rjmccall added a comment. Can we find a way to preserve the rewritten expression out of `DeduceAutoType` so that the initialization code just happens to never see a placeholder along this path? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55662/new/ https://re

r350506 - [X86] Update VBMI2 vshld/vshrd tests to use an immediate that doesn't require a modulo.

Author: ctopper Date: Sun Jan 6 22:01:58 2019 New Revision: 350506 URL: http://llvm.org/viewvc/llvm-project?rev=350506&view=rev Log: [X86] Update VBMI2 vshld/vshrd tests to use an immediate that doesn't require a modulo. Planning to replace these with funnel shift intrinsics which would mask ou

r350505 - DR674, PR38883, PR40238: Qualified friend lookup should look for a

Author: rsmith Date: Sun Jan 6 22:00:46 2019 New Revision: 350505 URL: http://llvm.org/viewvc/llvm-project?rev=350505&view=rev Log: DR674, PR38883, PR40238: Qualified friend lookup should look for a template specialization if there is no matching non-template function. This exposed a couple of r

[PATCH] D56271: [SemaCXX] Fix ICE for unexpanded parameter pack

modocache added a comment. Thank you for the review! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56271/new/ https://reviews.llvm.org/D56271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D56271: [SemaCXX] Fix ICE for unexpanded parameter pack

This revision was automatically updated to reflect the committed changes. Closed by commit rL350501: [SemaCXX] Fix ICE for unexpanded parameter pack (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.

r350501 - [SemaCXX] Fix ICE for unexpanded parameter pack

Author: modocache Date: Sun Jan 6 19:25:59 2019 New Revision: 350501 URL: http://llvm.org/viewvc/llvm-project?rev=350501&view=rev Log: [SemaCXX] Fix ICE for unexpanded parameter pack Summary: The documentation for RecursiveASTVisitor::TraverseDecl states that the Decl being traversed may be null

[PATCH] D56365: [X86] Use funnel shift intrinsics for the VBMI2 vshld/vshrd intrinsics.

craig.topper updated this revision to Diff 180429. craig.topper added a comment. Add select checks. Move masking for variable vpshld/vpshrd to the intrinsic header. So now we don't need different builtins for mask and maskz. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D52610: [Esan] Port cache frag to FreeBSD

krytarowski added a comment. Can you try to port this mutant thread-process in ESan to FreeBSD? I don't want to see changes in generic LLVM code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52610/new/ https://reviews.llvm.org/D52610

Re: r350340 - Validate -add-plugin arguments.

(Looks like the bot eventually cycled green: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/41779 ) On Fri, Jan 4, 2019 at 8:14 PM Nico Weber wrote: > Thanks for the note. 350451 will hopefully help. > > On Fri, Jan 4, 2019 at 2:18 PM Galina Kistanova via cfe

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber marked 4 inline comments as done. bernhardmgruber added inline comments. Comment at: test/clang-tidy/modernize-use-trailing-return.cpp:173 +auto l1 = [](int arg) {}; +auto l2 = [](int arg) -> double {}; JonasToth wrote: > you could figure out the

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

bernhardmgruber updated this revision to Diff 180419. bernhardmgruber added a comment. Big thank you to @JonasToth for providing some macro test cases. I played a bit with macros and settled on the following behavior: - if the closing parenthesis of the function is inside a macro, no FixIt will

[PATCH] D56368: [AST] Store the results in OverloadExpr in a trailing array

riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Use the newly available space in the bit-fields of `Stmt` to pack `OverloadExpr`, `UnresolvedLookupExpr` and `UnresolvedMemberExpr`. Additionally sto

[PATCH] D56367: [AST] Pack CXXDependentScopeMemberExpr

riccibruno created this revision. riccibruno added a reviewer: rjmccall. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Use the newly available space in the bit-fields of `Stmt`. Additionally store `FirstQualifierFoundInScope` as a trailing object since it is most of t

[PATCH] D56134: [AST] Store some data of CXXNewExpr as trailing objects

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/ExprCXX.h:1950 /// The allocated type-source information, as written in the source. TypeSourceInfo *AllocatedTypeInfo; rjmccall wrote: > If you ev

[PATCH] D56366: New warning call-to-virtual-from-ctor-dtor when calling a virtual function from a constructor or a destructor

ArnaudBienner created this revision. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56366 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaOverload.cpp test/Analysis/ctor.mm test/Analysis/dt

[PATCH] D56365: [X86] Use funnel shift intrinsics for the VBMI2 vshld/vshrd intrinsics.

RKSimon added inline comments. Comment at: test/CodeGen/avx512vlvbmi2-builtins.c:415 // CHECK-LABEL: @test_mm256_mask_shldv_epi64 - // CHECK: @llvm.x86.avx512.mask.vpshldv.q.256 + // CHECK: @llvm.fshl.v4i64(<4 x i64> %{{.*}}, <4 x i64> %{{.*}}, <4 x i64> %{{.*}}) return

[PATCH] D56365: [X86] Use funnel shift intrinsics for the VBMI2 vshld/vshrd intrinsics.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56365 Files: lib/CodeGen/CGBuiltin.cpp test/CodeGen/avx512vbmi2-builtins.c test/CodeGen/avx512vlvbmi2-builtins.c Inde

[PATCH] D37035: Implement __builtin_LINE() et. al. to support source location capture.

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:4108 +public: + enum IdentType { Function, File, Line, Column }; + `IdentType` -> `IdentKind` ? Comment at: include/clang/AST/Expr.h:4147 + SourceLocation getBeginLoc() co

Re: r350404 - Refactor the way we handle diagnosing unused expression results.

On Sun, Jan 6, 2019 at 10:58 AM Nico Weber wrote: > > On Sat, Jan 5, 2019 at 10:16 AM Aaron Ballman wrote: >> >> On Fri, Jan 4, 2019 at 8:41 PM Richard Smith wrote: >> > >> > On Fri, 4 Jan 2019 at 17:33, Nico Weber via cfe-commits >> > wrote: >> >> >> >> Nice, this is finding bugs: >> >> http

r350495 - Fix bug in test found by the diagnostic added in r350340.

Author: nico Date: Sun Jan 6 07:57:18 2019 New Revision: 350495 URL: http://llvm.org/viewvc/llvm-project?rev=350495&view=rev Log: Fix bug in test found by the diagnostic added in r350340. I meant to commit this change in 350341 but failed to do so (since it's in test/CodeGenCXX, not in test/Fron

[PATCH] D56303: [clang-tidy] Handle case/default statements when simplifying boolean expressions

aaron.ballman added inline comments. Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:386 - bool BoolValue = Bool->getValue(); + const bool BoolValue = Bool->getValue(); LegalizeAdulthood wrote: > JonasToth wrote: > > `const` on values is unc

[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

MyDeveloperDay added a comment. libprotobuf still builds cleanly with just the one expected warning..despite adding over 500 [[nodiscards]] F7800873: image.png I'll continue to look at other projects, but I'm happy at present that this gives us a good starti

[PATCH] D56050: [Sema] Diagnose array access preceding the array bounds even when the base type is incomplete.

riccibruno added a comment. Friendly ping ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56050/new/ https://reviews.llvm.org/D56050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D55405: [CMake] Use hidden visibility for static libc++ in Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL350491: [CMake] Use hidden visibility for static libc++ in Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55405?

r350491 - [CMake] Use hidden visibility for static libc++ in Fuchsia

Author: phosek Date: Sun Jan 6 00:23:56 2019 New Revision: 350491 URL: http://llvm.org/viewvc/llvm-project?rev=350491&view=rev Log: [CMake] Use hidden visibility for static libc++ in Fuchsia This is enables the use of libc++ in contexts such as device drivers. Differential Revision: https://rev