riccibruno marked an inline comment as done. riccibruno added inline comments.
================ Comment at: include/clang/AST/ExprCXX.h:1950 /// The allocated type-source information, as written in the source. TypeSourceInfo *AllocatedTypeInfo; ---------------- rjmccall wrote: > If you ever want a somewhat bigger refactoring project that might provide > major wins on C++ code, one idea I've had for awhile is to largely eliminate > `TypeSourceInfo` from the AST in favor of storing a `TypeLoc` in most places. > A TSI is basically a TL that stores the location data in a trailing array; > it was convenient as a way to retrofit type-location information into the AST > without massive changes, and it saves a pointer (at the cost of an extra > indirection) when the TSI can be shared between parent nodes. But I think > the TSI can rarely be shared between parent nodes (pretty much just template > instantiation of a non-dependent type), and the structure forces the location > data to be copied when the type changes (e.g. during template instantiation) > even if the location data would be the same. It also means we can't use a > preallocated zero buffer in `getTrivialTypeSourceInfo` with a null > `SourceLocation`, and instead we have to allocate and initialize an > appropriately-sized zero'ed trailing array. > > The win wouldn't be as large as it could be because `FunctionProtoTypeLoc` > includes `ParmVarDecl`s, which get cloned during template instantiation and > therefore would always require a new type-location buffer when e.g. > instantiating a function temploid. But it might still be quite significant. Thanks for the pointer; this type of hint is very useful. I will have to dig into this a bit before commenting on it, but I will definitely keep this in mind. If you have some time there are two last patches which deal with `CXXDependentScopeMemberExpr` and `OverloadExpr`, but I don't want to spam you (with arguably pretty boring patches). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56134/new/ https://reviews.llvm.org/D56134 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
