r346733 - [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

Author: tikuta Date: Mon Nov 12 20:14:09 2018 New Revision: 346733 URL: http://llvm.org/viewvc/llvm-project?rev=346733&view=rev Log: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag Summary: /Zc:dllexportInlines with /fallback may cause unexpected linker error. It is b

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

This revision was automatically updated to reflect the committed changes. Closed by commit rC346733: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag (authored by tikuta, committed by ). Changed prior to commit: https://reviews.llvm.org/D54426?vs=173810&id=173811#toc

[PATCH] D54426: [clang-cl] Do not allow using both /Zc:dllexportInlines- and /fallback flag

takuto.ikuta updated this revision to Diff 173810. takuto.ikuta marked an inline comment as done. takuto.ikuta added a comment. rebase Repository: rL LLVM https://reviews.llvm.org/D54426 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driver/ToolChains/Clang.cpp cla

[PATCH] D54463: [CMake] Support cross-compiling with Fuchsia toolchain build

phosek created this revision. phosek added reviewers: beanz, mcgrathr. Herald added subscribers: cfe-commits, mgorny. When second stage is being cross-compiled for a different platform we need to build enough of first stage runtimes to get a working compiler. Repository: rC Clang https://revi

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, so the point is to fix the current checker name problem, right? I guess let's land it then :) Code looks great. I'm thinking aloud in inline comments a little bit, but don't mind me. @rnkovacs

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/altivec-generic-overload.c:74 + convert1(gv1); + // CHECK: call void @_Z8convert1Dv16_a(<16 x i8> %{{[0-9]+}}) + convert1(gv2); Checking that the call is to the expected target in ter

[PATCH] D51714: CMake: Deprecate using llvm-config to detect llvm installation

This revision was automatically updated to reflect the committed changes. Closed by commit rC346732: CMake: Deprecate using llvm-config to detect llvm installation (authored by tstellar, committed by ). Changed prior to commit: https://reviews.llvm.org/D51714?vs=167413&id=173808#toc Repository

r346732 - CMake: Deprecate using llvm-config to detect llvm installation

Author: tstellar Date: Mon Nov 12 19:42:46 2018 New Revision: 346732 URL: http://llvm.org/viewvc/llvm-project?rev=346732&view=rev Log: CMake: Deprecate using llvm-config to detect llvm installation Summary: clang currently uses llvm-config to determine the installation paths for llvm's headers an

[PATCH] D32577: CMake: Replace open-coded find_package

This revision was automatically updated to reflect the committed changes. Closed by commit rL346731: CMake: Replace open-coded find_package (authored by tstellar, committed by ). Repository: rL LLVM https://reviews.llvm.org/D32577 Files: cfe/trunk/CMakeLists.txt Index: cfe/trunk/CMakeList

r346731 - CMake: Replace open-coded find_package

Author: tstellar Date: Mon Nov 12 19:16:45 2018 New Revision: 346731 URL: http://llvm.org/viewvc/llvm-project?rev=346731&view=rev Log: CMake: Replace open-coded find_package Reviewers: beanz, mgorny Reviewed By: mgorny Subscribers: cfe-commits, chapuni, llvm-commits Differential Revision: http

[PATCH] D54459: [analyzer] Dump reproducible identifiers for objects under construction.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, baloghadamsoftware. This continues the work that was started in https://reviews.llvm.org/D5

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

rsmith added a comment. Thank you, this is looking really good. Comment at: include/clang/Parse/Parser.h:2054 +case DeclSpecContext::DSC_template_param: +case DeclSpecContext::DSC_template_type_arg: +case DeclSpecContext::DSC_normal: Rakete wrot

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

george.karpenkov accepted this revision. george.karpenkov added inline comments. This revision is now accepted and ready to land. Comment at: lib/AST/DeclCXX.cpp:2249 +int64_t CXXCtorInitializer::getID(const ASTContext &Context) const { + Optional Out = Context.getAllocator().

[PATCH] D54457: [AST] Generate unique identifiers for CXXCtorInitializer objects.

NoQ created this revision. NoQ added reviewers: george.karpenkov, rsmith. Herald added a subscriber: cfe-commits. This follows https://reviews.llvm.org/D51822 and https://reviews.llvm.org/D52113 to add a cheap way of obtaining a unique and relatively stable* numeric identifier for `CXXCtorInitia

[PATCH] D54425: [AArch64] Add aarch64_vector_pcs function attribute to Clang

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1792 + let Spellings = [GNU<"aarch64_vector_pcs">, + CXX11<"clang", "aarch64_vector_pcs">, + Keyword<"__aarch64_vector_pcs">, Rather than using GNU a

[PATCH] D53982: Output "rule" information in SARIF

aaron.ballman added inline comments. Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:237-242 +#define GET_CHECKERS +#define CHECKER(FULLNAME, CLASS, CXXFILE, HELPTEXT, GROUPINDEX, HIDDEN) \ + .Case(FULLNAME, HELPTEXT) +#include "clang/StaticAnalyzer/Checkers/Che

[PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

aaron.ballman added a comment. In https://reviews.llvm.org/D54258#1295158, @richardmembarth wrote: > There are external tools (e.g. hipacc ) that > generate Clang AST. This AST uses `LangAS` annotations and emits incorrect > memory space specifiers for CUDA when pretty-

[PATCH] D54405: Record whether a AST Matcher constructs a Node

zturner added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfMa

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

aaron.ballman added inline comments. Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:57-58 +// One and only one of `IntLit` and `FloatLit` should be provided. +static double GetValue(const IntegerLiteral *IntLit, + const FloatingLiteral *FloatLit

[PATCH] D54372: [analyzer] MisusedMovedObject: NFC: Remove dead code after D18860

NoQ updated this revision to Diff 173779. NoQ added a comment. Bring back the early return for destructors. Cleaning up the state might be unnecessary, but calling a destructor on a moved object is still fine and should not cause a warning. Add a test because this wasn't caught by tests. http

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

Szelethus added a comment. Actually, no. The main problem here is that `InnerPointerChecker` doesn't only want to register `MallocBase`, it needs to modify the checker object. In any case, either `MallocChecker.cpp` needs the definition of `InnerPointerChecker`, or vice versa. Sure, I could sep

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfM

[PATCH] D54405: Record whether a AST Matcher constructs a Node

aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicA

[PATCH] D54402: Extract method to allow re-use

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D54402#1296273, @steveire wrote: > This is just a NFC change, which is normal to appear without tests. The > consensus on IRC is that this is fine.

[PATCH] D54405: Record whether a AST Matcher constructs a Node

zturner added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfMa

[PATCH] D54453: Remove myself as owner of clang-query.

aaron.ballman added a comment. Thank you for all of your hard work on clang-query! I'm happy to pick up the torch as I seem to do a fair amount of the reviews for the tool, but I'm also happy to let Manuel or Alex pick it up if they would prefer. Repository: rL LLVM https://reviews.llvm.or

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfM

[PATCH] D54399: Move ExprMutationAnalyzer to Tooling/Analysis (1/3)

dblaikie added a comment. Could you fix the modulemap (might amount to reverting the change Eric made in r342827? or maybe it's more involved than that) & validate that the modules build is working with this change (probably undo Eric's change, validate that you see the breakage that Eric was t

[PATCH] D54166: [AST] Store the string data in StringLiteral in a trailing array of chars

dblaikie added a comment. In https://reviews.llvm.org/D54166#1295730, @riccibruno wrote: > @dblaikie Thanks for looking at this patch ! > > I have a set of patches shrinking the other statements/expressions. > Can I add you to review some of these too ? Most of them consists of just > moving >

[PATCH] D54407: Record the matcher type when storing a binding

steveire added inline comments. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:154 +bool operator<(const NodeEntry &other) const { + return DynNode < other.DynNode && NodeKind < other.NodeKind; +} aaron.ballman wrote: > This doesn't prov

[PATCH] D54453: Remove myself as owner of clang-query.

pcc created this revision. pcc added reviewers: klimek, alexfh. Herald added a subscriber: llvm-commits. I haven't been involved with the project for years, so it's probably best for someone else to be the code owner. Repository: rL LLVM https://reviews.llvm.org/D54453 Files: clang-tools-e

[PATCH] D54407: Record the matcher type when storing a binding

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from a minor formatting nit, LGTM. Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:154 +bool operator<(const NodeEntry &Other) const { +

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

Szelethus added a comment. In https://reviews.llvm.org/D54438#1296239, @NoQ wrote: > Mm, i don't understand. I mean, what prevents you from cutting it off even > earlier and completely omitting that part of the patch? Somebody will get to > this later in order to see how exactly does the separa

[PATCH] D54402: Extract method to allow re-use

steveire added a comment. This is just a NFC change, which is normal to appear without tests. The consensus on IRC is that this is fine. Repository: rC Clang https://reviews.llvm.org/D54402 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D51531: [analyzer][UninitializedObjectChecker] Uninit regions are only reported once

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Mm, ok, i admit that i don't know what specific de-duplication do we want to have and what are the usability implications of it. If we want de-duplication for the same region reported in different s

[PATCH] D54407: Record the matcher type when storing a binding

steveire updated this revision to Diff 173774. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54407 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/ASTMatchersInternal.cpp lib/Tooling/RefactoringCallbacks.cpp unittests/ASTMatche

[PATCH] D54408: Add matchers available through casting to derived

aaron.ballman added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:645 +getNodeConstructorType(MatcherCtor targetCtor) { + auto const &ctors = RegistryData->nodeConstructors(); + Don't use `auto` here (and if you did. the `const` would go on t

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

NoQ added a comment. Mm, i don't understand. I mean, what prevents you from cutting it off even earlier and completely omitting that part of the patch? Somebody will get to this later in order to see how exactly does the separation needs to be performed. Repository: rC Clang https://review

[PATCH] D54407: Record the matcher type when storing a binding

aaron.ballman added a comment. In https://reviews.llvm.org/D54407#129, @sbenza wrote: > In https://reviews.llvm.org/D54407#1294934, @aaron.ballman wrote: > > > Adding @sbenza in case he has opinions on this approach. I think it's > > reasonable, but I also know that changes to the the AST ma

[PATCH] D54406: Add matchDynamic convenience functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D54406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D53949: [clang][CodeGen] Implicit Conversion Sanitizer: discover the world of CompoundAssign operators

rjmccall added a comment. Seems reasonable to me. Repository: rC Clang https://reviews.llvm.org/D53949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54405: Record whether a AST Matcher constructs a Node

aaron.ballman added a comment. Aside from the uses of auto and the lack of tests, this LGTM. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNode

[PATCH] D54404: Exclude matchers which can have multiple results

aaron.ballman added a reviewer: sbenza. aaron.ballman added a subscriber: sbenza. aaron.ballman added a comment. In https://reviews.llvm.org/D54404#1295426, @steveire wrote: > I acknowledge and share the future-proofing concern. > > We could possibly use something trait-based instead and put the

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

Burgos added a comment. Another ping :-). This looks like a very useful addition (and I need it myself so I'll end up applying this patchset manually) and I would like to find it merged. It doesn't look it brings any kind of negative value to the C API. Repository: rC Clang https://reviews.

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

NoQ added a reviewer: dcoughlin. NoQ added a subscriber: dcoughlin. NoQ added a comment. I think we should escalate this to cfe-dev first; this sounds pretty important. @dcoughlin should definitely say a word here, as the code owner. I agree that pictures and screenshots are very important to ke

[PATCH] D54403: Add new API for returning matching matchers

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor commenting nit. Comment at: include/clang/ASTMatchers/Dynamic/Registry.h:106 + /// Compute matchers which can be used within a matcher

[PATCH] D54402: Extract method to allow re-use

aaron.ballman added a comment. In https://reviews.llvm.org/D54402#1295420, @steveire wrote: > I think this commit is fine without tests. That's not something we do except under specific extenuating circumstances (NFC fixes or changes for which existing coverage suffices), per our developer po

[PATCH] D54408: Add matchers available through casting to derived

steveire updated this revision to Diff 173770. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54408 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/Dynamic/RegistryTest.cpp =

[PATCH] D54407: Record the matcher type when storing a binding

steveire updated this revision to Diff 173769. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54407 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/ASTMatchersInternal.cpp lib/Tooling/RefactoringCallbacks.cpp unittests/ASTMatche

[PATCH] D54406: Add matchDynamic convenience functions

steveire updated this revision to Diff 173768. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54406 Files: include/clang/ASTMatchers/ASTMatchFinder.h unittests/ASTMatchers/ASTMatchersNodeTest.cpp Index: unittests/ASTMatchers/ASTMatchersNodeTest.cpp

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire updated this revision to Diff 173767. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54405 Files: include/clang/ASTMatchers/ASTMatchersInternal.h lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp =

[PATCH] D54404: Exclude matchers which can have multiple results

steveire updated this revision to Diff 173766. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54404 Files: lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittests/ASTMatchers/Dynamic/RegistryTest.cpp

[PATCH] D54403: Add new API for returning matching matchers

steveire updated this revision to Diff 173765. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54403 Files: include/clang/ASTMatchers/Dynamic/Registry.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/Dynamic/RegistryTest.cpp Index: unittest

[PATCH] D53982: Output "rule" information in SARIF

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:237-242 +#define GET_CHECKERS +#define CHECKER(FULLNAME, CLASS, CXXFILE, HELPTEXT, GROUPINDEX, HIDDEN) \ + .Case(FULLNAME, HELPTEXT) +#include "clang/StaticAnalyzer/Checkers/Checker

[PATCH] D54402: Extract method to allow re-use

steveire updated this revision to Diff 173764. steveire added a comment. Update Repository: rC Clang https://reviews.llvm.org/D54402 Files: lib/ASTMatchers/Dynamic/Registry.cpp Index: lib/ASTMatchers/Dynamic/Registry.cpp ===

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

Szelethus added a comment. In https://reviews.llvm.org/D54438#1296155, @NoQ wrote: > Can we reduce this patch to simply introducing the dependency item in > `Checkers.td` and using it in, like, one place (eg., > `MallocChecker`/`CStringChecker` inter-op) and discuss the rest of the stuff > lat

Re: r346266 - Don't use std::next() on an input iterator; NFC.

On Mon, Nov 12, 2018 at 5:24 PM David Blaikie wrote: > > Thanks! Thank you for the review feedback, that was a good catch. I've changed to an assert in r346714. ~Aaron > > On Mon, Nov 12, 2018 at 2:14 PM Aaron Ballman wrote: >> >> On Mon, Nov 12, 2018 at 1:30 PM David Blaikie wrote: >> > >> >

r346714 - Convert a condition into an assertion per post-review feedback; NFC intended.

Author: aaronballman Date: Mon Nov 12 14:32:38 2018 New Revision: 346714 URL: http://llvm.org/viewvc/llvm-project?rev=346714&view=rev Log: Convert a condition into an assertion per post-review feedback; NFC intended. Modified: cfe/trunk/lib/StaticAnalyzer/Core/SarifDiagnostics.cpp Modified:

[PATCH] D54450: Get the correct range of tokens for preprocessor conditions

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie, echristo. Herald added subscribers: jsji, kbarton, nemanjai. While working on https://reviews.llvm.org/D54349, it was noted that the `SourceRange` returned from the preprocessor callbacks was bogus. It was expe

[PATCH] D52296: [Clang] - Add '-gsplit-dwarf[=split, =single]' version for '-gsplit-dwarf' option.

dblaikie added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:813-830 + if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) +if (StringRef(A->getValue()) == "single") + return Args.MakeArgString(Output.getFilename()); + Arg *FinalOutput = A

Re: r346266 - Don't use std::next() on an input iterator; NFC.

Thanks! On Mon, Nov 12, 2018 at 2:14 PM Aaron Ballman wrote: > On Mon, Nov 12, 2018 at 1:30 PM David Blaikie wrote: > > > > The previous code didn't have a conditional for Iter != End - was that a > bug? Should there be a test case for that bug? > > > > If that's not an actual change in behavio

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

NoQ added a comment. Hmm. All intentions in this patch are great and i love them! I think that the refactoring work in `MallocChecker` is a bit pre-mature; i don't have a clear picture of how the ideal `MallocChecker` should look like, and i'm not sure this patch moves us into the right direct

Re: r346266 - Don't use std::next() on an input iterator; NFC.

On Mon, Nov 12, 2018 at 1:30 PM David Blaikie wrote: > > The previous code didn't have a conditional for Iter != End - was that a bug? > Should there be a test case for that bug? > > If that's not an actual change in behavior, could it be an assert instead of > a condition? I think an assertion

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

ilya-biryukov added a comment. In https://reviews.llvm.org/D54310#1296080, @arphaman wrote: > Apologies for not seeing this earlier. No worries, thanks for the input! >> The logic to do this was based on resource dir as an approximation of >> where the compiler is installed. This broke the to

[PATCH] D53949: [clang][CodeGen] Implicit Conversion Sanitizer: discover the world of CompoundAssign operators

lebedev.ri added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D53949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

arphaman added a comment. Apologies for not seeing this earlier. I agree with George, this behavior doesn't seem right to me. > The logic to do this was based on resource dir as an approximation of > where the compiler is installed. This broke the tools that read > 'compile_commands.json' and d

r346709 - [Sema] Make sure we substitute an instantiation-dependent default template argument

Author: epilk Date: Mon Nov 12 13:31:06 2018 New Revision: 346709 URL: http://llvm.org/viewvc/llvm-project?rev=346709&view=rev Log: [Sema] Make sure we substitute an instantiation-dependent default template argument Fixes llvm.org/PR39623 Differential revision: https://reviews.llvm.org/D54414

[PATCH] D54414: [Sema] Make sure we substitute an instantiation-dependent default template parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rL346709: [Sema] Make sure we substitute an instantiation-dependent default template… (authored by epilk, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus updated this revision to Diff 173745. Szelethus edited the summary of this revision. Szelethus added a comment. Restored the discussed note. https://reviews.llvm.org/D54401 Files: include/clang/StaticAnalyzer/Core/CheckerRegistry.h include/clang/StaticAnalyzer/Frontend/FrontendAct

r346705 - Fix the 'fixit' for inline namespace replacement.

Author: erichkeane Date: Mon Nov 12 13:08:41 2018 New Revision: 346705 URL: http://llvm.org/viewvc/llvm-project?rev=346705&view=rev Log: Fix the 'fixit' for inline namespace replacement. I'd neglected to add to the fixit for r346677. Richard Smith mentioned this in a review-after-commit, so fixi

[PATCH] D54324: [AST] Store the value of CharacterLiteral in the bit-fields of Stmt if possible

riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:1407 public: - enum CharacterKind { -Ascii, -Wide, -UTF8, -UTF16, -UTF32 - }; + enum CharacterKind { Ascii, Wide, UTF8, UTF16, UTF32 }; shafik wrote: > Minor comment,

[PATCH] D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D54441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D53934: [clangd] Improve code completion for ObjC methods

dgoldman updated this revision to Diff 173737. dgoldman added a comment. CodeCompleteTests fixes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53934 Files: clangd/CodeCompletionStrings.cpp unittests/clangd/CodeCompleteTests.cpp unittests/clangd/CodeCompletionStringsTests

[PATCH] D54441: [OPENMP] Support relational-op !- (not-equal) as one of the canonical forms of random access iterator

anhtuyen created this revision. anhtuyen added reviewers: ABataev, Hahnfeld, RaviNarayanaswamy, mikerice, kkwli0, hfinkel, gtbercea. anhtuyen added projects: OpenMP, clang. In OpenMP 4.5, only 4 relational operators are supported: <, <=, >, and >=. This work is to enable support for relational op

[PATCH] D54324: [AST] Store the value of CharacterLiteral in the bit-fields of Stmt if possible

shafik added inline comments. Comment at: include/clang/AST/Expr.h:1407 public: - enum CharacterKind { -Ascii, -Wide, -UTF8, -UTF16, -UTF32 - }; + enum CharacterKind { Ascii, Wide, UTF8, UTF16, UTF32 }; Minor comment, does it make sense

RE: r346677 - Implement P1094R2 (nested inline namespaces)

Coolbeans, will do! Thanks for the review. -Erich From: Richard Smith [mailto:rich...@metafoo.co.uk] Sent: Monday, November 12, 2018 11:59 AM To: Keane, Erich Cc: cfe-commits Subject: Re: r346677 - Implement P1094R2 (nested inline namespaces) On Mon, 12 Nov 2018 at 09:22, Erich Keane via cfe-

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

llvm-commits added a comment. - F7538987: msg-17782-346.txt Repository: rL LLVM https://reviews.llvm.org/D54310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D54310: Make clang-based tools find libc++ on MacOS

On Mon, Nov 12, 2018, 20:53 George Karpenkov via Phabricator < revi...@reviews.llvm.org wrote: > george.karpenkov added a comment. > > I don't quite understand the need for this patch. > If we are talking about a binary built from source, wouldn't it make more > sense to build libcxx from source a

r346699 - PR39628 Treat all non-zero values as 'true' in bool compound-assignment

Author: rsmith Date: Mon Nov 12 12:11:57 2018 New Revision: 346699 URL: http://llvm.org/viewvc/llvm-project?rev=346699&view=rev Log: PR39628 Treat all non-zero values as 'true' in bool compound-assignment in constant evaluation, not just odd values. Modified: cfe/trunk/lib/AST/ExprConstant.cp

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:177 "no analyzer checkers are associated with '%0'">; -def note_suggest_disabling_all_checkers : Note< -"use -analyzer-disable-all-checks to disable all static analyzer checkers"

[PATCH] D54405: Record whether a AST Matcher constructs a Node

steveire added inline comments. Comment at: lib/ASTMatchers/Dynamic/Registry.cpp:77 + internal::MatcherDescriptor *matchDescriptor, StringRef MatcherName) { +auto K = ast_type_traits::ASTNodeKind::getFromNodeKind< +typename ast_matchers::internal::VariadicAllOfM

[PATCH] D54438: [analyzer][WIP] Reimplement dependencies between checkers

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun, rnkovacs. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, jfb, mikhail.ramalho, a.sidorin, mgrang, szepet, whisperity, mgorny. This patch solves the problem I explained in an earlier revision[

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

NoQ added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:177 "no analyzer checkers are associated with '%0'">; -def note_suggest_disabling_all_checkers : Note< -"use -analyzer-disable-all-checks to disable all static analyzer checkers">; ---

Re: r346677 - Implement P1094R2 (nested inline namespaces)

On Mon, 12 Nov 2018 at 09:22, Erich Keane via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: erichkeane > Date: Mon Nov 12 09:19:48 2018 > New Revision: 346677 > > URL: http://llvm.org/viewvc/llvm-project?rev=346677&view=rev > Log: > Implement P1094R2 (nested inline namespaces) > > As

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

george.karpenkov added a comment. In the future, for macOS-specific changes I think it would be better to wait for a sign-off from at least one maintainer who is an expert on Apple tools. Repository: rL LLVM https://reviews.llvm.org/D54310 ___ c

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

george.karpenkov added a comment. I suspect it broke http://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/14090/console as well. Repository: rL LLVM https://reviews.llvm.org/D54310 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D54310: Make clang-based tools find libc++ on MacOS

george.karpenkov added a comment. I don't quite understand the need for this patch. If we are talking about a binary built from source, wouldn't it make more sense to build libcxx from source as well? If libcxx is built from source in the same repo, clang-based tools do find it. Repository: r

[PATCH] D54437: [analyzer][NFC] Merge ClangCheckerRegistry to CheckerRegistry

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity. Now that `CheckerRegistry` lies in `Frontend`, we can finally eliminate `ClangChecker

r346696 - [NFC] Fix formatting in inline nested namespace definition.

Author: erichkeane Date: Mon Nov 12 11:29:26 2018 New Revision: 346696 URL: http://llvm.org/viewvc/llvm-project?rev=346696&view=rev Log: [NFC] Fix formatting in inline nested namespace definition. Apparently my invocation of clang-format in VIM didn't get this right, but the patch-version DID. Th

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus added a comment. In https://reviews.llvm.org/D54401#1295832, @george.karpenkov wrote: > > Also, remove diags::note_suggest_disabling_all_checkers. > > Isn't that a separate revision? Given that removing existing options is often > questionable, I'd much rather see this patch separated.

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

Szelethus added a comment. In https://reviews.llvm.org/D54429#1295838, @george.karpenkov wrote: > What do you propose we should do with other pages on the existing website? > (OpenProjects / etc.) I think we should just move everything here, and forget about the old site, as there clearly isn

[PATCH] D54436: [analyzer][NFC] Move CheckerRegistry from the Core directory to Frontend

Szelethus created this revision. Szelethus added reviewers: george.karpenkov, NoQ, xazax.hun. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, whisperity, mgorny. Herald added a reviewer: teemperor. `ClangCheckerRegistry` is a very non-obvio

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

dylanmckay updated this revision to Diff 173722. dylanmckay added a comment. Add the search path that Ubuntu installs libc to. Repository: rC Clang https://reviews.llvm.org/D54334 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Basic/DiagnosticGroups.td lib/Driver/Too

[PATCH] D54429: [analyzer] Creating standard Sphinx documentation

george.karpenkov added a comment. From a first glance, it's missing screenshots and an introduction section. What do you propose we should do with other pages on the existing website? (OpenProjects / etc.) Repository: rC Clang https://reviews.llvm.org/D54429 _

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

george.karpenkov added a comment. > Also, remove diags::note_suggest_disabling_all_checkers. Isn't that a separate revision? Given that removing existing options is often questionable, I'd much rather see this patch separated. Repository: rC Clang https://reviews.llvm.org/D54401

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

george.karpenkov added inline comments. Comment at: include/clang/Basic/DiagnosticFrontendKinds.td:177 "no analyzer checkers are associated with '%0'">; -def note_suggest_disabling_all_checkers : Note< -"use -analyzer-disable-all-checks to disable all static analyzer ch

[PATCH] D54401: [analyzer] Prefer returns values to out-params in CheckerRegistry.cpp

Szelethus updated this revision to Diff 173717. Szelethus set the repository for this revision to rC Clang. Szelethus added a comment. Might as well make it a method. Repository: rC Clang https://reviews.llvm.org/D54401 Files: include/clang/Basic/DiagnosticFrontendKinds.td include/clang/

[PATCH] D53764: [OpenCL] Enable address spaces for references in C++

rjmccall added inline comments. Comment at: lib/Sema/SemaExprCXX.cpp:4289 + /*BasePath=*/nullptr, CCK) + .get(); Okay. But if `ToType` *isn't* a reference type, this will never be an address-space conversion. I feel

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

hwright added inline comments. Comment at: clang-tidy/abseil/DurationFactoryScaleCheck.cpp:57-58 +// One and only one of `IntLit` and `FloatLit` should be provided. +static double GetValue(const IntegerLiteral *IntLit, + const FloatingLiteral *FloatLit) { +

[PATCH] D54246: [clang-tidy] Add the abseil-duration-factory-scale check

hwright updated this revision to Diff 173714. hwright marked 11 inline comments as done. hwright added a comment. Addressed small concerns. Larger issues pending feedback. https://reviews.llvm.org/D54246 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang

  1   2   3   >