[PATCH] D53066: [RFC] [Driver] Use forward slashes in most linker arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL345004: [Driver] Use forward slashes in most linker arguments (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53066?vs=

[PATCH] D53397: [MinGW] Link to correct openmp library

This revision was automatically updated to reflect the committed changes. Closed by commit rL345003: [MinGW] Link to correct openmp library (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53397 Files: cfe/trunk/li

r345003 - [MinGW] Link to correct openmp library

Author: mstorsjo Date: Mon Oct 22 23:33:22 2018 New Revision: 345003 URL: http://llvm.org/viewvc/llvm-project?rev=345003&view=rev Log: [MinGW] Link to correct openmp library Patch by Peiyuan Song! Differential Revision: https://reviews.llvm.org/D53397 Modified: cfe/trunk/lib/Driver/ToolChai

r345004 - [Driver] Use forward slashes in most linker arguments

Author: mstorsjo Date: Mon Oct 22 23:33:26 2018 New Revision: 345004 URL: http://llvm.org/viewvc/llvm-project?rev=345004&view=rev Log: [Driver] Use forward slashes in most linker arguments libtool inspects the output of $CC -v to detect what object files and libraries are linked in by default. Wh

[PATCH] D47687: [Sema] Missing -Wlogical-op-parentheses warnings in macros (PR18971)

Higuoxing added a comment. In https://reviews.llvm.org/D47687#1266893, @vsapsai wrote: > Sorry about the delay. The change seems to be correct but `ninja check-clang` > reveals the test "Misc/caret-diags-macros.c" is failing. Can you please look > into that? Hi, It's because the expression is

[PATCH] D53472: Add gfx904 and gfx906 to GPU Arch

This revision was automatically updated to reflect the committed changes. Closed by commit rL344996: Add gfx904 and gfx906 to GPU Arch (authored by yaxunl, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53472?vs=170311&id=170560#toc

r344996 - Add gfx904 and gfx906 to GPU Arch

Author: yaxunl Date: Mon Oct 22 19:05:31 2018 New Revision: 344996 URL: http://llvm.org/viewvc/llvm-project?rev=344996&view=rev Log: Add gfx904 and gfx906 to GPU Arch Differential Revision: https://reviews.llvm.org/D53472 Modified: cfe/trunk/include/clang/Basic/Cuda.h cfe/trunk/lib/Basic

[PATCH] D53547: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

rsmith added a comment. I'm very happy with reducing our configuration space like this, if the distinction is indeed unused (which it appears to be). (If compiling in ObjC1 mode actually is useful, we should instead have a command-line flag for that and tests; the fact that we don't tells us al

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:202 + void finalizeConstraints() { +Constraints.clear(

[PATCH] D53076: [analyzer] Enhance ConditionBRVisitor to write out more information

george.karpenkov added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h:80 class ConstraintManager { + using ConstraintMap = std::map; + ConstraintMap Constraints; Traditionally LLVM projects use `llvm::DenseMap

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

SquallATF updated this revision to Diff 170559. SquallATF added a comment. - add test Repository: rC Clang https://reviews.llvm.org/D53476 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/MSVC.cpp test/Driver/cl-options.c test/OpenMP/Inputs/resource_dir/x86_64-msvc-win32/

r344992 - [analyzer] [NFC] Correct comment on RetainSummaryManager

Author: george.karpenkov Date: Mon Oct 22 18:31:08 2018 New Revision: 344992 URL: http://llvm.org/viewvc/llvm-project?rev=344992&view=rev Log: [analyzer] [NFC] Correct comment on RetainSummaryManager Differential Revision: https://reviews.llvm.org/D53548 Modified: cfe/trunk/include/clang/Sta

r344991 - [analyzer] [www] Drop references to GC mode, which was deprecated years ago

Author: george.karpenkov Date: Mon Oct 22 18:30:45 2018 New Revision: 344991 URL: http://llvm.org/viewvc/llvm-project?rev=344991&view=rev Log: [analyzer] [www] Drop references to GC mode, which was deprecated years ago Differential Revision: https://reviews.llvm.org/D53302 Removed: cfe/trunk

r344990 - [analyzer] [testing] Compute data on path length, compute percentiles

Author: george.karpenkov Date: Mon Oct 22 18:30:26 2018 New Revision: 344990 URL: http://llvm.org/viewvc/llvm-project?rev=344990&view=rev Log: [analyzer] [testing] Compute data on path length, compute percentiles Differential Revision: https://reviews.llvm.org/D52844 Modified: cfe/trunk/util

[PATCH] D52844: [analyzer] [testing] Compute data on path length, compute percentiles

This revision was automatically updated to reflect the committed changes. Closed by commit rC344990: [analyzer] [testing] Compute data on path length, compute percentiles (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://revi

[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

aaronpuchert added a comment. I hope the cleanup makes the code more easily digestible, and to some extent might also transport why I think this is the most elegant approach. I think we should document the semantics of scoped capabilities in more detail, and I will do so once this is either mer

r344987 - [CodeGen] Attach InlineHint to more functions

Author: rtrieu Date: Mon Oct 22 18:26:28 2018 New Revision: 344987 URL: http://llvm.org/viewvc/llvm-project?rev=344987&view=rev Log: [CodeGen] Attach InlineHint to more functions For instantiated functions, search the template pattern to see if it marked inline to determine if InlineHint attribut

[PATCH] D52674: [AST] Add Obj-C discriminator to MS ABI RTTI

smeenai added a comment. @rjmccall I prototyped the ForRTTI parameter approach in https://reviews.llvm.org/D53546. It could definitely be cleaned up a bit, but it demonstrates the problems I saw with the added parameter. Namely, `mangleType(QualType, SourceRange, QualifierMangleMode)` has a bun

[PATCH] D53547: NFC: Remove the ObjC1/ObjC2 distinction from clang (and related projects)

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, rsmith. Herald added a subscriber: dexonsmith. We haven't supported compiling ObjC1 for a long time (and never will again), so there isn't any reason to keep these separate. This patch replaces LangOpts::ObjC1 and

[PATCH] D52418: [driver][mips] Enable integrated assembler for MIPS64 except N32 ABI selected

brad added a comment. How is it going with regard to N32 fixes / testing? Repository: rC Clang https://reviews.llvm.org/D52418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52578: Thread safety analysis: Allow scoped releasing of capabilities

aaronpuchert updated this revision to Diff 170545. aaronpuchert marked 3 inline comments as done. aaronpuchert added a comment. This revision is now accepted and ready to land. Addressed some review comments and simplified the code. There is a lot less duplication and maybe it's even easier to un

[PATCH] D53543: [analyzer] MallocChecker: pr39348: Realize that sized delete isn't a custom delete.

NoQ updated this revision to Diff 170543. NoQ added a comment. Remove weird flags that i used for debugging from the test run-lines. https://reviews.llvm.org/D53543 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/NewDelete-custom.cpp test/Analysis/NewDelete-sized-deallo

[PATCH] D53543: [analyzer] MallocChecker: pr39348: Realize that sized delete isn't a custom delete.

NoQ updated this revision to Diff 170541. NoQ added a comment. Nono, that was an old patch, sry. Here's the correct patch. https://reviews.llvm.org/D53543 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/NewDelete-custom.cpp test/Analysis/NewDelete-sized-deallocation.cpp

[PATCH] D53543: [analyzer] MallocChecker: pr39348: Realize that sized delete isn't a custom delete.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, baloghadamsoftware. Fixes https://bugs.llvm.org/show_bug.cgi?id=39348 Under `-fsized-deallo

[PATCH] D53541: [COFF, ARM64] Add aarch64_seh_recoverfp intrinsic

mgrang created this revision. mgrang added reviewers: rnk, compnerd, mstorsjo, TomTan, efriedma. Herald added subscribers: chrib, kristof.beyls, javed.absar. This patch mimics X86 behavior and add aarch64_seh_recoverfp similar to x86_seh_recoverfp. This patch is needed by https://reviews.llvm.org

r344978 - [X86] Remove 'rtm' feature from KNL.

Author: ctopper Date: Mon Oct 22 17:15:37 2018 New Revision: 344978 URL: http://llvm.org/viewvc/llvm-project?rev=344978&view=rev Log: [X86] Remove 'rtm' feature from KNL. I'm unsure if KNL has this feature, but the backend never thought it did, only clang did. The predefined-arch-macros test los

Re: r342827 - Fix modules build with shared library.

On Mon, 22 Oct 2018 at 14:57, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Richard - any further thoughts here (re: layering/dependencies, etc)? > Would love to get the layering oddity fixed rather than having it get more > embedded over time. > Here's the intended current

[PATCH] D53295: Mark store and load of block invoke function as invariant.group

Anastasia added a comment. Btw, blocks w/o captures are already optimized into regular calls? https://reviews.llvm.org/D53295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r344968 - [clang-tidy] Fix typo abls->absl.

Author: d0k Date: Mon Oct 22 15:43:17 2018 New Revision: 344968 URL: http://llvm.org/viewvc/llvm-project?rev=344968&view=rev Log: [clang-tidy] Fix typo abls->absl. Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/abseil-str-cat-append.rst Modified: clang-tools-extra/trunk/docs/clang

[PATCH] D51204: [COFF, ARM64] Add MS intrinsics: __getReg, _ReadStatusReg, _WriteStatusReg

dmajor added a comment. In https://reviews.llvm.org/D51204#1253230, @mgrang wrote: > Will abandon this patch since I have implementations of these which I will > upstream soon. Just to link up the reviews: these landed in https://reviews.llvm.org/D52838 and https://reviews.llvm.org/D53115. (T

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky updated this revision to Diff 170515. oleg.smolsky edited the summary of this revision. oleg.smolsky added a comment. Added another test case. Repository: rC Clang https://reviews.llvm.org/D52676 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Forma

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

oleg.smolsky added inline comments. Comment at: unittests/Format/FormatTest.cpp:11604 + " x.end(), //\n" + " [&](int, int) { return 1; });\n" "}\n"); krasimir wrote: > This looks a bit suspicious: I'd expect

[PATCH] D52441: [CodeGen] Update min-legal-vector width based on function argument and return types

rnk added a comment. In https://reviews.llvm.org/D52441#1258317, @craig.topper wrote: > Address Reid's comments. Add a comment with a list of all things that > currently effect the vector width attribute emitted in IR. > > For inlining, we update the caller's attribute during merging to ensure i

[PATCH] D52441: [CodeGen] Update min-legal-vector width based on function argument and return types

craig.topper added a comment. Ping https://reviews.llvm.org/D52441 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52742: [analyzer][PlistMacroExpansion] Part 1.: New expand-macros flag

Szelethus updated this revision to Diff 170509. Szelethus added a comment. Added a new `macro_expansions` key on the same level at `path` and `notes`, under which the macro expansions are listed, as suggested by @NoQ. There were a couple ways to make this happen. I could've changed how macro pi

Re: r344915 - Ensure sanitizer check function calls have a !dbg location

This change causes build failures on the UBSan bot, like so : 3. /b/sanitizer-x86_64-linux-bootstrap-ubsan/build/llvm/include/llvm/Support/Allocator.h:98:40: Generati

[PATCH] D53475: Create ConstantExpr class

rsmith added a comment. Thanks, this is looking good. Comment at: include/clang/AST/Expr.h:874-875 + +/// FullExpression - Represents a "full-expression" node. +class FullExpression : public Expr { +protected: All of our expression classes have names ending `Ex

[PATCH] D53066: [RFC] [Driver] Use forward slashes in most linker arguments

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D53066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r344963 - Revert "[Driver] Reland again: Default Android toolchains to libc++."

Author: danalbert Date: Mon Oct 22 14:58:22 2018 New Revision: 344963 URL: http://llvm.org/viewvc/llvm-project?rev=344963&view=rev Log: Revert "[Driver] Reland again: Default Android toolchains to libc++." More compiler-rt test bot breakages... Removed: cfe/trunk/test/Driver/Inputs/basic_an

Re: r342827 - Fix modules build with shared library.

Richard - any further thoughts here (re: layering/dependencies, etc)? Would love to get the layering oddity fixed rather than having it get more embedded over time. On Tue, Oct 2, 2018 at 2:44 PM Shuai Wang via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Mon, Oct 1, 2018 at 4:58 PM Rich

r344961 - Revert "Ensure sanitizer check function calls have a !dbg location"

Author: vlad.tsyrklevich Date: Mon Oct 22 14:51:58 2018 New Revision: 344961 URL: http://llvm.org/viewvc/llvm-project?rev=344961&view=rev Log: Revert "Ensure sanitizer check function calls have a !dbg location" This reverts commit r344915. It was causing exceptions on the x86_64-linux-ubsan bot.

[PATCH] D52676: [clang-format] tweaked another case of lambda formatting

krasimir added inline comments. Comment at: unittests/Format/FormatTest.cpp:11604 + " x.end(), //\n" + " [&](int, int) { return 1; });\n" "}\n"); This looks a bit suspicious: I'd expect a break before the fi

[PATCH] D53529: [Driver] fix broken test

This revision was automatically updated to reflect the committed changes. Closed by commit rL344958: [Driver] fix broken test (authored by nickdesaulniers, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53529 Files: cfe/trunk/test/Driv

r344958 - [Driver] fix broken test

Author: nickdesaulniers Date: Mon Oct 22 14:25:53 2018 New Revision: 344958 URL: http://llvm.org/viewvc/llvm-project?rev=344958&view=rev Log: [Driver] fix broken test Summary: Fixes test from r344941 which was broken on Windows. We want to check the selected toolchain rather than the found toolch

r344957 - Give Multiversion-inline functions linkonce linkage

Author: erichkeane Date: Mon Oct 22 14:20:45 2018 New Revision: 344957 URL: http://llvm.org/viewvc/llvm-project?rev=344957&view=rev Log: Give Multiversion-inline functions linkonce linkage Since multiversion variant functions can be inline, in C they become available-externally linkage. This end

[PATCH] D53529: [Driver] fix broken test

nickdesaulniers created this revision. nickdesaulniers added reviewers: srhines, danalbert. Herald added a subscriber: cfe-commits. Fixes test from r344941 which was broken on Windows. We want to check the selected toolchain rather than the found toolchain anyways. Repository: rC Clang https:

[PATCH] D53482: Add clang-format stability check with FormatTests

krasimir requested changes to this revision. krasimir added a comment. This revision now requires changes to proceed. Sadly I tried this out a year ago and hit the same thing. A root cause is that tabs have variable column length depending on their start column, and in clang-format tokens are mo

[PATCH] D53520: Update the example of BS_Stroustrup to match what is done by clang-format

krasimir requested changes to this revision. krasimir added inline comments. This revision now requires changes to proceed. Comment at: docs/ClangFormatStyleOptions.rst:904 * ``BS_Stroustrup`` (in configuration: ``Stroustrup``) -Like ``Attach``, but break before function d

[PATCH] D53025: [clang-tidy] implement new check for const return types.

JonasToth added a comment. > Also, the template version (whether trailing or normal return) does not > trigger the matchers at all, from which I surmise that clang doesn't consider > the type const qualified when it is not materialized with an actual type. > I've noted as much in the comments,

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson added a comment. In https://reviews.llvm.org/D53524#1271357, @pcc wrote: > The reason why LTO unit is always enabled is so that you can link translation > units compiled with `-fsanitize=cfi` and/or `-fwhole-program-vtables` against > translation units compiled without CFI/WPD. With t

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

rnk requested changes to this revision. rnk added a comment. This revision now requires changes to proceed. Actually, can you please add -fopenmp to `test/Driver/cl-options.c` to verify that we accept `-fopenmp`? Repository: rC Clang https://reviews.llvm.org/D53476 ___

[PATCH] D53476: [clang-cl] Allowed -fopenmp work and link openmp library from per-runtime library directory

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D53476 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D53025: [clang-tidy] implement new check for const return types.

JonasToth added a comment. In https://reviews.llvm.org/D53025#1270784, @ymandel wrote: > Correction: the code *catches* the trailing return cases, I just couldn't > find a way to *fix* them; specifically, I was not able to get the necessary > source ranges to re-lex the trailing return type.

[PATCH] D53339: [clang-tidy] Add the abseil-duration-factory-float check

JonasToth added inline comments. Comment at: clang-tidy/abseil/DurationFactoryFloatCheck.cpp:51 + hasArgument(0, + anyOf(cxxStaticCastExpr( +hasDestinationType(realFloatingPointType()), What about c-st

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

pcc requested changes to this revision. pcc added a comment. This revision now requires changes to proceed. The reason why LTO unit is always enabled is so that you can link translation units compiled with `-fsanitize=cfi` and/or `-fwhole-program-vtables` against translation units compiled witho

[PATCH] D53527: Fix range length comparison in DraftStore::UpdateDraft when Unicode characters are removed from the document

DaanDeMeyer created this revision. DaanDeMeyer added a reviewer: sammccall. DaanDeMeyer added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, ioeric, ilya-biryukov. See http://lists.llvm.org/pipermail/clangd-dev/2018-October/000171.html for conte

[PATCH] D53483: [analyzer] Restrict AnalyzerOptions' interface so that non-checker objects have to be registered

Szelethus added a comment. > (though I would also prefer if even checkers could pre-register their options > somehow) Good news, I've also successfully modified the tblgen file `Checkers.td` to be able to register checker options (it took wy more effort and I thought it'd take), so a list

[clang-tools-extra] r344947 - [clang-tidy] tryfix windows build

Author: jonastoth Date: Mon Oct 22 13:29:15 2018 New Revision: 344947 URL: http://llvm.org/viewvc/llvm-project?rev=344947&view=rev Log: [clang-tidy] tryfix windows build Modified: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/MacroUsageCheck.cpp Modified: clang-tools-extra/trunk/clan

r344946 - [Driver] Reland again: Default Android toolchains to libc++.

Author: danalbert Date: Mon Oct 22 13:16:21 2018 New Revision: 344946 URL: http://llvm.org/viewvc/llvm-project?rev=344946&view=rev Log: [Driver] Reland again: Default Android toolchains to libc++. Some of the test data went missing last time I tried to submit this, causing the tests to fail when

[PATCH] D53488: [clang-tidy] Catching narrowing from double to float.

JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:58 + const QualType Rhs) { + assert(Lhs->isRealType()); // Either integer or floating point. + assert(Rhs->isFloatingType()); // Floating point only

r344944 - [analyzer] Fix dumping for SymbolConjured conjured at no particular statement.

Author: dergachev Date: Mon Oct 22 13:11:10 2018 New Revision: 344944 URL: http://llvm.org/viewvc/llvm-project?rev=344944&view=rev Log: [analyzer] Fix dumping for SymbolConjured conjured at no particular statement. Added: cfe/trunk/test/Analysis/dump_egraph.cpp Modified: cfe/trunk/lib/Sta

[PATCH] D53524: [ThinLTO] Enable LTOUnit only when it is needed

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: dexonsmith, steven_wu, inglorion, mehdi_amini. Currently, -flto-unit is specified whenever LTO options are used (unless using the old LTO API). This causes vtable defs to be processed using regular LTO, whi

[clang-tools-extra] r344943 - [Documentation] Fix grammar related to Clang-tidy cppcoreguidelines-macro-usage.

Author: eugenezelenko Date: Mon Oct 22 12:55:52 2018 New Revision: 344943 URL: http://llvm.org/viewvc/llvm-project?rev=344943&view=rev Log: [Documentation] Fix grammar related to Clang-tidy cppcoreguidelines-macro-usage. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools

[PATCH] D53488: [clang-tidy] Catching narrowing from double to float.

JonasToth added a comment. Please add a short sentence to the release notes and adjust the documentation to that check to cover the changes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53488 ___ cfe-commits mailing list cfe-comm

[PATCH] D53463: [Driver] allow Android triples to alias for non Android targets

This revision was automatically updated to reflect the committed changes. Closed by commit rC344941: [Driver] allow Android triples to alias for non Android targets (authored by nickdesaulniers, committed by ). Changed prior to commit: https://reviews.llvm.org/D53463?vs=170283&id=170478#toc Re

r344941 - [Driver] allow Android triples to alias for non Android targets

Author: nickdesaulniers Date: Mon Oct 22 12:48:08 2018 New Revision: 344941 URL: http://llvm.org/viewvc/llvm-project?rev=344941&view=rev Log: [Driver] allow Android triples to alias for non Android targets Summary: Partial revert of r330873 ('[Driver] Reland "Android triples are not aliases for o

[PATCH] D53522: [Frontend] Include module map header declaration in dependency file output

erik.pilkington created this revision. erik.pilkington added reviewers: bruno, rsmith. Herald added a subscriber: dexonsmith. This patch makes clang include headers found in modulemap files in the `.d` file. This is necessary to capture symlinked headers, which previously were ignored, since onl

[PATCH] D52857: [clang-query] Add non-exclusive output API

steveire added a comment. > This is already not the case with set output diag etc. Oh, I'm wrong here. I misread your post, sorry. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52857 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D53513 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D52857: [clang-query] Add non-exclusive output API

steveire added a comment. > This seems confusing to me because I would expect set foo bar to set the > value of a variable foo to bar, This is already not the case with `set output diag` etc. That said, I don't mind spelling this ` output foo`. It's not my decision. It's up to the reviewers.

[PATCH] D53206: Allow padding checker to traverse simple class hierarchies

tekknolagi updated this revision to Diff 170475. tekknolagi added a comment. Make the test case a little easier to read Repository: rC Clang https://reviews.llvm.org/D53206 Files: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp test/Analysis/padding_inherit.cpp Index: test/Analysis/paddi

[PATCH] D53206: Allow padding checker to traverse simple class hierarchies

tekknolagi added inline comments. Comment at: test/Analysis/padding_cpp.cpp:204-212 +// expected-warning@+1{{Excessive padding in 'struct FakeIntSandwich'}} +struct FakeIntSandwich { + char c1; + int i; + char c2; +}; + tekknolagi wrote: > bcraig wrote: > > Lo

[PATCH] D53463: [Driver] allow Android triples to alias for non Android targets

danalbert accepted this revision. danalbert added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D53463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D53520: Update the example of BS_Stroustrup to match what is done by clang-format

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: krasimir. reported here https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911561 clang-format-7 -style="{BreakBeforeBraces: Stroustrup}" wasn't doing the same as the doc Repository: rC Clang https://reviews.llvm.org/D53

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE344940: [clang-tidy] implement cppcoreguidelines macro rules (authored by JonasToth, committed by ). Changed prior to commit: https://reviews.llvm.org/D41648?vs=170472&id=170473#toc Repository: rCT

[clang-tools-extra] r344940 - [clang-tidy] implement cppcoreguidelines macro rules

Author: jonastoth Date: Mon Oct 22 12:20:01 2018 New Revision: 344940 URL: http://llvm.org/viewvc/llvm-project?rev=344940&view=rev Log: [clang-tidy] implement cppcoreguidelines macro rules Summary: In short macros are discouraged by multiple rules (and sometimes reference randomly). [Enum.1], [E

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 170472. JonasToth added a comment. - [Doc] add missing release notes Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 170471. JonasToth added a comment. - add missing private Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp clang-tidy

[PATCH] D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive

patricklyster added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:930 + /// Returns location of clause kind. + SourceLocation getAtomicDefaultMemOrderKindKwLoc() const { return KindKwLoc; } + ABataev wrote: > Again, probably too long line

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth updated this revision to Diff 170470. JonasToth marked 4 inline comments as done. JonasToth added a comment. - address review nits Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D41648 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt clang-tidy/cppcoreguidelines/

[PATCH] D41648: [clang-tidy] implement cppcoreguidelines macro rules

JonasToth added inline comments. Comment at: clang-tidy/cppcoreguidelines/MacroUsageCheck.h:34-35 + void registerPPCallbacks(CompilerInstance &Compiler) override; + void warnMacro(const MacroDirective *MD); + void warnNaming(const MacroDirective *MD); + aaron.

r344939 - Hopefully fix the documentation generation issue

Author: sylvestre Date: Mon Oct 22 12:07:29 2018 New Revision: 344939 URL: http://llvm.org/viewvc/llvm-project?rev=344939&view=rev Log: Hopefully fix the documentation generation issue Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst cfe/trunk/include/clang/Format/Format.h Modified:

[PATCH] D53308: [Fixed Point Arithmetic] Fixed Point to Boolean Cast

leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:2026 +return EmitScalarConversion(Visit(E), E->getType(), DestTy, +CE->getExprLoc()); ebevhan wrote: > rjmccall wrote: > > Why are you pushing

[PATCH] D52857: [clang-query] Add non-exclusive output API

pcc added a comment. I'm not really involved in clang-query development these days, so this is more of a drive-by comment. It wasn't really obvious to me what the wording of the help text for `set enable-output` meant: > Set whether to enable content non-exclusively. I figured out from the na

[PATCH] D51531: [analyzer][UninitializedObjectChecker] Uninit regions are only reported once

NoQ added a comment. I think `RetainCountChecker` is the only checker that maintains such maps and does such cleanup: https://github.com/llvm-mirror/clang/blob/efe41bf98/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h#L288 I didn't know it does that until today. https://re

[PATCH] D53066: [RFC] [Driver] Use forward slashes in most linker arguments

mstorsjo added a comment. Ping @rnk https://reviews.llvm.org/D53066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r344934 - Generate ClangFormatStyleOptions.rst from Format.h (using docs/tools/dump_format_style.py)

Author: sylvestre Date: Mon Oct 22 11:48:58 2018 New Revision: 344934 URL: http://llvm.org/viewvc/llvm-project?rev=344934&view=rev Log: Generate ClangFormatStyleOptions.rst from Format.h (using docs/tools/dump_format_style.py) Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: c

[PATCH] D53206: Allow padding checker to traverse simple class hierarchies

tekknolagi updated this revision to Diff 170464. tekknolagi edited the summary of this revision. tekknolagi added a comment. Remove useless test case in `padding_cpp.cpp` Repository: rC Clang https://reviews.llvm.org/D53206 Files: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp test/Analy

[PATCH] D53206: Allow padding checker to traverse simple class hierarchies

tekknolagi added inline comments. Comment at: test/Analysis/padding_cpp.cpp:204-212 +// expected-warning@+1{{Excessive padding in 'struct FakeIntSandwich'}} +struct FakeIntSandwich { + char c1; + int i; + char c2; +}; + bcraig wrote: > Looking at this again...

[PATCH] D53206: Allow padding checker to traverse simple class hierarchies

george.karpenkov added a comment. @bcraig comments look valid, marking as "Needs Changes" Repository: rC Clang https://reviews.llvm.org/D53206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[PATCH] D53483: [analyzer] Restrict AnalyzerOptions' interface so that non-checker objects have to be registered

george.karpenkov added a comment. OK, so the overall direction makes sense: unregistered options are restricted to checkers, and for others, an explicit getter must be maintained. (though I would also prefer if even checkers could pre-register their options somehow) @NoQ does this make sense to

[PATCH] D52949: [Diagnostics] Implement -Wsizeof-pointer-div

xbolva00 added a comment. Ping https://reviews.llvm.org/D52949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D52835: [Diagnostics] Check integer to floating point number implicit conversions

xbolva00 added a comment. Ping https://reviews.llvm.org/D52835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

george.karpenkov added a comment. Herald added subscribers: dkrupp, donat.nagy. I'm marking it as "needs changes" for now -- the idea seems reasonable, but it's hard to tell without a thorough evaluation on at least a few codebases. Additionally, we should figure out a checker group for this - if

[PATCH] D53069: [analyzer][www] Update avaible_checks.html

george.karpenkov requested changes to this revision. george.karpenkov added inline comments. This revision now requires changes to proceed. Comment at: www/analyzer/available_checks.html:459 + Spurious newline Comment at: www/analyzer/avail

r344929 - [X86] Add new features to the priority list for target attribute multiversioning.

Author: ctopper Date: Mon Oct 22 10:59:58 2018 New Revision: 344929 URL: http://llvm.org/viewvc/llvm-project?rev=344929&view=rev Log: [X86] Add new features to the priority list for target attribute multiversioning. Modified: cfe/trunk/include/clang/Basic/X86Target.def Modified: cfe/trunk/i

[PATCH] D53457: clang-cl: Add "/Xdriver:" pass-through arg support.

neerajksingh added a comment. In https://reviews.llvm.org/D53457#1269769, @hans wrote: > I'm not completely convinced that we want this. So far we've used the > strategy of promoting clang options that are also useful in clang-cl to core > options, and if someone wants to use more clang than th

[PATCH] D38061: Set AnonymousTagLocations false for ASTContext if column info is expected not to be used

dblaikie added a comment. In https://reviews.llvm.org/D38061#1271021, @twoh wrote: > @aprantl It is a debug info. If you compile > test/CodeGenCXX/debug-info-anonymous.cpp file with `clang -g2 -emit-llvm -S > `, you will find debug metadata something like `distinct !DISubprogram(name: > "foo /

[PATCH] D53296: [analyzer] New flag to print all -analyzer-config options

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Good to go, with minor nits inline. Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:255 +ento::printAnalyzerConfigList(llvm::outs()); +

[PATCH] D53513: [OPENMP] Add support for 'atomic_default_mem_order' clause on requires directive

ABataev added a comment. Check the code formatting, please. There should be lines longer than 80 symbols. Comment at: clang/include/clang/AST/OpenMPClause.h:886 + /// \param K Kind of clause. + void setAtomicDefaultMemOrderKind(OpenMPAtomicDefaultMemOrderClauseKind K) { +

  1   2   >