george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land.
Good to go, with minor nits inline. ================ Comment at: lib/FrontendTool/ExecuteCompilerInvocation.cpp:255 + ento::printAnalyzerConfigList(llvm::outs()); + return true; + } ---------------- Hm, should we return here? If there are errors, which are only printed in the next part, should they still be printed? ================ Comment at: test/Analysis/analyzer-list-configs.c:13 +// +// CHECK: OPTIONS: ---------------- Just to be sure, I would hardcode checking for at least the first option here. https://reviews.llvm.org/D53296 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
