Author: sammccall
Date: Mon Oct 15 23:32:14 2018
New Revision: 344586
URL: http://llvm.org/viewvc/llvm-project?rev=344586&view=rev
Log:
[clangd] Disable timeouting test while investigating
Modified:
clang-tools-extra/trunk/unittests/clangd/BackgroundIndexTests.cpp
Modified: clang-tools-extra
takuto.ikuta updated this revision to Diff 169783.
takuto.ikuta added a comment.
Remove unnecessary attr creation
https://reviews.llvm.org/D51340
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/LangOptions.h
clang/include/clang/Driver/CC1Options.td
clang/include/clang
Author: atanasyan
Date: Mon Oct 15 22:18:36 2018
New Revision: 344583
URL: http://llvm.org/viewvc/llvm-project?rev=344583&view=rev
Log:
[mips] Group similar commands in the test case. NFC
Modified:
cfe/trunk/test/CodeGen/target-data.c
Modified: cfe/trunk/test/CodeGen/target-data.c
URL:
http
atanasyan added a comment.
Could you please rebase this patch against the trunk?
Comment at: lib/Driver/ToolChains/Linux.cpp:717
+ const StringRef MIPS64R6ELMultiarchIncludeDirs[] = {
+ "/usr/include/mipsisa64r6el-linux-gnu",
+ "/usr/include/mipsisa64r6el-linux-gnuab
thiagomacieira updated this revision to Diff 169779.
thiagomacieira added a comment.
Update detection: as of Clear Linux 25620, /usr/lib/os-relaese contains
ID_LIKE=clear-linux-os, which allows detecting not only Clear itself, but also
Linux distributions derived from it (Clear Linux mixes).
h
NoQ added a comment.
Re-applied https://reviews.llvm.org/rL344546 as
https://reviews.llvm.org/rL344582.
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
NoQ added a comment.
Also i should not have reverted r344546, it was completely unrelated >_<
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Well, i guess something went wrong, because the job behind the link is in fact
the first job on this buildbot that included r344535.
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
mclow.lists added a comment.
In https://reviews.llvm.org/D51762#1266086, @NoQ wrote:
> Had to revert. Sorry! https://reviews.llvm.org/rL344580.
>
> This failure was masked by another error, so i guess it was missed.
This was supposed to be fixed by commit r344535.
https://reviews.llvm.org/D51
NoQ added a comment.
Had to revert. Sorry! https://reviews.llvm.org/rL344580.
This failure was masked by another error, so i guess it was missed.
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
phosek added a comment.
In https://reviews.llvm.org/D45639#1243010, @ldionne wrote:
> Sorry, my comment was wrong. You're right, using new libc++ headers and
> linking against an old `libc++.dylib` is a supported use case, and in fact
> this is exactly what happens whenever you use new libc++ h
alexshap added a comment.
I see, many thanks. I've cherry-picked this patch locally and played with GDB -
it appears to work fine with it.
I'm also interested and support this change since this would simplify the
adoption of Fission by some build systems.
@dblaikie, @echristo - are there any pa
Hi Sam,
The test you added in this commit is timing out when run on the PS4 Windows bot:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/20724/steps/test/logs/stdio
command timed out: 1200 seconds without output running ['ninja', '-j', '36',
'check-all'
phosek added a comment.
In https://reviews.llvm.org/D53249#1264900, @sidneym wrote:
> https://reviews.llvm.org/D53219 added a check for either hexagon-ld or ld. I
> merged that change earlier today. I can change the test to pass -fuse-ld,
> let me know. Thanks,
Passing `-fuse-ld=ld` is les
leonardchan created this revision.
leonardchan added reviewers: ebevhan, rjmccall, bjope.
leonardchan added a project: clang.
This patch is a part of https://reviews.llvm.org/D48456 in an attempt to split
the casting logic up into smaller patches. This contains the code for casting
from fixed po
NoQ added a comment.
There seem to be more buildbots failing even after
https://reviews.llvm.org/rL344535, eg.
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/50318/console
Failing Tests (3):
libc++ ::
std/utilities/time/time.cal/time.cal.day/time.cal.day.nonmembers/liter
Hi Galina, thanks for letting me know. Committed rL344574 to fix this problem.
Best regards,
Alexey Bataev
15 окт. 2018 г., в 19:03, Galina Kistanova
mailto:gkistan...@gmail.com>> написал(а):
Hello Alexey,
It looks like this commit broke tests on one of our builders.
This failure did not manif
Author: abataev
Date: Mon Oct 15 17:09:06 2018
New Revision: 344574
URL: http://llvm.org/viewvc/llvm-project?rev=344574&view=rev
Log:
[OPENMP][NVPTX]Increment iterator only when it is used, NFC.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMP
modocache added a comment.
Oh, I'm sorry I let this languish! I'll address your comments later this week,
@vsk. Thanks so much for the review!
Repository:
rC Clang
https://reviews.llvm.org/D44672
___
cfe-commits mailing list
cfe-commits@lists.ll
Hello Alexey,
It looks like this commit broke tests on one of our builders.
This failure did not manifest, but masked by another build failures.
Please have a look?
Thanks
Galina
http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/13262
. . .
Failing Tests (10):
NoQ added a comment.
The current text looks great.
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added inline comments.
Comment at: clang/www/analyzer/open_projects.html:27-32
+New checkers which were contributed to the analyzer,
+but have not passed a rigorous evaluation process,
+are committed as "alpha checkers" (from "alpha version"),
+and are not ena
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344570: [mips] Fix handling of GNUABIN32 environment in a
target triple (authored by atanasyan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51464?vs=168116&id=169763#toc
Reposito
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the patch.
https://reviews.llvm.org/D51464
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: atanasyan
Date: Mon Oct 15 15:43:23 2018
New Revision: 344570
URL: http://llvm.org/viewvc/llvm-project?rev=344570&view=rev
Log:
[mips] Fix handling of GNUABIN32 environment in a target triple
The `GNUABIN32` environment in a target triple implies using the N32
ABI. This patch adds support
Szelethus added a comment.
I dislike web development, but that would indeed be invaluable. I'll take a
look.
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
Szelethus marked 2 inline comments as done.
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:354
+StringRef AnalyzerOptions::getOptionAsString(Optional &V,
+ StringRef Name,
geo
george.karpenkov added a comment.
@Szelethus thanks! BTW if you really want to invest into maintaining the
website,
I think it's totally worth it to change all contents to markdown,
and then have a script to generate HTML from that.
Committers would be expected to manually run that script.
This w
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great!
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Szelethus added a comment.
Cheers, thanks for the review!
In https://reviews.llvm.org/D53296#1265927, @george.karpenkov wrote:
> Also, that's a lot of code for printing options. I understand it's hard to do
> wrapping properly, but I'm not sure whether it makes sense for half of the
> `Checker
george.karpenkov added a comment.
OK that makes sense to me, just let's be careful not to crash in places where
we weren't crashing before.
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:354
+StringRef AnalyzerOptions::getOptionAsString(Optional &V,
+
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
+1, I think this is a great addition!
BTW in theory it should be possible to go wild on compile-time programming, and
generate the entire description string at co
george.karpenkov updated this revision to Diff 169758.
https://reviews.llvm.org/D53024
Files:
clang/www/analyzer/open_projects.html
Index: clang/www/analyzer/open_projects.html
===
--- clang/www/analyzer/open_projects.html
+++ cla
george.karpenkov added a comment.
I have tried to clean up the list.
https://reviews.llvm.org/D53024
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344556: [Driver] Support direct split DWARF emission for
Fuchsia (authored by phosek, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53248?vs
Author: phosek
Date: Mon Oct 15 14:30:32 2018
New Revision: 344556
URL: http://llvm.org/viewvc/llvm-project?rev=344556&view=rev
Log:
[Driver] Support direct split DWARF emission for Fuchsia
This enables the driver support for direct split DWARF emission for
Fuchsia in addition to Linux.
Differen
jakehehrlich added a comment.
This just seems like a lit test in unit test form, why does this need to use
unit tests and not lit tests?
https://reviews.llvm.org/D53084
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jakehehrlich accepted this revision.
jakehehrlich added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/unittests/clang-doc/MergeTest.cpp:222
+
+ Expected->DefLoc = Location(10, llvm::SmallString<16>("test.cpp"));
+ Expected->Loc.
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
LGTM, I'd file a bug about SmallString not taking const char* in its
constructor and I'd also put a TODO somewhere to fix that once that's resolved.
https://reviews.llvm.org/D5308
juliehockett updated this revision to Diff 169754.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53081
Files:
clang-tools-extra/unittests/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
c
juliehockett updated this revision to Diff 169752.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53085
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/MDGeneratorTest.cpp
Index: clang-tools-extra/unittests/clang-doc
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:320
+ ExtractInfosFromCodeWithArgs(
+ "export module M;\n"
+ "int moduleFunction(int x);\n"
Can you use raw strings here (and elsewhere in this file) as w
juliehockett updated this revision to Diff 169751.
juliehockett marked an inline comment as done.
https://reviews.llvm.org/D53084
Files:
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp
Index: clang-tools-extra/unittests/clang-d
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D53082
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
nickdesaulniers added a comment.
Nevermind, looks like flaky tests. Will try to repro and contact msan
maintainers.
Repository:
rC Clang
https://reviews.llvm.org/D53210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
juliehockett updated this revision to Diff 169748.
juliehockett marked 2 inline comments as done.
https://reviews.llvm.org/D53081
Files:
clang-tools-extra/unittests/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/CMakeLists.txt
clang-tools-extra/unittests/clang-doc/ClangDocTest.cpp
c
Author: leonardchan
Date: Mon Oct 15 12:59:52 2018
New Revision: 344548
URL: http://llvm.org/viewvc/llvm-project?rev=344548&view=rev
Log:
added fix
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
Modified:
clang-tools-extra/trunk/clang-tidy/modernize/Use
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344549: [Fixed Point Arithmetic] Fix for clang-tools-extra
warning (authored by leonardchan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53299?vs=169741&id=169745#toc
Repositor
Author: leonardchan
Date: Mon Oct 15 13:00:03 2018
New Revision: 344549
URL: http://llvm.org/viewvc/llvm-project?rev=344549&view=rev
Log:
[Fixed Point Arithmetic] Fix for clang-tools-extra warning
Fix for warnings generated on unhandled enum value `STK_FixedPoint`.
Differential Revision: https:/
leonardchan updated this revision to Diff 169741.
leonardchan marked 2 inline comments as done.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53299
Files:
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
Index: clang-tools-extra/clang-tidy/modernize/UseDe
bjope accepted this revision.
bjope added a comment.
This revision is now accepted and ready to land.
Just some inline nit:s about whitespace.
LGTM, apart from that!
Comment at:
clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:63
InitType->getAs()
nickdesaulniers added a comment.
I think this is now breaking:
lld :: ELF/format-binary.test
lld :: ELF/relocatable-versioned.s
Repository:
rC Clang
https://reviews.llvm.org/D53210
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
leonardchan created this revision.
leonardchan added a reviewer: bjope.
leonardchan added a project: clang-tools-extra.
Fix for warnings generated on unhandled enum value `STK_FixedPoint`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53299
Files:
clang-tools-extra/clang-tid
rjmccall added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:1318
+CGM.getModule().getMDKindID("invariant.load"),
+llvm::MDNode::get(getLLVMContext(), None));
+
OpenCL blocks are still potentially function-local, right? I don't think
you
uweigand added a comment.
In https://reviews.llvm.org/D52840#1265615, @mgorny wrote:
> The first one seems to indicate that your `libclang.so` is broken in release
> mode (optimization error?). The second one is correct (some of the tests test
> for errors, and apparently don't silence the mess
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, MTC, rnkovacs.
Herald added subscribers: cfe-commits, donat.nagy, mikhail.ramalho, dmgreen,
a.sidorin, mgrang, szepet, whisperity.
Title says it all, here's how it look like locally:
OVERVIEW: Clang S
Szelethus added a comment.
In https://reviews.llvm.org/D53274#1265625, @george.karpenkov wrote:
> I'm not sure why you could get away with removing those llvm_unreachable
> cases?
Because I got a warning for using `default` when every enum value was handled
in the switch. Since whether the fl
Szelethus updated this revision to Diff 169731.
Szelethus retitled this revision from "[analyzer][NFC][WIP] Collect all
-analyzer-config options in a .def file" to "[analyzer][NFC] Collect all
-analyzer-config options in a .def file".
Szelethus edited the summary of this revision.
Szelethus added
nickdesaulniers accepted this revision.
nickdesaulniers added a comment.
This revision is now accepted and ready to land.
Thanks for this patch. With it I was able to link+boot a BE aarch64 Linux
kernel (and a LE aarch64 Linux kernel).
Comment at: lib/Driver/ToolChains/Gnu.cp
yaxunl created this revision.
yaxunl added reviewers: rjmccall, Anastasia.
OpenCL v2.0 s6.12.5:
Block variable declarations are implicitly qualified with const.
Therefore all block variables must be initialized at declaration time and
may not be reassigned.
As such, load of block in
NoQ added a comment.
Whoops, almost forgot to doxygen-ize comments. Landed in
https://reviews.llvm.org/rC344540.
Repository:
rL LLVM
https://reviews.llvm.org/D52957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
Author: dergachev
Date: Mon Oct 15 11:01:34 2018
New Revision: 344540
URL: http://llvm.org/viewvc/llvm-project?rev=344540&view=rev
Log:
[analyzer] Add doxygen comments for the new CXXAllocatorCall APIs.
Forgot to squeeze this into r344539.
Modified:
cfe/trunk/include/clang/StaticAnalyzer/Cor
Author: dergachev
Date: Mon Oct 15 10:53:18 2018
New Revision: 344539
URL: http://llvm.org/viewvc/llvm-project?rev=344539&view=rev
Log:
[analyzer] Teach CallEvent about C++17 aligned operator new().
In C++17, when class C has large alignment value, a special case of
overload resolution rule kicks
thiagomacieira marked an inline comment as done.
thiagomacieira added inline comments.
Comment at: lib/Driver/Distro.cpp:148
+for (StringRef Line : Lines)
+ if (Version == Distro::UnknownDistro && Line.startswith("ID="))
+Version = llvm::StringSwitch(Line.substr(
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344539: [analyzer] Teach CallEvent about C++17 aligned
operator new(). (authored by dergachev, committed by ).
Herald added subscribers: llvm-commits, donat.nagy.
Changed prior to commit:
https://review
Author: dergachev
Date: Mon Oct 15 10:47:56 2018
New Revision: 344538
URL: http://llvm.org/viewvc/llvm-project?rev=344538&view=rev
Log:
[analyzer] NFC: RetainCountChecker: Don't dump() symbols into program point
tags.
We don't need a separate node for every symbol, because whenever the first
sym
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344538: [analyzer] NFC: RetainCountChecker: Don't
dump() symbols into program point… (authored by dergachev, committed by ).
Herald added a subscriber: donat.nagy.
Repository:
rC Clang
https://reviews.
george.karpenkov added a comment.
I'm not sure why you could get away with removing those llvm_unreachable cases?
Comment at: lib/StaticAnalyzer/Core/AnalyzerOptions.cpp:373
- default:
-llvm_unreachable("Invalid mode.");
case UMK_Shallow:
Wh
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344537: [python] [tests] Disable python binding tests under
LLVM_USE_SANITIZER=Address (authored by dergachev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
Author: dergachev
Date: Mon Oct 15 10:43:23 2018
New Revision: 344537
URL: http://llvm.org/viewvc/llvm-project?rev=344537&view=rev
Log:
[python] [tests] Disable python binding tests under LLVM_USE_SANITIZER=Address
They don't work yet.
Patch by Dan Liew!
rdar://problem/45242886
Differential Re
george.karpenkov added a comment.
> The main motivation behind here is to emit warnings if an invalid
I'm totally with you here, but IIRC (@NoQ might want to correct me here),
the design decision was made specifically to ignore incorrect options, so that
e.g. old versions of Xcode used with old
This revision was automatically updated to reflect the committed changes.
Closed by commit rC344536: Revert 344389 "Revert r344375 "[Driver]
check for exit code from SIGPIPE"" (authored by nickdesaulniers,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53210?vs=169474&id=16
Author: nickdesaulniers
Date: Mon Oct 15 10:39:00 2018
New Revision: 344536
URL: http://llvm.org/viewvc/llvm-project?rev=344536&view=rev
Log:
Revert 344389 "Revert r344375 "[Driver] check for exit code from SIGPIPE""
Summary:
Add preprocessor guards for UNIX.
This reverts commit r344389.
Review
mgorny added a comment.
The first one seems to indicate that your `libclang.so` is broken in release
mode (optimization error?). The second one is correct (some of the tests test
for errors, and apparently don't silence the messages).
Repository:
rC Clang
https://reviews.llvm.org/D52840
JDevlieghere added a comment.
Can you add a test case please?
Repository:
rC Clang
https://reviews.llvm.org/D53200
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
uweigand added a comment.
This causes check-all to abort for me on SystemZ in Release mode (and never
actually run the lit tests):
[40/365] cd /home/uweigand/llvm/llvm-head/tools/clang/bindings/python &&
/usr/bin/cmake -E...BRARY_PATH=/home/uweigand/llvm/build/llvm-head/lib
/usr/bin/python2.
Author: sammccall
Date: Mon Oct 15 09:47:45 2018
New Revision: 344533
URL: http://llvm.org/viewvc/llvm-project?rev=344533&view=rev
Log:
[clangd] Revert include path change in Dexp. NFC
Modified:
clang-tools-extra/trunk/clangd/index/dex/dexp/CMakeLists.txt
clang-tools-extra/trunk/clangd/in
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
I think it'd be a good idea to separate out the on-initialization vs
dynamically-changing parameters more - I think they should probably be disjoint
in fact.
But we can discuss/implemen
ymandel added inline comments.
Comment at: clang-tidy/readability/ConstValueReturnCheck.cpp:64
+
+ // Fix the definition.
+ llvm::Optional Loc = findConstToRemove(Def, Result);
JonasToth wrote:
> ymandel wrote:
> > JonasToth wrote:
> > > ymandel wrote:
> > > >
This revision was automatically updated to reflect the committed changes.
Closed by commit rL344530: [Fixed Point Arithmetic] FixedPointCast (authored by
leonardchan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50616?vs=169714&id=1
mclow.lists accepted this revision.
mclow.lists added a comment.
After discussions with @EricWF, I landed a modified version as revision 344529.
https://reviews.llvm.org/D51762
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
Author: leonardchan
Date: Mon Oct 15 09:07:02 2018
New Revision: 344530
URL: http://llvm.org/viewvc/llvm-project?rev=344530&view=rev
Log:
[Fixed Point Arithmetic] FixedPointCast
This patch is a part of https://reviews.llvm.org/D48456 in an attempt to
split them up. This contains the code for cast
leonardchan updated this revision to Diff 169714.
leonardchan marked an inline comment as done.
Repository:
rC Clang
https://reviews.llvm.org/D50616
Files:
include/clang/AST/OperationKinds.def
include/clang/AST/Type.h
include/clang/Basic/DiagnosticCommonKinds.td
lib/AST/Expr.cpp
lib/
simark marked an inline comment as done.
simark added inline comments.
Comment at: clangd/ClangdLSPServer.h:90
void reparseOpenedFiles();
+ void applyConfiguration(const ClangdInitializationOptions &Settings);
void applyConfiguration(const ClangdConfigurationParamsChange &
sammccall added a comment.
For reference, @jkorous has a WIP in https://reviews.llvm.org/D53290.
It's scope is a superset, and I think everything in common is basically the
same (they were both based on a common prototype).
Jan is out at the moment, so I think it makes sense to move ahead with th
xudaliang.pku created this revision.
xudaliang.pku added a reviewer: asb.
Herald added subscribers: cfe-commits, jocewei, PkmX, the_o, brucehoult,
MartinMosbeck, rogfer01, mgrang, edward-jones, zzheng, jrtc27, shiva0217,
kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar.
1. add op
phosek added inline comments.
Comment at: clang-tools-extra/unittests/clang-doc/YAMLGeneratorTest.cpp:45
+ assert(!Err);
+ std::string Expected =
+ "---\n"
Nit: use raw strings here as well, the same here below.
https://reviews.llvm.org/D53084
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344521: [clangd] Add createIndex in dexp (authored by
hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53292?vs=169712&id=169713#toc
Repository:
rCTE Clang Tools Extra
ht
Author: hokein
Date: Mon Oct 15 08:12:40 2018
New Revision: 344521
URL: http://llvm.org/viewvc/llvm-project?rev=344521&view=rev
Log:
[clangd] Add createIndex in dexp
Summary:
This would allow easily injecting our internal customization.
Also updates the stale "symbol-collection-file" flag.
Revi
hokein updated this revision to Diff 169712.
hokein marked 2 inline comments as done.
hokein added a comment.
createIndex => openIndex
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53292
Files:
clangd/index/dex/dexp/Dexp.cpp
Index: clangd/index/dex/dexp/Dexp.cpp
==
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/dex/dexp/Dexp.cpp:256
+std::unique_ptr createIndex(llvm::StringRef Index) {
+ return loadIndex(Index, /*URISchemes=*/{}, /*UseDex=*/true
Author: sammccall
Date: Mon Oct 15 08:04:03 2018
New Revision: 344520
URL: http://llvm.org/viewvc/llvm-project?rev=344520&view=rev
Log:
[clangd] Use SyncAPI in more places in tests. NFC
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
clang-tools-extra/trunk/unittests/clangd/FileInd
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
ilya-biryukov.
This would allow easily injecting our internal customization.
Also updates the stale "symbol-collection-file" flag.
Repository:
rCTE Clang
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clangd/ClangdServer.h:79
+/// Use a heavier and faster in-memory index implementation.
+/// FIXME: we should make this true if it isn't too slow!.
+
jkorous created this revision.
jkorous added a reviewer: sammccall.
Herald added subscribers: cfe-commits, kadircet, jfb, arphaman, dexonsmith,
MaskRay, ioeric, ilya-biryukov, mgorny.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53290
Files:
clangd/CMakeLists.txt
clangd/Cl
Szelethus updated this revision to Diff 169703.
https://reviews.llvm.org/D53274
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/CoreEngine.cpp
Index: lib/StaticAnalyzer/Core/CoreEngine.cpp
==
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay,
ioeric, ilya-biryukov.
Reuse the old -use-dex-index experiment flag for this.
To avoid breaking the tests, make Dex deduplicate symbols, addressing an
Szelethus updated this revision to Diff 169697.
https://reviews.llvm.org/D53277
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/CoreEngine.cpp
Index: lib/S
Szelethus updated this revision to Diff 169696.
https://reviews.llvm.org/D53277
Files:
include/clang/StaticAnalyzer/Core/AnalyzerOptions.def
include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
lib/StaticAnalyzer/Core/CoreEngine.cpp
Index: lib/S
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE344513: [clangd] Minimal implementation of automatic
static index (not enabled). (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D53032?vs=169694&id=169695#to
1 - 100 of 140 matches
Mail list logo
