Szelethus added a comment.

Cheers, thanks for the review!

In https://reviews.llvm.org/D53296#1265927, @george.karpenkov wrote:

> Also, that's a lot of code for printing options. I understand it's hard to do 
> wrapping properly, but I'm not sure whether it makes sense for half of the 
> `CheckerRegistration.cpp` file to be doing option wrapping for help printing.
>  Could you look into simpler alternatives? (or if your wrapping printer is 
> indeed indispensable, maybe it should go somewhere into 
> `llvm/lib/Support/format`?)
>  I am not sure what would be a better solution here, maybe it's already 
> possible to write something much smaller using components from `lib/Support`.


Aye, the formatting looks a little ridiculous. I'm not making a good job 
selling this, but I'm somewhat surprised it even works. Thanks for the 
suggestions, I'll take a look -- I wanted to find an existing solution while 
writing this, but didn't try hard enough.


Repository:
  rC Clang

https://reviews.llvm.org/D53296



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to