rjmccall added inline comments.
Comment at: include/clang/AST/Decl.h:977
+
+unsigned EscapingByref : 1;
};
This doesn't actually seem to be initialized anywhere.
Comment at: include/clang/AST/Decl.h:1422
+
+ bool isNonEscapingByref() co
rjmccall added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:4924
+<< Callee->getSourceRange();
+ }
+
rjmccall wrote:
> Why is the diagnostic at the end location? And why are you separately
> checking whether it's ignored at the begin location
tstellar created this revision.
tstellar added reviewers: chandlerc, beanz.
Herald added a subscriber: mgorny.
This makes it possible to build the unittests with only the gtest sources
and without a full LLVM source tree.
Repository:
rC Clang
https://reviews.llvm.org/D51567
Files:
CMakeLis
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:91
+ for (const auto &P : FileToSlabs)
+Result += P.second->size();
+ return Result;
Why not `bytes` here as well?
https://reviews.llvm.org/D51539
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:184
+ size_t Bytes = PairedSlabSize;
+ Bytes += LookupTable.size() * sizeof(std::pair);
Bytes += SymbolQuality.size() * sizeof(std::pair);
Why not use `LookupTable.ge
thiagomacieira added a comment.
See https://reviews.llvm.org/D51565
Repository:
rC Clang
https://reviews.llvm.org/D51510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thiagomacieira added a comment.
Sure. Hadn't seen that file.
Repository:
rC Clang
https://reviews.llvm.org/D51510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaInit.cpp:1827-1829
+ if (SemaRef.DiagnoseUseOfDecl(Destructor, Loc))
+return false;
+ return true;
Usual Clang convention
ahatanak created this revision.
ahatanak added a reviewer: rjmccall.
Herald added a subscriber: dexonsmith.
This patch changes the way `__block` variables that aren't captured by escaping
blocks are handled:
- Since non-escaping blocks on the stack never get copied to the heap (see
https://revi
ahatanak updated this revision to Diff 163612.
ahatanak marked 3 inline comments as done.
ahatanak added a comment.
Move the call that checks the element's destructor into
InitListChecker::CheckStructUnionTypes.
Repository:
rC Clang
https://reviews.llvm.org/D45898
Files:
lib/Sema/SemaInit
leonardchan added inline comments.
Comment at: lib/AST/TypePrinter.cpp:1370
+
+// Remove the underlying address space so it won't be printed.
+SplitQualType SplitTy = T->getModifiedType().split();
rsmith wrote:
> leonardchan wrote:
> > rsmith wrote:
> > >
leonardchan updated this revision to Diff 163604.
leonardchan marked 8 inline comments as done.
leonardchan added a comment.
- Removed default value for `getAttributedType` and added any macro identifier
necessary as a fourth argument to `getAttributedType`
- Added tracking for `LateAttr`s to kee
rsmith added a comment.
In https://reviews.llvm.org/D51333#1220878, @christylee wrote:
> In https://reviews.llvm.org/D51333#1219938, @rsmith wrote:
>
> > Instead of guessing whether the corrected filename would be valid, why not
> > strip off the leading and trailing non-alphanumeric characters,
Author: ctopper
Date: Fri Aug 31 15:29:56 2018
New Revision: 341265
URL: http://llvm.org/viewvc/llvm-project?rev=341265&view=rev
Log:
[X86] Add ktest intrinsics to match gcc and icc.
These aren't documented in the Intel Intrinsics Guide, but are supported by gcc
and icc.
Includes these intrinsi
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Nice. So, in effect, for optimized builds we'll generate pre-DWARF line info
only, unless --cuda-noopt-device-debug is specified.
Will this deal with the warnings about back-end being unable to handl
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341254: [WebAssembly] clang-format (NFC) (authored by
aheejin, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51448
Files:
cfe/trunk/lib/Drive
Author: aheejin
Date: Fri Aug 31 13:57:00 2018
New Revision: 341254
URL: http://llvm.org/viewvc/llvm-project?rev=341254&view=rev
Log:
[WebAssembly] clang-format (NFC)
Summary: This patch runs clang-format on all wasm-only files.
Subscribers: dschuff, sbc100, jgravelle-google, sunfish, jfb, cfe-c
This revision was automatically updated to reflect the committed changes.
Closed by commit rC341254: [WebAssembly] clang-format (NFC) (authored by
aheejin, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51448?vs=163152&id=163590#toc
Repository:
rL LLVM
https://reviews.ll
Author: ctopper
Date: Fri Aug 31 13:41:06 2018
New Revision: 341251
URL: http://llvm.org/viewvc/llvm-project?rev=341251&view=rev
Log:
[X86] Add k-mask conversion and load/store instrinsics to match gcc and icc.
This adds:
_cvtmask8_u32, _cvtmask16_u32, _cvtmask32_u32, _cvtmask64_u64
_cvtu32_mask8
rsmith updated this revision to Diff 163584.
rsmith added a comment.
Don't add #pragma clang attribute support for 'mode' and 'ext_vector_type'.
Repository:
rC Clang
https://reviews.llvm.org/D51507
Files:
include/clang/Basic/Attr.td
test/Misc/pragma-attribute-supported-attributes-list.te
The builder is just fixed, so I am wrong. Sorry to bother you.
Thanks
Galina
On Fri, Aug 31, 2018 at 1:08 PM Zachary Turner wrote:
> Are we sure it was my commit? Because this seems like a very unusual
> failure given the nature of the commit. I'll try to reproduce it locally
> and report ba
It looks like tnorthover has fixed these in r341240
On Fri, Aug 31, 2018 at 1:08 PM Zachary Turner wrote:
> Are we sure it was my commit? Because this seems like a very unusual
> failure given the nature of the commit. I'll try to reproduce it locally
> and report back.
>
> On Fri, Aug 31, 201
Are we sure it was my commit? Because this seems like a very unusual
failure given the nature of the commit. I'll try to reproduce it locally
and report back.
On Fri, Aug 31, 2018 at 11:49 AM Galina Kistanova
wrote:
> Hello Zachary,
>
> It looks like this commit added broken tests on one of ou
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE341242: [clangd] Implement findOccurrences interface in
dynamic index. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51279?vs=163539&id=163580#toc
Repository
Author: hokein
Date: Fri Aug 31 12:53:37 2018
New Revision: 341242
URL: http://llvm.org/viewvc/llvm-project?rev=341242&view=rev
Log:
[clangd] Implement findOccurrences interface in dynamic index.
Summary:
Implement the interface in
- FileIndex
- MemIndex
- MergeIndex
Depends on https://rev
ABataev created this revision.
ABataev added reviewers: tra, echristo.
Herald added subscribers: JDevlieghere, guansong, aprantl.
Added support for the -gline-directives-only option + fixed logic of the
debug info for CUDA devices. If optimization level is O0, then options
--[no-]cuda-noopt-device
jfb updated this revision to Diff 163577.
jfb added a comment.
- Don't diagnose initialization, only assignment.
Repository:
rC Clang
https://reviews.llvm.org/D51084
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/atomic-implicit-seq_cst.c
test/S
Author: tnorthover
Date: Fri Aug 31 12:24:37 2018
New Revision: 341240
URL: http://llvm.org/viewvc/llvm-project?rev=341240&view=rev
Log:
Tests: fix tests encoding specific hash values for 32-bit systems.
I changed the seed slightly, but forgot to run the tests on a 32-bit system, so
tests which h
On Fri, 31 Aug 2018 at 06:35, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> My reasoning is because type attributes have more impact than variable
> attributes and types appear more frequently. Consider using
> address_space where the region includes function definitions. Sh
Hello Zachary,
It looks like this commit added broken tests on one of our builders:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/19508
. . .
Failing Tests (2):
LLVM-Unit :: ADT/./ADTTests.exe/HashingTest.HashCombineRangeGoldenTest
Clang :: Code
ahatanak added a comment.
The GNUstep documentation I found replaces '@' with '\1'. Would that fix the
problem?
https://github.com/gnustep/libobjc2/blob/master/ABIDoc/abi.tex
Repository:
rC Clang
https://reviews.llvm.org/D50783
___
cfe-commits
Author: ctopper
Date: Fri Aug 31 11:22:52 2018
New Revision: 341234
URL: http://llvm.org/viewvc/llvm-project?rev=341234&view=rev
Log:
[X86] Add kshift intrinsics to match gcc and icc.
This adds the following intrinsics:
_kshiftli_mask8
_kshiftli_mask16
_kshiftli_mask32
_kshiftli_mask64
_kshiftri_
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341232: Export public functions implemented in assembly on
Windows. (authored by cdavis, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D51508
Fi
Author: cdavis
Date: Fri Aug 31 11:11:48 2018
New Revision: 341232
URL: http://llvm.org/viewvc/llvm-project?rev=341232&view=rev
Log:
Export public functions implemented in assembly on Windows.
Summary:
By default, symbols aren't visible outside of the module that defines
them. To make them visibl
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: src/assembly.h:76-78
+ .section .drectve,"yn" SEPARATOR\
+ .ascii "-export:", #name, "\0" SEPARATOR\
+ .text
---
saugustine closed this revision.
saugustine added a comment.
commited as r341231.
Repository:
rC Clang
https://reviews.llvm.org/D51521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: saugustine
Date: Fri Aug 31 10:59:03 2018
New Revision: 341231
URL: http://llvm.org/viewvc/llvm-project?rev=341231&view=rev
Log:
Refactor Addlibgcc to make the when and what logic more straightfoward.
Add Android tests.
Modified:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
cf
usaxena95 added a comment.
Made the suggested changes.
Comment at: include/clang/Basic/VirtualFileSystem.h:359
+ public:
+ /// Add a HardLink to a File.
+ /// The To path must be an existing file or a hardlink. The From file must
not
ilya-biryukov wrote:
>
srhines accepted this revision.
srhines added a comment.
This revision is now accepted and ready to land.
Thanks for cleaning this up and adding better checks for Android. :)
Repository:
rC Clang
https://reviews.llvm.org/D51521
___
cfe-commits ma
usaxena95 updated this revision to Diff 163549.
usaxena95 marked 15 inline comments as done.
usaxena95 added a comment.
- Made suggested changes.
Repository:
rC Clang
https://reviews.llvm.org/D51359
Files:
include/clang/Basic/VirtualFileSystem.h
lib/Basic/VirtualFileSystem.cpp
unittest
lebedev.ri added reviewers: thakis, vsk, phosek.
lebedev.ri added a comment.
In https://reviews.llvm.org/D51545#1220967, @eandrews wrote:
> @lebedev.ri is there a specific reason -Wtautological-unsigned-zero-compare
> was removed? All the issues I am aware of talks about comparisons with
> min/
eandrews added a comment.
@lebedev.ri is there a specific reason -Wtautological-unsigned-zero-compare was
removed? All the issues I am aware of talks about comparisons with min/max.
https://reviews.llvm.org/D51545
___
cfe-commits mailing list
cfe-c
Szelethus updated this revision to Diff 163542.
https://reviews.llvm.org/D51531
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker.cpp
lib/StaticAnalyzer/Checkers/UninitializedObject/Uniniti
eandrews created this revision.
eandrews added reviewers: lebedev.ri, rsmith, rjmccall, rnk, mclow.lists,
erichkeane.
GCC enables -Wtype-limits under -Wextra. Warnings under GCC's -Wtype-limits is
covered in Clang by -Wtautological-type-limit-compare and
-Wtautological-unsigned-zero-compare.
S
kbobyrev planned changes to this revision.
kbobyrev added a comment.
I'll rebase it on top of https://reviews.llvm.org/D51422 and address the last
comment before proceeding to the review.
https://reviews.llvm.org/D51539
___
cfe-commits mailing list
asavonic created this revision.
asavonic added reviewers: Anastasia, yaxunl, bader.
Herald added subscribers: cfe-commits, jfb, mgorny.
TL;DR
-
This patch splits huge opencl-c.h header into multiple headers to
support efficient use of Precompiled Headers (or Modules):
- opencl-c-defs.h conta
mstorsjo added a comment.
In https://reviews.llvm.org/D51440#1220925, @phosek wrote:
> In https://reviews.llvm.org/D51440#1218859, @mstorsjo wrote:
>
> > I'll see if I can get to looking at that sometime soon. I had this patch
> > lying around as an attempt to work around the libtool issue in
>
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/Token.h:54
Scope,
+/// Path to symbol declaration.
+///
ioeric wrote:
> As this is called `Path`, I'd try to decouple it from URIs, so that we don't
> need special handli
hokein updated this revision to Diff 163539.
hokein marked 3 inline comments as done.
hokein added a comment.
address review comments:
- build memindex with symbol slab and occurrence slab
- remove withAllCode in TestTU
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51279
File
kbobyrev updated this revision to Diff 163538.
kbobyrev marked an inline comment as not done.
kbobyrev added a comment.
Fix tests
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/d
phosek added a comment.
In https://reviews.llvm.org/D51440#1218859, @mstorsjo wrote:
> I'll see if I can get to looking at that sometime soon. I had this patch
> lying around as an attempt to work around the libtool issue in
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27866 which doesn't se
kbobyrev updated this revision to Diff 163537.
kbobyrev marked 14 inline comments as done.
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/DexIndex.h
clang-tools-extra/clangd/
sammccall added inline comments.
Comment at: clangd/index/FileIndex.h:47
+ // The shared_ptr keeps the symbols alive.
+ std::shared_ptr buildMemIndex();
ioeric wrote:
> Maybe avoid hardcoding the index name, so that we could potentially switch to
> use a dif
jkorous created this revision.
jkorous added reviewers: arphaman, vsapsai, dexonsmith, rsmith.
jkorous added a project: clang.
Herald added subscribers: cfe-commits, mgorny.
It's rather error-prone to leave that member variable uninitialized. The
DeclAccessPair seems to be intentionally POD and i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341217: Fix existing code for SEH on ARM to compile
correctly (authored by mstorsjo, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://reviews.llvm.org/D
Author: mstorsjo
Date: Fri Aug 31 07:56:55 2018
New Revision: 341217
URL: http://llvm.org/viewvc/llvm-project?rev=341217&view=rev
Log:
Fix existing code for SEH on ARM to compile correctly
Even though SEH for ARM is incomplete, make what code already exists
at least compile correctly.
The _LIBUN
sammccall added inline comments.
Comment at: unittests/clangd/TestTU.h:41
+ static TestTU withAllCode(llvm::StringRef HeaderCode, llvm::StringRef Code,
+llvm::StringRef Filename = "") {
hokein wrote:
> sammccall wrote:
> > We've avo
christylee marked 2 inline comments as done.
christylee added a comment.
In https://reviews.llvm.org/D51333#1219938, @rsmith wrote:
> Instead of guessing whether the corrected filename would be valid, why not
> strip off the leading and trailing non-alphanumeric characters, look up the
> result
ioeric added inline comments.
Comment at: clangd/index/MemIndex.h:30
+ /// Builds an index from a slab. The shared_ptr manages the slab's lifetime.
+ static std::shared_ptr build(SymbolSlab Slab);
sammccall wrote:
> ioeric wrote:
> > (It's a bit unfortunate t
hokein updated this revision to Diff 163532.
hokein added a comment.
Minor cleanup.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51279
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/Index.h
clangd/index/MemIndex.cpp
clangd/index/MemIndex.h
hokein added inline comments.
Comment at: clangd/index/MemIndex.cpp:35
std::unique_ptr MemIndex::build(SymbolSlab Slab) {
auto Idx = llvm::make_unique();
sammccall wrote:
> This is still implicitly creating an index with no occurrences. Did you mean
> to a
hokein updated this revision to Diff 163531.
hokein marked 4 inline comments as done.
hokein added a comment.
- rebase
- address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51279
Files:
clangd/index/FileIndex.cpp
clangd/index/FileIndex.h
clangd/index/In
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341212: [DEBUGINFO] Add support for emission of the debug
directives only. (authored by ABataev, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D5
Author: abataev
Date: Fri Aug 31 06:56:14 2018
New Revision: 341212
URL: http://llvm.org/viewvc/llvm-project?rev=341212&view=rev
Log:
[DEBUGINFO] Add support for emission of the debug directives only.
Summary:
Added option -gline-directives-only to support emission of the debug directives
only. I
cdavis5x added inline comments.
Comment at: src/assembly.h:76-78
+ .section .drectve,"yn" SEPARATOR\
+ .ascii "-export:", #name, "\0" SEPARATOR\
+ .text
rnk wrote:
> Maybe .pushsection / .popsection is better than assumi
Author: sammccall
Date: Fri Aug 31 06:55:01 2018
New Revision: 341211
URL: http://llvm.org/viewvc/llvm-project?rev=341211&view=rev
Log:
[clangd] Flatten out Symbol::Details. It was ill-conceived, sorry.
Reviewers: ioeric
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commi
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341211: [clangd] Flatten out Symbol::Details. It was
ill-conceived, sorry. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
sammccall added a comment.
This looks reasonable!
This is going to conflict with https://reviews.llvm.org/D51422, you might want
to rebase.
Comment at: clang-tools-extra/clangd/index/MemIndex.h:26
+ void build(std::shared_ptr> Symbols,
+ size_t SlabSize=0);
kbobyrev updated this revision to Diff 163523.
kbobyrev added a comment.
Resolved the issues. Measurements show that static Dex index for LLVM takes
~140 MB, ~80 MB of which is the size of `SymbolSlab`.
https://reviews.llvm.org/D51539
Files:
clang-tools-extra/clangd/index/FileIndex.cpp
cl
ioeric added inline comments.
Comment at: clang-tools-extra/clangd/index/dex/DexIndex.cpp:137
+ BoostingIterators.push_back(
+ createBoost(create(It->second), P.second + 10));
+ }
Could you comment on `P.second + 10` here? It sounds lik
sammccall added inline comments.
Comment at: clangd/index/Index.h:416
+ // until the call returns (even if reset() is called).
+ bool fuzzyFind(const FuzzyFindRequest &,
+ llvm::function_ref) const override;
kbobyrev wrote:
> Do we want these fu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341210: [AddressSpace] Use the macro to set hidden
visibility on LocalAddressSpace. (authored by cdavis, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llv
Author: cdavis
Date: Fri Aug 31 06:41:05 2018
New Revision: 341210
URL: http://llvm.org/viewvc/llvm-project?rev=341210&view=rev
Log:
[AddressSpace] Use the macro to set hidden visibility on LocalAddressSpace.
Summary:
That attribute has no effect on Windows anyway--classes are hidden by
default.
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:396
+// Prefer includes that do not need edits (i.e. already exist).
+std::stable_sort(Completion.Includes.begin(), Comp
On Fri, Aug 31, 2018 at 9:23 AM, Duncan P. N. Exon Smith via
Phabricator wrote:
> dexonsmith added inline comments.
>
>
>
> Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:50
> // CHECK-NEXT: EnumExtensibility (SubjectMatchRule_enum)
> +// CHECK-NEXT: ExtVec
ioeric added inline comments.
Comment at: clangd/index/dex/DexIndex.h:42
+ // All symbols must outlive this index.
+ template DexIndex(Range &&Symbols) {
+for (auto &&Sym : Symbols)
Why is this constructor needed? I think this could restrict the flexibilit
kbobyrev planned changes to this revision.
kbobyrev added a comment.
I should use `SymbolSlab.bytes()` instead of `SymbolSlab.size()`. Either way,
something seems to be wrong, because manually checking the `PairedSlabSize`
made me suspicious.
https://reviews.llvm.org/D51539
dexonsmith added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:50
// CHECK-NEXT: EnumExtensibility (SubjectMatchRule_enum)
+// CHECK-NEXT: ExtVectorType (SubjectMatchRule_type_alias)
// CHECK-NEXT: ExternalSourceSymbol ((SubjectMatchRule
baloghadamsoftware updated this revision to Diff 163517.
baloghadamsoftware removed a reviewer: george.karpenkov.
baloghadamsoftware added a comment.
Herald added a reviewer: george.karpenkov.
Since https://reviews.llvm.org/rL338263 fixed a bug in the cleanup phase the
tests for mismatched iterat
kbobyrev created this revision.
kbobyrev added reviewers: ioeric, sammccall.
kbobyrev added a project: clang-tools-extra.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay.
Currently, `SymbolIndex::estimateMemoryUsage()` returns the "overhead"
estimate, i.e. the estimate of the Index
hokein closed this revision.
hokein added a comment.
Committed in https://reviews.llvm.org/rL341208.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
Author: hokein
Date: Fri Aug 31 05:54:13 2018
New Revision: 341208
URL: http://llvm.org/viewvc/llvm-project?rev=341208&view=rev
Log:
[clangd] Collect symbol occurrences in SymbolCollector.
SymbolCollector will be used for two cases:
- collect Symbol type only, used for indexing preamble AST.
-
aaron.ballman added inline comments.
Comment at: include/clang/AST/Type.h:4343
QualType getEquivalentType() const { return EquivalentType; }
+ IdentifierInfo *getAddressSpaceMacroII() const { return AddressSpaceMacroII;
}
+ bool hasAddressSpaceMacroII() const { return Addre
hokein marked 3 inline comments as done.
hokein added a comment.
Sorry! Just realised I messed up this patch with
https://reviews.llvm.org/D50385 (mostly SymbolCollector changes), all the
comments about `SymbolCollector` are fixed in https://reviews.llvm.org/D50385.
Repository:
rCTE Clang To
hokein updated this revision to Diff 163512.
hokein added a comment.
Address review comments in https://reviews.llvm.org/D51279.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50385
Files:
clangd/index/Index.cpp
clangd/index/Index.h
clangd/index/SymbolCollector.cpp
clan
aaron.ballman added inline comments.
Comment at: test/Misc/pragma-attribute-supported-attributes-list.test:50
// CHECK-NEXT: EnumExtensibility (SubjectMatchRule_enum)
+// CHECK-NEXT: ExtVectorType (SubjectMatchRule_type_alias)
// CHECK-NEXT: ExternalSourceSymbol ((SubjectMatchR
aaron.ballman added a comment.
I think the fix generally looks good, but can you please add some test coverage
for the change?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D51192
___
cfe-commits mailing list
cfe-commits@lists.llvm
On Thu, Aug 30, 2018 at 4:12 PM, Richard Smith wrote:
> On Thu, 30 Aug 2018 at 12:27, Aaron Ballman via cfe-commits
> wrote:
>>
>> On Thu, Aug 30, 2018 at 3:21 PM, Richard Smith - zygoloid via
>> Phabricator wrote:
>> > rsmith marked an inline comment as done.
>> > rsmith added inline comments.
aaron.ballman added a comment.
In https://reviews.llvm.org/D51333#1219938, @rsmith wrote:
> Instead of guessing whether the corrected filename would be valid, why not
> strip off the leading and trailing non-alphanumeric characters, look up the
> resulting filename, and find out? If we did that
kbobyrev updated this revision to Diff 163507.
kbobyrev added a comment.
Canonicalize URIs, slightly simplify code structure.
https://reviews.llvm.org/D51481
Files:
clang-tools-extra/clangd/CMakeLists.txt
clang-tools-extra/clangd/index/dex/DexIndex.cpp
clang-tools-extra/clangd/index/dex/D
atanasyan added a comment.
Thanks for review.
Repository:
rL LLVM
https://reviews.llvm.org/D51356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341201: [docs][mips] Clang 7.0 Release notes (authored by
atanasyan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51356?vs=162850&id=163501
Szelethus updated this revision to Diff 163499.
Szelethus added a comment.
Reuploaded with `-U9`. Oops.
https://reviews.llvm.org/D51057
Files:
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObject.h
lib/StaticAnalyzer/Checkers/UninitializedObject/UninitializedObjectChecker
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
This basically looks good to go (some fixes needed but they're pretty clear I
think let me know if not!)
Comment at: clangd/index/FileIndex.cpp:63
+ auto Occurrences
kristina added a comment.
Giving it a second glance, just as an idea, maybe it's better to leave ObjC
pragmas out for now, for another more narrower-scope revision/review specific
to ObjC(/Swift)? Since they could cause incorrect code generation if combined
in odd ways (as well as making no sen
theraven added inline comments.
Comment at: lib/CodeGen/CGBlocks.cpp:163
+ std::string TypeAtEncoding =
+ CGM.getContext().getObjCEncodingForBlock(BlockInfo.getBlockExpr());
+ Name += "e" + llvm::to_string(TypeAtEncoding.size()) + "_" + TypeAtEncoding;
Spe
theraven added a comment.
This revision broke blocks on all ELF targets. The block descriptors' symbol
names can now include the @ character, which is reserved on ELF platforms as a
separator between symbol name and symbol version. As a result, nothing
containing a block that has an Objective
kbobyrev added inline comments.
Comment at: clangd/index/Index.h:416
+ // until the call returns (even if reset() is called).
+ bool fuzzyFind(const FuzzyFindRequest &,
+ llvm::function_ref) const override;
Do we want these functions to be `fina
martong created this revision.
martong added reviewers: a_sidorin, r.stahl, xazax.hun.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
Some `Expr` classes set up default values for the `ExprBits` of `Stmt`. These
default values are then overwritten by
kbobyrev added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:48
+// loading.
+class AsyncLoadIndex : public SymbolIndex {
+public:
Also, do we want only static index to be built asynchronously? Do we want it to
be used only in our Clangd tool driver? L
1 - 100 of 120 matches
Mail list logo
