ank added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4359
+ "return 3;\n"
+ " }).as("");\n"
+ "}");
klimek wrote:
> ank wrote:
> > klimek wrote:
> > > ank wrote:
> > > > klimek wrote:
> > > > > What
ank updated this revision to Diff 152842.
Repository:
rC Clang
https://reviews.llvm.org/D45719
Files:
lib/Format/ContinuationIndenter.cpp
lib/Format/FormatToken.h
unittests/Format/FormatTest.cpp
Index: unittests/Format/FormatTest.cpp
=
Author: vedantk
Date: Mon Jun 25 20:53:06 2018
New Revision: 335577
URL: http://llvm.org/viewvc/llvm-project?rev=335577&view=rev
Log:
Fix an ambiguous overload issue pointed out by MSVC
Log:
http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/11390
Modified:
cfe/trunk/include/clang
Author: vedantk
Date: Mon Jun 25 19:50:01 2018
New Revision: 335571
URL: http://llvm.org/viewvc/llvm-project?rev=335571&view=rev
Log:
Modernize a function, NFC.
Modified:
cfe/trunk/lib/Sema/SemaLambda.cpp
Modified: cfe/trunk/lib/Sema/SemaLambda.cpp
URL:
http://llvm.org/viewvc/llvm-project/c
Author: vedantk
Date: Mon Jun 25 19:50:04 2018
New Revision: 335572
URL: http://llvm.org/viewvc/llvm-project?rev=335572&view=rev
Log:
[ubsan] Relax nullability-return for blocks with deduced types
When the return type of an ObjC-style block literals is deduced, pick
the candidate type with the st
Author: pcc
Date: Mon Jun 25 19:15:47 2018
New Revision: 335569
URL: http://llvm.org/viewvc/llvm-project?rev=335569&view=rev
Log:
Implement CFI for indirect calls via a member function pointer.
Similarly to CFI on virtual and indirect calls, this implementation
tries to use program type informati
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335569: Implement CFI for indirect calls via a member
function pointer. (authored by pcc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47567?vs=151272&id=152819#toc
Repository:
Author: ctopper
Date: Mon Jun 25 17:44:02 2018
New Revision: 335564
URL: http://llvm.org/viewvc/llvm-project?rev=335564&view=rev
Log:
[X86] Redefine avx512 packed fpclass intrinsics to return a vXi1 mask and
implement the mask input argument using an 'and' IR instruction.
Additional IR is emitte
(Sorry for the late reply...)
On Mon, Jun 25, 2018 at 2:45 PM Michael Kruse via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> I just revert if to have further discussions (r335516)
>
> Michael
>
> 2018-06-25 14:58 GMT-05:00 Eric Christopher :
> >
> >
> > On Mon, Jun 25, 2018 at 12:21 PM Rich
smeenai added a comment.
Okay, upon playing with this further, the following seems to do what I want
(for a custom sysroot), and seems to be a pretty common pattern as well:
set(CMAKE_FIND_ROOT_PATH_MODE_INCLUDE ONLY)
set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY ONLY)
set(CMAKE_FIND_ROOT_PATH_MOD
smeenai added a comment.
Ah, the documentation is confusing, but CMAKE_FIND_ROOT_PATH and
CMAKE_FIND_ROOT_PATH_MODE_PACKAGE only have an effect when using the config
mode of find_package, whereas this invocation is using the module mode. That's
a bummer, and definitely makes custom sysroots and
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335559: [analyzer] Track null and undef values through
expressions with cleanups. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48204?vs=151450&id=152810#toc
Author: dergachev
Date: Mon Jun 25 16:55:07 2018
New Revision: 335559
URL: http://llvm.org/viewvc/llvm-project?rev=335559&view=rev
Log:
[analyzer] Track null and undef values through expressions with cleanups.
ExprWithCleanups wraps full-expressions that require temporary destructors
and highligh
dblaikie added a comment.
This doesn't seem to build for me - so hard to debug/probe it:
llvm/src/tools/clang/lib/CodeGen/CGBuiltin.cpp:1264:65: error: no viable
conversion from 'clang::QualType' to 'llvm::Type *'
CGF.CGM.getDataLayout().getTypeSizeInBits(CanonicalType),
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1241
if (const llvm::APSInt *I =
- SVB.getKnownValue(State, nonloc::SymbolVal(S)))
+ SVB.getKnownValue(State, SVB.makeSymbolVal(S)))
return Loc::isLocTyp
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/SimpleSValBuilder.cpp:1241
if (const llvm::APSInt *I =
- SVB.getKnownValue(State, nonloc::SymbolVal(S)))
+ SVB.getKnownValue(State, SVB.makeSymbolVal(S)))
return Loc::isLocTyp
Author: dergachev
Date: Mon Jun 25 16:43:45 2018
New Revision: 33
URL: http://llvm.org/viewvc/llvm-project?rev=33&view=rev
Log:
[analyzer] Fix invalidation on C++ const methods with arrow syntax.
Conservative evaluation of a C++ method call would invalidate the object,
as long as the meth
This revision was automatically updated to reflect the committed changes.
Closed by commit rC33: [analyzer] Fix invalidation on C++ const methods
with arrow syntax. (authored by dergachev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48460?vs=152391&id=152805#toc
Repo
smeenai added a comment.
Actually, I would imagine that if you're cross-compiling or using a custom
sysroot, you should probably also specify CMAKE_FIND_ROOT_PATH and set
CMAKE_FIND_ROOT_PATH_MODE_PACKAGE to ONLY, to limit all these searches to the
desired directories?
(I'm actually playing ar
rtrieu added a comment.
Running this, I see that it causes a regression in one of the other ODR Hash
tests. Specifically, the diagnostics on line 1150 & 1151 of
test/Modules/odr_hash.cpp are not seen. Was that an expected side-effect of
this patch?
Repository:
rC Clang
https://reviews.ll
Author: yunlian
Date: Mon Jun 25 16:05:27 2018
New Revision: 335546
URL: http://llvm.org/viewvc/llvm-project?rev=335546&view=rev
Log:
Add an option to support debug fission on implicit ThinLTO.
Summary:
This adds an option -gsplit-dwarf=. LLVM can create .dwo files in the
given directory
during
Author: paquette
Date: Mon Jun 25 16:20:18 2018
New Revision: 335549
URL: http://llvm.org/viewvc/llvm-project?rev=335549&view=rev
Log:
[MachineOutliner] NFC - simplify -moutline/-mno-outline logic
It's a bit cleaner to use `hasFlag` instead of nested ifs. This
just refactors the -moutline/-mno-ou
I don't have an objection having another interface which is just a simple
wrapper to __gcov_flush but with default visibility. Also clearly document
its usage and behavior.
David
On Mon, Jun 25, 2018 at 10:12 AM, Chih-Hung Hsieh via Phabricator via
llvm-commits wrote:
> chh added a comment.
>
>
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335546: Add an option to support debug fission on implicit
ThinLTO. (authored by yunlian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D4478
Meinersbur added a comment.
In https://reviews.llvm.org/D48100#1142866, @erichkeane wrote:
> I'm currently attempting to remove the AttributeList's linked-listness.
Thank you. This should also resolve the non-optimal asymptotic execution time
to append new attributes at the end of the list.
srhines accepted this revision.
srhines added a comment.
Agree. This is the first time anyone is linking against static sanitizers on
Android, so this is just something that we missed updating in the past.
Repository:
rC Clang
https://reviews.llvm.org/D48570
__
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yunlian updated this revision to Diff 152794.
https://reviews.llvm.org/D44788
Files:
lib/Driver/ToolChains/CommonArgs.cpp
test/Driver/lto-dwo.c
Index: test/Driver/lto-dwo.c
===
--- /dev/null
+++ test/Driver/lto-dwo.c
@@ -0,0 +1
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D48342
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai added a comment.
Ping.
https://reviews.llvm.org/D47341
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Committed r335542
https://reviews.llvm.org/D47301
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Mon Jun 25 15:25:48 2018
New Revision: 335543
URL: http://llvm.org/viewvc/llvm-project?rev=335543&view=rev
Log:
Fix tests from r335542 to use %hmaptool
Modified:
cfe/trunk/test/Modules/framework-public-includes-private.m
Modified: cfe/trunk/test/Modules/framework-public-i
devnexen created this revision.
devnexen added a reviewer: dberris.
devnexen created this object with visibility "All Users".
Herald added a subscriber: cfe-commits.
- Base GNU ld is pretty old and does not support --dynamic-list flag.
- For conveniency we can add it automatically when compile wit
Author: bruno
Date: Mon Jun 25 15:24:17 2018
New Revision: 335542
URL: http://llvm.org/viewvc/llvm-project?rev=335542&view=rev
Log:
Warning for framework include violation from Headers to PrivateHeaders
Framework vendors usually layout their framework headers in the
following way:
Foo.framework/
ahatanak added a comment.
Yes, that is the case. It doesn't change overloading resolution, it is just
producing a diagnostic.
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
yunlian marked 2 inline comments as done.
yunlian added a comment.
ping?
https://reviews.llvm.org/D44788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
In https://reviews.llvm.org/D47757#1142886, @ahatanak wrote:
> I mean ToT clang (without my patch applied) seems to select the non-sized
> host version 'T::operator delete(void*)'.
OK, if this is just making an error out of something which previously silently
didn't wo
Whenever possible, do include context for why a patch is being reverted in
the commit message - buildbot links, but also potentially
describing/copy-pasting inline whatever the problem(s) are. This makes it
easier for people tracking the state of upstream to know whether they may
need to pull in th
ahatanak added a comment.
I mean ToT clang (without my patch applied) seems to select the non-sized host
version 'T::operator delete(void*)'.
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
cfe-commits@lists.llv
rsmith created this revision.
rsmith added a reviewer: dblaikie.
Herald added a subscriber: eraman.
We track when we see a name-shaped expression followed by a `<` token that we
parse as a comparison. Then:
- if we see a token sequence that cannot possibly be an expression but can be a
template
ahatanak added a comment.
The original comment said "call sized device delete even though host has
preferable non-sized version", but it seems that the non-sized host version
'T::operator delete(void*)' is being called in the IR, not the sized device
version of delete. Is that a bug in overload
Author: tstellar
Date: Mon Jun 25 14:50:42 2018
New Revision: 335540
URL: http://llvm.org/viewvc/llvm-project?rev=335540&view=rev
Log:
Creating release candidate final from release_601 branch
Added:
libunwind/tags/RELEASE_601/final/
- copied from r335539, libunwind/branches/release_60/
Author: tstellar
Date: Mon Jun 25 14:50:14 2018
New Revision: 335534
URL: http://llvm.org/viewvc/llvm-project?rev=335534&view=rev
Log:
Creating release candidate final from release_601 branch
Added:
libcxxabi/tags/RELEASE_601/final/
- copied from r335533, libcxxabi/branches/release_60/
Author: tstellar
Date: Mon Jun 25 14:50:10 2018
New Revision: 335533
URL: http://llvm.org/viewvc/llvm-project?rev=335533&view=rev
Log:
Creating release candidate final from release_601 branch
Added:
libcxx/tags/RELEASE_601/final/ (props changed)
- copied from r335532, libcxx/branches/
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
This has always been the case.
Repository:
rC Clang
https://reviews.llvm.org/D48570
___
cfe-commits mailing list
cfe-commits@lists.llvm
erichkeane added a comment.
In https://reviews.llvm.org/D48100#1142842, @rsmith wrote:
> This patch appears to have at least caused us to process attributes too many
> times in some cases. For example:
>
> __attribute__((noreturn,noinline,unused)) void f();
>
>
> before your patch gives this w
Meinersbur added inline comments.
Comment at: test/Sema/attr-micromips.c:9
-__attribute__((micromips,mips16)) void foo5(); // expected-error
{{'micromips' and 'mips16' attributes are not compatible}} \
+__attribute__((micromips,mips16)) void foo5(); // expected-error {{'mips
boga95 updated this revision to Diff 152778.
boga95 marked 3 inline comments as done.
boga95 added a comment.
Add std::srand check to C++ tests. Format patch.
https://reviews.llvm.org/D44143
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/ProperlyS
cryptoad created this revision.
cryptoad added reviewers: eugenis, pirama, srhines.
I am not sure anyone has tried to compile an application with sanitizers on
Android with `-static-libsan`, and a recent NDK, but it fails with:
.../i686-linux-android/bin/ld.gold: error: cannot find -lpthread
Author: meinersbur
Date: Mon Jun 25 13:06:13 2018
New Revision: 335516
URL: http://llvm.org/viewvc/llvm-project?rev=335516&view=rev
Log:
Revert "Append new attributes to the end of an AttributeList."
This reverts commit r335084 as requested by David Jones and
Eric Christopher because of differenc
bruno added inline comments.
Comment at: clang/lib/Lex/HeaderSearch.cpp:285
// directory.
-loadSubdirectoryModuleMaps(SearchDirs[Idx]);
+if (ModMap.getLangOpts().ObjC1 || ModMap.getLangOpts().ObjC2)
+ loadSubdirectoryModuleMaps(SearchDirs[Idx]);
I just revert if to have further discussions (r335516)
Michael
2018-06-25 14:58 GMT-05:00 Eric Christopher :
>
>
> On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits
> wrote:
>>
>> On 23 June 2018 at 22:34, Michael Kruse via cfe-commits
>> wrote:
>>>
>>> Hi,
>>>
>>> multiple comment
2018-06-25 14:20 GMT-05:00 Richard Smith :
> (I'm not sure what the problem is, but as a data point, Sema::checkCall
> iterates over the FormatAttrs in order, so it's possible that changing the
> order may have triggered a new warning. That may be due to a pre-existing
> order-dependence bug, or it
jlebar added a comment.
> @jlebar, is the change I made to call-host-fn-from-device.cu correct?
I don't think so -- that's a change in overloading behavior afaict.
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits mailing list
ahatanak added a reviewer: jlebar.
ahatanak added a subscriber: jlebar.
ahatanak added a comment.
ping.
@jlebar, is the change I made to call-host-fn-from-device.cu correct?
Repository:
rC Clang
https://reviews.llvm.org/D47757
___
cfe-commits ma
smeenai added reviewers: beanz, phosek.
smeenai added a comment.
I think it might be more appropriate to pass NO_SYSTEM_ENVIRONMENT_PATH to
find_package in case CMAKE_SYSROOT or CMAKE_CROSSCOMPILING are set? That way,
we won't search the host system for libxml2 in those cases, but we'll still be
rsmith added a comment.
This patch appears to have at least caused us to process attributes too many
times in some cases. For example:
__attribute__((noreturn,noinline,unused)) void f();
before your patch gives this with `clang -Xclang -ast-dump`:
`-FunctionDecl 0xccef1e0 <:1:1, col:50> co
erichkeane added inline comments.
Comment at: test/Sema/attr-target-mv.c:98
int __attribute__((target("sse4.2"))) diff_cc(void);
-// expected-error@+1 {{multiversioned function declaration has a different
calling convention}}
+// expected-error@+1 {{attribute 'target' multivers
Hi Nico,
Yes, I reverted because it broke one of the lldb build bots.
Next time I'll include the reason in the revert commit.
Gábor
On Mon, 25 Jun 2018, 22:50 Nico Weber, wrote:
> When reverting things, please say why in the commit message. (In this
> case, apparently because it broke the lld
When reverting things, please say why in the commit message. (In this case,
apparently because it broke the lldb buildbots?)
On Mon, Jun 25, 2018 at 12:30 PM Gabor Marton via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: martong
> Date: Mon Jun 25 09:25:30 2018
> New Revision: 335491
srhines added a comment.
Rui, I added you to this review (and the other corresponding one), as you
reviewed ecbeckmann's original work here. Can you take a quick look at these?
Thanks.
Repository:
rC Clang
https://reviews.llvm.org/D48459
___
cf
arphaman added inline comments.
Comment at: xpc/test-client/ClangdXPCTestClient.cpp:51
+ dlHandle, "clangd_xpc_get_bundle_identifier");
+ xpc_connection_t conn =
+ xpc_connection_create(clangd_xpc_get_bundle_identifier(), NULL);
We should probably
jkorous added a comment.
Followed by these two patches:
[clangd] JSON <-> XPC conversions
https://reviews.llvm.org/D48560
[clangd] XPC transport layer
https://reviews.llvm.org/D48562
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48559
phosek created this revision.
phosek added reviewers: mcgrathr, juliehockett, jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
Now that the structure of Fuchsia SDK has been formalized, we no
longer need to pass all the different CFLAGS/LDFLAGS to the CMake
build separately, we can sim
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, mgorny.
Previously we were using default logic when building Linux runtimes
in Fuchsia toolchain, but that leads to various issues due to how
the CMake logic in compiler-rt for determining the p
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny.
Implementation of alternative transport layer for macOS based on XPC.
Based on these two other patches:
https://reviews.llvm.org/D48559
https:/
jlebar added a comment.
@rsmith friendly ping on this one.
https://reviews.llvm.org/D48036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny.
This is a self-contained pair of utility functions for the XPC transport layer.
It's not dependent on but following the refactoring patch:
http
pcc added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1413
+ FD->getType(), Context.getRecordType(Base).getTypePtr()));
+ F->addTypeMetadata(0, Id);
+}
vlad.tsyrklevich wrote:
> It'd be nice to have a test that reaches t
jkorous created this revision.
jkorous added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, MaskRay, ioeric, ilya-biryukov, mgorny.
Hi all,
We finally finished a self-contained first version of our implementation of
alternative transport layer for macOS based on XPC.
To en
On Mon, Jun 25, 2018 at 12:21 PM Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On 23 June 2018 at 22:34, Michael Kruse via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Hi,
>>
>> multiple comments in the code indicate that the attribute order was
>> surprising and
echristo added subscribers: dlj, echristo.
echristo added a comment.
I've added a couple of inline comments here - between this and the comments in
the post-commit review from dlj it seems like we might want to revert this for
now and figure out the best way forward.
Thanks!
-eric
=
baloghadamsoftware updated this revision to Diff 152752.
baloghadamsoftware added a comment.
Comment fixed, assertions inserted, new tests added.
https://reviews.llvm.org/D35110
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h
lib/StaticAnalyzer/Core/RangeCon
vlad.tsyrklevich accepted this revision.
vlad.tsyrklevich added a comment.
This revision is now accepted and ready to land.
I think it would be clearer to replace uses of 'member function pointer' with
'pointer to member function'; however, a google search shows that the usage of
both terms is b
On 23 June 2018 at 22:34, Michael Kruse via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi,
>
> multiple comments in the code indicate that the attribute order was
> surprising and probably has lead to bugs, and will lead to bugs in the
> future. The order had to be explicitly reversed to a
rnkovacs added inline comments.
Comment at: test/Analysis/dangling-internal-buffer.cpp:10
const CharT *c_str();
+ const CharT *data();
};
xazax.hun wrote:
> Note that these methods are const according to the standard. Even if it does
> not make any differen
rnkovacs updated this revision to Diff 152737.
rnkovacs marked an inline comment as done.
https://reviews.llvm.org/D48532
Files:
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
test/Analysis/dangling-internal-buffer.cpp
Index: test/Analysis/dangling-internal-buffer.cpp
Author: sbc
Date: Mon Jun 25 11:47:32 2018
New Revision: 335510
URL: http://llvm.org/viewvc/llvm-project?rev=335510&view=rev
Log:
[WebAssembly] Add no-prototype attribute to prototype-less C functions
The WebAssembly backend in particular benefits from being
able to distinguish between varargs fu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335510: [WebAssembly] Add no-prototype attribute to
prototype-less C functions (authored by sbc, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4
shuaiwang added a comment.
Could someone help commit this now that the build issue with header include is
fixed? Thanks a lot!
(meanwhile I'm requesting commit access)
In https://reviews.llvm.org/D45679#1132327, @alexfh wrote:
> In https://reviews.llvm.org/D45679#1132086, @JonasToth wrote:
>
>
krytarowski added a comment.
ping^2
Repository:
rL LLVM
https://reviews.llvm.org/D47814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: morehouse
Date: Mon Jun 25 11:01:51 2018
New Revision: 335507
URL: http://llvm.org/viewvc/llvm-project?rev=335507&view=rev
Log:
[CMake] Fix install-cxx target.
Was broken by r334477.
Modified:
libcxx/trunk/include/CMakeLists.txt
Modified: libcxx/trunk/include/CMakeLists.txt
URL:
ht
Author: paquette
Date: Mon Jun 25 10:36:05 2018
New Revision: 335504
URL: http://llvm.org/viewvc/llvm-project?rev=335504&view=rev
Log:
[MachineOutliner] Outline from linkonceodrs by default in LTO when -moutline is
passed
Pass -enable-linkonceodr-outlining by default when LTO is enabled.
The ou
Author: paquette
Date: Mon Jun 25 10:27:51 2018
New Revision: 335503
URL: http://llvm.org/viewvc/llvm-project?rev=335503&view=rev
Log:
[MachineOutliner] Make last of -moutline/-mno-outline win
The expected behaviour of command-line flags to clang is to have
the last of -m(whatever) and -mno-(what
rnkovacs updated this revision to Diff 152719.
rnkovacs added a comment.
Fixed the constness of `c_str()` in the test file.
https://reviews.llvm.org/D48522
Files:
lib/StaticAnalyzer/Checkers/AllocationState.h
lib/StaticAnalyzer/Checkers/DanglingInternalBufferChecker.cpp
lib/StaticAnalyzer
chh added a comment.
In https://reviews.llvm.org/D45454#1142197, @marco-c wrote:
> In https://reviews.llvm.org/D45454#1070884, @belleyb wrote:
>
> > @chh I had a chance to try out your proposed changes. It's not causing us
> > any trouble. In fact, `__gcov_flush()` is not even used at all (at le
Author: arichardson
Date: Mon Jun 25 09:49:52 2018
New Revision: 335495
URL: http://llvm.org/viewvc/llvm-project?rev=335495&view=rev
Log:
Use Triple::isMIPS() instead of enumerating all Triples. NFC
Reviewed By: atanasyan
Differential Revision: https://reviews.llvm.org/D48549
Modified:
cfe/
This revision was automatically updated to reflect the committed changes.
Closed by commit rC335495: Use Triple::isMIPS() instead of enumerating all
Triples. NFC (authored by arichardson, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48549?vs=152696&id=152713#toc
Repositor
This revision was automatically updated to reflect the committed changes.
Closed by commit rL335492: [clang-format] Add a default format style that can
be used by users of… (authored by ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.or
Author: ioeric
Date: Mon Jun 25 09:29:19 2018
New Revision: 335492
URL: http://llvm.org/viewvc/llvm-project?rev=335492&view=rev
Log:
[clang-format] Add a default format style that can be used by users of
`getStyle`
Summary:
Tools that reformat code often call `getStyle` to decide the format styl
martong added a comment.
This is not trivial to fix. Reverting until we can reproduce and fix it.
Reverted with commit: r335491
Repository:
rC Clang
https://reviews.llvm.org/D47532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
Author: martong
Date: Mon Jun 25 09:25:30 2018
New Revision: 335491
URL: http://llvm.org/viewvc/llvm-project?rev=335491&view=rev
Log:
Revert "[ASTImporter] Import the whole redecl chain of functions"
This reverts commit r335480.
Modified:
cfe/trunk/include/clang/AST/ASTImporter.h
cfe/tru
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martong added a comment.
@labath
Sure, looking into it.
Repository:
rC Clang
https://reviews.llvm.org/D47532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MTC updated this revision to Diff 152702.
MTC added a comment.
Sorry for the long long delay, I was on the Dragon Boat Festival a few days ago.
This update has two parts:
- Use the `matchesName` to match the AST node with the specified name,
`matchesName` use regex to match the specified name.
martong updated this revision to Diff 152703.
martong added a comment.
- Rebase from master.
Repository:
rC Clang
https://reviews.llvm.org/D47632
Files:
include/clang/AST/ASTImporter.h
include/clang/AST/DeclBase.h
lib/AST/ASTImporter.cpp
lib/AST/ExternalASTMerger.cpp
Index: lib/AST/
klimek added inline comments.
Comment at: unittests/Format/FormatTest.cpp:4359
+ "return 3;\n"
+ " }).as("");\n"
+ "}");
ank wrote:
> klimek wrote:
> > ank wrote:
> > > klimek wrote:
> > > > What would be interesting
xazax.hun added inline comments.
Comment at: test/Analysis/dangling-internal-buffer.cpp:10
const CharT *c_str();
+ const CharT *data();
};
Note that these methods are const according to the standard. Even if it does
not make any difference for this check we
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LG!
Repository:
rC Clang
https://reviews.llvm.org/D48532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: abataev
Date: Mon Jun 25 08:32:05 2018
New Revision: 335483
URL: http://llvm.org/viewvc/llvm-project?rev=335483&view=rev
Log:
[OPENMP] Do not consider address constant vars as possibly
threadprivate.
Do not delay emission of the address constant variables in OpenMP mode
as they cannot be
1 - 100 of 152 matches
Mail list logo
