shuaiwang added a comment.

Could someone help commit this now that the build issue with header include is 
fixed? Thanks a lot!
(meanwhile I'm requesting commit access)

In https://reviews.llvm.org/D45679#1132327, @alexfh wrote:

> In https://reviews.llvm.org/D45679#1132086, @JonasToth wrote:
>
> > It might be the case, that the test is run with -no-stdinc (or similar),
> >  so the standard library is not available.
>
>
> Tests should be self-contained and must not depend on any system headers. 
> Standard library implementations may differ, which would make tests brittle. 
> Instead, tests should mock implementations of the APIs they work with (if 
> necessary, multiple times - once for every distinct standard library version 
> the check supports).


Yep. It doesn't include any headers anymore :)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45679



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to