sammccall added inline comments.
Comment at: clangd/FindSymbols.cpp:20
+#define DEBUG_TYPE "FindSymbols"
+
malaperle wrote:
> nit: I don't think this is used. Remove?
This is consumed by the LLVM_DEBUG macro. You can enable program-wide debug
output with -debu
On Wed, Jun 6, 2018 at 11:24 PM Richard Trieu via cfe-commits
wrote:
>
> Author: rtrieu
> Date: Wed Jun 6 20:20:30 2018
> New Revision: 334160
>
> URL: http://llvm.org/viewvc/llvm-project?rev=334160&view=rev
> Log:
> Change return value of trivial visibility check.
>
> Previous, if no Decl's were
Higuoxing updated this revision to Diff 150253.
Higuoxing added a reviewer: echristo.
Higuoxing added a comment.
update with comments & remove some useless blank lines.
https://reviews.llvm.org/D47687
Files:
lib/Sema/SemaExpr.cpp
test/Sema/parentheses.c
Index: test/Sema/parentheses.c
ethanhs created this revision.
ethanhs added a reviewer: bkramer.
Herald added a subscriber: cfe-commits.
This fixes all but one of the test cases for Windows. TestCDB will
take more work to debug, as CompilationDatabase seems not to work correctly.
Repository:
rC Clang
https://reviews.llvm.o
Author: rtrieu
Date: Wed Jun 6 20:20:30 2018
New Revision: 334160
URL: http://llvm.org/viewvc/llvm-project?rev=334160&view=rev
Log:
Change return value of trivial visibility check.
Previous, if no Decl's were checked, visibility was set to false. Switch it
so that in cases of no Decl's, return
leonardchan added inline comments.
Comment at: lib/AST/ExprConstant.cpp:9323
+ if (Value.isSigned() && Value.isMinSignedValue() && E->canOverflow() &&
+ !HandleOverflow(Info, E, -Value.extend(Value.getBitWidth() + 1),
+ E->getType()))
--
leonardchan updated this revision to Diff 150248.
leonardchan marked 20 inline comments as done.
leonardchan added a comment.
- Moved definition of the fractional/integral bits to TargetInfo. Checks are
also performed to make sure any target specific definitions of the F/IBits
follow the restric
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334159: [X86] Add back _mask, _maskz, and _mask3 builtins
for some 512-bit… (authored by ctopper, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D
Author: ctopper
Date: Wed Jun 6 19:46:02 2018
New Revision: 334159
URL: http://llvm.org/viewvc/llvm-project?rev=334159&view=rev
Log:
[X86] Add back _mask, _maskz, and _mask3 builtins for some 512-bit
fmadd/fmsub/fmaddsub/fmsubadd builtins.
Summary:
We recently switch to using a selects in the i
smeenai created this revision.
smeenai added reviewers: compnerd, DHowett-MSFT, rnk.
The windows-msvc target is meant to be ABI compatible with MSVC,
including the exception handling. Ensure that a windows-msvc triple
always equates to the MSVC personality being used.
This mostly affects the GNUS
Author: shenhan
Date: Wed Jun 6 17:55:54 2018
New Revision: 334155
URL: http://llvm.org/viewvc/llvm-project?rev=334155&view=rev
Log:
ClangTidy fix - 'clang::Sema::checkAllowedCUDAInitializer' has a definition
with different parameter names.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
Mod
@rnk I tried building spec2000/eon for Windows ARM64 and ran into these
errors:
use of undeclared identifier '_interlockedbittestandset_acq'
use of undeclared identifier '_interlockedbittestandset_rel'
use of undeclared identifier '_interlockedbittestandset_nf'
I see that you have removed them
Author: ssrivastava
Date: Wed Jun 6 17:42:59 2018
New Revision: 334153
URL: http://llvm.org/viewvc/llvm-project?rev=334153&view=rev
Log:
Change the wording of RTTI errors to make them more generic.
An attempt to use dynamic_cast while rtti is disabled, used to emit the error:
cannot use dynam
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334153: Change the wording of RTTI errors to make them more
generic. (authored by ssrivastava, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D47291
Files:
include/clang/Basic/Diagnos
Author: rtrieu
Date: Wed Jun 6 17:20:58 2018
New Revision: 334151
URL: http://llvm.org/viewvc/llvm-project?rev=334151&view=rev
Log:
[ODRHash] Adjust info stored for FunctionTemplateDecl.
Avoid storing information for definitions since those can be out-of-line and
vary between modules even when t
smeenai created this revision.
smeenai added reviewers: compnerd, mstorsjo, rnk.
The windows-msvc target is used for MSVC ABI compatibility, including
the exceptions model. It doesn't make sense to pair a windows-msvc
target with a non-MSVC exception model. This would previously cause an
assertion
ABataev added a comment.
Add tests for C++ and move OpenMP specific tests to OpenMP directory
Comment at: lib/Headers/__clang_cuda_device_functions.h:28
+#if defined(_OPENMP)
+#include <__clang_cuda_libdevice_declares.h>
+#include
Do we really need to include
ahatanak added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:7117
+if (E && S.checkNonNullExpr(E))
+ return NullabilityKind::Nullable;
+
jordan_rose wrote:
> This isn't quite correct, unfortunately. `(_Nonnull id)nil` should be
> considered non-nul
ahatanak updated this revision to Diff 150218.
ahatanak marked an inline comment as done.
ahatanak added a reviewer: dcoughlin.
ahatanak set the repository for this revision to rC Clang.
ahatanak added a comment.
Sorry for the delay in responding. I've addressed Jordan's review comments.
I had to
gtbercea created this revision.
gtbercea added reviewers: Hahnfeld, tra, hfinkel, carlo.bertolli, caomhin,
ABataev.
Herald added subscribers: cfe-commits, guansong, mgorny.
In current Clang, on the OpenMP NVPTX toolchain, math functions are resolved as
math functions for the host. For example, a
morehouse added inline comments.
Comment at: tools/clang-fuzzer/CMakeLists.txt:28
protobuf_generate_cpp(PROTO_SRCS PROTO_HDRS cxx_proto.proto)
+ protobuf_generate_cpp(PROTO_SRCS PROTO_HDRS cxx_loop_proto.proto)
set(LLVM_OPTIONAL_SOURCES ${LLVM_OPTIONAL_SOURCES} ${PROTO_SRC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334145: [Driver] Stop passing -fseh-exceptions for
x86_64-windows-msvc (authored by smeenai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47850
Author: smeenai
Date: Wed Jun 6 16:09:02 2018
New Revision: 334145
URL: http://llvm.org/viewvc/llvm-project?rev=334145&view=rev
Log:
[Driver] Stop passing -fseh-exceptions for x86_64-windows-msvc
-fseh-exceptions is only meaningful for MinGW targets, and that driver
already has logic to pass eit
ahatanak updated this revision to Diff 150211.
ahatanak marked an inline comment as done.
ahatanak retitled this revision from "[Sema] Diagnose unavailable aligned
deallocation functions called from deleting destructors." to "[Sema] Produce
diagnostics when unavailable aligned allocation/dealloca
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rC Clang
https://reviews.llvm.org/D47850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
emmettneyman updated this revision to Diff 150213.
emmettneyman added a comment.
- Combined two header files into one
Repository:
rC Clang
https://reviews.llvm.org/D47843
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp
tools/clang-fuzzer/cxx_
smeenai created this revision.
smeenai added reviewers: compnerd, mstorsjo, rnk.
Herald added subscribers: JDevlieghere, aprantl.
-fseh-exceptions is only meaningful for MinGW targets, and that driver
already has logic to pass either -fdwarf-exceptiosn or -fseh-exceptions
as appropriate. -fseh-exc
Author: tra
Date: Wed Jun 6 15:37:25 2018
New Revision: 334143
URL: http://llvm.org/viewvc/llvm-project?rev=334143&view=rev
Log:
[CUDA] Check initializers of instantiated template variables.
We were already performing checks on non-template variables,
but the checks on templated ones were missin
morehouse added inline comments.
Comment at: tools/clang-fuzzer/cxx_loop_proto.proto:93
+
+message Function {
+ required StatementSeq statements = 1;
Maybe call this `LoopFunction` to distinguish from the other protobuf.
Comment at: tools/clan
craig.topper added a comment.
It looks like gcc implements additional bits that can be passed to
_atomic_exchange and friends, __ATOMIC_HLE_ACQUIRE(1 << 16) and
__ATOMIC_HLE_RELEASE(1 << 17). Basically they're using bits above bit 16 in the
order/memory_model as target specific flags. These con
Hello everyone,
LLVM buildmaster will be updated and restarted after 6PM Pacific time today.
Thanks
Galina
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ruiu added a comment.
So the best practice is, when you get a UTF-16 string from an Windows API, you
should convert it to UTF-8 as soon as you can so that you can always process
strings as UTF-8. Likewise, you should always keep all string in UTF-8 in
memory and convert them to UTF-16 just befo
malaperle added inline comments.
Comment at: unittests/clangd/FindSymbolsTests.cpp:39
}
+MATCHER_P(QName, Name, "") {
+ if (arg.containerName.empty())
I updated the other tests to use this in https://reviews.llvm.org/D47847
Repository:
rCTE Clang Tools Extr
stephanemoore added reviewers: benhamilton, jolesiak, djasper.
stephanemoore added a comment.
I believe I have consensus that this is the correct change for Google
Objective-C style.
Repository:
rC Clang
https://reviews.llvm.org/D47393
___
cfe-c
ruiu added a comment.
It seems you converted the same string back and forth between UTF-8 and UTF-16
to call Windows functions and LLVM functions. That's not only a waste of time
(which is not a big problem) but complicates the code.
I'd define `std::error GetExecutableName(std::string &Result)
malaperle created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
Instead of checking symbol name and container (scope) separately, check the
qualified name instead. This is much shorter and similar to how it is done
in the SymbolCollector tests.
Sig
emmettneyman updated this revision to Diff 150200.
emmettneyman added a comment.
Hopefully rebased correctly.
Repository:
rC Clang
https://reviews.llvm.org/D47843
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp
tools/clang-fuzzer/cxx_loop_pro
malaperle added a comment.
This works much better! Just a nit.
Comment at: clangd/FindSymbols.cpp:20
+#define DEBUG_TYPE "FindSymbols"
+
nit: I don't think this is used. Remove?
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47821
__
malaperle created this revision.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
An AST-based approach is used to retrieve the document symbols rather than an
in-memory index query. The index is not an ideal fit to achieve this because of
the file-centric query bein
morehouse added a comment.
This contains changes from previous patch. Please rebase.
Repository:
rC Clang
https://reviews.llvm.org/D47843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
vitalybuka requested changes to this revision.
vitalybuka added inline comments.
This revision now requires changes to proceed.
Comment at: tools/clang-fuzzer/fuzzer-initialize/fuzzer_initialize.cpp:23
+
+namespace clang_fuzzer {
+
I guess you already committed t
tra created this revision.
tra added reviewers: jlebar, arsenm.
Herald added subscribers: bixia, wdng, sanjoy, jholewinski.
They were hot even hooked into CGBuiltin's machinery. Even if they were,
CUDA does not support AS-specific pointers, so there would be no legal way
no way to call these built
emmettneyman updated this revision to Diff 150192.
emmettneyman added a comment.
Took out typo'd comment
Repository:
rC Clang
https://reviews.llvm.org/D47843
Files:
tools/clang-fuzzer/CMakeLists.txt
tools/clang-fuzzer/ExampleClangLoopProtoFuzzer.cpp
tools/clang-fuzzer/ExampleClangProto
emmettneyman created this revision.
emmettneyman added reviewers: kcc, vitalybuka, morehouse.
Herald added subscribers: cfe-commits, mgorny.
Created a new protobuf and protobuf-to-C++ "converter" that wraps the entire
C++ code in a single for loop.
- Slightly changed cxx_proto.proto -> cxx_loop_
ethanhs added inline comments.
Comment at: lib/Headers/immintrin.h:387
+#if defined(__i386__) || defined(__x86_64__)
+static __inline__ long __DEFAULT_FN_ATTRS
+_InterlockedExchange_HLEAcquire(long volatile *_Target, long _Value) {
craig.topper wrote:
> what is _
ethanhs updated this revision to Diff 150189.
ethanhs added a comment.
Guard to be used only under MSVC, define default FN attrs
Repository:
rC Clang
https://reviews.llvm.org/D47672
Files:
lib/Headers/immintrin.h
lib/Headers/intrin.h
Index: lib/Headers/intrin.h
=
craig.topper added inline comments.
Comment at: lib/Headers/immintrin.h:387
+#if defined(__i386__) || defined(__x86_64__)
+static __inline__ long __DEFAULT_FN_ATTRS
+_InterlockedExchange_HLEAcquire(long volatile *_Target, long _Value) {
what is __DEFAULT_FN_ATTRS
efriedma added a comment.
Is this something which is actually useful to control? From your description,
you want to add the flag to clang not because you actually want to use it, but
just because you can't figure out how to pass the right flags to your clang
build.
If it is useful, it should
This revision was automatically updated to reflect the committed changes.
yaxunl marked 3 inline comments as done.
Closed by commit rC334128: [HIP] Fix unbundling (authored by yaxunl, committed
by ).
Changed prior to commit:
https://reviews.llvm.org/D47555?vs=149191&id=150188#toc
Repository:
Author: yaxunl
Date: Wed Jun 6 12:44:10 2018
New Revision: 334128
URL: http://llvm.org/viewvc/llvm-project?rev=334128&view=rev
Log:
[HIP] Fix unbundling
HIP uses clang-offload-bundler to bundle intermediate files for host
and different gpu archs together. When a file is unbundled,
clang-offload-
craig.topper added a comment.
Fair enough, Then I think we should have a #ifdef _MSC_VER around them so they
are only available when pretending to be MSVC. I believe intrin.h does that
check very early in the file.
Repository:
rC Clang
https://reviews.llvm.org/D47672
Author: rksimon
Date: Wed Jun 6 12:31:39 2018
New Revision: 334122
URL: http://llvm.org/viewvc/llvm-project?rev=334122&view=rev
Log:
Fix MSVC 'not all control paths return a value' warning. NFCI.
Modified:
clang-tools-extra/trunk/clang-doc/tool/ClangDocMain.cpp
Modified: clang-tools-extra/t
ethanhs marked an inline comment as done.
ethanhs added a comment.
In https://reviews.llvm.org/D47672#1123953, @craig.topper wrote:
> We (Intel) have discussed this a little internally. I'll be responding more
> shortly.
Great!
FWIW, re intrin.h vs immintrin.h, the documentation for these put
arsenm updated this revision to Diff 150179.
arsenm added a comment.
Rebase and add comment
https://reviews.llvm.org/D47154
Files:
include/clang/AST/ASTContext.h
include/clang/Basic/BuiltinsAMDGPU.def
include/clang/Basic/TargetInfo.h
lib/AST/ASTContext.cpp
lib/Basic/Targets/AMDGPU.h
arsenm added inline comments.
Comment at: include/clang/Basic/BuiltinsAMDGPU.def:49
+
+// FIXME: Need to disallow constant address space.
BUILTIN(__builtin_amdgcn_div_scale, "dddbb*", "n")
Anastasia wrote:
> Do you plan to provide the support for it later? Or if
yaxunl marked 3 inline comments as done.
yaxunl added inline comments.
Comment at: lib/Driver/Driver.cpp:3895
+if (UI.DependentOffloadKind == Action::OFK_Host)
+ Arch = StringRef();
+else
tra wrote:
> Should it be something more descripti
aaron.ballman added subscribers: hans, joerg.
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1115352, @jfb wrote:
> Hopefully this makes sense? I'm not sure I summarize my context very well.
> I'm happy to talk about it in-person next week too.
I appreciate the in-person con
Author: evandro
Date: Wed Jun 6 11:58:01 2018
New Revision: 334116
URL: http://llvm.org/viewvc/llvm-project?rev=334116&view=rev
Log:
[PATCH 2/2] [test] Add support for Samsung Exynos M4 (NFC)
Add test cases for Exynos M4.
Modified:
cfe/trunk/test/CodeGen/arm-target-features.c
cfe/trunk/
george.burgess.iv created this revision.
george.burgess.iv added reviewers: rsmith, aaron.ballman.
The following code is invalid before C99, since we try to declare `i` inside
the first clause of the for loop:
void foo() {
for (int i = 0; i < 10; i++);
}
GCC does not accept this code in
craig.topper added a comment.
We (Intel) have discussed this a little internally. I'll be responding more
shortly.
Comment at: lib/Headers/immintrin.h:386
+\**/
+#if defined(__i386__) || defined(__x86_
rnk added a comment.
Thanks for the patch!
Repository:
rC Clang
https://reviews.llvm.org/D47784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334112: [MS][ARM64]: Promote _setjmp to_setjmpex as there is
no _setjmp in the ARM64… (authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47784?vs=149984&id=150171#toc
Author: rnk
Date: Wed Jun 6 11:39:47 2018
New Revision: 334112
URL: http://llvm.org/viewvc/llvm-project?rev=334112&view=rev
Log:
[MS][ARM64]: Promote _setjmp to_setjmpex as there is no _setjmp in the ARM64
libvcruntime.lib
Factor out the common setjmp call emission code.
Based on a patch by Ch
This revision was automatically updated to reflect the committed changes.
Closed by commit rC334108: [CUDA] Replace 'nv_weak' attributes in
CUDA headers with 'weak'. (authored by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47804?vs=150055&id=150166#toc
Repository:
Author: tra
Date: Wed Jun 6 10:52:55 2018
New Revision: 334108
URL: http://llvm.org/viewvc/llvm-project?rev=334108&view=rev
Log:
[CUDA] Replace 'nv_weak' attributes in CUDA headers with 'weak'.
Differential Revision: https://reviews.llvm.org/D47804
Modified:
cfe/trunk/lib/Headers/__clang_cu
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
Few minor nits/suggestions. LGTM otherwise.
Comment at: lib/Driver/Driver.cpp:3895
+if (UI.DependentOffloadKind == Action::OFK_Host)
+ Arch = StringRef();
+
tkrupa accepted this revision.
tkrupa added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D47724
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
tra added a comment.
@rsmith - Richard, can you take a look?
Comment at: test/CodeGenCUDA/kernel-args.cu:1-2
+// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fcuda-is-device -emit-llvm %s -o
- | FileCheck -check-prefix=AMDGCN %s
+// RUN: %clang_cc1 -triple nvptx64-nvidia-cuda- -
dmgreen added a comment.
In https://reviews.llvm.org/D47267#1123318, @hfinkel wrote:
> I have a preference for using the underscores as our primary spelling. I
> think that it's easier to read.
I agree with it being easier to read.
> I prefer we have a different syntax that we can use consist
Author: rsmith
Date: Wed Jun 6 09:36:56 2018
New Revision: 334106
URL: http://llvm.org/viewvc/llvm-project?rev=334106&view=rev
Log:
PR37680: fix faulty assertion condition.
When looking up a template name, we can find an overload set containing a
function template and an unresolved non-type usin
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D47291
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
juliehockett closed this revision.
juliehockett added a comment.
Closed in r334103 .
https://reviews.llvm.org/D43667
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: juliehockett
Date: Wed Jun 6 09:13:17 2018
New Revision: 334103
URL: http://llvm.org/viewvc/llvm-project?rev=334103&view=rev
Log:
[clang-doc] Implement a YAML generator
Implmenting a YAML generator from the emitted bitcode summary of
declarations. Emits one YAML file for each declaration
chill updated this revision to Diff 150148.
chill added a comment.
Update: refactor a bit to not impose size overhead on targets, which don't use
natural alignment.
https://reviews.llvm.org/D46013
Files:
include/clang/AST/ASTContext.h
include/clang/AST/RecordLayout.h
lib/AST/ASTContext.c
sdardis created this revision.
sdardis added a reviewer: rsmith.
Herald added a reviewer: javed.absar.
Herald added subscribers: atanasyan, kristof.beyls, arichardson.
As reported in GCC bug #86069, LLVM currently provokes a bug in GCC where
objects compiled for MIPS with PIC and optimizations whe
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: docs/clang-tidy/checks/bugprone-exception-escape.rst:6
+
+Finds functions which should not throw exceptions:
+* Destructors
I don't
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334101: [clang-tidy] Store checks profiling info as JSON
files (authored by lebedevri, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46602?vs=149933&id=150142#toc
Repository:
rL
Author: lebedevri
Date: Wed Jun 6 08:07:51 2018
New Revision: 334101
URL: http://llvm.org/viewvc/llvm-project?rev=334101&view=rev
Log:
[clang-tidy] Store checks profiling info as JSON files
Summary:
Continuation of D46504.
Example output:
```
$ clang-tidy -enable-check-profile -store-check-pr
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clangd/FindSymbols.cpp:159
+else
+ return;
+Relevance.merge(Sym);
Should we add a log statement here? IMO, this rarely happens
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D45927
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
lebedev.ri added a comment.
In https://reviews.llvm.org/D46602#1123631, @alexfh wrote:
> LG
Thank you for the review!
Repository:
rL LLVM
https://reviews.llvm.org/D46602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D46602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
gramanas updated this revision to Diff 150135.
gramanas added a comment.
make code more readable
Repository:
rC Clang
https://reviews.llvm.org/D47720
Files:
lib/CodeGen/CGExprScalar.cpp
test/CodeGen/debug-info-inline-for.c
Index: test/CodeGen/debug-info-inline-for.c
===
aprantl added inline comments.
Comment at: lib/CodeGen/CGDecl.cpp:1949
+ // Set artificial debug location in order to preserve the scope
+ auto DL = ApplyDebugLocation::CreateArtificial(*this);
Can you make that comment elaborate more about why this is being
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334096: [Driver] Add flag "--dependent-lib=..."
when enabling asan or ubsan on PS4. (authored by pgousseau, committed by )
Author: pgousseau
Date: Wed Jun 6 07:04:15 2018
New Revision: 334096
URL: http://llvm.org/viewvc/llvm-project?rev=334096&view=rev
Log:
[Driver] Add flag "--dependent-lib=..." when enabling asan or ubsan on PS4.
NFC for targets other than PS4.
Simplify users' workflow when enabling asan or ubsan
gtbercea added a comment.
@tra Thank you for your comments and help with the patch.
Repository:
rC Clang
https://reviews.llvm.org/D47394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
pgousseau updated this revision to Diff 150124.
pgousseau added a comment.
Updated patch with requested changes.
https://reviews.llvm.org/D47375
Files:
lib/Driver/ToolChains/Clang.cpp
lib/Driver/ToolChains/PS4CPU.cpp
lib/Driver/ToolChains/PS4CPU.h
test/Driver/fsanitize.c
test/Driver/s
gramanas added a comment.
What about this? Ping!
Repository:
rC Clang
https://reviews.llvm.org/D47097
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: tnorthover
Date: Wed Jun 6 06:28:49 2018
New Revision: 334093
URL: http://llvm.org/viewvc/llvm-project?rev=334093&view=rev
Log:
Add semicolon to recent MSVC fix.
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Modified: clang-tools-extra/trunk/clangd/Quality.cpp
URL:
http://ll
krasimir added inline comments.
Comment at: lib/Format/TokenAnnotator.cpp:1566
-if (PrevToken->is(tok::coloncolon))
+if (PrevToken->isOneOf(tok::coloncolon, tok::kw_const))
return TT_PointerOrReference;
I'd also check for `volatile` here, for exa
Author: rksimon
Date: Wed Jun 6 05:48:27 2018
New Revision: 334091
URL: http://llvm.org/viewvc/llvm-project?rev=334091&view=rev
Log:
Fix MSVC 'implicit double to float truncation and 'not all control paths return
a value' warnings. NFCI.
Modified:
clang-tools-extra/trunk/clangd/Quality.cpp
Author: sammccall
Date: Wed Jun 6 05:38:37 2018
New Revision: 334089
URL: http://llvm.org/viewvc/llvm-project?rev=334089&view=rev
Log:
[clangd] Boost fuzzy match score by 2x (so a maximum of 2) when the query is
the full identifier name.
Summary: Fix a couple of bugs in tests an in Quality to k
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334089: [clangd] Boost fuzzy match score by 2x (so a maximum
of 2) when the query is… (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://re
sammccall updated this revision to Diff 150117.
sammccall added a comment.
Explain WordN == PatN criterion for an exact match.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47815
Files:
clangd/FuzzyMatch.cpp
clangd/FuzzyMatch.h
clangd/Quality.cpp
clangd/Quality.h
uni
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
sammccall updated this revision to Diff 150115.
sammccall added a comment.
Add test that _f isn't a reserved name.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47707
Files:
clangd/Quality.cpp
clangd/Quality.h
unittests/clangd/QualityTests.cpp
Index: unittests/clangd/Qu
sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric, ilya-biryukov.
The index doesn't actually return results in ranked order.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47821
Files:
clangd/F
Hmm. SVN does not want me to commit anything :/
I will retry later today, but maybe i cant commit.
Best, Jonas
Am 06.06.2018 um 10:47 schrieb Aaron Ballman:
> On Wed, Jun 6, 2018 at 4:40 AM Jonas Toth via Phabricator
> wrote:
>> JonasToth added a comment.
>>
>> @shuaiwang I can commit it in
filcab added a comment.
I have a minor nit + what Paul mentioned (missing a `-NOT` check). Otherwise
LGTM.
Comment at: lib/Driver/ToolChains/Clang.cpp:3690
- // Add runtime flag for PS4 when PGO or Coverage are enabled.
- if (RawTriple.isPS4CPU())
+ // Add runtime flag fo
1 - 100 of 122 matches
Mail list logo
