ahatanak added inline comments.
================ Comment at: lib/Sema/SemaExpr.cpp:7117 + if (E && S.checkNonNullExpr(E)) + return NullabilityKind::Nullable; + ---------------- jordan_rose wrote: > This isn't quite correct, unfortunately. `(_Nonnull id)nil` should be > considered non-nullable, since it's the canonical way to avoid all these > warnings. It might just be good enough to move this check below the > `getNullability` one, though. Sema::CheckNonNullExpr checks the nullability of the type of the expression first and returns false if there is a cast to `_Nonnull`. Repository: rC Clang https://reviews.llvm.org/D22391 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
