jlaz added a comment.
@jbcoe could you commit this change? I don't have repository access for commit.
Thank you.
Repository:
rC Clang
https://reviews.llvm.org/D46383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
mstorsjo added a comment.
In https://reviews.llvm.org/D46520#1092233, @rnk wrote:
> Please don't do this, this is actually really problematic, since `#line`
> directives lose information about what's a system header. That means the
> result of -E usually won't compile, since Windows headers are
This revision was automatically updated to reflect the committed changes.
jfb marked an inline comment as done.
Closed by commit rC331845: _Atomic of empty struct shouldn't assert
(authored by jfb, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46613?vs=145858&id=145859#toc
Author: jfb
Date: Tue May 8 20:51:12 2018
New Revision: 331845
URL: http://llvm.org/viewvc/llvm-project?rev=331845&view=rev
Log:
_Atomic of empty struct shouldn't assert
Summary:
An _Atomic of an empty struct is pretty silly. In general we just widen empty
structs to hold a byte's worth of stor
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D46613
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
jfb marked an inline comment as done.
jfb added inline comments.
Comment at: lib/AST/ASTContext.cpp:1965
+ Width = Target->getCharWidth();
+ Align = Target->getCharWidth();
+} else if (Width <= Target->getMaxAtomicPromoteWidth()) {
rjmccall wrote:
>
jfb updated this revision to Diff 145858.
jfb added a comment.
- Assert on zero alignment, instead of making it always byte-aligned.
Repository:
rC Clang
https://reviews.llvm.org/D46613
Files:
lib/AST/ASTContext.cpp
test/CodeGen/c11atomics-ios.c
test/CodeGen/c11atomics.c
Index: test/
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331843: [DebugInfo] Generate debug information for labels.
(authored by shiva, committed by ).
Changed prior to commit:
Quuxplusone added a comment.
> Can you post the diagnostic exactly as it appears in the compiler output? I
> am surprised that it would appear here. It should appear here only if the
> standard library's implicit conversion from std::map<...>::iterator to
> std::map<...>::const_iterator were im
rjmccall added inline comments.
Comment at: lib/AST/ASTContext.cpp:1965
+ Width = Target->getCharWidth();
+ Align = Target->getCharWidth();
+} else if (Width <= Target->getMaxAtomicPromoteWidth()) {
Alignment, unlike size, is definitely never 0. I
rjmccall added a comment.
In https://reviews.llvm.org/D42933#1092077, @smeenai wrote:
> Apple's current recommendation for using printf with the NSInteger types is
> casting to a long, per
> https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/Strings/Articles/formatSpecif
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331834: Remove \brief commands from doxygen comments.
(authored by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46320?vs=144736&id=
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331834: Remove \brief commands from doxygen comments.
(authored by adrian, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46320?vs=144736&id=145831#toc
Repository:
rC Clang
https
Author: phosek
Date: Tue May 8 17:58:12 2018
New Revision: 331833
URL: http://llvm.org/viewvc/llvm-project?rev=331833&view=rev
Log:
Set CMAKE_BUILD_WITH_INSTALL_RPATH for Fuchsia runtimes
This doesn't make any difference since we don't use RPATH/RUNPATH
on Fuchsia but it avoids the CMake error w
jakehehrlich accepted this revision.
jakehehrlich added a comment.
This revision is now accepted and ready to land.
Spoke offline, LGTM
Repository:
rC Clang
https://reviews.llvm.org/D46610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
jfb added a comment.
In https://reviews.llvm.org/D45470#1092212, @vsapsai wrote:
> Here is another approach that should emit an error only when mixing headers
> causes compilation problems.
>
> Have no ideas how to test the change. `-verify` doesn't work with fatal errors
> and libcxx doesn't u
juliehockett created this revision.
juliehockett added a reviewer: aaron.ballman.
juliehockett added a project: clang-tools-extra.
Herald added subscribers: jkorous, kbarton, ioeric, nemanjai.
[[ https://reviews.llvm.org/D46614 | [https://reviews.llvm.org/D46614] ]] adds
SrcMgr::CharacteristicKi
juliehockett created this revision.
juliehockett added a reviewer: aaron.ballman.
juliehockett added a project: clang.
Herald added subscribers: kbarton, nemanjai.
Adding a SrcMgr::CharacteristicKind parameter to the InclusionDirective in
PPCallbacks, and updating calls to that function. This wil
rnk reopened this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Please don't do this, this is actually really problematic, since `#line`
directives lose information about what's a system header. That means the result
of -E usually won't compile, since Windows he
jfb created this revision.
jfb added reviewers: arphaman, rjmccall.
Herald added subscribers: cfe-commits, aheejin.
An _Atomic of an empty struct is pretty silly. In general we just widen empty
structs to hold a byte's worth of storage, and we represent size and alignment
as 0 internally and let
rnk added inline comments.
Comment at: include/clang/Basic/Attr.td:1494
+def NoStackProtector : InheritableAttr {
+ let Spellings = [GCC<"no_stack_protector">];
+ let Subjects = SubjectList<[Function]>;
aaron.ballman wrote:
> manojgupta wrote:
> > aaron.ballman
jakehehrlich added a comment.
Need some clarification on this option
1. The rpath is the path from which libs mentioned in .dynamic are relative to?
2. Normally cmake first links binaries without setting the RPATH and then sets
it later.
3. This makes RPATH always equal to the empty string and a
Author: phosek
Date: Tue May 8 17:05:28 2018
New Revision: 331826
URL: http://llvm.org/viewvc/llvm-project?rev=331826&view=rev
Log:
[CMake] Include llvm-strip in Fuchsia toolchain distribution
Now that llvm-strip is available, include it in the Fuchsia toolchain.
Differential Revision: https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rC331826: [CMake] Include llvm-strip in Fuchsia toolchain
distribution (authored by phosek, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46612?vs=145815&id=145818#toc
Repository:
vsapsai updated this revision to Diff 145817.
vsapsai added a comment.
Here is another approach that should emit an error only when mixing headers
causes compilation problems.
Have no ideas how to test the change. `-verify` doesn't work with fatal errors
and libcxx doesn't use FileCheck. Performe
vsapsai reopened this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
`__ALLOW_STDC_ATOMICS_IN_CXX__` approach didn't work in practice, I've reverted
all changes.
Repository:
rC Clang
https://reviews.llvm.org/D45470
_
phosek created this revision.
phosek added a reviewer: jakehehrlich.
Herald added subscribers: cfe-commits, mgorny.
Now that llvm-strip is available, include it in the Fuchsia toolchain.
Repository:
rC Clang
https://reviews.llvm.org/D46612
Files:
clang/cmake/caches/Fuchsia-stage2.cmake
I
phosek added a comment.
Actually after testing this I believe this is really what we want, without this
option CMake sets RPATH for build libraries and then removes it when installing
these. With this option it doesn't even set the RPATH for build libraries.
Repository:
rC Clang
https://rev
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added subscribers: cfe-commits, mgorny.
This doesn't make any difference since we don't use RPATH/RUNPATH
on Fuchsia but it avoids the CMake error when re-linking libraries
while building with Ninja.
Repository:
rC Clang
jfb added a comment.
In https://reviews.llvm.org/D42933#1092077, @smeenai wrote:
> In https://reviews.llvm.org/D42933#1092048, @rjmccall wrote:
>
> > I agree that the format-specifier checker is not intended to be a
> > portability checker.
>
I don't disagree with the original intent, but AFAI
lebedev.ri added a comment.
In https://reviews.llvm.org/D46603#1092135, @george.karpenkov wrote:
> @lebedev.ri LLVM already has facilities for outputting statistics in JSON, it
> seems that would be sufficient for your purposes?
> I did something similar for the static analyzer in
> https://re
Author: lebedevri
Date: Tue May 8 16:15:58 2018
New Revision: 331822
URL: http://llvm.org/viewvc/llvm-project?rev=331822&view=rev
Log:
Partially revert r331456: [clang-tidy] Remove AnalyzeTemporaryDtors option.
That broke every single .clang-tidy config out there
which happened to specify Analyz
george.karpenkov added a comment.
@lebedev.ri LLVM already has facilities for outputting statistics in JSON, it
seems that would be sufficient for your purposes?
I did something similar for the static analyzer in
https://reviews.llvm.org/D43131
Repository:
rL LLVM
https://reviews.llvm.org/D
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D46332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: vsapsai
Date: Tue May 8 15:50:35 2018
New Revision: 331818
URL: http://llvm.org/viewvc/llvm-project?rev=331818&view=rev
Log:
Revert "Emit an error when mixing and "
It reverts commit r331379 because turned out `__ALLOW_STDC_ATOMICS_IN_CXX__`
doesn't work well in practice.
Removed:
rja added a comment.
+1 for JSON
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lebedev.ri added a comment.
In https://reviews.llvm.org/D46602#1092084, @Eugene.Zelenko wrote:
> I think will be good idea to store data in JSON format too.
Yeah, i have thought about it, and i'm not sure.
The output is so dumb so there isn't even much point in using anything more
advanced tha
Eugene.Zelenko added a comment.
I think will be good idea to store data in JSON format too.
Comment at: docs/ReleaseNotes.rst:60
+- clang-tidy learned to store checks profiling info as CSV files.
+
May be //Profile information could be stored in SSV format.//
Author: sas
Date: Tue May 8 12:46:29 2018
New Revision: 331802
URL: http://llvm.org/viewvc/llvm-project?rev=331802&view=rev
Log:
Add missing newlines to cl::extrahelp uses
Modified:
cfe/trunk/docs/LibASTMatchersTutorial.rst
cfe/trunk/docs/LibTooling.rst
cfe/trunk/include/clang/Toolin
smeenai added a comment.
In https://reviews.llvm.org/D42933#1092048, @rjmccall wrote:
> I agree that the format-specifier checker is not intended to be a portability
> checker.
>
> Any attempt to check portability problems has to account for two things:
>
> - Not all code is intended to be porta
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/RestrictSystemIncludesCheck.cpp:67
+ llvm::SmallDenseMap IncludeDirectives;
+ llvm::StringMap IsSystem;
+
Rather than use this `StringMap`, can you change `InclusionDirective()` to
filter out
lebedev.ri added subscribers: cfe-commits, alexfh, lebedev.ri.
lebedev.ri raised a concern with this commit.
lebedev.ri added a comment.
Every single `.clang-tidy` config file that still happens to contain
`AnalyzeTemporaryDtors: true/false` param specified is now **silently** (!)
ignored,
and a
rjmccall added a comment.
I agree that the format-specifier checker is not intended to be a portability
checker.
Any attempt to check portability problems has to account for two things:
- Not all code is intended to be portable. If you're going to warn about
portability problems, you need som
lebedev.ri created this revision.
lebedev.ri added reviewers: alexfh, sbenza, bkramer, george.karpenkov.
This is needed for the continuation of https://reviews.llvm.org/D46504,
to be able to store the timings as CSV.
The floating-point values are dumped with no precision loss.
See dependent diff
lebedev.ri created this revision.
lebedev.ri added reviewers: alexfh, sbenza.
Herald added subscribers: mgrang, xazax.hun.
Continuation of https://reviews.llvm.org/D46504.
Example output:
$ clang-tidy -enable-check-profile -store-check-profile=.
-store-check-profile-elide-prefix=. -checks=-*,
Eugene.Zelenko added inline comments.
Comment at: docs/ReleaseNotes.rst:116
+
+ Checks for allowed system includes and suggests removal of any others. If no
+ includes are specified, the check will exit without issuing any warnings.
Is it necessary to highlight
Author: erichkeane
Date: Tue May 8 14:26:21 2018
New Revision: 331812
URL: http://llvm.org/viewvc/llvm-project?rev=331812&view=rev
Log:
Fix float->int conversion warnings when near barriers.
As Eli brought up here: https://reviews.llvm.org/D46535
I'd previously messed up this fix by missing conv
efriedma added a comment.
I think the request was that we check that a type is trivially copyable when we
perform an atomic operation? I don't see the code for that anywhere.
Also needs some test coverage for atomic operations which aren't calls, like
"typedef struct S S; void f(_Atomic S *s,
juliehockett updated this revision to Diff 145788.
juliehockett marked 10 inline comments as done.
juliehockett added a comment.
Made the check for system headers more comprehensive & fixed newline issues
https://reviews.llvm.org/D43778
Files:
clang-tidy/fuchsia/CMakeLists.txt
clang-tidy/fu
smeenai added a subscriber: rsmith.
smeenai added a comment.
In https://reviews.llvm.org/D42933#1091943, @jyknight wrote:
> In https://reviews.llvm.org/D42933#1091817, @jfb wrote:
>
> > In https://reviews.llvm.org/D42933#1091809, @jyknight wrote:
> >
> > > I also think that special casing these t
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rL331811: [HIP] Add hip offload kind (authored by yaxunl,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
jyknight added a comment.
In https://reviews.llvm.org/D42933#1091817, @jfb wrote:
> In https://reviews.llvm.org/D42933#1091809, @jyknight wrote:
>
> > I also think that special casing these two specifiers doesn't make sense.
> > The problem is a general issue -- and one I've often found irritati
Author: yaxunl
Date: Tue May 8 14:02:12 2018
New Revision: 331811
URL: http://llvm.org/viewvc/llvm-project?rev=331811&view=rev
Log:
[HIP] Add hip offload kind
There are quite differences in HIP action builder and action job creation,
which justifies to define a separate offload kind.
Differenti
Author: paquette
Date: Tue May 8 13:58:32 2018
New Revision: 331810
URL: http://llvm.org/viewvc/llvm-project?rev=331810&view=rev
Log:
Add a mno-outline flag to disable the MachineOutliner
Since we're working on turning the MachineOutliner by default under -Oz for
AArch64, it makes sense to have
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331807: [Driver] Don't add -dwarf-column-info when
using -gcodeview on non-msvc targets (authored by mstorsjo, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
Author: mstorsjo
Date: Tue May 8 13:55:23 2018
New Revision: 331807
URL: http://llvm.org/viewvc/llvm-project?rev=331807&view=rev
Log:
[Driver] Don't add -dwarf-column-info when using -gcodeview on non-msvc targets
-dwarf-column-info is omitted if -gcodeview is specified for msvc
targets at the m
Author: paquette
Date: Tue May 8 13:53:19 2018
New Revision: 331806
URL: http://llvm.org/viewvc/llvm-project?rev=331806&view=rev
Log:
Change -foutline to -moutline
Nitpicky, but the MachineOutliner is a machine-level pass, and so we should
reflect that by using "m" instead of "n".
Figured we sh
b-sumner added a comment.
Thanks! Looks good to me.
https://reviews.llvm.org/D46601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yaxunl created this revision.
yaxunl added reviewers: Anastasia, b-sumner.
Two typos:
vaarg => vararg
get_kernel_preferred_work_group_multiple =>
get_kernel_preferred_work_group_size_multiple
https://reviews.llvm.org/D46601
Files:
lib/CodeGen/CGBuiltin.cpp
test/CodeGenOpenCL/cl20-device-s
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
I'm pretty sure this has zero visible effect, but I guess it makes sense as
documentation. LGTM.
https://reviews.llvm.org/D46349
___
cfe-co
rjmccall added inline comments.
Comment at: docs/LanguageExtensions.rst:1998
+``__ATOMIC_CONSUME``, ``__ATOMIC_ACQUIRE``, ``__ATOMIC_RELEASE``,
+``__ATOMIC_ACQ_REL``, or ``__ATOMIC_SEQ_CST`` following C++11 memory model
semantics.
+
Thank you for adding this doc
Author: rksimon
Date: Tue May 8 13:24:45 2018
New Revision: 331805
URL: http://llvm.org/viewvc/llvm-project?rev=331805&view=rev
Log:
Fix Wdocumentation warning. NFCI.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidy.h
Modified: clang-tools-extra/trunk/clang-tidy/ClangTidy.h
URL:
http
yaxunl marked an inline comment as done.
yaxunl added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:133-135
Work(*C.getSingleOffloadToolChain());
+ if (JA.isHostOffloading(Action::OFK_HIP))
tra wrote:
> CUDA and HIP are mutually exclusive,
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
https://reviews.llvm.org/D46475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
erichkeane added a comment.
In https://reviews.llvm.org/D46535#1091787, @efriedma wrote:
> The check for whether an input is "out of range" doesn't handle fractions
> correctly. Testcase:
>
> int a() { return 2147483647.5; }
> unsigned b() { return -.5; }
>
Hrm... For some reaosn I had it
rnkovacs added inline comments.
Comment at: lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2342
+BugReport &BR) {
+ if (isInvalidated)
+return nullptr;
george.karpenkov wrote:
> Is this field actually necessary? D
rnkovacs updated this revision to Diff 145762.
rnkovacs marked 4 inline comments as done.
rnkovacs edited the summary of this revision.
rnkovacs added a comment.
Expression chaining is fixed. The visitor now collects constraints that are
about to disappear along the bug path and checks them once
aaron.ballman added a reviewer: rjmccall.
aaron.ballman added a subscriber: rjmccall.
aaron.ballman added a comment.
In https://reviews.llvm.org/D42933#1091502, @jfb wrote:
> In https://reviews.llvm.org/D42933#1091234, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D42933#1090268, @jfb w
jfb added a comment.
In https://reviews.llvm.org/D42933#1091809, @jyknight wrote:
> I also think that special casing these two specifiers doesn't make sense. The
> problem is a general issue -- and one I've often found irritating. This exact
> same situation comes up all the time in non-Darwin
craig.topper added a comment.
Ping
https://reviews.llvm.org/D46349
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyknight added a comment.
In https://reviews.llvm.org/D42933#1090384, @jfb wrote:
> In https://reviews.llvm.org/D42933#1090286, @smeenai wrote:
>
> > I'd be fine with adding an option to relax the printf checking if the size
> > and alignment of the specifier and the actual type match, even if t
efriedma added a comment.
The check for whether an input is "out of range" doesn't handle fractions
correctly. Testcase:
int a() { return 2147483647.5; }
unsigned b() { return -.5; }
Repository:
rC Clang
https://reviews.llvm.org/D46535
___
tra accepted this revision.
tra added a comment.
Small nit. LGTM otherwise.
Comment at: lib/Driver/ToolChains/Clang.cpp:133-135
Work(*C.getSingleOffloadToolChain());
+ if (JA.isHostOffloading(Action::OFK_HIP))
CUDA and HIP are mutually exclusive, so thi
xbolva00 added a comment.
In https://reviews.llvm.org/D46593#1091732, @smeenai wrote:
> Generating the patch from libc++ is fine (and this patch looks like it has
> sane paths).
Thank you
https://reviews.llvm.org/D46593
___
cfe-commits mailing l
smeenai added a comment.
Generating the patch from libc++ is fine (and this patch looks like it has sane
paths).
https://reviews.llvm.org/D46593
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
xbolva00 updated this revision to Diff 145745.
xbolva00 added a comment.
Can anybody give me advice from where to generate patch? I do it from libcxx.
https://reviews.llvm.org/D46593
Files:
include/experimental/filesystem
Index: include/experimental/filesystem
==
xbolva00 updated this revision to Diff 145742.
Herald added a subscriber: christof.
https://reviews.llvm.org/D46593
Files:
libcxx/trunk/include/experimental/filesystem
Index: libcxx/trunk/include/experimental/filesystem
===
--- l
xbolva00 updated this revision to Diff 145740.
Herald added a subscriber: cfe-commits.
Repository:
rCXX libc++
https://reviews.llvm.org/D46593
Files:
include/experimental/filesystem
Index: include/experimental/filesystem
===
-
Author: zturner
Date: Tue May 8 11:20:10 2018
New Revision: 331786
URL: http://llvm.org/viewvc/llvm-project?rev=331786&view=rev
Log:
[lit] Fix running tests that require 'examples'.
Differential Revision: https://reviews.llvm.org/D46514
Patch by Nikolai Kosjar.
Modified:
cfe/trunk/test/lit.
sepavloff added a comment.
> Hmm. In C++, a static object which isn't constant-initialized is
> zero-initialized, which is required to set any padding bits to zero (N4640
> [dcl.init]p6) in both structs and unions. In C, a static object which doesn't
> have an initializer also has all any paddi
sepavloff updated this revision to Diff 145735.
sepavloff added a comment.
Added treatment of structures/unions
Repository:
rC Clang
https://reviews.llvm.org/D46241
Files:
include/clang/AST/Expr.h
lib/AST/ExprConstant.cpp
lib/CodeGen/CGExprConstant.cpp
test/CodeGen/const-init.c
tes
Hahnfeld added a comment.
Could you maybe add some short summaries to your patches? It's hard for
non-Intel employees to guess what all these instructions do...
https://reviews.llvm.org/D46540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm! (Back from a week long vacation)
https://reviews.llvm.org/D46320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
craig.topper added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:2342
// Only positive features are "required".
- if (F.getValue())
+ if (F.getValue()) {
+if (std::any_of(ParsedAttr.Features.begin(), ParsedAttr.Features.end(),
-
tra added a comment.
Great! Let's close this review then.
And good luck with cling.
https://reviews.llvm.org/D44435
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb added a comment.
In https://reviews.llvm.org/D42933#1091234, @aaron.ballman wrote:
> In https://reviews.llvm.org/D42933#1090268, @jfb wrote:
>
> > I was just looking at this, and I think @arphaman's patch is pretty much
> > the right approach (with 2 suggested fixes below).
> >
> > I don't t
jdenny updated this revision to Diff 145711.
jdenny edited the summary of this revision.
jdenny added a comment.
Made the suggested changes.
https://reviews.llvm.org/D45093
Files:
include/clang/Sema/Sema.h
lib/Frontend/ASTConsumers.cpp
lib/Sema/Sema.cpp
test/Misc/ast-print-bool.c
Index
yaxunl updated this revision to Diff 145699.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Revised by John's comments.
https://reviews.llvm.org/D46475
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Options.td
include/clang/Driver/Types.h
lib/
smeenai added a comment.
In https://reviews.llvm.org/D42933#1091234, @aaron.ballman wrote:
> In https://reviews.llvm.org/D42933#1090268, @jfb wrote:
>
> > I was just looking at this, and I think @arphaman's patch is pretty much
> > the right approach (with 2 suggested fixes below).
> >
> > I don
craig.topper added inline comments.
Comment at: lib/CodeGen/CodeGenFunction.cpp:2346
+ return Feat.substr(1) == F.getKey();
+ }))
+ReqFeatures.insert(ReqFeatures.begin(), F.getKey());
This and the next line a
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D46540
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
ilya-biryukov added inline comments.
Comment at: include/clang-c/Index.h:5237
+/**
+ * \brief FixIts that *must* be applied before inserting the text for the
+ * corresponding completion item. Completion items with non-empty fixits will
This seems too large for a
ilya-biryukov updated this revision to Diff 145691.
ilya-biryukov added a comment.
- Fixed infinite loop with comments that contain doxygen commands
Repository:
rC Clang
https://reviews.llvm.org/D46000
Files:
include/clang/AST/CommentLexer.h
include/clang/AST/RawCommentList.h
lib/AST/C
aaron.ballman added inline comments.
Comment at: clang-tidy/fuchsia/FuchsiaTidyModule.cpp:41
+CheckFactories.registerCheck(
+"fuchsia-restrict-includes");
CheckFactories.registerCheck(
I think this should be named `fuchsia-restrict-system-include
chill marked an inline comment as done.
chill added a comment.
Update: updated comment, added a test.
Comment at: lib/Sema/SemaDecl.cpp:15651
}
} else {
ObjCIvarDecl **ClsFields =
rsmith wrote:
> Do we need to do any attribute processing in this Ob
chill updated this revision to Diff 145687.
https://reviews.llvm.org/D46439
Files:
lib/Sema/SemaDecl.cpp
test/Layout/itanium-pack-and-align.cpp
Index: test/Layout/itanium-pack-and-align.cpp
===
--- /dev/null
+++ test/Layout/ita
Author: abataev
Date: Tue May 8 07:16:57 2018
New Revision: 331768
URL: http://llvm.org/viewvc/llvm-project?rev=331768&view=rev
Log:
[OPENMP, NVPTX] Fix linkage of the global entries.
The linkage of the global entries must be weak to enable support of
redefinition of the same target regions in m
alexfh added a comment.
In https://reviews.llvm.org/D46187#1088722, @NoQ wrote:
> It seems that you're using debug checkers of the analyzer to gain some free
> tools for exploring the source code (such as displaying a call graph) for
> free, right?
>
> I believe we could also benefit from a met
alexfh added a comment.
In https://reviews.llvm.org/D46188#1091237, @lebedev.ri wrote:
> In https://reviews.llvm.org/D46188#1091221, @alexfh wrote:
>
> > I don't think debug CSA checkers belong to clang-tidy. If one needs to dump
> > CFG, they are probably doing quite involved stuff already, so
This revision was automatically updated to reflect the committed changes.
Closed by commit rL331766: [OpenCL] Factor out language version printing
(authored by svenvh, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D46382?vs=144991&id=
1 - 100 of 147 matches
Mail list logo
