baloghadamsoftware added inline comments.
Comment at:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h:148
+ Name.endswith_lower(".cc") || Name.endswith_lower(".m") ||
+ Name.endswith_lower(".mm")) {
+return true;
Altho
Thanks!
On 04/19/2018 03:39 PM, Haojian Wu wrote:
Thanks! I didn't see this warning when running check-clang-tools on my
machine. Fixed in r330327.
On Thu, Apr 19, 2018 at 7:39 AM, Mikael Holmén
mailto:mikael.hol...@ericsson.com>> wrote:
Hi,
On 04/18/2018 10:54 AM, Haojian Wu via
modocache created this revision.
modocache added reviewers: GorNishanov, EricWF.
http://wg21.link/P0664r2 section "Evolution/Core Issues 24" describes a
proposed change to Coroutines TS that would have any exceptions thrown
after the initial suspend point of a coroutine be caught by the handler
sp
malaperle updated this revision to Diff 143220.
malaperle added a comment.
Remove more includes.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44882
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/Clangd
yaxunl updated this revision to Diff 143218.
yaxunl marked 14 inline comments as done.
yaxunl added a comment.
Revised by Artem's comments.
https://reviews.llvm.org/D45212
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Options.td
i
malaperle added a comment.
Sorry for the embarrassing clean-ups I forgot!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
malaperle updated this revision to Diff 143219.
malaperle marked 5 inline comments as done.
malaperle added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D44882
Files:
clangd/CMakeLists.txt
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
yaxunl marked 21 inline comments as done.
yaxunl added inline comments.
Comment at: include/clang/Driver/Options.td:552-553
+def : Joined<["--"], "offload-arch=">, Alias;
+def offload_archs : Joined<["--"], "offload-archs=">, Flags<[DriverOption]>,
+ HelpText<"List of offload ar
NoQ added a comment.
Looks great, thanks!
> CXXDynamicCastExpr: I don't think evalCast would handle this correctly, does
> it?
Seems so. It is partially supported by `StoreManager::attemptDownCast()`. I
also see relatively little urgency in handling it here because the whole point
of `dynamic
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/readability/RedundantDataCallCheck.cpp:22
+
+const char kDefaultTypes[] =
+"::std::basic_string;::std::basic_string_view;::std::vector;::std::array";
shuaiwang wrote:
> Eugene.Zelenko wrote:
> > Act
shuaiwang added inline comments.
Comment at: clang-tidy/readability/RedundantDataCallCheck.cpp:22
+
+const char kDefaultTypes[] =
+"::std::basic_string;::std::basic_string_view;::std::vector;::std::array";
Eugene.Zelenko wrote:
> Actually you should use stati
shuaiwang updated this revision to Diff 143207.
shuaiwang marked 7 inline comments as done.
shuaiwang added a comment.
Addressed more comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45702
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Readabili
Eugene.Zelenko added inline comments.
Comment at: clang-tidy/readability/RedundantDataCallCheck.cpp:22
+
+const char kDefaultTypes[] =
+"::std::basic_string;::std::basic_string_view;::std::vector;::std::array";
Actually you should use static, not anonymous na
shuaiwang updated this revision to Diff 143204.
shuaiwang marked 7 inline comments as done.
shuaiwang added a comment.
Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D45702
Files:
clang-tidy/readability/CMakeLists.txt
clang-tidy/readability/Readabi
compnerd added inline comments.
Comment at: clang/lib/CodeGen/CGAtomic.cpp:883
if (UseLibcall) {
+CGM.getDiags().Report(E->getLocStart(), diag::warn_atomic_op_misaligned);
+
t.p.northover wrote:
> compnerd wrote:
> > It is kinda unfortunate that you need t
compnerd accepted this revision.
compnerd added a comment.
Some cleanup suggestions included, but I like the change overall.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:1250
+ // Setup statistics file output.
+ if (const Arg *A = Args.getLastArg(options::OPT_save_stats_E
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
Well that was unusually easy...
https://reviews.llvm.org/D45827
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
shuaiwang added a comment.
Regarding full dependency analysis, I think it's out of the scope of this
change at least for now. We're only trying to find //one// possible point where
the given `Expr` is (assumed to be) mutated. This is known to be useful at this
point for use cases like "check wh
shuaiwang updated this revision to Diff 143197.
shuaiwang marked 13 inline comments as done.
shuaiwang added a comment.
- Moved out of ASTUtils and becomes a separte class ExprMutationAnalyzer
(bikeshedding on name a bit.)
- Reverted back to return bool instead of tri-valued enum, the meanings of
NoQ updated this revision to Diff 143195.
NoQ added a comment.
Hopefully a more portable way of testing this stuff.
https://reviews.llvm.org/D45839
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/AnalysisManager.h
lib/StaticAnalyzer/Core/CallEvent.cpp
lib/StaticAnalyzer/Core/ExprEn
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330382: [CFG] [analyzer] Add construction contexts for loop
condition variables. (authored by dergachev, committed by ).
H
Author: dergachev
Date: Thu Apr 19 16:30:15 2018
New Revision: 330382
URL: http://llvm.org/viewvc/llvm-project?rev=330382&view=rev
Log:
[CFG] [analyzer] Add construction contexts for loop condition variables.
Loop condition variables, eg.
while (shared_ptr P = getIntPtr()) { ... })
weren't ha
NoQ added a comment.
In https://reviews.llvm.org/D45698#1069121, @xazax.hun wrote:
> I am in favour of this approach. This is what I suggested back than in
> https://reviews.llvm.org/D23014 but it was somehow overlooked.
I'll try to follow-up on this.
Repository:
rC Clang
https://reviews.
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330380: [analyzer] When we fail to evaluate a pointer cast,
escape the pointer. (authored by dergachev, committed by ).
He
Author: dergachev
Date: Thu Apr 19 16:24:32 2018
New Revision: 330380
URL: http://llvm.org/viewvc/llvm-project?rev=330380&view=rev
Log:
[analyzer] When we fail to evaluate a pointer cast, escape the pointer.
If a pointer cast fails (evaluates to an UnknownVal, i.e. not implemented in the
analyzer
Author: compnerd
Date: Thu Apr 19 16:14:57 2018
New Revision: 330378
URL: http://llvm.org/viewvc/llvm-project?rev=330378&view=rev
Log:
Implement proper support for `-falign-functions`
This implements support for the previously ignored flag
`-falign-functions`. This allows the frontend to request
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330377: [CFG] [analyzer] Don't treat argument
constructors as temporary constructors. (authored by dergachev, committed by
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330377: [CFG] [analyzer] Don't treat argument
constructors as temporary constructors. (authored by dergachev, committed by
Author: dergachev
Date: Thu Apr 19 16:09:22 2018
New Revision: 330377
URL: http://llvm.org/viewvc/llvm-project?rev=330377&view=rev
Log:
[CFG] [analyzer] Don't treat argument constructors as temporary constructors.
Function argument constructors (that are used for passing objects into functions
by
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: baloghadamsoftware.
Committed in https://reviews.llvm.org/rC330375 but i misplaced the phabricator
link again, sorry.
Repository:
rC Clang
https://reviews.llvm.org/D45
NoQ added a comment.
Herald added a subscriber: baloghadamsoftware.
https://reviews.llvm.org/rC330375 has nothing to do with this review; i
misplaced the link in the commit message again.
Repository:
rL LLVM
https://reviews.llvm.org/D45117
___
c
Author: dergachev
Date: Thu Apr 19 16:00:22 2018
New Revision: 330375
URL: http://llvm.org/viewvc/llvm-project?rev=330375&view=rev
Log:
[analyzer] RetainCount: Accept more "safe" CFRetain wrappers.
r315736 added support for the misplaced CF_RETURNS_RETAINED annotation on
CFRetain() wrappers. It w
This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX330372: Don't do aligned allocations on MSVCRT before
19.12 (update 15.3) (authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45836?vs=143161&id=143173#toc
Repository
dblaikie added a comment.
I've pushed this further - it builds now & has no fallback in libBasic to the
old behavior/table.
One remaining thing I'm unsure about is the table of DIAG_START_* values. Do
you think this is OK/good to leave hardcoded in diagnostics? Should I somehow
remove the need
Author: rnk
Date: Thu Apr 19 15:12:10 2018
New Revision: 330372
URL: http://llvm.org/viewvc/llvm-project?rev=330372&view=rev
Log:
Don't do aligned allocations on MSVCRT before 19.12 (update 15.3)
Reviewers: EricWF, pcc
Subscribers: christof, cfe-commits
Differential Revision: https://reviews.ll
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs, baloghadamsoftware.
Since recently, WebKit uses a peculiar build system that compiles multiple
translation units at once by automatically joi
rnk created this revision.
rnk added reviewers: EricWF, pcc.
Herald added a subscriber: christof.
https://reviews.llvm.org/D45836
Files:
libcxx/include/__config
Index: libcxx/include/__config
===
--- libcxx/include/__config
+++ l
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D45807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
aaron.ballman added a comment.
In https://reviews.llvm.org/D45835#1072557, @efriedma wrote:
> The list of features/extensions seems okay; it's information which is already
> available through a stable interface (specifically, clang -E). JSON also
> seems fine as a representation.
>
> Including
efriedma added a comment.
The list of features/extensions seems okay; it's information which is already
available through a stable interface (specifically, clang -E). JSON also seems
fine as a representation.
Including the language/codegen/etc. options as-is doesn't make sense; we can,
and of
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330360: Remove impossible _MSC_VER check (authored by rnk,
committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D45829?vs=143137&id=143151#toc
Repo
Author: rnk
Date: Thu Apr 19 12:40:12 2018
New Revision: 330360
URL: http://llvm.org/viewvc/llvm-project?rev=330360&view=rev
Log:
Remove impossible _MSC_VER check
Summary:
It is immediately preceded by this check:
#if _MSC_VER < 1900
#error "MSVC versions prior to Visual Studio 2015 are not s
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
LGTM. I'd tried to clean all stale `_MSC_VER` conditionals in the past, but I
must have missed some.
https://reviews.llvm.org/D45829
___
cfe-c
aaron.ballman created this revision.
aaron.ballman added a reviewer: rsmith.
Herald added a subscriber: cryptoad.
There are situations where an out-of-tree user may need to know information
about what compiler options are used and what features/extensions may be
available for a given invocation
Hahnfeld updated this revision to Diff 143145.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Move module ID to corresponding `else` branch.
https://reviews.llvm.org/D42922
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenCUDA/device-
tra added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:364-377
+ llvm::Constant *NVModuleIDConstant;
+ SmallString<64> NVModuleID;
+ if (RelocatableDeviceCode) {
+// Generate a unique module ID.
+llvm::raw_svector_ostream OS(NVModuleID);
+OS << "__nv_" <<
tra added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:287
+CtorSuffix.append("_");
+CtorSuffix.append(ModuleName);
+ }
There is a general problem with this approach. File name can contain the
characters that PTX does not allow.
We currently on
rnk created this revision.
rnk added a reviewer: EricWF.
Herald added a subscriber: christof.
It is immediately preceded by this check:
#if _MSC_VER < 1900
#error "MSVC versions prior to Visual Studio 2015 are not supported"
#endif
https://reviews.llvm.org/D45829
Files:
libcxx/include/
efriedma added inline comments.
Comment at: lib/Frontend/FrontendTiming.cpp:14
+
+#include "llvm/Support/Timer.h"
+
This should include clang/Frontend/Utils.h .
Comment at: test/Frontend/ftime-report-template-decl.cpp:2
+// RUN: %clang %s -S -o
Hahnfeld added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:283-285
+ llvm::FunctionType *RegisterGlobalsFnTy;
+ llvm::FunctionType *RegisterLinkedBinaryFnTy;
+ llvm::Function *DummyCallback;
tra wrote:
> Instead of tracking these through the conditio
Hahnfeld updated this revision to Diff 143136.
Hahnfeld marked 2 inline comments as done.
Hahnfeld added a comment.
Move `FunctionType`s to methods and change test prefixes.
https://reviews.llvm.org/D42922
Files:
lib/CodeGen/CGCUDANV.cpp
test/CodeGenCUDA/device-stub.cu
Index: test/CodeGenC
davezarzycki closed this revision.
davezarzycki added a comment.
Thanks @thakis!
Committed as r330353
Repository:
rC Clang
https://reviews.llvm.org/D45777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
Author: davezarzycki
Date: Thu Apr 19 11:19:02 2018
New Revision: 330353
URL: http://llvm.org/viewvc/llvm-project?rev=330353&view=rev
Log:
[UnitTests] NFC/build-perf: Break up nontrivial compile jobs
RecursiveASTVisitorTest.cpp is one of the longest compile jobs and a
build bottleneck on many-cor
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D37475
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
hiraditya added a comment.
The bug which motivated this warning is:
https://github.com/jemalloc/jemalloc/commit/4df483f0fd76a64e116b1c4f316f8b941078114d#diff-7b26b977303fe92c093a2245b0eaf255
https://reviews.llvm.org/D45601
___
cfe-commits mailing l
tra created this revision.
tra added a reviewer: jlebar.
Herald added a subscriber: sanjoy.
https://reviews.llvm.org/D45827
Files:
clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cuda.cpp
clang/lib/Driver/ToolChains/Cuda.cpp
clang/lib/Headers/__clang_cuda_runtime_wrapper.h
Index: clang
thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.
Makes sense to me.
Repository:
rC Clang
https://reviews.llvm.org/D45777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
tra added a comment.
Could you please resubmit your patch with complete context?
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
https://reviews.llvm.org/D44435
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
tra added inline comments.
Comment at: lib/CodeGen/CGCUDANV.cpp:283-285
+ llvm::FunctionType *RegisterGlobalsFnTy;
+ llvm::FunctionType *RegisterLinkedBinaryFnTy;
+ llvm::Function *DummyCallback;
Instead of tracking these through the conditionals of pretty lon
aprantl added a comment.
I'm not sure. Compatibility with GCC and getting identical output for debugging
purposes seem to be at odds here. I personally lean slightly towards stripping
it from the debug info as well.
https://reviews.llvm.org/D45255
___
miyuki added a comment.
In https://reviews.llvm.org/D45255#1072200, @aprantl wrote:
> Does gcc's Qy/Qn option also affect the generated debug information?
No, it does not. Do you think it would be better to leave debug information
unchanged as well?
https://reviews.llvm.org/D45255
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330338: [CXX] Templates specialization visibility can be
wrong (authored by steven_wu, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44670?vs=142961&id=143103#toc
Repository:
rC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330338: [CXX] Templates specialization visibility can be
wrong (authored by steven_wu, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D44670
File
Author: steven_wu
Date: Thu Apr 19 08:46:43 2018
New Revision: 330338
URL: http://llvm.org/viewvc/llvm-project?rev=330338&view=rev
Log:
[CXX] Templates specialization visibility can be wrong
Summary:
Under some conditions, LinkageComputer can get the visibility for
ClassTemplateSpecializationDecl
sammccall added a comment.
I think this implementation will have problems in a "real" multi-machine MR
framework. The lifetime of the Merger is the whole program, with output only
coming at the end.
With N workers, each will store >1/N of the symbols (more because of overlap),
and the streaming
aprantl added a comment.
Does gcc's Qy/Qn option also affect the generated debug information? Clang is
embedding the version number also into the DICompileUnit's producer string; I
wonder if that should be affected by this option, too.
https://reviews.llvm.org/D45255
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL330336: [NEON] Define vfma_n_f32() and vfmaq_n_f32()
intrinsics in AArch32 mode (authored by kosarev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
Author: kosarev
Date: Thu Apr 19 08:27:28 2018
New Revision: 330336
URL: http://llvm.org/viewvc/llvm-project?rev=330336&view=rev
Log:
[NEON] Define vfma_n_f32() and vfmaq_n_f32() intrinsics in AArch32 mode
Differential Revision: https://reviews.llvm.org/D45670
Modified:
cfe/trunk/include/cla
JDevlieghere added a comment.
Please run your changes through clang format before checking this in; otherwise
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D45045
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.
LGTM with comment nit
Comment at: lib/Driver/ToolChains/CommonArgs.h:107
llvm::opt::OptSpecifier Group);
+SmallString<128> getStatsFileN
JDevlieghere added inline comments.
Comment at: test/CodeGen/no-ident-version.c:1
+// RUN: %clang_cc1 -Qn -emit-llvm -debug-info-kind=limited -o - %s | FileCheck
%s
+
Please test both -Qy and -Qn as well as the default case.
https://reviews.llvm.org/D45255
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330331: Fix __attribute__((force_align_arg_pointer))
misalignment bug (authored by erichkeane, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45812
Files:
lib/CodeGen/TargetInfo.cpp
Author: erichkeane
Date: Thu Apr 19 07:27:05 2018
New Revision: 330331
URL: http://llvm.org/viewvc/llvm-project?rev=330331&view=rev
Log:
Fix __attribute__((force_align_arg_pointer)) misalignment bug
The force_align_arg_pointer attribute was using a hardcoded 16-byte
alignment value which in combi
Gramner added a comment.
In https://reviews.llvm.org/D45812#1072128, @erichkeane wrote:
> LGTM, Do you have commit access, or do you want me to commit it for you?
I do not have commit access, so please do. Thanks for the review.
https://reviews.llvm.org/D45812
_
whisperity added inline comments.
Comment at: clang-tidy/tool/CMakeLists.txt:19
clangBasic
+ clangFrontend
clangTidy
ilya-biryukov wrote:
> whisperity wrote:
> > ilya-biryukov wrote:
> > > Why do we need an extra dependency?
> > In the current state of the
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
LGTM, Do you have commit access, or do you want me to commit it for you?
https://reviews.llvm.org/D45812
___
cfe-commits mailing list
cfe
nik added a comment.
This one still applies and tests pass.
Please review.
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Sorry for the delay, I think I'll come back to this one soon.
Repository:
rC Clang
https://reviews.llvm.org/D41005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
nik added a comment.
@ilya: Using SkipFunctionBodies_AllExceptTemplates for the preamble might be
also useful for clangd.
Repository:
rC Clang
https://reviews.llvm.org/D45815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
nik created this revision.
Herald added subscribers: cfe-commits, kbarton, nemanjai, klimek.
As an addition to CXTranslationUnit_SkipFunctionBodies, provide the new
options
CXTranslationUnit_LimitSkipFunctionBodiesToPreamble
CXTranslationUnit_LimitSkipFunctionBodiesToNonTemplates.
The first
Thanks! I didn't see this warning when running check-clang-tools on my
machine. Fixed in r330327.
On Thu, Apr 19, 2018 at 7:39 AM, Mikael Holmén
wrote:
> Hi,
>
>
> On 04/18/2018 10:54 AM, Haojian Wu via cfe-commits wrote:
>
>> Author: hokein
>> Date: Wed Apr 18 01:54:28 2018
>> New Revision: 330
Author: hokein
Date: Thu Apr 19 06:34:03 2018
New Revision: 330327
URL: http://llvm.org/viewvc/llvm-project?rev=330327&view=rev
Log:
[clang-tidy] Fix unused-variable warning.
Modified:
clang-tools-extra/trunk/clang-tidy/ClangTidyOptions.cpp
Modified: clang-tools-extra/trunk/clang-tidy/ClangT
asb added a comment.
Hi @spetrovic - I think Hal Finkel's earlier request to update the comments of
IsBetterAsSingleFieldRun remains unaddressed. It looks like at least the
comment string immediately before `auto IsBetterAsSingleFieldRun` needs to be
updated to reflect the changed behaviour.
T
sammccall added a comment.
In https://reviews.llvm.org/D45764#1072067, @jkorous wrote:
> [ultranit] Sorry, just to be sure - did you really mean any number of dashes
>
> if (LineRef.startswith("-") && LineRef.find_first_not_of('-') ==
> llvm::StringRef::npos)
>
>
> or at least three?
>
> if
Gramner added a comment.
In https://reviews.llvm.org/D45812#1072066, @erichkeane wrote:
> Can you make sure that this doesn't cause stackrealign to happen 2x if using
> -mstackrealign? Additionally, please provide the diff with full-context (see
> https://llvm.org/docs/Phabricator.html#request
Author: aivchenk
Date: Thu Apr 19 05:15:11 2018
New Revision: 330323
URL: http://llvm.org/viewvc/llvm-project?rev=330323&view=rev
Log:
Lowering x86 adds/addus/subs/subus intrinsics (clang)
This is the patch that lowers x86 intrinsics to native IR
in order to enable optimizations.
Patch by tkrupa
Gramner updated this revision to Diff 143083.
Gramner added a comment.
Full context.
https://reviews.llvm.org/D45812
Files:
lib/CodeGen/TargetInfo.cpp
test/CodeGen/function-attributes.c
Index: test/CodeGen/function-attributes.c
=
t.p.northover added inline comments.
Comment at: clang/lib/CodeGen/CGAtomic.cpp:883
if (UseLibcall) {
+CGM.getDiags().Report(E->getLocStart(), diag::warn_atomic_op_misaligned);
+
compnerd wrote:
> It is kinda unfortunate that you need to look up 125 lines
jkorous added a comment.
[ultranit] Sorry, just to be sure - did you really mean any number of dashes
if (LineRef.startswith("-") && LineRef.find_first_not_of('-') ==
llvm::StringRef::npos)
or at least three?
if (LineRef.startswith("---") && LineRef.find_first_not_of('-') ==
llvm::StringR
erichkeane added a comment.
Can you make sure that this doesn't cause stackrealign to happen 2x if using
-mstackrealign? Additionally, please provide the diff with full-context (see
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface).
What is the commit before th
chrib created this revision.
Herald added a subscriber: cfe-commits.
Fix an assertion when -print-prog-name=
Repository:
rC Clang
https://reviews.llvm.org/D45814
Files:
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
jkorous added a comment.
By "Comments should be allowed at the end of test files." I meant that we
shouldn't log it as an exceptional state. Should've worded that better.
I included a wrong test in the patch. I had realized the same thing as you and
had written another test but messed up.
htt
Gramner created this revision.
Gramner added a reviewer: erichkeane.
Gramner added a project: clang.
Herald added a subscriber: javed.absar.
The force_align_arg_pointer attribute was using a hardcoded 16-byte
alignment value which in combination with -mstack-alignment=32 (or
larger) would produce
jkorous updated this revision to Diff 143079.
jkorous added a comment.
Include the correct test.
https://reviews.llvm.org/D45763
Files:
JSONRPCDispatcher.cpp
clangd/delimited-input-comment-at-the-end.test
Index: clangd/delimited-input-comment-at-the-end.test
==
This revision was automatically updated to reflect the committed changes.
krasimir marked an inline comment as done.
Closed by commit rL330324: [clang-format] Don't remove empty lines before
namespace endings (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Changed
Author: krasimir
Date: Thu Apr 19 06:02:15 2018
New Revision: 330324
URL: http://llvm.org/viewvc/llvm-project?rev=330324&view=rev
Log:
[clang-format] Don't remove empty lines before namespace endings
Summary: This implements an alternative to r327861, namely preserving empty
lines before namespa
ilya-biryukov added inline comments.
Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:53
+/// Combines occurrences of the same symbols across translation units.
+class SymbolMerger {
ilya-biryukov wrote:
> sammccall wrote:
> > Seems reasonab
sammccall added a comment.
In https://reviews.llvm.org/D45478#1071983, @ilya-biryukov wrote:
> In https://reviews.llvm.org/D45478#1064027, @sammccall wrote:
>
> > Is this patch still relevant after haojian's string deduplication?
>
>
> Apparently it does. It has an advantage of distributing the w
ilya-biryukov added a comment.
Herald added a subscriber: jkorous.
In https://reviews.llvm.org/D45478#1064027, @sammccall wrote:
> Is this patch still relevant after haojian's string deduplication?
Apparently it does. It has an advantage of distributing the work more evenly
between the program
asb added a comment.
Herald added a subscriber: edward-jones.
This is looking great, the only remaining code comment I have is that
getExtensionFeatures needs a comment describing it.
The remaining issue I have is more of a spec issue - do canonical ordering
requirements apply to extension cate
1 - 100 of 133 matches
Mail list logo
