Gramner added a comment. In https://reviews.llvm.org/D45812#1072066, @erichkeane wrote:
> Can you make sure that this doesn't cause stackrealign to happen 2x if using > -mstackrealign? Additionally, please provide the diff with full-context (see > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface). > What is the commit before this? The line numbers don't look right to me. > > Barring any surprises from those two, this looks alright to me. The commit before this one is git hash 4889058f23607ff086470afe013082ca4a278ddb It does "the right thing" as far as I can see, e.g. no double stack realignment or anything weird, when tested on 64-bit Linux with various combinations (and lack of thereof) of -mstack-alignment=32, -mstack-alignment=64, -mstackrealign, -m32. Unable to test on other systems though. https://reviews.llvm.org/D45812 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
