[PATCH] D44609: [Clang-Format] New option BreakBeforeLambdaBody to manage lambda line break inside function parameter call

djasper added a comment. Please read: https://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options In this case in particular, I would be very interested in a style guide that defines how Allman brace style and lambdas work together. IMO, it has so many corner ca

r329378 - [XRay][clang] Only run driver test for Linux and FreeBSD

Author: dberris Date: Thu Apr 5 23:09:57 2018 New Revision: 329378 URL: http://llvm.org/viewvc/llvm-project?rev=329378&view=rev Log: [XRay][clang] Only run driver test for Linux and FreeBSD This is a follow-up to D45354, which we should have only been running on Linux and FreeBSD for specific ta

[PATCH] D45354: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

This revision was automatically updated to reflect the committed changes. Closed by commit rL329376: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

r329376 - [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

Author: dberris Date: Thu Apr 5 22:28:54 2018 New Revision: 329376 URL: http://llvm.org/viewvc/llvm-project?rev=329376&view=rev Log: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly Summary: This change introduces `-fxray-link-deps` and `-fnoxray-link-deps`. The `-fnoxray-

[libcxx] r329375 - Mark as "In progress"

Author: marshall Date: Thu Apr 5 21:43:27 2018 New Revision: 329375 URL: http://llvm.org/viewvc/llvm-project?rev=329375&view=rev Log: Mark as "In progress" Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://llvm.org/viewvc/llvm-project/l

[PATCH] D45354: [XRay][clang] Add a flag to enable/disable linking XRay deps explicitly

dberris created this revision. dberris added reviewers: eizan, echristo, chandlerc. This change introduces `-fxray-link-deps` and `-fnoxray-link-deps`. The `-fnoxray-link-deps` allows for directly controlling which specific XRay runtime to link. The default is for clang to link the XRay runtime th

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rL329372: [XRay][clang] Consolidate runtime and link-time flag processing (NFC) (authored by dberris, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r329372 - [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

Author: dberris Date: Thu Apr 5 20:53:04 2018 New Revision: 329372 URL: http://llvm.org/viewvc/llvm-project?rev=329372&view=rev Log: [XRay][clang] Consolidate runtime and link-time flag processing (NFC) Summary: This change fixes http://llvm.org/PR36985 to define a single place in CommonArgs.{h,

[PATCH] D45243: [XRay][clang] Consolidate runtime and link-time flag processing (NFC)

dberris updated this revision to Diff 141265. dberris added a comment. - fixup: Rebase, and re-do OpenBSD specific changes https://reviews.llvm.org/D45243 Files: clang/include/clang/Driver/XRayArgs.h clang/lib/Driver/ToolChains/CommonArgs.cpp clang/lib/Driver/ToolChains/CommonArgs.h cla

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

weimingz added a comment. Thanks Eli! Repository: rCXX libc++ https://reviews.llvm.org/D41316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41316: [libcxx] Allow random_device to be built optionally

efriedma updated this revision to Diff 141255. efriedma added a comment. Get rid of the test changes. They were broken in multiple ways, and weren't really useful anyway because the targets where you would want to use this can't run the libcxx testsuite anyway (because they don't have an operat

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. I think the tests are already broken in Gentoo when clang is installed in /usr/bin even without this patch. The tests only work if clang binary is not installed in /usr/bin. RootCause is the existing lines in Gnu.cpp: // Then look for gcc installed alongs

r329366 - CMake option to allow enabling experimental new pass manager by default

Author: phosek Date: Thu Apr 5 17:53:00 2018 New Revision: 329366 URL: http://llvm.org/viewvc/llvm-project?rev=329366&view=rev Log: CMake option to allow enabling experimental new pass manager by default This CMake flag allows setting the default value for the -f[no]-experimental-new-pass-manage

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

This revision was automatically updated to reflect the committed changes. Closed by commit rC329366: CMake option to allow enabling experimental new pass manager by default (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D44330?vs=137844&id=141249#toc Rep

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 141248. saar.raz added a comment. Adjusted to piecewise substitution. - Constraint satisfaction will no longer happen for depenent CSEs (was originally needed for normalization, but not worth the trouble with the new piecewise substitution and the fact tha

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

arphaman added a comment. In https://reviews.llvm.org/D40983#1059087, @arphaman wrote: > In https://reviews.llvm.org/D40983#968796, @bruno wrote: > > > Makes sense, LGTM. > > > > Should we add documentation explaining how to use this? I'm fine if it > > comes in a follow up commit. > > > Sorry,

[PATCH] D40983: Generate Libclang invocation reproducers using a new -cc1gen-reproducer option

arphaman added a comment. In https://reviews.llvm.org/D40983#968796, @bruno wrote: > Makes sense, LGTM. > > Should we add documentation explaining how to use this? I'm fine if it comes > in a follow up commit. Sorry, just got time to get back to this now. Thanks for the review! I'll add a doc

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

efriedma updated this revision to Diff 141237. efriedma added a comment. Compute arch used passed-in CPU, not the global arch. Repository: rC Clang https://reviews.llvm.org/D45240 Files: lib/Basic/Targets/ARM.cpp test/CodeGen/arm-long-calls.c test/CodeGen/arm-no-movt.c test/CodeGen/a

r329361 - Fix test added in r329301 to work properly with Windows paths.

Author: dyung Date: Thu Apr 5 15:58:14 2018 New Revision: 329361 URL: http://llvm.org/viewvc/llvm-project?rev=329361&view=rev Log: Fix test added in r329301 to work properly with Windows paths. Modified: cfe/trunk/test/ASTMerge/struct/test.c Modified: cfe/trunk/test/ASTMerge/struct/test.c U

r329357 - [Sema] Revert r329346 because of memory sanitizer failures.

Author: eugenezelenko Date: Thu Apr 5 15:15:42 2018 New Revision: 329357 URL: http://llvm.org/viewvc/llvm-project?rev=329357&view=rev Log: [Sema] Revert r329346 because of memory sanitizer failures. Modified: cfe/trunk/include/clang/Sema/DeclSpec.h cfe/trunk/include/clang/Sema/SemaFixItU

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

EricWF added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:3250-3251 - mangleType(T->getBaseType()); + for (auto Ty : T->getArgs()) +mangleType(Ty); } EricWF wrote: > rsmith wrote: > > We need manglings to be self-delimiting, and we can't tell w

r329352 - Add a couple more tests for DR372.

Author: rsmith Date: Thu Apr 5 14:49:20 2018 New Revision: 329352 URL: http://llvm.org/viewvc/llvm-project?rev=329352&view=rev Log: Add a couple more tests for DR372. Modified: cfe/trunk/test/CXX/drs/dr3xx.cpp Modified: cfe/trunk/test/CXX/drs/dr3xx.cpp URL: http://llvm.org/viewvc/llvm-proj

Re: r329300 - Disable -fmerge-all-constants as default.

Thanks Richard, I was wondering how a Clang change can break the Backend tests given that the tests are all pre-checked IR files. Failing Tests (7): LLVM :: CodeGen/Mips/Fast-ISel/fastalloca.ll LLVM :: CodeGen/Mips/Fast-ISel/fastcc-miss.ll LLVM :: CodeGen/Mips/Fast-ISel/memtest1.ll

Re: r329300 - Disable -fmerge-all-constants as default.

MipsFastISel::fastLowerArguments looks very broken and is likely the culprit here: const ArrayRef GPR32ArgRegs = {Mips::A0, Mips::A1, Mips::A2, Mips::A3}; const ArrayRef FGR32ArgRegs = {Mips::F12, Mips::F14}; const ArrayRef AFGR64ArgRegs = {Mips::D

Re: r329300 - Disable -fmerge-all-constants as default.

Hello Manoj, Looks like this commit broke tests at couple of our builders: r329300 http://lab.llvm.org:8011/builders/clang-with-thin-lto-ubuntu/builds/9600 Few tests failed: . . . Failing Tests (7): LLVM :: CodeGen/Mips/Fast-ISel/fastalloca.ll LLVM :: CodeGen/Mips/Fast-ISel/fastcc-miss.ll

[PATCH] D44616: Update existed CodeGen TBAA tests

DanilM added a comment. ping Repository: rC Clang https://reviews.llvm.org/D44616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44617: [Transforms] Keep TBAA tags in SimplifyCFG transformations

DanilM added a comment. ping Repository: rC Clang https://reviews.llvm.org/D44617 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45335: [analyzer] RetainCount: Accept more "safe" CFRetain wrappers.

NoQ created this revision. NoQ added reviewers: dcoughlin, george.karpenkov. Herald added subscribers: cfe-commits, a.sidorin, JDevlieghere, szepet, xazax.hun. https://reviews.llvm.org/D38877 added support for the misplaced `CF_RETURNS_RETAINED` annotation on `CFRetain()` wrappers. It works by t

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Ok, that's a problem. I think we really ought to consider all possibilites of sysroot first, and either do not fall back to main system at all or do that only if sysroot doesn't have any install at all. Basically, it is important that we don't break non-Gentoo sysroots,

[PATCH] D45212: [HIP] Let CUDA toolchain support HIP language mode and amdgpu

yaxunl updated this revision to Diff 141221. yaxunl marked an inline comment as done. yaxunl edited the summary of this revision. yaxunl added a comment. Revised by reviewers' comments, including comments from previous review. https://reviews.llvm.org/D45212 Files: include/clang/Basic/Diagnos

r329346 - [Sema] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Thu Apr 5 14:09:03 2018 New Revision: 329346 URL: http://llvm.org/viewvc/llvm-project?rev=329346&view=rev Log: [Sema] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/Sema/DeclSpec.h c

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. My understanding is that some of the tests are failing since we are scanning for Gentoo specific GCC installation first in both sysroot and "/". So, clang succeeds in find the libraries in "/usr/lib/gcc" even when sysroot argument is passed. Previously, "/usr/lib/gcc

r329342 - PR36992: do not store beyond the dsize of a class object unless we know

Author: rsmith Date: Thu Apr 5 13:52:58 2018 New Revision: 329342 URL: http://llvm.org/viewvc/llvm-project?rev=329342&view=rev Log: PR36992: do not store beyond the dsize of a class object unless we know the tail padding is not reused. We track on the AggValueSlot (and through a couple of other

[PATCH] D45306: PR36992 don't overwrite virtual bases in tail padding

This revision was automatically updated to reflect the committed changes. Closed by commit rC329342: PR36992: do not store beyond the dsize of a class object unless we know (authored by rsmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D45306?vs=141205&id=141217#toc Rep

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 5, 2018, at 3:54 PM, Akira Hatanaka wrote: > > >> On Apr 5, 2018, at 12:39 PM, John McCall > > wrote: >> >> >> >>> On Apr 4, 2018, at 7:37 PM, Akira Hatanaka >> > wrote: >>> >>> >>> On Apr 4, 2018, at 4:24 PM, Akira Hat

[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rjmccall added a comment. In https://reviews.llvm.org/D42092#1058841, @rsmith wrote: > In https://reviews.llvm.org/D42092#1058772, @rjmccall wrote: > > > Issue #3 is tricky; it's arguably not okay to force a landing at a landing > > pad if we're not actually catching anything. > > > I think the

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Meh, I think this is fine as-is. Repository: rC Clang https://reviews.llvm.org/D44330 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D45306: PR36992 don't overwrite virtual bases in tail padding

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, LGTM. https://reviews.llvm.org/D45306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D45095: [clang-tidy] Align usage of ClangTool interface with new VFS injection

whisperity updated this revision to Diff 141207. whisperity added a comment. Update to be in line with contents in dependency patch. https://reviews.llvm.org/D45095 Files: clang-tidy/ClangTidy.cpp clang-tidy/ClangTidy.h clang-tidy/tool/CMakeLists.txt clang-tidy/tool/ClangTidyMain.cpp I

[PATCH] D45094: [LibTooling] Make interface of VFS injection into ClangTool more user-friendly

whisperity updated this revision to Diff 141206. whisperity added a comment. Simplify the patch. https://reviews.llvm.org/D45094 Files: include/clang/Basic/VirtualFileSystem.h include/clang/Tooling/Tooling.h lib/Basic/VirtualFileSystem.cpp lib/Tooling/Tooling.cpp unittests/Tooling/Too

[PATCH] D45306: PR36992 don't overwrite virtual bases in tail padding

rsmith added a comment. In https://reviews.llvm.org/D45306#1058792, @rjmccall wrote: > Changing the requirements on the return-value slot would be an ABI break, no? It would be, yes. But WG21 seems to have a taste for breaking changes at the moment, so who knows... I'm happy to remove `overlap

[PATCH] D45306: PR36992 don't overwrite virtual bases in tail padding

rsmith updated this revision to Diff 141205. rsmith marked 2 inline comments as done. https://reviews.llvm.org/D45306 Files: CodeGen/CGAtomic.cpp CodeGen/CGBlocks.cpp CodeGen/CGCall.cpp CodeGen/CGClass.cpp CodeGen/CGDecl.cpp CodeGen/CGDeclCXX.cpp CodeGen/CGExpr.cpp CodeGen/CGExprA

[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rsmith abandoned this revision. rsmith added a comment. In https://reviews.llvm.org/D42092#1058772, @rjmccall wrote: > Issue #3 is tricky; it's arguably not okay to force a landing at a landing > pad if we're not actually catching anything. I think the only way this is observable (at least wit

[PATCH] D45094: [LibTooling] Make interface of VFS injection into ClangTool more user-friendly

whisperity updated this revision to Diff 141204. whisperity added a comment. - Use an even more explicit way with the documentation requiring that the file system should be an overlay. - Add a method to easily overlay a `FileSystem` above the real one. Repository: rC Clang https://reviews.ll

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 5, 2018, at 12:39 PM, John McCall wrote: > > > >> On Apr 4, 2018, at 7:37 PM, Akira Hatanaka > > wrote: >> >> >> >>> On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits >>> mailto:cfe-commits@lists.llvm.org>> wrote: >>> On Apr 4, 2018

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

efriedma added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:345 // get default FPU features + llvm::ARM::ArchKind Arch = llvm::ARM::parseArch(getTriple().getArchName()); unsigned FPUKind = llvm::ARM::getDefaultFPU(CPU, Arch); fhahn wrote: > Is th

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Ok, I've tried it on top of clang-6.0.0 and I get the following test failures: Failing Tests (8): Clang :: Driver/android-ndk-standalone.cpp Clang :: Driver/constructors.c Clang :: Driver/cuda-detect.cu Clang :: Driver/env.c Clang :: Driver/

[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

whisperity added a comment. @alexfh I have updated the patch. I don't have commit rights, so if you think this is good to go, could you please commit for me? Repository: rC Clang https://reviews.llvm.org/D45096 ___ cfe-commits mailing list cfe-c

[PATCH] D44295: [clang-tidy] Detects and fixes calls to grand-...parent virtual methods instead of calls to parent's virtual methods

zinovy.nis updated this revision to Diff 141199. zinovy.nis added a comment. - Switched to use 'tooling::fixit::getText' for qualified names. - Shortened test code with {{.*}}. https://reviews.llvm.org/D44295 Files: clang-tidy/bugprone/BugproneTidyModule.cpp clang-tidy/bugprone/CMakeLists.t

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 4, 2018, at 7:37 PM, Akira Hatanaka wrote: > > > >> On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits >> mailto:cfe-commits@lists.llvm.org>> wrote: >> >>> >>> On Apr 4, 2018, at 3:38 PM, Richard Smith >> > wrote: >>> >>> Hi Akira, >>> >>> T

[PATCH] D45310: Warn about memcpy'ing non-trivial C structs

rjmccall added inline comments. Comment at: include/clang/AST/NonTrivialCStructTypeVisitor.h:12 +// +//===--===// + The header comment here was clearly just copied from another file. I would nam

[PATCH] D45306: PR36992 don't overwrite virtual bases in tail padding

rjmccall added a comment. Changing the requirements on the return-value slot would be an ABI break, no? And it would force to us to treat all complete-object constructions as nvsize-limited unless they're constructions of known sizeof-sized allocations. Comment at: CodeGen/C

[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

whisperity updated this revision to Diff 141194. whisperity added a comment. - Overload removed, now only one `CreateASTDumper` function remains. - Updated the call sites of this function to use this call. Repository: rC Clang https://reviews.llvm.org/D45096 Files: docs/HowToSetupToolingFo

[PATCH] D45176: implement recent "standard-layout" changes

This revision was automatically updated to reflect the committed changes. Closed by commit rC329332: DR1672, DR1813, DR1881, DR2120: Implement recent fixes to "standard (authored by rsmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D45176?vs=140897&id=141193#toc Reposit

r329332 - DR1672, DR1813, DR1881, DR2120: Implement recent fixes to "standard

Author: rsmith Date: Thu Apr 5 11:55:37 2018 New Revision: 329332 URL: http://llvm.org/viewvc/llvm-project?rev=329332&view=rev Log: DR1672, DR1813, DR1881, DR2120: Implement recent fixes to "standard layout" rules. The new rules say that a standard-layout struct has its first non-static data mem

[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rjmccall added a comment. In https://reviews.llvm.org/D42092#1057881, @rsmith wrote: > In https://reviews.llvm.org/D42092#983892, @rjmccall wrote: > > > This is definitely something that the personality function should handle. > > If we want to do heroic things in the absence of personality fun

[PATCH] D44659: [libcxx] Optimize -O0 performance for operators

timshen updated this revision to Diff 141189. timshen added a comment. Also optimize -O0 load and stores by using memcpy. https://reviews.llvm.org/D44659 Files: libcxx/include/experimental/simd libcxx/test/std/experimental/simd/simd.elementwise/operators.pass.cpp Index: libcxx/test/std/exp

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen marked 5 inline comments as done. timshen added inline comments. Comment at: libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:68 + +static_assert(!is_simd_mask::value, ""); + mclow.lists wrote: > How about a couple more negative tests

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

timshen updated this revision to Diff 141188. timshen added a comment. Addressed comments. https://reviews.llvm.org/D41148 Files: libcxx/include/experimental/__config libcxx/include/experimental/simd libcxx/include/module.modulemap libcxx/test/libcxx/double_include.sh.cpp libcxx/test/

[PATCH] D45277: [CUDA] Add amdgpu sub archs

tra added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: yaxunl wrote: > tra wrote: > > Unless you're planning to guarantee 1:1 match to functionality provided by > > nvidia's

[PATCH] D45277: [CUDA] Add amdgpu sub archs

yaxunl added inline comments. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: tra wrote: > Unless you're planning to guarantee 1:1 match to functionality provided by > nvidia's sm_32, it would b

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

rjmccall added a comment. The change LGTM, but please add a test. Repository: rC Clang https://reviews.llvm.org/D45305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r329324 - Remove the temporary availability checking workaround for

Author: arphaman Date: Thu Apr 5 11:12:06 2018 New Revision: 329324 URL: http://llvm.org/viewvc/llvm-project?rev=329324&view=rev Log: Remove the temporary availability checking workaround for the nested declarations in @interface. rdar://28825862 Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cp

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141182. manojgupta added a comment. Updated tests and added a sysroot to test that LDLIBS are picked by parsing /etc/env.d/gcc/tuple-version file. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver

[PATCH] D45102: Fix typo in comment -fmath-errno=0 -> -fno-math-errno

This revision was automatically updated to reflect the committed changes. Closed by commit rL329323: Fix typo in comment -fmath-errno=0 -> -fno-math-errno (authored by sbc, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45102 Files: cf

r329323 - Fix typo in comment -fmath-errno=0 -> -fno-math-errno

Author: sbc Date: Thu Apr 5 10:44:08 2018 New Revision: 329323 URL: http://llvm.org/viewvc/llvm-project?rev=329323&view=rev Log: Fix typo in comment -fmath-errno=0 -> -fno-math-errno The former is not a valid clang argument Differential Revision: https://reviews.llvm.org/D45102 Modified: c

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

benhamilton added a comment. > By default, Xcode has a "Line wrapping" setting Ah, that appears to just be a visual thing. Xcode doesn't actually insert newlines into the source code. Repository: rC Clang https://reviews.llvm.org/D45004 ___ cfe

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

benhamilton added a comment. Actually, a slight correction. By default, Xcode has a "Line wrapping" setting under Preferences -> Text editing which says: [ X ] Wrap lines to editor width Indent wrapped lines by: [4 ] Spaces which suggests people using Xcode may expect indentation

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

benhamilton added a comment. > A FormatStyle already contains a reference to the FormatStyleSet it was > created from and you can get the FormatStyle for a different language through > that. It might just be a bit hacky and not easy to understand as is, but > maybe there are easy abstractions t

[PATCH] D44764: [clangd] Use operator<< to prevent printers issues in Gtest

malaperle added a comment. @sammccall Are you OK with the latest version? Thanks! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D45277: [CUDA] Add amdgpu sub archs

tra added a comment. I didn't get a chance to review the patch before it got committed. Comment at: lib/Basic/Targets.cpp:161 +case CudaArch::GFX902: + return "320"; +case CudaArch::UNKNOWN: Unless you're planning to guarantee 1:1 match to function

[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

craig.topper added a comment. There's a similar patch for sqrt here https://reviews.llvm.org/D41168 and it uses a scalar sqrt and insert element for the scalar case. I think we need a consistent direction here. https://reviews.llvm.org/D45202 ___

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone updated this revision to Diff 141174. Quuxplusone added a comment. Finally learned how to "make check-clang" and actually run the test in the correct environment. Had to add `-fcxx-exceptions` to the command lines at the top of that file, because the code uses `throw`. @rsmith PTAL?

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

djasper added a comment. I'd go to great lengths to avoid adding new config options and so I don't think this would be a bad trade-off to make. Also, note that you might not actually have to change much. A FormatStyle already contains a reference to the FormatStyleSet it was created from and yo

[PATCH] D45006: [Tooling] A CompilationDatabase wrapper that infers header commands.

sammccall updated this revision to Diff 141172. sammccall added a comment. Address cross-language issues in a more comprehensive way. Prefers (potentially) same-language over cross-language, handles cross-language flag transfers correctly using -x and handling (dropping) -std. Repository: rC C

[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

craig.topper added a comment. But it’s not really consistent because the mask is being removed early for the packed intrinsics, but late for the scalar intrinsics. Doesn’t it also introduce extra code for fast isel? https://reviews.llvm.org/D45202 ___

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

MaskRay added a comment. Do we really want to keep editor plugins in the repository? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

malaperle added a comment. Do we need to bump the version of the extension and do a new release or anything like that? Or leave this for later? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D45285 ___ cfe-commits mailing list cfe-c

[PATCH] D45289: Disable -fmerge-all-constants as default.

This revision was automatically updated to reflect the committed changes. Closed by commit rC329300: Disable -fmerge-all-constants as default. (authored by manojgupta, committed by ). Changed prior to commit: https://reviews.llvm.org/D45289?vs=141081&id=141164#toc Repository: rC Clang https

[PATCH] D45289: Disable -fmerge-all-constants as default.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329300: Disable -fmerge-all-constants as default. (authored by manojgupta, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45289 Files: cfe/tru

r329301 - [ASTImporter] Fix for importing unnamed structs

Author: a.sidorin Date: Thu Apr 5 08:31:49 2018 New Revision: 329301 URL: http://llvm.org/viewvc/llvm-project?rev=329301&view=rev Log: [ASTImporter] Fix for importing unnamed structs Patch by Peter Szecsi! Differential Revision: https://reviews.llvm.org/D30876 Modified: cfe/trunk/lib/AST/

r329300 - Disable -fmerge-all-constants as default.

Author: manojgupta Date: Thu Apr 5 08:29:52 2018 New Revision: 329300 URL: http://llvm.org/viewvc/llvm-project?rev=329300&view=rev Log: Disable -fmerge-all-constants as default. Summary: "-fmerge-all-constants" is a non-conforming optimization and should not be the default. It is also causing mi

[PATCH] D44996: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rC329297: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D44996?vs=141161&id=141162#to

[PATCH] D45185: [clang-format] Support lightweight Objective-C generics

This revision was automatically updated to reflect the committed changes. Closed by commit rC329298: [clang-format] Support lightweight Objective-C generics (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D45185?vs=140968&id=141163#toc Repository:

[PATCH] D44996: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly

benhamilton updated this revision to Diff 141161. benhamilton added a comment. Add FIXME comments. Repository: rC Clang https://reviews.llvm.org/D44996 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index: unittests/Format/FormatTestObjC.cpp ==

r329298 - [clang-format] Support lightweight Objective-C generics

Author: benhamilton Date: Thu Apr 5 08:26:25 2018 New Revision: 329298 URL: http://llvm.org/viewvc/llvm-project?rev=329298&view=rev Log: [clang-format] Support lightweight Objective-C generics Summary: Previously, `clang-format` didn't understand lightweight Objective-C generics, which have the

r329297 - [clang-format] Ensure ObjC selectors with 0 args are annotated correctly

Author: benhamilton Date: Thu Apr 5 08:26:23 2018 New Revision: 329297 URL: http://llvm.org/viewvc/llvm-project?rev=329297&view=rev Log: [clang-format] Ensure ObjC selectors with 0 args are annotated correctly Summary: Previously, clang-format would incorrectly annotate 0-argument Objective-C se

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

benhamilton added a comment. > a user sets the existing IndentWrappedFunctionNames to true for ObjC and to > false for C++. > Now IMO, that should mean that ObjC function names are indented and C++ > functions are not, even if the language of the *file* is ObjC. > Getting this right will requ

[PATCH] D45185: [clang-format] Support lightweight Objective-C generics

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good, thank you! Repository: rC Clang https://reviews.llvm.org/D45185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

fhahn added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:345 // get default FPU features + llvm::ARM::ArchKind Arch = llvm::ARM::parseArch(getTriple().getArchName()); unsigned FPUKind = llvm::ARM::getDefaultFPU(CPU, Arch); Is there a reason we re

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 4, 2018, at 5:38 PM, Richard Smith wrote: > > On 4 April 2018 at 16:57, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Apr 4, 2018, at 4:47 PM, Richard Smith > > wrote: >> >> On 4 April 2018 at 16:24, Akira Hatanaka

[clang-tools-extra] r329292 - [clang-tidy] Remove google-runtime-member-string-references

Author: d0k Date: Thu Apr 5 07:51:01 2018 New Revision: 329292 URL: http://llvm.org/viewvc/llvm-project?rev=329292&view=rev Log: [clang-tidy] Remove google-runtime-member-string-references This is triggering on a pattern that's both too broad (const std::string& members can be used safely) and t

[libclc] r329291 - r600: Update datalayout after LLVM r328656

Author: jvesely Date: Thu Apr 5 07:47:57 2018 New Revision: 329291 URL: http://llvm.org/viewvc/llvm-project?rev=329291&view=rev Log: r600: Update datalayout after LLVM r328656 Signed-off-by: Jan Vesely Reviewed-by: Aaron Watry Modified: libclc/trunk/r600/lib/synchronization/barrier_impl.l

[libclc] r329290 - amdgcn: Update datalayout after LLVM r328656

Author: jvesely Date: Thu Apr 5 07:47:44 2018 New Revision: 329290 URL: http://llvm.org/viewvc/llvm-project?rev=329290&view=rev Log: amdgcn: Update datalayout after LLVM r328656 Signed-off-by: Jan Vesely Reviewed-by: Aaron Watry Modified: libclc/trunk/amdgcn/lib/cl_khr_int64_extended_atom

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

malcolm.parsons added a comment. In https://reviews.llvm.org/D43764#1058120, @jdemeule wrote: > Can I help in some way to close this PR? I applied the patch and ran the tests. There was one unexpected failure: [100%] Running the Clang extra tools' regression tests FAIL: Clang Tools :: cla

r329289 - [ObjC] Make C++ triviality type traits available to non-trivial C

Author: ahatanak Date: Thu Apr 5 07:39:57 2018 New Revision: 329289 URL: http://llvm.org/viewvc/llvm-project?rev=329289&view=rev Log: [ObjC] Make C++ triviality type traits available to non-trivial C structs. r326307 and r327870 made changes that allowed using non-trivial C structs with fields q

[PATCH] D45202: [X86] Replacing X86-specific floor and ceil vector intrinsics with generic LLVM intrinsics

mike.dvoretsky added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8307 +Dst = Ops[0]; +Mask = llvm::ConstantInt::get(CGF.Builder.getInt32Ty(), 1); + } else { craig.topper wrote: > I'm not sure we should even try to emit a mask for the leg

[PATCH] D45059: [clang-tidy] Add check to catch comparisons in TEMP_FAILURE_RETRY

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. The TEMP_FAILURE_RETRY macro is specific to the GNU C library (and environments that attempt to mimic it). The generic bugprone- module is not the best place for this check. I sugges

[PATCH] D45096: Allow the creation of human-friendly ASTDumper to arbitrary output stream

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good to me. One optional comment. Comment at: include/clang/Frontend/ASTConsumers.h:39-41 std::unique_ptr CreateASTDumper(StringRef FilterString,

[PATCH] D45319: [Atomics] warn about misaligned atomic accesses using libcalls

t.p.northover created this revision. t.p.northover added a reviewer: rsmith. t.p.northover added a project: clang. Herald added a subscriber: mcrosier. If an atomic variable is misaligned Clang will emit accesses to it as a libcall. These calls are likely to be slow and involve locks; they are al

  1   2   >