alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Looks good to me. One optional comment.
================
Comment at: include/clang/Frontend/ASTConsumers.h:39-41
std::unique_ptr<ASTConsumer> CreateASTDumper(StringRef FilterString,
bool DumpDecls, bool Deserialize,
bool DumpLookups);
----------------
With just three users of the old API it might make sense to just add a
parameter to it and update the callers instead of adding another override.
Repository:
rC Clang
https://reviews.llvm.org/D45096
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
