[PATCH] D45310: Warn about memcpy'ing non-trivial C structs

ahatanak created this revision. ahatanak added a reviewer: rjmccall. Issue a warning when non-trivial C structs (structs with '__weak' or '__strong' fields) are copied or initialized by calls to memset, bzero, memcpy, and memmove. This is similar to gcc's -Wclass-memaccess warning. It might be b

[PATCH] D43764: [clang-apply-replacements] Convert tooling::Replacements to tooling::AtomicChange for conflict resolving of changes, code cleanup, and code formatting.

jdemeule added a comment. Can I help in some way to close this PR? https://reviews.llvm.org/D43764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. If that's not a problem, then the more tests, the merrier ;-). Preferably something specific to crossdev would be helpful, given this is a new use case, and/or something that would actually have directory mismatches with CURRENT entry name (i.e. that wouldn't have worked

[PATCH] D42893: [libclang] Add clang_File_tryGetRealPathName

MaskRay added a comment. In https://reviews.llvm.org/D42893#1053754, @jbcoe wrote: > Can you add some simple tests? Where should I add tests? I cannot find tests for other clang_File_* functions. Repository: rC Clang https://reviews.llvm.org/D42893 __

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

EricWF marked 4 inline comments as done. EricWF added inline comments. Comment at: lib/Parse/ParseDeclCXX.cpp:1077-1087 + auto DiagSelect = [&]() -> Optional { +if (Info.MinArity && Info.MinArity == Info.MaxArity && +Info.MinArity != Args.size()) + return DiagIn

[PATCH] D45284: [RISCV] More validations on the input value of -march=

kito-cheng added a comment. Long time ago, GCC also accept upper case too, but I have no idea why Andrew change that? I guess one possible reason is because multi-lib? [1] https://github.com/riscv/riscv-gcc/commit/6531a11f03ec3a95cd8b9033daeab0ebf23b5472 https://reviews.llvm.org/D45284 ___

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

EricWF marked 10 inline comments as done. EricWF added inline comments. Comment at: include/clang/AST/Type.h:3990 /// The untransformed type. - QualType BaseType; + SmallVector ArgTypes; rsmith wrote: > You can't store types with non-trivial destructors on

[PATCH] D45004: [clang-format] New style option IndentWrappedObjCMethodNames

stephanemoore added a comment. Update: I am proposing to update the Google Objective-C style guide to explicitly describe the desired indentation behavior. Comment at: include/clang/Format/Format.h:1154-1163 + /// \brief The style of indenting long function or method names wr

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141099. manojgupta added a comment. Avoid double appending of sysroot prefix to base path. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h test/Driver/Inputs/gentoo_linux_gcc

[PATCH] D45131: [AST] Refactor UnaryTransformType into TransformTraitType supporting non-unary transforms

rsmith added inline comments. Comment at: include/clang/AST/Type.h:3990 /// The untransformed type. - QualType BaseType; + SmallVector ArgTypes; You can't store types with non-trivial destructors on AST nodes; the Type destructor will never run, so you'll

[PATCH] D45306: PR36992 don't overwrite virtual bases in tail padding

rsmith created this revision. rsmith added a reviewer: rjmccall. Herald added subscribers: cfe-commits, sanjoy. When initializing a base class, we might accidentally overwrite a virtual base in its tail padding in some situations (in particular, when emitting a trivial copy constructor as a memc

[PATCH] D45234: CMake: Check LLVM_ENABLE_LIBXML2 in clang

rinon added a comment. I'd be fine with not building c-index-test when building clang, but I didn't see any easy way to disable it. My use-case here is just to build LLVM+clang without having to link against my system libxml2 at all. It's a rather weird build situation, but Android builds a to

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added a comment. Modified an existing gentoo sysroot as the test case. Please let me know if you want me checkin a new sysroot. Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141096. manojgupta added a comment. Fix a bug in passing the actual path when libraries are present in sysroot. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h test/Driver/In

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

On 4 April 2018 at 16:57, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Apr 4, 2018, at 4:47 PM, Richard Smith wrote: > > On 4 April 2018 at 16:24, Akira Hatanaka via cfe-commits lists.llvm.org> wrote: > >> >> On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: >> >> H

r329247 - Revert r328680 ("[ObjC] Make C++ triviality type traits available to non-trivial C structs.")

Author: rsmith Date: Wed Apr 4 17:34:54 2018 New Revision: 329247 URL: http://llvm.org/viewvc/llvm-project?rev=329247&view=rev Log: Revert r328680 ("[ObjC] Make C++ triviality type traits available to non-trivial C structs.") It unintentionally caused the values of the __has_* type traits to ch

[PATCH] D45305: ObjCGNU: Fix empty v3 protocols being emitted two fields short

DHowett-MSFT created this revision. DHowett-MSFT added reviewers: rjmccall, theraven. DHowett-MSFT added a project: clang. Herald added a subscriber: cfe-commits. Protocols that were being referenced but could not be fully realized were being emitted without `properties`/`optional_properties`. Si

[libcxx] r329245 - [coroutines] libcxx, noop_coroutine, make bots even more happy

Author: gornishanov Date: Wed Apr 4 17:18:37 2018 New Revision: 329245 URL: http://llvm.org/viewvc/llvm-project?rev=329245&view=rev Log: [coroutines] libcxx, noop_coroutine, make bots even more happy Modified: libcxx/trunk/include/experimental/coroutine libcxx/trunk/test/std/experimenta

[PATCH] D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL329244: [AST] Don't track lambda captures when checking a potential constant expression. (authored by epilk, committed by

r329244 - [AST] Don't track lambda captures when checking a potential constant expression.

Author: epilk Date: Wed Apr 4 17:12:05 2018 New Revision: 329244 URL: http://llvm.org/viewvc/llvm-project?rev=329244&view=rev Log: [AST] Don't track lambda captures when checking a potential constant expression. Fixes PR36054. Differential revision: https://reviews.llvm.org/D45194 Modified:

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

phosek added a comment. I don't like this but I'm not sure if there's a better way to do this, do you have any ideas? Repository: rCXX libc++ https://reviews.llvm.org/D45304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D45304: [libcxx] Set ABI version 2 as default for Fuchsia

phosek created this revision. phosek added a reviewer: EricWF. Herald added subscribers: cfe-commits, christof, mgorny. phosek added a comment. I don't like this but I'm not sure if there's a better way to do this, do you have any ideas? This avoids the need for a custom generated config file.

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 4, 2018, at 4:47 PM, Richard Smith wrote: > > On 4 April 2018 at 16:24, Akira Hatanaka via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > >> On Apr 4, 2018, at 3:38 PM, Richard Smith > > wrote: >> >> Hi Akira, >> >> This change has broken th

[PATCH] D44927: Enable msan unconditionally on Linux

eugenis added a comment. Merged. Please don't forget to update tests next time. Repository: rL LLVM https://reviews.llvm.org/D44927 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44927: Enable msan unconditionally on Linux

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL329241: Enable msan unconditionally on Linux. (authored by eugenis, committed by ). Herald added a subscriber: llvm-commit

r329241 - Enable msan unconditionally on Linux.

Author: eugenis Date: Wed Apr 4 16:48:06 2018 New Revision: 329241 URL: http://llvm.org/viewvc/llvm-project?rev=329241&view=rev Log: Enable msan unconditionally on Linux. Memory sanitizer compatibility are already done in MemorySanitizer::doInitialization. It verifies whether the necessary offse

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

On 4 April 2018 at 16:24, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: > > Hi Akira, > > This change has broken the C++ versions of these type traits for classes > with volatile members. Such classes are required to claim

[libcxx] r329240 - [coroutines] libcxx noop_coroutine. Make bots happier

Author: gornishanov Date: Wed Apr 4 16:43:50 2018 New Revision: 329240 URL: http://llvm.org/viewvc/llvm-project?rev=329240&view=rev Log: [coroutines] libcxx noop_coroutine. Make bots happier Modified: libcxx/trunk/test/std/experimental/language.support/support.coroutines/coroutine.handle/co

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

On 4 April 2018 at 16:37, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > > On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: > > Hi Akira, > > This change has broken the

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

On 4 April 2018 at 16:24, Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: > > Hi Akira, > > This change has broken the C++ versions of these type traits for classes > with volatile members. Such classes are required to claim

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 4, 2018, at 4:24 PM, Akira Hatanaka via cfe-commits > wrote: > >> >> On Apr 4, 2018, at 3:38 PM, Richard Smith > > wrote: >> >> Hi Akira, >> >> This change has broken the C++ versions of these type traits for classes >> with volatile members. Such cla

[PATCH] D42092: implement C++ dr388 for the Itanium C++ ABI: proper handling of catching exceptions by reference

rsmith added a comment. In https://reviews.llvm.org/D42092#983892, @rjmccall wrote: > This is definitely something that the personality function should handle. If > we want to do heroic things in the absence of personality function support, > we can, but the code should at least be written to

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

> On Apr 4, 2018, at 3:38 PM, Richard Smith wrote: > > Hi Akira, > > This change has broken the C++ versions of these type traits for classes with > volatile members. Such classes are required to claim to be trivial per C++ DR > 2094 (http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.ht

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

NoQ added inline comments. Comment at: lib/Analysis/CFG.cpp:1435 /// extended by a local reference with the given initializer. static QualType getReferenceInitTemporaryType(ASTContext &Context, const Expr *Init, rs

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta updated this revision to Diff 141084. manojgupta added a comment. Fix some typos. Reduced indent in the loop. Repository: rC Clang https://reviews.llvm.org/D45233 Files: lib/Driver/ToolChains/Gnu.cpp lib/Driver/ToolChains/Gnu.h Index: lib/Driver/ToolChains/Gnu.h =

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta added inline comments. Comment at: include/clang/Driver/Options.td:1286 def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants">, Group, Flags<[CC1Option]>, HelpText<"Disallow merging of constants">; def fno_modules : Flag <["-"], "fno-modules">, Gr

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta updated this revision to Diff 141081. manojgupta added a comment. Bring back Help Text for "-fno-merge-all-constants" Repository: rC Clang https://reviews.llvm.org/D45289 Files: include/clang/Driver/Options.td lib/AST/ExprConstant.cpp lib/Driver/ToolChains/Clang.cpp lib/Fr

[PATCH] D45240: [ARM] Compute a target feature which corresponds to the ARM version.

efriedma updated this revision to Diff 141078. efriedma added a comment. Fixed to use the arch name as the "feature"; otherwise, we miss relevant features in certain cases. This is taken from ARMAsmParser::parseDirectiveArch. Repository: rC Clang https://reviews.llvm.org/D45240 Files: li

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

phosek marked an inline comment as done. phosek added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D44330 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41748: [libcxx] [test] Fix Xxx_scan tests using nonstandard things and MSVC++ warnings

BillyONeal added a comment. @EricWF / @mclow.lists Any chance you could take a look sometime soon? https://reviews.llvm.org/D41748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

mclow.lists added inline comments. Comment at: libcxx/test/std/experimental/simd/simd.traits/is_abi_tag.pass.cpp:44 +static_assert(is_abi_tag>::value, ""); +static_assert(is_abi_tag>::value, ""); + Needs negative tests. Comment at: libcxx/test

[libcxx] r329239 - [coroutines] Allow compilation under c++03

Author: gornishanov Date: Wed Apr 4 15:51:57 2018 New Revision: 329239 URL: http://llvm.org/viewvc/llvm-project?rev=329239&view=rev Log: [coroutines] Allow compilation under c++03 Modified: libcxx/trunk/include/experimental/coroutine Modified: libcxx/trunk/include/experimental/coroutine URL

[PATCH] D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class.

erik.pilkington added a comment. > LGTM - can you commit? Yep, I'll do that now. Thanks for reviewing! Comment at: clang/lib/AST/ExprConstant.cpp:5212 + cast(E)->refersToEnclosingVariableOrCapture()) { +// We don't track the lambda's captures in a potential constant e

[PATCH] D44927: Enable msan unconditionally on Linux

vit9696 added a comment. Now that https://reviews.llvm.org/D44926 was merged upstream, may I request this to be merged as well? As stated above it is pretty much pointless to have the check doubled, and after more than a week nobody thought of any issue. Thanks :) Repository: rC Clang https

[PATCH] D45289: Disable -fmerge-all-constants as default.

rjmccall added inline comments. Comment at: include/clang/Driver/Options.td:1286 def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants">, Group, Flags<[CC1Option]>, HelpText<"Disallow merging of constants">; def fno_modules : Flag <["-"], "fno-modules">, Grou

[PATCH] D45294: [libcxx] [test] Remove non-portable assertions from filebuf's seekoff.pass.cpp test

BillyONeal created this revision. BillyONeal added reviewers: mclow.lists, EricWF. libc++'s tests are asserting things about the buffer passed to pubsetbuf. [filebuf.virtuals]/12 says that what the filebuf does with the buffer you give it is completely implementation defined. The MSVC++ implemen

Re: r328680 - [ObjC] Make C++ triviality type traits available to non-trivial C

Hi Akira, This change has broken the C++ versions of these type traits for classes with volatile members. Such classes are required to claim to be trivial per C++ DR 2094 ( http://www.open-std.org/jtc1/sc22/wg21/docs/cwg_defects.html#2094) but return false from isNonTrivialToPrimitiveCopy(). Also

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta updated this revision to Diff 141075. manojgupta added a comment. Removed unused CC1 option and updated broken tests. Repository: rC Clang https://reviews.llvm.org/D45289 Files: include/clang/Driver/Options.td lib/AST/ExprConstant.cpp lib/Driver/ToolChains/Clang.cpp lib/Fr

[PATCH] D45152: [MinGW] Add option for disabling looking for a mingw gcc in PATH

martell added a comment. @mstorsjo I would much prefer to detect the clang sysroot first and if that exists just ignore the gcc one. Most of the time clang and gcc will be in the same bin folder and in the case where the clang sysroot with mingw prefix folders is not found we can just default b

[PATCH] D45289: Disable -fmerge-all-constants as default.

rjmccall added a comment. It's not unreasonable to just add -fmerge-all-constants to the command line invocations for the individual tests, yeah. We can take those off as necessary later. Repository: rC Clang https://reviews.llvm.org/D45289 __

[libcxx] r329237 - [coroutines] Add noop_coroutine to

Author: gornishanov Date: Wed Apr 4 15:18:03 2018 New Revision: 329237 URL: http://llvm.org/viewvc/llvm-project?rev=329237&view=rev Log: [coroutines] Add noop_coroutine to A recent addition to Coroutines TS (https://wg21.link/p0913) adds a pre-defined coroutine noop_coroutine that does nothing.

[PATCH] D29768: [TargetInfo] Set 'UseSignedCharForObjCBool' to false by default

arphaman updated this revision to Diff 141070. arphaman added a comment. Only make the change for the Darwin platforms to avoid ObjC ABI breakage for non-Darwin platforms. https://reviews.llvm.org/D29768 Files: lib/Basic/TargetInfo.cpp lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta added a comment. Thanks a lot for the quick review! There a bunch of broken tests because of different IR generated. Is it preferable to fix them individually or add the option -fmerge-all-constants to clang arguments to avoid figuring out changes needed to fix the tests? Reposito

[PATCH] D45292: [Driver] Obey computed sysroot when finding libc++ headers.

danalbert created this revision. danalbert added a reviewer: srhines. Herald added a reviewer: EricWF. A handful of targets will try some default paths if --sysroot is not provided. If that is the case, it should be used for the libc++ header paths. Repository: rC Clang https://reviews.llvm.o

[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329236: AArch64: Implement support for the shadowcallstack attribute. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D45239?vs=141063&id=141068#toc Repository: rL

[PATCH] D44842: Add Parameters to DW_AT_name Attribute of Template Variables

ormris abandoned this revision. ormris added a comment. I'm abandoning this revision based on some internal feedback. Thanks for the review @JDevlieghere and @jingham! Repository: rC Clang https://reviews.llvm.org/D44842 ___ cfe-commits mailing

r329236 - AArch64: Implement support for the shadowcallstack attribute.

Author: pcc Date: Wed Apr 4 14:55:44 2018 New Revision: 329236 URL: http://llvm.org/viewvc/llvm-project?rev=329236&view=rev Log: AArch64: Implement support for the shadowcallstack attribute. The implementation of shadow call stack on aarch64 is quite different to the implementation on x86_64. In

[PATCH] D45291: [Driver] Infer Android sysroot location.

danalbert created this revision. danalbert added a reviewer: srhines. Android toolchains include their headers and libraries in a self-contained directory within the toolchain. Repository: rC Clang https://reviews.llvm.org/D45291 Files: lib/Driver/ToolChains/Linux.cpp Index: lib/Driver/T

[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

pcc updated this revision to Diff 141063. pcc marked 3 inline comments as done. pcc added a comment. - Addres review comments https://reviews.llvm.org/D45239 Files: clang/docs/ShadowCallStack.rst clang/lib/Driver/SanitizerArgs.cpp clang/lib/Driver/ToolChain.cpp clang/test/Driver/sanitiz

[PATCH] D45289: Disable -fmerge-all-constants as default.

chandlerc accepted this revision. chandlerc added a comment. Just wanted to explicitly say +1 to this default change (with the adjustment Richard suggested). Also, John already said +1 to this default change on the bug. Repository: rC Clang https://reviews.llvm.org/D45289 ___

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

rnk accepted this revision. rnk added a comment. Thousands of lines of C++ to answer one of life's most simple questions: where are the libraries and where are the headers. =p lgtm Comment at: lib/Driver/ToolChains/Gnu.cpp:2275 // CURRENT=triple-version if (Line

[PATCH] D45290: [Driver] Use the per-API level Android library directories.

danalbert created this revision. danalbert added a reviewer: srhines. Herald added a subscriber: javed.absar. Android sysroots contain libraries for each OS version, as well as a handful of unversioned libraries in the typical multiarch directory. Repository: rC Clang https://reviews.llvm.org

[PATCH] D44995: [Driver] Include the Android multiarch includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL329234: [Driver] Include the Android multiarch includes. (authored by danalbert, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D44995 Files: c

r329234 - [Driver] Include the Android multiarch includes.

Author: danalbert Date: Wed Apr 4 14:28:34 2018 New Revision: 329234 URL: http://llvm.org/viewvc/llvm-project?rev=329234&view=rev Log: [Driver] Include the Android multiarch includes. Summary: Most Android headers live in a single directory, but a small handful live in multiarch directories. Re

[PATCH] D45289: Disable -fmerge-all-constants as default.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. One minor change, then this looks good to me. Thank you! Comment at: include/clang/Driver/Options.td:1286 def fno_merge_all_constants : Flag<["-"], "fno-merge-all-constants"

[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

eugenis added inline comments. Comment at: clang/docs/ShadowCallStack.rst:12 ShadowCallStack is an **experimental** instrumentation pass, currently only implemented for x86_64, that protects programs against return address overwrites (e.g. stack buffer overflows.) It works by

[PATCH] D45239: AArch64: Implement support for the shadowcallstack attribute.

vlad.tsyrklevich accepted this revision. vlad.tsyrklevich added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ShadowCallStack.rst:12 ShadowCallStack is an **experimental** instrumentation pass, currently only implemented for x86_64, th

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

DHowett-MSFT updated this revision to Diff 141055. DHowett-MSFT added a comment. Switched from `i686-windows` to `i686-unknown-windows-msvc` as per @compnerd's suggestion. Based on the prior discussion around MSVC's definition of `va_{start,end,arg}` and how it is not a valid implementation that

[PATCH] D44238: [CFG] Fix automatic destructors when a member is bound to a reference.

rsmith added inline comments. Comment at: lib/Analysis/CFG.cpp:1435 /// extended by a local reference with the given initializer. static QualType getReferenceInitTemporaryType(ASTContext &Context, const Expr *Init,

[PATCH] D45289: Disable -fmerge-all-constants as default.

manojgupta created this revision. manojgupta added reviewers: rjmccall, rsmith, chandlerc. "-fmerge-all-constants" is a non-conforming optimization and should not be the default. It is also causing miscompiles when building Linux Kernel (https://lkml.org/lkml/2018/3/20/872). Fixes PR18538. Repo

r329232 - [CUDA] Add amdgpu sub archs

Author: yaxunl Date: Wed Apr 4 14:19:27 2018 New Revision: 329232 URL: http://llvm.org/viewvc/llvm-project?rev=329232&view=rev Log: [CUDA] Add amdgpu sub archs Patch by Greg Rodgers. Revised and lit tests added by Yaxun Liu. Differential Revision: https://reviews.llvm.org/D45277 Modified:

[PATCH] D45277: [CUDA] Add amdgpu sub archs

This revision was automatically updated to reflect the committed changes. Closed by commit rC329232: [CUDA] Add amdgpu sub archs (authored by yaxunl, committed by ). Repository: rC Clang https://reviews.llvm.org/D45277 Files: include/clang/Basic/Cuda.h lib/Basic/Cuda.cpp lib/Basic/Targe

[PATCH] D41148: [libcxx] implement declarations based on P0214R7.

mclow.lists added a comment. When you add a new header file to libc++, you have to update two additional files: - include/module.modulemap - test/libcxx/double_include.sh.cpp See http://llvm.org/viewvc/llvm-project?view=revision&revision=329144 for an example of how to do this.

[PATCH] D42034: [clang-format] In tests, expected code should be format-stable

This revision was automatically updated to reflect the committed changes. Closed by commit rL329231: [clang-format] In tests, expected code should be format-stable (authored by mzeren-vmw, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42

r329231 - [clang-format] In tests, expected code should be format-stable

Author: mzeren-vmw Date: Wed Apr 4 14:09:00 2018 New Revision: 329231 URL: http://llvm.org/viewvc/llvm-project?rev=329231&view=rev Log: [clang-format] In tests, expected code should be format-stable Summary: Extend various verifyFormat helper functions to check that the expected text is "stable"

[PATCH] D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class.

faisalv added a comment. LGTM - can you commit? Thank you! Comment at: clang/lib/AST/ExprConstant.cpp:4313 +// We're in a lambda; determine the lambda capture field maps unless we're +// just constexpr checking a lambda's call operator. constexpr checking is +// don

[PATCH] D44995: [Driver] Include the Android multiarch includes.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Thanks for adding this support. Sorry about the delay in reviewing. Repository: rC Clang https://reviews.llvm.org/D44995 ___ cfe-commits mai

[PATCH] D45284: [RISCV] More validations on the input value of -march=

asb added inline comments. Comment at: test/Driver/riscv-arch.c:151 +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-LETTER %s +// RV32-LETTER: error: invalid arch name 'rv32e', +// RV32-LETTER: first letter should be 'e', 'i' or 'g' But rv32e is a vali

[PATCH] D44995: [Driver] Include the Android multiarch includes.

danalbert updated this revision to Diff 141053. danalbert added a comment. Fix some style issues. Repository: rC Clang https://reviews.llvm.org/D44995 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/Inputs/basic_android_ndk_tree/include/c++/4.9/x86_64-linux-android/.keep test/Driv

[PATCH] D45288: [Driver] Include the Android multiarch includes.

danalbert abandoned this revision. danalbert added a comment. was supposed to be an update of https://reviews.llvm.org/D44995 Repository: rC Clang https://reviews.llvm.org/D45288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D45288: [Driver] Include the Android multiarch includes.

danalbert created this revision. danalbert added a reviewer: srhines. Herald added a subscriber: javed.absar. Most Android headers live in a single directory, but a small handful live in multiarch directories. Repository: rC Clang https://reviews.llvm.org/D45288 Files: lib/Driver/ToolChain

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

manojgupta added reviewers: thakis, rnk. manojgupta added a comment. Adding more reviewers. Repository: rC Clang https://reviews.llvm.org/D45233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 141050. apazos added a comment. fixed test merged line https://reviews.llvm.org/D45284 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index: test/Driver/riscv-arch.c ==

r329229 - Revert "[CUDA] Check initializers of instantiated template variables."

Author: tra Date: Wed Apr 4 13:48:42 2018 New Revision: 329229 URL: http://llvm.org/viewvc/llvm-project?rev=329229&view=rev Log: Revert "[CUDA] Check initializers of instantiated template variables." This (temporarily) reverts commit r329127 due to the problems it exposed in TensorFlow. Modifie

[PATCH] D29768: [TargetInfo] Set 'UseSignedCharForObjCBool' to false by default

arphaman updated this revision to Diff 141045. arphaman marked 2 inline comments as done. arphaman added a comment. Herald added subscribers: jkorous-apple, kbarton, javed.absar, nemanjai. Sorry, missed the comments last year. Updated. Repository: rC Clang https://reviews.llvm.org/D29768 Fil

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 141048. apazos added a comment. test fix https://reviews.llvm.org/D45284 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index: test/Driver/riscv-arch.c

[PATCH] D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class.

erik.pilkington added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4312 + } else if (MD && isLambdaCallOperator(MD) + && !Info.checkingPotentialConstantExpression()) { // We're in a lambda; determine the lambda capture field maps.

[PATCH] D45194: [Sema] Defer checking constexpr lambda until after we've finished the lambda class.

erik.pilkington updated this revision to Diff 141042. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Add refersToEnclosingVariableOrCaptureCheck(), comments. https://reviews.llvm.org/D45194 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaCXX/cxx1z-co

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos updated this revision to Diff 141043. apazos added a comment. updated test case https://reviews.llvm.org/D45284 Files: include/clang/Basic/DiagnosticDriverKinds.td lib/Driver/ToolChains/Arch/RISCV.cpp test/Driver/riscv-arch.c Index: test/Driver/riscv-arch.c ===

[PATCH] D44449: [Parser] Fix assertion-on-invalid for unexpected typename.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks, seems reasonable to me. Comment at: clang/lib/Parse/ParseDecl.cpp:3076 DS.SetRangeEnd(Tok.getAnnotationEndLoc()); ConsumeAnnotationToken(); // The t

[PATCH] D45285: [clangd-vscode] Update VScode dependencies

malaperle created this revision. Herald added subscribers: cfe-commits, MaskRay, ioeric, jkorous-apple, ilya-biryukov, klimek. malaperle retitled this revision from "[clangd-vscode] Vscode dependencies" to "[clangd-vscode] Update VScode dependencies". This allows the extension to work with LSP 3

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added inline comments. Comment at: clangd/ClangdLSPServer.cpp:101 + // All clients should support those. + for (SymKindUnderlyingType I = SymbolKindMin; + I <= static_cast(SymbolKind::Array); ++I) I'd like to add some test to exercise the change

[PATCH] D45284: [RISCV] More validations on the input value of -march=

apazos created this revision. apazos added reviewers: asb, kito-cheng. Herald added subscribers: shiva0217, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar. - Updated diagnostic messages for invalid/unsupported march combinations. - Parsing X, SX and S extensions. https://revi

[PATCH] D35181: Defer addition of keywords to identifier table when loading AST

jklaehn updated this revision to Diff 141033. jklaehn set the repository for this revision to rC Clang. jklaehn added a comment. ping? (rebased) Repository: rC Clang https://reviews.llvm.org/D35181 Files: include/clang/Basic/IdentifierTable.h lib/Basic/IdentifierTable.cpp lib/Lex/Prepr

[PATCH] D45233: [Driver] Update GCC libraries detection logic for Gentoo.

mgorny added a comment. Thanks. Besides that one tiny nit, looks good at a first glance. I'll test it tomorrow or the next day (but only for the most basic use, sorry). However, I do not feel confident enough with Clang code to ack change this large on my own. So let's wait for @chandlerc to ta

r329225 - [analyzer][test] Set C++14 as language standard for test depending on new

Author: jkorous Date: Wed Apr 4 12:58:48 2018 New Revision: 329225 URL: http://llvm.org/viewvc/llvm-project?rev=329225&view=rev Log: [analyzer][test] Set C++14 as language standard for test depending on new features Modified: cfe/trunk/test/Analysis/missing-bind-temporary.cpp Modified: cfe/

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle updated this revision to Diff 141028. malaperle marked 27 inline comments as done. malaperle added a comment. Address comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 Files: clangd/CMakeLists.txt clangd/ClangdLSPServer.cpp clangd/ClangdLSPServer.h

[PATCH] D44882: [clangd] Implementation of workspace/symbol request

malaperle added inline comments. Comment at: clangd/ClangdLSPServer.cpp:99 Params.capabilities.textDocument.completion.completionItem.snippetSupport; + if (Params.capabilities.workspace && Params.capabilities.workspace->symbol && + Params.capabilities.workspace->sym

[PATCH] D45178: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960

This revision was automatically updated to reflect the committed changes. Closed by commit rC329223: Fixes errors with FS iterators caused by https://reviews.llvm.org/D44960 (authored by Dor1s, committed by ). Changed prior to commit: https://reviews.llvm.org/D45178?vs=141026&id=141027#toc Rep

[PATCH] D45257: [X86] Introduce cldemote intrinsic

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D45257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

  1   2   >