[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL326542: [Frontend] Avoid including default system header paths on Fuchsia (authored by phosek, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

r326542 - [Frontend] Avoid including default system header paths on Fuchsia

Author: phosek Date: Thu Mar 1 23:19:42 2018 New Revision: 326542 URL: http://llvm.org/viewvc/llvm-project?rev=326542&view=rev Log: [Frontend] Avoid including default system header paths on Fuchsia These paths aren't used and don't make sense on Fuchsia. Differential Revision: https://reviews.l

[PATCH] D43741: [Analyzer] More accurate modeling about the increment operator of the operand with type bool.

alexshap added a comment. i see, but just in case - what about the decrement operator ? Repository: rC Clang https://reviews.llvm.org/D43741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang https://reviews.llvm.org/D43992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D43995: Do not generate calls to fentry with __attribute__((no_instrument_function))

manojgupta created this revision. manojgupta added reviewers: hfinkel, rengolin, srhines, chandlerc. Currently only calls to mcount were suppressed with no_instrument_function attribute. Linux kernel requires that calls to fentry should also not be generated. This is an extended fix for PR PR33515

[PATCH] D43992: [Frontend] Avoid including default system header paths on Fuchsia

phosek created this revision. phosek added reviewers: mcgrathr, jakehehrlich. Herald added a subscriber: cfe-commits. These paths aren't used and don't make sense on Fuchsia. Repository: rC Clang https://reviews.llvm.org/D43992 Files: clang/lib/Frontend/InitHeaderSearch.cpp Index: clang/

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 136660. juliehockett marked an inline comment as done. juliehockett added a comment. Cleaning up some and updating based on changes to the parent diff. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h c

r326531 - Remove debugging code I accidentally committed in r326530.

Author: ahatanak Date: Thu Mar 1 18:03:21 2018 New Revision: 326531 URL: http://llvm.org/viewvc/llvm-project?rev=326531&view=rev Log: Remove debugging code I accidentally committed in r326530. Modified: cfe/trunk/lib/Sema/SemaPseudoObject.cpp Modified: cfe/trunk/lib/Sema/SemaPseudoObject.cp

[PATCH] D43841: Add an option to disable tail-call optimization for escaping blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rL326530: Add an option to disable tail-call optimization for escaping blocks. (authored by ahatanak, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm

r326530 - Add an option to disable tail-call optimization for escaping blocks.

Author: ahatanak Date: Thu Mar 1 17:53:15 2018 New Revision: 326530 URL: http://llvm.org/viewvc/llvm-project?rev=326530&view=rev Log: Add an option to disable tail-call optimization for escaping blocks. This makes it easier to debug crashes and hangs in block functions since users can easily fin

[PATCH] D43990: set dso_local on tls init functions

espindola created this revision. espindola added a reviewer: echristo. We copy the visibility, so copying the dso_local flag seems the natural thing to do. https://reviews.llvm.org/D43990 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/runtime-dllstorage.cpp Index: test/CodeGenCXX/r

r326529 - [analyzer] [tests] Again, make tests more resilient to changes in exploration strategy

Author: george.karpenkov Date: Thu Mar 1 17:41:19 2018 New Revision: 326529 URL: http://llvm.org/viewvc/llvm-project?rev=326529&view=rev Log: [analyzer] [tests] Again, make tests more resilient to changes in exploration strategy Modified: cfe/trunk/test/Analysis/MisusedMovedObject.cpp c

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek added a comment. Ping? Can we land this as a temporary solution until the config generator logic is rewritten? This is currently breaking the libFuzzer build for us. Repository: rCXX libc++ https://reviews.llvm.org/D43797 ___ cfe-commits

r326527 - Always set dso_local in CodeGenModule::setDSOLocal.

Author: rafael Date: Thu Mar 1 17:29:51 2018 New Revision: 326527 URL: http://llvm.org/viewvc/llvm-project?rev=326527&view=rev Log: Always set dso_local in CodeGenModule::setDSOLocal. This shouldn't change any results for now, but is more consistent with how we set dllimport/dllexport and will m

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeWriter.cpp:196 +/// \brief Emits a record name to the BLOCKINFO block. +void ClangDocBitcodeWriter::emitRecordID(RecordId ID) { + assert(RecordIdNameMap[ID] && "Unknown Abbreviation"); lebedev.ri w

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136650. juliehockett marked 16 inline comments as done. juliehockett added a comment. Adding tests, fixing comments, and removing an (as-of-yet) unused element of the CommentInfo struct. https://reviews.llvm.org/D41102 Files: CMakeLists.txt clang-

[PATCH] D43925: [analyzer] Prevent crashing in NonNullParamChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rC326520: [analyzer] Prevent crashing in NonNullParamChecker (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D43925 F

[PATCH] D43731: [clang-format] Fix documentation for SpaceAfterCStyleCast option

EricMarti updated this revision to Diff 136645. EricMarti added a comment. Herald added a subscriber: klimek. Updated the comment in Format.h and ran the python script. Looks like a few more changes got pulled into the rst file. https://reviews.llvm.org/D43731 Files: docs/ClangFormatStyleOpt

r326520 - [analyzer] Prevent crashing in NonNullParamChecker

Author: george.karpenkov Date: Thu Mar 1 16:55:59 2018 New Revision: 326520 URL: http://llvm.org/viewvc/llvm-project?rev=326520&view=rev Log: [analyzer] Prevent crashing in NonNullParamChecker https://bugs.llvm.org/show_bug.cgi?id=36381 rdar://37543426 Turns out, the type passed for the lambda

r326519 - [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Thu Mar 1 16:54:51 2018 New Revision: 326519 URL: http://llvm.org/viewvc/llvm-project?rev=326519&view=rev Log: [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/StaticAnaly

r326518 - [analyzer] [NFC] [tests] Make test more resilient to changes in exploration strategy

Author: george.karpenkov Date: Thu Mar 1 16:54:05 2018 New Revision: 326518 URL: http://llvm.org/viewvc/llvm-project?rev=326518&view=rev Log: [analyzer] [NFC] [tests] Make test more resilient to changes in exploration strategy Modified: cfe/trunk/test/Analysis/MisusedMovedObject.cpp Modifi

[PATCH] D43681: [WebAssembly] Add exception handling option

This revision was automatically updated to reflect the committed changes. Closed by commit rL326517: [WebAssembly] Add exception handling option (authored by aheejin, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43681 Files: cfe/trun

r326517 - [WebAssembly] Add exception handling option

Author: aheejin Date: Thu Mar 1 16:39:16 2018 New Revision: 326517 URL: http://llvm.org/viewvc/llvm-project?rev=326517&view=rev Log: [WebAssembly] Add exception handling option Summary: Add exception handling option to clang. Reviewers: dschuff Subscribers: jfb, sbc100, jgravelle-google, sunfi

[PATCH] D43980: Push a function scope when parsing function bodies without a declaration

rnk created this revision. rnk added a reviewer: rsmith. This is PR36536. There are a few ways to reach Sema::ActOnStartOfFunctionDef with a null Decl. Currently, the parser continues on to attempt to parse the statements in the function body without pushing a function scope or declaration contex

r326512 - [NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying r326501.)

Author: dlj Date: Thu Mar 1 16:07:45 2018 New Revision: 326512 URL: http://llvm.org/viewvc/llvm-project?rev=326512&view=rev Log: [NFC] Move CommentOpts checks to the call sites that depend on it. (Re-applying r326501.) When parsing comments, for example, for -Wdocumentation, slightly different

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: include/clang/AST/Attr.h:206 + + void cmpable(const ParamIdx &I) const { +assert(isValid() && I.isValid() && aaron.ballman wrote: > jdenny wrote: > > aaron.ballman wrote: > > > The name here can be improved. How abou

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 136624. jdenny marked 23 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. This update should address all outstanding comments. https://reviews.llvm.org/D43248 Files: include/clang/AST/Attr.h include/clang/Basic

Re: r326141 - Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver."

I want to do that, but it will surely break the LLDB test suite, which assumes `clang -g` makes dwarf. It's just a matter of fixing up the flags their test makefiles use. On Thu, Mar 1, 2018 at 3:22 PM Nico Weber wrote: > Should we key the default off the triple? (I thought that what was the >

Re: r326141 - Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver."

Should we key the default off the triple? (I thought that what was the patch did, but I misread.) I.e. with an MSVC triple, default to emitting codeview? On Mon, Feb 26, 2018 at 5:55 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Mon Feb 26 14:55:33 2

r326508 - Revert r326501 due to buildbot breakage.

Author: dlj Date: Thu Mar 1 15:14:00 2018 New Revision: 326508 URL: http://llvm.org/viewvc/llvm-project?rev=326508&view=rev Log: Revert r326501 due to buildbot breakage. Original change: [NFC] Move CommentOpts checks to the call sites that depend on it. When parsing comments, for example, for

[PATCH] D43663: [NFC] Move CommentOpts checks to the call sites that depend on it.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326501: [NFC] Move CommentOpts checks to the call sites that depend on it. (authored by dlj, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D4

r326501 - [NFC] Move CommentOpts checks to the call sites that depend on it.

Author: dlj Date: Thu Mar 1 14:41:53 2018 New Revision: 326501 URL: http://llvm.org/viewvc/llvm-project?rev=326501&view=rev Log: [NFC] Move CommentOpts checks to the call sites that depend on it. When parsing comments, for example, for -Wdocumentation, slightly different behaviour occurs when -f

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

This revision was automatically updated to reflect the committed changes. Closed by commit rL326499: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS (authored by chh, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D439

r326499 - [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

Author: chh Date: Thu Mar 1 14:26:19 2018 New Revision: 326499 URL: http://llvm.org/viewvc/llvm-project?rev=326499&view=rev Log: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS Since LLVM r326341, default EmulatedTLS mode is decided in backend according to target triple. Any fro

r326496 - [modules] Don't diagnose "redefinition" of a friend with a pending definition

Author: rsmith Date: Thu Mar 1 14:20:13 2018 New Revision: 326496 URL: http://llvm.org/viewvc/llvm-project?rev=326496&view=rev Log: [modules] Don't diagnose "redefinition" of a friend with a pending definition if the other definition is a merged copy of the same function. Added: cfe/trunk/te

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

mstorsjo added a comment. Tested on the case that was broken before, and seems to work fine. Thanks! https://reviews.llvm.org/D43965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

chh added a comment. Martin, thanks for finding this problem. Please review/accept my new change if it passes your tests. After this and https://reviews.llvm.org/D42999, the default emulated TLS mode should only be decided in llvm/trunk/include/llvm/ADT/Triple.h hasDefaultEmulatedTLS(). https:/

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM (although I didn't test run it). https://reviews.llvm.org/D43965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r326493 - [www] Capitalize "Clang" when referring to the project, and generalize the

Author: rsmith Date: Thu Mar 1 14:01:06 2018 New Revision: 326493 URL: http://llvm.org/viewvc/llvm-project?rev=326493&view=rev Log: [www] Capitalize "Clang" when referring to the project, and generalize the introduction on the front page page. We still use the lowercase "clang" spelling when ref

[PATCH] D43965: [Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS

chh updated this revision to Diff 136601. chh retitled this revision from "[CodeGen] Force the backend to follow clang's EmulatedTLS flag" to "[Driver] Pass -f[no-]emulated-tls and set up ExplicitEmulatedTLS". chh edited the summary of this revision. chh added a reviewer: srhines. https://review

[PATCH] D43969: Improve completion experience for headers

phst updated this revision to Diff 136598. phst added a comment. Fix condition Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 Files: include-fixer/tool/clang-include-fixer.el Index: include-fixer/tool/clang-include-fixer.el

[PATCH] D43969: Improve completion experience for headers

phst updated this revision to Diff 136597. phst added a comment. Revert bogus additions Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43969 Files: include-fixer/tool/clang-include-fixer.el Index: include-fixer/tool/clang-include-fixer.el ===

[PATCH] D43969: Improve completion experience for headers

phst created this revision. phst added a reviewer: klimek. Herald added a subscriber: cfe-commits. When calling `completing-read', we should provide a default to prevent the behavior described in https://github.com/DarwinAwardWinner/ido-completing-read-plus#why-does-ret-sometimes-not-select-the-

[PATCH] D43965: [CodeGen] Force the backend to follow clang's EmulatedTLS flag

mstorsjo added a comment. Ok, thanks. Yes, this should probably only set it if some of those flags are set here. FWIW, clang also has got a list of targets where emulated TLS is enabled by default - could this be omitted somehow, now that LLVM can handle that on its own? Repository: rC Cla

[PATCH] D43967: Add test helper Fixture

martong added a comment. We add several test cases here, some of them are disabled. We plan to pass the disabled tests in different patches. Repository: rC Clang https://reviews.llvm.org/D43967 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D43967: Add test helper Fixture

martong created this revision. martong added reviewers: a.sidorin, xazax.hun, szepet. Herald added subscribers: cfe-commits, dkrupp, rnkovacs. [ASTImporter] Add a helper test Fixture, so we can add tests which may check internal attributes of AST nodes. Also it makes possible to import from severa

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny marked 3 inline comments as done. jdenny added inline comments. Comment at: include/clang/Basic/Attr.td:172-174 + // Whether the C++ implicit this parameter is allowed. Users that construct + // attributes from the source code use this information when validating + //

[PATCH] D43965: [CodeGen] Force the backend to follow clang's EmulatedTLS flag

chh commandeered this revision. chh edited reviewers, added: mstorsjo; removed: chh. chh added a comment. I will upload a different fix soon. We should set ExplicitEmulatedTLS only when -f[no-]emulated-tls flag is found at command line. Any front-end should only pass the flag and let backend deci

[libcxx] r326485 - Added P0805 to the list of ready bits

Author: marshall Date: Thu Mar 1 13:16:07 2018 New Revision: 326485 URL: http://llvm.org/viewvc/llvm-project?rev=326485&view=rev Log: Added P0805 to the list of ready bits Modified: libcxx/trunk/www/upcoming_meeting.html Modified: libcxx/trunk/www/upcoming_meeting.html URL: http://llvm.org

[PATCH] D43965: [CodeGen] Force the backend to follow clang's EmulatedTLS flag

mstorsjo created this revision. mstorsjo added reviewers: chh, jyknight. Since LLVM r326341, this is needed for the backend to actually respect the EmulatedTLS flag that is set, otherwise it just uses the target default flag instead. Repository: rC Clang https://reviews.llvm.org/D43965 Fil

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman added inline comments. Comment at: include/clang/AST/Attr.h:206 + + void cmpable(const ParamIdx &I) const { +assert(isValid() && I.isValid() && jdenny wrote: > aaron.ballman wrote: > > The name here can be improved. How about `checkInvariants()

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added a comment. In https://reviews.llvm.org/D43248#1024183, @aaron.ballman wrote: > In https://reviews.llvm.org/D43248#1023720, @jdenny wrote: > > > Hi Aaron. It occurs to me now that this patch has grown rather large and, > > in some places, a little subtle. Would it help the review i

[PATCH] D43841: Add an option to disable tail-call optimization for escaping blocks

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Alright, this looks good to me. Comment at: lib/Sema/SemaExpr.cpp:4846 +if (auto *BE = dyn_cast(Arg->IgnoreParenNoopCasts(Context))) + BE->getBlockDecl()

[PATCH] D43841: Add an option to disable tail-call optimization for escaping blocks

ahatanak updated this revision to Diff 136584. ahatanak marked an inline comment as done. ahatanak added a comment. Check the function prototype's noescape bit. https://reviews.llvm.org/D43841 Files: include/clang/AST/Decl.h include/clang/Driver/Options.td include/clang/Frontend/CodeGenOp

[PATCH] D43841: Add an option to disable tail-call optimization for escaping blocks

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/Sema/SemaExpr.cpp:4846 +if (auto *BE = dyn_cast(Arg->IgnoreParenNoopCasts(Context))) + BE->getBlockDecl()->setDoesNotEscape(); + rjmccall wrote: > Can this

[PATCH] D43908: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rL326476: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

r326476 - [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC

Author: mstorsjo Date: Thu Mar 1 12:22:57 2018 New Revision: 326476 URL: http://llvm.org/viewvc/llvm-project?rev=326476&view=rev Log: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC Make types with sizes that aren't a power of two an error (that can be disabled) i

[PATCH] D41102: Setup clang-doc frontend framework

lebedev.ri added a comment. Thank you for working on this! Some more nitpicking. //Please// consider adding even more tests (ideally, all this code should have 100% test coverage) Comment at: clang-doc/BitcodeWriter.cpp:139 + {COMMENT_NAME, {"Name", &StringAbbrev}},

[PATCH] D43961: OpenBSD Driver basic sanitiser support

devnexen created this revision. devnexen added reviewers: krytarowski, vitalybuka, kettenis. devnexen created this object with visibility "All Users". Herald added a subscriber: cfe-commits. Basic support of Sanitiser to follow-up ubsan support in compiler-rt. Needs to use lld instead of base ld t

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists updated this revision to Diff 136582. mclow.lists added a comment. Add the `tuple` bits. Regularize the equality comparisons of the containers; i.e, don't try to be clever - let the compiler be clever. https://reviews.llvm.org/D43773 Files: include/array include/deque include

[PATCH] D43841: Add an option to disable tail-call optimization for escaping blocks

rjmccall added inline comments. Comment at: lib/Sema/SemaExpr.cpp:4846 +if (auto *BE = dyn_cast(Arg->IgnoreParenNoopCasts(Context))) + BE->getBlockDecl()->setDoesNotEscape(); + Can this be based on the noescape parameter bit on the function type?

[PATCH] D43841: Add an option to disable tail-call optimization for escaping blocks

ahatanak updated this revision to Diff 136580. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D43841 Files: include/clang/AST/Decl.h include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/Code

[PATCH] D43841: Add an option to disable tail-call optimization for escaping blocks

ahatanak added inline comments. Comment at: include/clang/Driver/Options.td:1419 +def fno_disable_tail_calls_escaping_blocks : Flag<["-"], "fno-disable-tail-calls-escaping-blocks">, Group, Flags<[CC1Option]>; +def fdisable_tail_calls_escaping_blocks : Flag<["-"], "fdisable-tail

[PATCH] D42938: [Sema] Emit -Winteger-overflow for arguments in function calls, ObjC messages.

vsapsai added a comment. Ping. It would be helpful to know how reasonable is the idea to handle more expression types in `Sema::CheckForIntOverflow`. https://reviews.llvm.org/D42938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lis

[PATCH] D43908: [RecordLayout] Only assert that fundamental type sizes are power of two on MSVC

compnerd accepted this revision. compnerd added a comment. Awesome, thanks, this makes me feel much more comfortable. https://reviews.llvm.org/D43908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

r326469 - Driver: hoist `-fno-rtti-data` to a driver flag

Author: compnerd Date: Thu Mar 1 11:13:43 2018 New Revision: 326469 URL: http://llvm.org/viewvc/llvm-project?rev=326469&view=rev Log: Driver: hoist `-fno-rtti-data` to a driver flag This is needed for building with the GNU driver (`clang++`) when targeting Windows and using msvcprt. This flag i

[PATCH] D43681: [WebAssembly] Add exception handling option

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. This flag turns on CPU features (i.e. there's one for each new wasm feature proposal that has to be feature-detected), so I think this makes sense to be consistent with all the others. I cou

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman added a comment. In https://reviews.llvm.org/D43248#1023720, @jdenny wrote: > Hi Aaron. It occurs to me now that this patch has grown rather large and, in > some places, a little subtle. Would it help the review if I were to break it > up into a patch series that introduces Para

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

aaron.ballman added inline comments. Comment at: include/clang/AST/Attr.h:206 + + void cmpable(const ParamIdx &I) const { +assert(isValid() && I.isValid() && The name here can be improved. How about `checkInvariants()`? Might as well make this inline while

[PATCH] D43804: [analyzer] Enable cfg-temporary-dtors by default?

This revision was automatically updated to reflect the committed changes. Closed by commit rL326461: [analyzer] Enable cfg-temporary-dtors by default. (authored by dergachev, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D43804?vs=136

r326461 - [analyzer] Enable cfg-temporary-dtors by default.

Author: dergachev Date: Thu Mar 1 10:53:13 2018 New Revision: 326461 URL: http://llvm.org/viewvc/llvm-project?rev=326461&view=rev Log: [analyzer] Enable cfg-temporary-dtors by default. Don't enable c++-temp-dtor-inlining by default yet, due to this reference counting pointe problem. Otherwise t

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

ftingaud added inline comments. Comment at: test/clang-tidy/modernize-make-unique-cxx14.cpp:10 + // CHECK-MESSAGES: :[[@LINE-1]]:17: warning: use std::make_unique instead + // CHECK-FIXES: auto my_ptr = std::make_unique(1); + return 0; Quuxplusone wrote: > IIU

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

ftingaud updated this revision to Diff 136575. ftingaud added a comment. Remove customizable c++ version that added no real value. https://reviews.llvm.org/D43766 Files: clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/modernize/MakeSmartPtrCheck.h clang-tidy/modernize/MakeUniqueChec

[PATCH] D40737: [clang-tidy] Resubmit hicpp-multiway-paths-covered without breaking test

JonasToth added a comment. After long inactivity (sorry!) i had a chance to look at it again: switch(i) { case 0:; case 1:; case 2:; ... } does *NOT* lead to the stack overflow. This is most likely an issue in the AST: https://godbolt.org/g/vZw2BD Empty case labels do nest, an empty

[clang-tools-extra] r326458 - [clangd] Make symbol name a required parameter for CanonicalIncludes::mapHeader

Author: ioeric Date: Thu Mar 1 10:30:48 2018 New Revision: 326458 URL: http://llvm.org/viewvc/llvm-project?rev=326458&view=rev Log: [clangd] Make symbol name a required parameter for CanonicalIncludes::mapHeader Modified: clang-tools-extra/trunk/clangd/index/CanonicalIncludes.cpp clang-t

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

jordan_rose added a comment. It's been a long time since that commit, but I think the difference is that `-pedantic` / `Extension`-type diagnostics are magic and `-Wc++98-compat-pedantic` is not. I like Richard's way better and if it could be applied to -Wnewline-eof later as well then that sou

[PATCH] D43625: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang https://reviews.llvm.org/D43625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D43625: [OpenMP] Remove implicit data sharing code gen that aims to use device shared memory

gtbercea updated this revision to Diff 136570. gtbercea added a comment. Add Source location. Repository: rC Clang https://reviews.llvm.org/D43625 Files: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp lib/CodeGen/CGOpenMPRuntimeNVPTX.h test/OpenMP/nvptx_data_sharing.cpp test/OpenMP/nvptx_paral

[PATCH] D43957: Fixing issue where a space was not added before a global namespace variable when SpacesInParentheses is set

dpayne created this revision. dpayne added a reviewer: djasper. Herald added subscribers: cfe-commits, klimek. When SpacesInParentheses is set to true clang-format does not add a space before a global namespace variable. For example this is the output of clang-format for a somewhat contrived exa

[PATCH] D43745: Fix cppcoreguidelines-pro-bounds-pointer-arithmetic not working for functions with auto return specifier.

aaron.ballman added a comment. Some minor formatting nits, but otherwise LGTM. You should run the patch through clang-format: https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting Comment at: clang-tidy/cppcoreguidelines/ProBoundsPointerArithmeticCheck.cp

[PATCH] D43869: [clangd] Support include canonicalization in symbol leve.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE326456: [clangd] Support include canonicalization in symbol leve. (authored by ioeric, committed by ). Changed prior to commit: https://reviews.llvm.org/D43869?vs=136561&id=136565#toc Repository: r

[clang-tools-extra] r326456 - [clangd] Support include canonicalization in symbol leve.

Author: ioeric Date: Thu Mar 1 10:06:40 2018 New Revision: 326456 URL: http://llvm.org/viewvc/llvm-project?rev=326456&view=rev Log: [clangd] Support include canonicalization in symbol leve. Summary: Symbols with different canonical includes might be defined in the same header (e.g. symbols defin

[PATCH] D43869: [clangd] Support include canonicalization in symbol leve.

ioeric added inline comments. Comment at: clangd/index/CanonicalIncludes.h:54 /// a canonical header name. - llvm::StringRef mapHeader(llvm::StringRef Header) const; + /// An optional qualified symbol name can be provided to check against the + /// symbol mapping. -

[PATCH] D43847: [clang-tidy] Add check: replace string::find(...) == 0 with absl::StartsWith

aaron.ballman added a comment. In https://reviews.llvm.org/D43847#1023452, @hokein wrote: > In https://reviews.llvm.org/D43847#1021967, @aaron.ballman wrote: > > > I need a bit more context because I'm unfamiliar with `absl`. What is this > > module's intended use? > > > As `absl` has been open-

[PATCH] D43869: [clangd] Support include canonicalization in symbol leve.

ioeric updated this revision to Diff 136561. ioeric marked 2 inline comments as done. ioeric added a comment. - Merge with origin/master - Address review comments. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43869 Files: clangd/index/CanonicalIncludes.cpp clangd/index/Ca

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

Quuxplusone added inline comments. Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:21 +: MakeSmartPtrCheck(Name, Context, "std::make_unique"), + MinimumLanguageVersion(Options.get("MakeUniqueLanguageVersion", + getDefaultMinim

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:21 +: MakeSmartPtrCheck(Name, Context, "std::make_unique"), + MinimumLanguageVersion(Options.get("MakeUniqueLanguageVersion", + getDefaultMin

[PATCH] D43800: [ASTMatchers] Allow file-based narrowing matches to work with NestedNameSpecifierLocs.

rsmith added a comment. Please add some test coverage for the NNS case. Repository: rC Clang https://reviews.llvm.org/D43800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42684: clang-format: Allow optimizer to break template declaration.

Typz updated this revision to Diff 136557. Typz added a comment. Change options values to No/MultiLine/Yes. Repository: rC Clang https://reviews.llvm.org/D42684 Files: include/clang/Format/Format.h lib/Format/ContinuationIndenter.cpp lib/Format/Format.cpp lib/Format/TokenAnnotator.cp

[PATCH] D42730: [clang-tidy]] Add check for use of types/classes/functions from header which are deprecated and removed in C++17

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/DeprecatedFunctionalCheck.cpp:48-54 + } else if (const auto *const Call = + Result.Nodes.getNodeAs("ptr_fun_call")) { +diag(Call->getLocStart(), Message) << "'std::ptr_fun'"; + } else if (

[PATCH] D43015: clang-format: Introduce BreakInheritanceList option

Typz added a comment. ping? Repository: rC Clang https://reviews.llvm.org/D43015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43281: [AMDGPU] fixes for lds f32 builtins

dfukalov added a comment. The problem is that if set addrspace "2" in description string, CanT.getAddressSpace() returns target addrspace value "11" (shifted in the enum) and compares it with input LangAS addrspace ("2", "opencl_local" in our case). So I cannot set a number a description string

[clang-tools-extra] r326452 - [clangd] Forward all environment variables along with CLANGD_TRACE to clangd.

Author: ioeric Date: Thu Mar 1 09:42:27 2018 New Revision: 326452 URL: http://llvm.org/viewvc/llvm-project?rev=326452&view=rev Log: [clangd] Forward all environment variables along with CLANGD_TRACE to clangd. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/src/extension.ts M

[PATCH] D43953: clangformat-vs: Fix plugin not correctly loading in some cases

fxroure-ubisoft created this revision. fxroure-ubisoft added a reviewer: clang. fxroure-ubisoft created this object with edit policy "Only User: fxroure-ubisoft (François-Xavier Roure)". Herald added a subscriber: cfe-commits. When installing the clang-format visual studio plugin

[PATCH] D43928: [analyzer] Correctly measure array size in security.insecureAPI.strcpy

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:517 if (const auto *Array = dyn_cast(DeclRef->getType())) { - uint64_t ArraySize = BR.getContext().getTypeSize(Array) / 8; + auto ArraySize = BR.getContext().getTypeSizeI

[PATCH] D43108: Support for the mno-stack-arg-probe flag

nruslan added a comment. @aemerson : yes, it is just part of MS ABI Repository: rC Clang https://reviews.llvm.org/D43108 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43162: [Parser] (C++) Make -Wextra-semi slightly more useful

lebedev.ri added a comment. **If** i'm reading `git blame` correctly, the `-Wnewline-eof` diag, which i used as a base to model the previous version of this diff on, was added in https://reviews.llvm.org/rL189110 / https://github.com/llvm-mirror/clang/commit/7865b8e4324378e06f59adb4d60bec26a7d3d

[PATCH] D43817: [x86] wbnoinvd intrinsic

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D43766: [clang-tidy][modernize-make-unique] Checks c++14 flag before using std::make_unique

alexfh added inline comments. Comment at: clang-tidy/modernize/MakeUniqueCheck.cpp:21 +: MakeSmartPtrCheck(Name, Context, "std::make_unique"), + MinimumLanguageVersion(Options.get("MakeUniqueLanguageVersion", + getDefaultMinimumLan

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: unittests/clang-tidy/ClangTidyTest.h:145 + + if (Options.FormatStyle) { +llvm::Expected Style = format::getStyle( I wonder whe

  1   2   >