alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.


================
Comment at: unittests/clang-tidy/ClangTidyTest.h:145
+
+  if (Options.FormatStyle) {
+    llvm::Expected<format::FormatStyle> Style = format::getStyle(
----------------
I wonder whether it's better to use lit for the tests that require formatting 
than to expand clang-tidy unit test utilities with runCheckAndFormatOnCode? 
What was the reason to use unit tests in this patch as opposed to lit tests?


https://reviews.llvm.org/D43500



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to