[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

krisb updated this revision to Diff 136041. krisb added a comment. Reverted unintentional changes. Repository: rC Clang https://reviews.llvm.org/D43809 Files: include/clang/Frontend/CompilerInstance.h lib/CodeGen/CodeGenAction.cpp lib/Frontend/CompilerInstance.cpp unittests/Frontend/

[PATCH] D43805: Optionally use nameless IR types

rjmccall added inline comments. Comment at: include/clang/Driver/Options.td:1735 + HelpText<"Whether to use IR type names (option: none, use)">, + Values<"none,use">; def relocatable_pch : Flag<["-", "--"], "relocatable-pch">, Flags<[CC1Option]>, This is an un

[PATCH] D43809: Add possibility to specify output stream for CompilerInstance

krisb created this revision. Herald added subscribers: cfe-commits, mgorny, klimek. Repository: rC Clang https://reviews.llvm.org/D43809 Files: include/clang/Frontend/CompilerInstance.h lib/CodeGen/CodeGenAction.cpp lib/Frontend/CompilerInstance.cpp unittests/Format/FormatTest.cpp un

Re: r326168 - Attempt to fix greendragon bot after r326141

Hmm. Reid had included a fix for compiler-rt in r326141, but that doesn't seem particularly relevant to this failure. In any case, I expect I'll receive emails when that bot is up and running again, and I can take a look then. (It didn't repro locally on Linux for me.) From: Zachary Turner Dat

Re: r326168 - Attempt to fix greendragon bot after r326141

So this doesn’t appear to fix the issue that led to my revert earlier. http://lab.llvm.org:8011/builders/clang-cmake-x86_64-sde-avx512-linux/builds/6760 There’s no slashes in the command line that’s failing. However, this bot doesn’t seem to be updating and hasn’t pulled in this cl yet, but I exp

[PATCH] D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

This revision was automatically updated to reflect the committed changes. Closed by commit rL326173: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

r326173 - [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

Author: mstorsjo Date: Mon Feb 26 22:27:06 2018 New Revision: 326173 URL: http://llvm.org/viewvc/llvm-project?rev=326173&view=rev Log: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields When targeting GNU/MinGW for i386, the size of the "long double" data type is 12 byte

Re: r326168 - Attempt to fix greendragon bot after r326141

Never mind, I didn’t realize Reid resubmitted my cl after I reverted it. In fact, I reverted it because of this greendragon failure which I wasn’t sure how to fix at the time On Mon, Feb 26, 2018 at 10:12 PM Adam Nemet wrote: > BTW, I think that the LLVM bots have trouble accessing subversion too

Re: r326168 - Attempt to fix greendragon bot after r326141

BTW, I think that the LLVM bots have trouble accessing subversion too. I already let Galina know. > On Feb 26, 2018, at 10:06 PM, Shoaib Meenai wrote: > > r326171 works locally. I'll keep an eye on the bots. > > From: on behalf of Adam Nemet > Date: Monday, February 26, 2018 at 9:51 PM > T

Re: r326168 - Attempt to fix greendragon bot after r326141

Interesting, thanks for the fix. > On Feb 26, 2018, at 10:06 PM, Shoaib Meenai wrote: > > r326171 works locally. I'll keep an eye on the bots. > > From: mailto:ane...@apple.com>> on behalf of Adam Nemet > mailto:ane...@apple.com>> > Date: Monday, February 26, 2018 at 9:51 PM > To: Shoaib Meen

Re: r326168 - Attempt to fix greendragon bot after r326141

r326171 works locally. I'll keep an eye on the bots. From: on behalf of Adam Nemet Date: Monday, February 26, 2018 at 9:51 PM To: Shoaib Meenai Cc: Zachary Turner , "cfe-commits@lists.llvm.org" , Reid Kleckner Subject: Re: r326168 - Attempt to fix greendragon bot after r326141 Yep. On Feb

r326171 - [Driver] Fix codeview-column-info on macOS

Author: smeenai Date: Mon Feb 26 22:04:23 2018 New Revision: 326171 URL: http://llvm.org/viewvc/llvm-project?rev=326171&view=rev Log: [Driver] Fix codeview-column-info on macOS macOS home directory paths begin with /Users, and clang-cl interprets the /U portion as a macro undefine rather than a p

[PATCH] D43303: [Format] Fix for bug 35641

kadircet added a comment. ping Repository: rC Clang https://reviews.llvm.org/D43303 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r326168 - Attempt to fix greendragon bot after r326141

Yep. > On Feb 26, 2018, at 9:50 PM, Shoaib Meenai wrote: > > Reid re-committed r326141 this morning (and followed up with r326144), and I > don't think either of those have been reverted? > > From: Zachary Turner > Date: Monday, February 26, 2018 at 9:47 PM > To: Adam Nemet > Cc: Shoaib Mee

Re: r326168 - Attempt to fix greendragon bot after r326141

Reid re-committed r326141 this morning (and followed up with r326144), and I don't think either of those have been reverted? From: Zachary Turner Date: Monday, February 26, 2018 at 9:47 PM To: Adam Nemet Cc: Shoaib Meenai , "cfe-commits@lists.llvm.org" , Reid Kleckner Subject: Re: r326168 - A

Re: r326168 - Attempt to fix greendragon bot after r326141

What did you revert? > On Feb 26, 2018, at 9:46 PM, Zachary Turner wrote: > > I already reverted this a long time ago, but if Shoaib has a proper fix that > would be great > On Mon, Feb 26, 2018 at 9:45 PM Adam Nemet > wrote: > Ah, that should be sufficient. > > >>

Re: r326168 - Attempt to fix greendragon bot after r326141

I already reverted this a long time ago, but if Shoaib has a proper fix that would be great On Mon, Feb 26, 2018 at 9:45 PM Adam Nemet wrote: > Ah, that should be sufficient. > > > On Feb 26, 2018, at 9:44 PM, Shoaib Meenai wrote: > > Thanks. I'm building on macOS locally to confirm the original

Re: r326168 - Attempt to fix greendragon bot after r326141

Thanks. I'm building on macOS locally to confirm the original problem and my fix. From: on behalf of Adam Nemet Date: Monday, February 26, 2018 at 9:42 PM To: Shoaib Meenai Cc: "cfe-commits@lists.llvm.org" , Reid Kleckner , Zachary Turner Subject: Re: r326168 - Attempt to fix greendragon bot

Re: r326168 - Attempt to fix greendragon bot after r326141

Ah, that should be sufficient. > On Feb 26, 2018, at 9:44 PM, Shoaib Meenai wrote: > > Thanks. I'm building on macOS locally to confirm the original problem and my > fix. > > From: on behalf of Adam Nemet > Date: Monday, February 26, 2018 at 9:42 PM > To: Shoaib Meenai > Cc: "cfe-commits@l

Re: r326168 - Attempt to fix greendragon bot after r326141

This is the bot with the failure: http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental/46794/#showFailuresLink But to make matters worse, greendragon is experience some difficulty fetc

Re: r326168 - Attempt to fix greendragon bot after r326141

Could you point me to the specific bot that was failing? I've dealt with that problem before, and it shouldn't be hard to fix, but I wanna monitor the bot after the fix to make sure it stays green. From: on behalf of Adam Nemet Date: Monday, February 26, 2018 at 9:30 PM To: Shoaib Meenai Cc:

Re: r326168 - Attempt to fix greendragon bot after r326141

I don’t think we can deal with the slash options: clang-7.0: warning: '/Users/buildslave/jenkins/workspace/apple-clang-master-RA-stage1-cmake-incremental/clang/src/tools/clang/test/Driver/codeview-column-info.c' treated as the '/U' option [-Wslash-u-filename] clang-7.0: note: Use '--' to treat s

Re: r326168 - Attempt to fix greendragon bot after r326141

This seems bogus to me. CodeView can be generated on any build platform; it just needs the correct triple, which Reid added in r326144. From: cfe-commits on behalf of Adam Nemet via cfe-commits Reply-To: Adam Nemet Date: Monday, February 26, 2018 at 8:51 PM To: "cfe-commits@lists.llvm.org" S

r326168 - Attempt to fix greendragon bot after r326141

Author: anemet Date: Mon Feb 26 20:49:26 2018 New Revision: 326168 URL: http://llvm.org/viewvc/llvm-project?rev=326168&view=rev Log: Attempt to fix greendragon bot after r326141 Modified: cfe/trunk/test/Driver/codeview-column-info.c Modified: cfe/trunk/test/Driver/codeview-column-info.c URL:

[PATCH] D40508: Replace long type names in IR with hashes

sepavloff abandoned this revision. sepavloff added a comment. Using llvm type names is considered a wrong direction. https://reviews.llvm.org/D40508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D40567: Always show template parameters in IR type names

sepavloff abandoned this revision. sepavloff added a comment. The feedback here, in https://reviews.llvm.org/D40508 and in the mail list (http://lists.llvm.org/pipermail/llvm-dev/2017-December/119585.html) demonstrates that this is a wrong direction. Part of this patch is used in https://reviews

[PATCH] D43805: Optionally use nameless IR types

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall. Type in the LLVM IR may have names but only for the purpose of human readability (see discussions in https://reviews.llvm.org/D40567, http://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20171127/210816.html and http:

[PATCH] D43804: [analyzer] Enable cfg-temporary-dtors by default?

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Final results are still being baked on my end, but by putting this on review i'm trying to say that i believe i managed to fix the biggest pr

[PATCH] D43800: [ASTMatchers] Allow file-based narrowing matches to work with NestedNameSpecifierLocs.

dlj created this revision. dlj added a reviewer: rsmith. Herald added subscribers: sanjoy, klimek. The narrowing matchers isExpansionInMainFile, isExpansionInSystemHeader, and isExpansionInFileMatching work for TypeLocs, but not NestedNameSpecifierLocs. This changes the matchers to use getSourceRa

[PATCH] D43798: [analyzer] UndefinedAssignment: Fix warning message on implicit copy/move constructors.

NoQ added a comment. See also https://reviews.llvm.org/rC326165. Repository: rC Clang https://reviews.llvm.org/D43798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326164: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on… (authored by ikudrin, committed by ). Changed prior to commit: https://reviews.llvm.org/D43621?vs=135888&id=136026#

r326165 - [analyzer] Fix an uninitialized field.

Author: dergachev Date: Mon Feb 26 18:53:30 2018 New Revision: 326165 URL: http://llvm.org/viewvc/llvm-project?rev=326165&view=rev Log: [analyzer] Fix an uninitialized field. Found by the analyzer! Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/FunctionSummary.h Modifie

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. OK I would still appreciate a comment on why you expect fetch_add and friends in the lowest destructor in the stack. https://reviews.llvm.org/D43791 ___

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2899 + // to find out if a likely-false-positive suppression should kick in. + for (const LocationContext *LC = CurrentLC; LC; LC = LC->getParent()) { +if (isa(LC->getDecl())) {

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2899 + // to find out if a likely-false-positive suppression should kick in. + for (const LocationContext *LC = CurrentLC; LC; LC = LC->getParent()) { +if (isa(LC->

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny added inline comments. Comment at: include/clang/AST/Attr.h:210-212 + unsigned Idx; + bool HasThis; + bool IsValid; aaron.ballman wrote: > I think it might be best to mash these together using bit-fields: > ``` > unsigned Idx : 30; > unsigned HasThis :

[PATCH] D43248: [Attr] Fix parameter indexing for attributes

jdenny updated this revision to Diff 136019. jdenny marked 8 inline comments as done. jdenny edited the summary of this revision. jdenny added a comment. This revision should address all issues raised. https://reviews.llvm.org/D43248 Files: include/clang/AST/Attr.h include/clang/Basic/Attr.

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2847 + + AtomicExpr::AtomicOp Op = AE->getOp(); + if (Op != AtomicExpr::AO__c11_atomic_fetch_add && george.karpenkov wrote: > IMO would be slightly easier to read with logic re

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ updated this revision to Diff 136020. NoQ added a comment. Address comments. https://reviews.llvm.org/D43791 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/NewDelete-atomics.cpp Index: test/Analysis/NewDelete-atomics.cpp =

[PATCH] D43798: [analyzer] UndefinedAssignment: Fix warning message on implicit copy/move constructors.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. When a class forgets to initialize a field in the constructor, and then gets copied around, a warning is emitted that the value assigned to a

[PATCH] D43797: [CMake] Copy the generated __config header into build directory

phosek created this revision. phosek added reviewers: EricWF, mclow.lists, beanz. Herald added subscribers: cfe-commits, christof, mgorny. When the generated __config file is being used, it is currently only copied during installation process. However, that means that the file that gets copied int

r326157 - [analyzer] Switch the default exploration strategy to priority queue based on coverage

Author: george.karpenkov Date: Mon Feb 26 17:31:56 2018 New Revision: 326157 URL: http://llvm.org/viewvc/llvm-project?rev=326157&view=rev Log: [analyzer] Switch the default exploration strategy to priority queue based on coverage After the investigation it seems safe to flip the switch. Differe

[PATCH] D43782: [analyzer] Switch the default exploration strategy to priority queue based on coverage

This revision was automatically updated to reflect the committed changes. Closed by commit rC326157: [analyzer] Switch the default exploration strategy to priority queue based on… (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https:

r326156 - [analyzer] Logging test typo quickfix.

Author: george.karpenkov Date: Mon Feb 26 17:31:06 2018 New Revision: 326156 URL: http://llvm.org/viewvc/llvm-project?rev=326156&view=rev Log: [analyzer] Logging test typo quickfix. Modified: cfe/trunk/test/Analysis/region_store_overflow.c Modified: cfe/trunk/test/Analysis/region_store_overf

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists added a comment. > Is there a subtle reason for this inconsistency that I'm not seeing? I suspect that it's because they were written at different times. (When I say 'written at different times', I mean I adapted the existing `op==` for the containers - not that this new code was wri

[PATCH] D43773: Implement the container bits of P0805R1

mclow.lists added a comment. I can certainly make them all the same. https://reviews.llvm.org/D43773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r326155 - [analyzer] Logging test quickfix.

Author: george.karpenkov Date: Mon Feb 26 17:13:28 2018 New Revision: 326155 URL: http://llvm.org/viewvc/llvm-project?rev=326155&view=rev Log: [analyzer] Logging test quickfix. Modified: cfe/trunk/test/Analysis/region_store_overflow.c Modified: cfe/trunk/test/Analysis/region_store_overflow.c

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D41102#1017918, @lebedev.ri wrote: > Is there some (internal to `BitstreamWriter`) logic that would 'assert()' if > trying to output some recordid > which is, according to the `BLOCKINFO_BLOCK`, should not be there? > E.g. outputting `V

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 136010. juliehockett marked 10 inline comments as done. juliehockett added a comment. 1. Moved the serialization logic out of the Mapper class and into its own namespace 2. Updated tests 3. Addressing comments https://reviews.llvm.org/D41102 Files:

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

george.karpenkov added inline comments. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:527 private: +bool shouldSuppressOnAtomicReferenceCountingPointers( +const Stmt *S, const LocationContext *CurrentLC); Docstring. C

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

Eugene.Zelenko added inline comments. Comment at: clang-tidy/fuchsia/CMakeLists.txt:8 OverloadedOperatorCheck.cpp + RestrictIncludesCheck.cpp StaticallyConstructedObjectsCheck.cpp Will be good idea to be have consistent name and documentation terminology:

r326152 - Revert "Revert "[analyzer] Quickfix: do not overflow in calculating offset in RegionManager""

Author: george.karpenkov Date: Mon Feb 26 16:05:04 2018 New Revision: 326152 URL: http://llvm.org/viewvc/llvm-project?rev=326152&view=rev Log: Revert "Revert "[analyzer] Quickfix: do not overflow in calculating offset in RegionManager"" This reverts commit c4cc41166d93178a3ddd4b2b5a685cf74a45924

[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

This revision was automatically updated to reflect the committed changes. Closed by commit rL326151: [Driver] Add SafeStack to a map of incompatible sanitizers (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D43606?vs=136002&id=136004#toc Repository: rL

r326151 - [Driver] Add SafeStack to a map of incompatible sanitizers

Author: phosek Date: Mon Feb 26 16:01:26 2018 New Revision: 326151 URL: http://llvm.org/viewvc/llvm-project?rev=326151&view=rev Log: [Driver] Add SafeStack to a map of incompatible sanitizers This allows reporting an error when user tries to use SafeStack with incompatible sanitizers. Differenti

[PATCH] D43606: [Driver] Add SafeStack to a map of incompatible sanitizers

phosek updated this revision to Diff 136002. phosek marked an inline comment as done. Herald added subscribers: Sanitizers, llvm-commits. Repository: rCRT Compiler Runtime https://reviews.llvm.org/D43606 Files: clang/lib/Driver/SanitizerArgs.cpp clang/test/Driver/fsanitize.c Index: clang

[PATCH] D43791: [analyzer] Suppress MallocChecker positives in destructors with atomics.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. This patch is a targeted suppression heuristic for false positives `MallocChecker` produces when a shared / reference-counting pointer is cop

r326146 - [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC).

Author: eugenezelenko Date: Mon Feb 26 15:15:52 2018 New Revision: 326146 URL: http://llvm.org/viewvc/llvm-project?rev=326146&view=rev Log: [StaticAnalyzer] Fix some Clang-tidy modernize and Include What You Use warnings; other minor fixes (NFC). Modified: cfe/trunk/include/clang/StaticAnaly

r326145 - Fix which Darwin versions have ObjC runtime with full subscripting support.

Author: vsapsai Date: Mon Feb 26 15:10:23 2018 New Revision: 326145 URL: http://llvm.org/viewvc/llvm-project?rev=326145&view=rev Log: Fix which Darwin versions have ObjC runtime with full subscripting support. Update min deployment target in some tests so that they don't try to link against libar

r326144 - Fix codeview-column-info.c test with a triple

Author: rnk Date: Mon Feb 26 15:06:40 2018 New Revision: 326144 URL: http://llvm.org/viewvc/llvm-project?rev=326144&view=rev Log: Fix codeview-column-info.c test with a triple Modified: cfe/trunk/test/Driver/codeview-column-info.c Modified: cfe/trunk/test/Driver/codeview-column-info.c URL:

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL326143: Fix which Darwin versions have ObjC runtime with full subscripting support. (authored by vsapsai, committed by ). Herald added subscribers: llvm-commits, delcypher. Changed prior to commit: http

[PATCH] D43748: [Attr] Fix paren, comma, and omitted arg printing in some cases

jdenny updated this revision to Diff 135982. jdenny added a comment. Aaron: Because the last two arguments for objc_bridge_related must be delimited with commas, this revision takes the view that they are not optional but are permitted to be the empty string. The test suite behaves as expected.

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

rsmith added a comment. In https://reviews.llvm.org/D43576#1019703, @zahiraam wrote: > Currently this declaration: > struct > __declspec(uuid("{DDB47A6A-0F23-11D5-9109-00E0296B75D3}")) > S1; > > a CXXRecordDecl type is generated with attributes (the uuid being an > attribute). Are you proposin

[PATCH] D43666: [analyzer] When constructing a temporary without construction context, track it for destruction anyway.

NoQ updated this revision to Diff 135994. NoQ marked 3 inline comments as done. NoQ added a comment. Fix cleanup node generation logic. https://reviews.llvm.org/D43666 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp test/Analysis/

[PATCH] D43666: [analyzer] When constructing a temporary without construction context, track it for destruction anyway.

NoQ added inline comments. Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2262 + assert(DidCacheOutOnCleanup || + areInitializedTemporariesClear(Pred->getState(), Pred->getLocationContext(), dcoughlin wrote: >

r326141 - Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver."

Author: rnk Date: Mon Feb 26 14:55:33 2018 New Revision: 326141 URL: http://llvm.org/viewvc/llvm-project?rev=326141&view=rev Log: Re-land "Emit proper CodeView when -gcodeview is passed without the cl driver." Reverts r326116 and re-lands r326113 with a fix to ASan so that it enables column info

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

vsapsai added a comment. In https://reviews.llvm.org/D43787#1019886, @kubamracek wrote: > Great! So the versions in `ObjCRuntime.h` didn't really match what the iOS > and macOS supported? Yes, support for assigning nil for a key for NSMutableDictionary was added in macOS 10.11, iOS 9. Earlier

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

erichkeane added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:519 + /// Whether this function has nocf_check attribute. + unsigned NoCfCheck : 1; + aaron.ballman wrote: > oren_ben_simhon wrote: > > aaron.ballman wrote: > > > This is unfor

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

kubamracek added a comment. Great! So the versions in `ObjCRuntime.h` didn't really match what the iOS and macOS supported? https://reviews.llvm.org/D43787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks for digging into and addressing this! https://reviews.llvm.org/D43787 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

rnk accepted this revision. rnk added a comment. Thanks! https://reviews.llvm.org/D43734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43787: Fix which Darwin versions have ObjC runtime with full subscripting support.

vsapsai created this revision. vsapsai added reviewers: vsk, kubamracek. Herald added a subscriber: jkorous-apple. Update min deployment target in some tests so that they don't try to link against libarclite and don't fail when it's not available. rdar://problem/29253617 https://reviews.llvm.or

[PATCH] D41880: Adding nocf_check attribute for cf-protection fine tuning

aaron.ballman added inline comments. Comment at: include/clang/CodeGen/CGFunctionInfo.h:519 + /// Whether this function has nocf_check attribute. + unsigned NoCfCheck : 1; + oren_ben_simhon wrote: > aaron.ballman wrote: > > This is unfortunate -- it bumps the b

[PATCH] D43354: [analyzer] Exploration strategy prioritizing unexplored nodes first

This revision was automatically updated to reflect the committed changes. Closed by commit rC326136: [analyzer] Exploration strategy prioritizing unexplored nodes first (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.l

[PATCH] D43421: [analyzer] Do not analyze bison-generated files

This revision was automatically updated to reflect the committed changes. Closed by commit rC326135: [analyzer] Do not analyze bison-generated files (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D43421 File

r326135 - [analyzer] Do not analyze bison-generated files

Author: george.karpenkov Date: Mon Feb 26 14:14:16 2018 New Revision: 326135 URL: http://llvm.org/viewvc/llvm-project?rev=326135&view=rev Log: [analyzer] Do not analyze bison-generated files Bison/YACC generated files result in a very large number of (presumably) false positives from the analyzer

r326136 - [analyzer] Exploration strategy prioritizing unexplored nodes first

Author: george.karpenkov Date: Mon Feb 26 14:14:18 2018 New Revision: 326136 URL: http://llvm.org/viewvc/llvm-project?rev=326136&view=rev Log: [analyzer] Exploration strategy prioritizing unexplored nodes first See D42775 for discussion. Turns out, just exploring nodes which weren't explored fir

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D43621 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

rnk added a comment. In https://reviews.llvm.org/D43621#1019724, @ruiu wrote: > This change looks good to me, but I think we shouldn't check in an executable > binary file. Can you create `ld.foo.exe` in the test? Since you don't > actually run ld.foo.exe, creating that executable should be ver

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

jdemeule added inline comments. Comment at: unittests/clang-tidy/ClangTidyTest.h:159-160 + CleannedReplacements = std::move(FormattedReplacements); + if (!CleannedReplacements) +llvm_unreachable("!CleannedReplacements"); +} else { aaron.ball

[PATCH] D42644: [asan] Intercept std::rethrow_exception indirectly.

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT326132: [asan] Intercept std::rethrow_exception indirectly (authored by vitalybuka, committed by ). Changed prior to commit: https://reviews.llvm.org/D42644?vs=132990&id=135965#toc Repository: rCRT

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

jakehehrlich added a comment. Can you add a test for when #pragma GCC visibility push(hidden) is used and the visibility attribute is hidden? https://reviews.llvm.org/D43392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r326131 - Revert "[analyzer] Quickfix: do not overflow in calculating offset in RegionManager"

Author: george.karpenkov Date: Mon Feb 26 13:32:57 2018 New Revision: 326131 URL: http://llvm.org/viewvc/llvm-project?rev=326131&view=rev Log: Revert "[analyzer] Quickfix: do not overflow in calculating offset in RegionManager" This reverts commit df306c4c5ab4a6b8d3c47432346d1f9b90c328b4. Rever

[PATCH] D43783: [OpenCL] Remove block invoke function from emitted block literal struct

yaxunl created this revision. yaxunl added reviewers: b-sumner, Anastasia, bader. Herald added a subscriber: nhaehnle. OpenCL runtime tracks the invoke function emitted for any block expression. Due to restrictions on blocks in OpenCL (v2.0 s6.12.5), it is always possible to know the block invoke

[PATCH] D43621: [Driver] Allow using a canonical form of '-fuse-ld=' when cross-compiling on Windows.

ruiu added a comment. This change looks good to me, but I think we shouldn't check in an executable binary file. Can you create `ld.foo.exe` in the test? Since you don't actually run ld.foo.exe, creating that executable should be very easy. https://reviews.llvm.org/D43621 __

[PATCH] D43773: Implement the container bits of P0805R1

tcanens added a comment. Hmm, for `vector` and `deque`, we define a temporary variable, check that sizes match and then use range-and-a-half `equal`: const typename vector<_Tp1, _Allocator1>::size_type __sz = __x.size(); return __sz == __y.size() && _VSTD::equal(__x.begin(), __x.end(), __y.

[PATCH] D43218: [analyzer] Quickfix: do not overflow in calculating offset in RegionManager

This revision was automatically updated to reflect the committed changes. Closed by commit rC326122: [analyzer] Quickfix: do not overflow in calculating offset in RegionManager (authored by george.karpenkov, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://r

r326122 - [analyzer] Quickfix: do not overflow in calculating offset in RegionManager

Author: george.karpenkov Date: Mon Feb 26 13:03:06 2018 New Revision: 326122 URL: http://llvm.org/viewvc/llvm-project?rev=326122&view=rev Log: [analyzer] Quickfix: do not overflow in calculating offset in RegionManager Addresses https://bugs.llvm.org/show_bug.cgi?id=36206 rdar://37159026 A prop

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam added a comment. In https://reviews.llvm.org/D43576#1016588, @rsmith wrote: > In https://reviews.llvm.org/D43576#1016561, @majnemer wrote: > > > Here's my thinking: the `__uuidof` expression literally declares a variable > > called `_GUID_ddb47a6a_0f23_11d5_9109_00e0296b75d3` of type `_

[PATCH] D43322: Diagnose cases of "return x" that should be "return std::move(x)" for efficiency

Quuxplusone added a comment. @rtrieu please take a look? Repository: rC Clang https://reviews.llvm.org/D43322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

jakehehrlich added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:26 + +// AST_MATCHER(FunctionDecl, isInHeaderFile) { +// return Node.getExplicitVisibility(NamedDecl::VisibilityForType); What are these comments doing here? ===

[libcxx] r326120 - [libcxx] [test] Fix MSVC warnings and errors.

Author: stl_msft Date: Mon Feb 26 12:47:46 2018 New Revision: 326120 URL: http://llvm.org/viewvc/llvm-project?rev=326120&view=rev Log: [libcxx] [test] Fix MSVC warnings and errors. test/std/numerics/numeric.ops/exclusive.scan/exclusive_scan.pass.cpp test/std/numerics/numeric.ops/exclusive.scan/ex

[PATCH] D43780: [Tooling] [1/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri created this revision. lebedev.ri added reviewers: klimek, bkramer, alexfh, pcc. lebedev.ri added projects: clang, clang-tools-extra. Herald added subscribers: jkorous-apple, ioeric. I'm not sure whether there are any principal reasons why it returns raw owning pointer, or it is just a

[PATCH] D43779: [Tooling] [0/1] Refactor FrontendActionFactory::create() to return std::unique_ptr<>

lebedev.ri created this revision. lebedev.ri added reviewers: klimek, bkramer, alexfh, pcc. lebedev.ri added a project: clang. Noticed during review of https://reviews.llvm.org/D41102. I'm not sure whether there are any principal reasons why it returns raw owning pointer, or it is just a old cod

[PATCH] D43778: [clang-tidy] Adding RestrictIncludes check to Fuchsia module

juliehockett created this revision. juliehockett added reviewers: aaron.ballman, hokein, ilya-biryukov. juliehockett added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Adding a check to restrict specific includes. Given a list of includes that should not be used, the

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett updated this revision to Diff 135944. juliehockett marked 6 inline comments as done. juliehockett added a comment. After discussion, the goal of this checker slightly changed to target definitions in header files, rather than declarations. As a result, the check now adds the attribu

[PATCH] D43392: [clang-tidy] Add Fuchsia checker for visibility attributes

juliehockett added inline comments. Comment at: clang-tidy/fuchsia/AddVisibilityCheck.cpp:52-53 + Finder->addMatcher( + functionDecl(allOf(hasAnyName(SmallVector(Names.begin(), + Names.end())), +

[clang-tools-extra] r326118 - Fix for LLVM r326109

Author: davezarzycki Date: Mon Feb 26 12:21:30 2018 New Revision: 326118 URL: http://llvm.org/viewvc/llvm-project?rev=326118&view=rev Log: Fix for LLVM r326109 Modified: clang-tools-extra/trunk/clang-query/QueryParser.cpp clang-tools-extra/trunk/clang-query/QueryParser.h Modified: clang-

[PATCH] D43775: add UUID to the acronyms list of objc property name checks

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Wizard added reviewers: benhamilton, hokein. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43775 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp Index: clang-tidy/objc/PropertyDeclarationCheck.c

[PATCH] D43734: [RecordLayout] Don't align to non-power-of-2 sizes when using -mms-bitfields

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. If its easy enough to wire that through to the frontend as a proper diagnostic, that would be better with a test. Otherwise, this is good to continue to make progress. https://reviews.l

[PATCH] D43700: Emit proper CodeView even when not using the cl driver.

zturner added a comment. I had to revert this for now. It breaks the asan bots which expect column info. That fix is easy, but it also breaks a random linux bots which I don't have the ability to debug at the moment because my linux machine is not working. Hopefully I can get that resolved s

  1   2   >