[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache updated this revision to Diff 133154. modocache added a comment. Update the tests to work with scalar parameter copies. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp test/CodeGenCoroutines/coro-gro

Re: r324439 - AST: support SwiftCC on MS ABI

On Tue, Feb 6, 2018 at 5:55 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Tue Feb 6 17:55:08 2018 > New Revision: 324439 > > URL: http://llvm.org/viewvc/llvm-project?rev=324439&view=rev > Log: > AST: support SwiftCC on MS ABI > > Microsoft

[PATCH] D42987: [libc++abi] fix compilation in C++17 mode

mclow.lists added a comment. I'm fine with this, though I wonder if using the more specific `_LIBCPP_ENABLE_CXX17_REMOVED_UNEXPECTED_FUNCTIONS` might be a better thing to define. Repository: rCXXA libc++abi https://reviews.llvm.org/D42987 ___ c

[PATCH] D42933: [Sema] Avoid -Wformat warning for NSInteger/NSUInteger 'int' values with %zu/%zi long specifiers

compnerd added a comment. @aaron.ballman, yeah, I believe that the warning is working as intended, it just so happens that at runtime things just happened to work out. Repository: rC Clang https://reviews.llvm.org/D42933 ___ cfe-commits mailing

[PATCH] D42719: [CFG] [analyzer] Add construction context when constructor is wrapped into ExprWithCleanups.

NoQ updated this revision to Diff 133142. NoQ added a comment. Rebase. https://reviews.llvm.org/D42719 Files: lib/Analysis/CFG.cpp test/Analysis/cfg-rich-constructors.cpp test/Analysis/temp-obj-dtors-cfg-output.cpp Index: test/Analysis/temp-obj-dtors-cfg-output.cpp ==

[PATCH] D42672: [CFG] [analyzer] Heavier CFGConstructor elements.

NoQ updated this revision to Diff 133139. NoQ added a comment. Make CFGConstructor a sub-class of CFGStmt. I failed to notice any compile time regressions for now; if any, they must be super bottlenecked on CFG construction or analysis-based warnings. After poking @rsmith in the chat a little b

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

tejohnson added a comment. > Empty ThinLTOIndexFile signals that we don't need this module during > linking. Not the only case actually. We now also pass an empty index file when we want to compile the bitcode down to object without applying any LTO optimization (there are a few cases where we

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133134. MaskRay marked 2 inline comments as done. MaskRay added a comment. Warning messages of operator+ as operator+ operator- .. are free functions on simd objects. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133133. MaskRay marked an inline comment as done. MaskRay added a comment. docs/ReleaseNotes.rst and use StringRef::consume_front Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-ti

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

timshen added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:34 +// [simd.binary] +{"add", "std::experimental::simd::operator+"}, +{"sub", "std::experimental::simd::operator-"}, Technically, std::experimental::simd::operat

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

timshen added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:24 + if (Name.startswith("vec_")) +Name = Name.substr(4); + else timshen wrote: > Can you either find or create a wrapper for this? > > bool StripPrefix(StringRef P

[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache updated this revision to Diff 133129. modocache added a comment. Prevent coroutine parameter stores from being moved, rely on https://reviews.llvm.org/D43000 instead. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

timshen added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:24 + if (Name.startswith("vec_")) +Name = Name.substr(4); + else Can you either find or create a wrapper for this? bool StripPrefix(StringRef Prefix, StringRef& S)

[clang-tools-extra] r324441 - test: use target triple for the test

Author: compnerd Date: Tue Feb 6 18:27:34 2018 New Revision: 324441 URL: http://llvm.org/viewvc/llvm-project?rev=324441&view=rev Log: test: use target triple for the test Now that `pragma comment` is also used on ELF-ish targets with a restricted set of options, we need to specify the full targe

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

timshen added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:22 + +static StringRef CheckPPC(StringRef Name) { + if (Name.startswith("vec_")) "Check" usually indicates to return a bool, but what it actually returns is a possible map

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:97 +- New `readability-simd-intrinsics + `_ check Please move it new checks section. Repository: rCTE

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133126. MaskRay added a comment. docs/ReleaseNotes.rst Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/SIMDIntri

[PATCH] D42768: AST: support SwiftCC on MS ABI

compnerd closed this revision. compnerd added a comment. SVN r324439 Repository: rC Clang https://reviews.llvm.org/D42768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324439 - AST: support SwiftCC on MS ABI

Author: compnerd Date: Tue Feb 6 17:55:08 2018 New Revision: 324439 URL: http://llvm.org/viewvc/llvm-project?rev=324439&view=rev Log: AST: support SwiftCC on MS ABI Microsoft has reserved the identifier 'S' as the swift calling convention. Decorate the symbols appropriately. This enables swift

[PATCH] D42768: AST: support SwiftCC on MS ABI

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, ship it :) Repository: rC Clang https://reviews.llvm.org/D42768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133120. MaskRay added a comment. if (!Result.Context->getLangOpts().CPlusPlus11) return; Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

compnerd closed this revision. compnerd added a comment. SVN r324438 Repository: rC Clang https://reviews.llvm.org/D42758 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324438 - Support `#pragma comment(lib, "name")` in the frontend for ELF

Author: compnerd Date: Tue Feb 6 17:46:46 2018 New Revision: 324438 URL: http://llvm.org/viewvc/llvm-project?rev=324438&view=rev Log: Support `#pragma comment(lib, "name")` in the frontend for ELF This adds the frontend support required to support the use of the comment pragma to enable auto lin

[PATCH] D42995: [ThinLTO] Ignore object files with empty ThinLTO index

vitalybuka created this revision. vitalybuka added reviewers: pcc, tejohnson. Herald added subscribers: eraman, inglorion, mehdi_amini. Empty ThinLTOIndexFile signals that we don't need this module during linking. So we should not run ThinLTO backend even if it contains the ThinLTO module. Backend

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133116. vitalybuka added a comment. set triple https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_backend.ll Index: c

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

compnerd added inline comments. Comment at: docs/LanguageExtensions.rst:2732 + +The ``#pragma comment(lib, ...)`` directive is supported on all ELF targets. +The second parameter is the library name (without the traditional Unix prefix of erichkeane wrote: > The

[PATCH] D42645: New simple Checker for mmap calls

NoQ added a comment. > What I propose is "two" separated checkers one using same but the value of > PROT_EXEC will depend on the checker name e.g. security.MmapWriteExecGen vs > security.MmapWriteExecGlibc ... or by default we keep PROT_EXEC as is and we > would allow to override the value via

[PATCH] D42768: AST: support SwiftCC on MS ABI

compnerd updated this revision to Diff 133114. compnerd retitled this revision from "AST: add an extension to support SwiftCC on MS ABI" to "AST: support SwiftCC on MS ABI". compnerd edited the summary of this revision. compnerd added a comment. Update to what Microsoft has communicated offline

r324433 - [NFC] Change odd cast-through-unknown behavior to an Optional

Author: erichkeane Date: Tue Feb 6 16:37:19 2018 New Revision: 324433 URL: http://llvm.org/viewvc/llvm-project?rev=324433&view=rev Log: [NFC] Change odd cast-through-unknown behavior to an Optional This bit of code in the driver uses '~0U' as a sentinel value. The result is an odd mishmash of ca

[PATCH] D42918: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates

This revision was automatically updated to reflect the committed changes. Closed by commit rL324432: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates (authored by juliehockett, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit: https:

[clang-tools-extra] r324432 - [clang-tidy] Update fuchsia-multiple-inheritance to check for templates

Author: juliehockett Date: Tue Feb 6 16:33:50 2018 New Revision: 324432 URL: http://llvm.org/viewvc/llvm-project?rev=324432&view=rev Log: [clang-tidy] Update fuchsia-multiple-inheritance to check for templates Updating fuchsia-multiple-inheritance to not crash when a record inherits a template.

r324430 - [NFC] Correct a typo'ed comment and reworded, since it is awkward.

Author: erichkeane Date: Tue Feb 6 16:19:58 2018 New Revision: 324430 URL: http://llvm.org/viewvc/llvm-project?rev=324430&view=rev Log: [NFC] Correct a typo'ed comment and reworded, since it is awkward. Modified: cfe/trunk/lib/Driver/Driver.cpp Modified: cfe/trunk/lib/Driver/Driver.cpp URL

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett added inline comments. Comment at: tools/clang-doc/ClangDoc.h:29 +struct ClangDocContext { + // Which format in which to emit representation. + OutFormat EmitFormat; sammccall wrote: > juliehockett wrote: > > sammccall wrote: > > > Is this the inte

[PATCH] D41102: Setup clang-doc frontend framework

juliehockett updated this revision to Diff 133108. juliehockett marked 27 inline comments as done. juliehockett edited the summary of this revision. juliehockett edited projects, added clang-tools-extra; removed clang. juliehockett added a comment. 1. Moved the tool to clang-tools-extra 1. Refac

[PATCH] D42680: [ThinLTO] Ignore object files with no ThinLTO modules if -fthinlto-index= is set

vitalybuka updated this revision to Diff 133111. vitalybuka added a comment. Create valid empty object file https://reviews.llvm.org/D42680 Files: clang/include/clang/CodeGen/BackendUtil.h clang/lib/CodeGen/BackendUtil.cpp clang/lib/CodeGen/CodeGenAction.cpp clang/test/CodeGen/thinlto_b

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

Eugene.Zelenko added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:77 +void SIMDIntrinsicsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee(functionDecl(matchesName("^::(_mm_|_mm256_|_mm512_|vec_)"))),

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133109. MaskRay added a comment. Remove private section Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp clang-tidy/readability/SIMDIntr

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:77 +void SIMDIntrinsicsCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee(functionDecl(matchesName("^::(_

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

MaskRay updated this revision to Diff 133107. MaskRay marked 5 inline comments as done. MaskRay added a comment. LLVM Style Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp c

[PATCH] D42991: [analyzer] Use EvalCallOptions for destructors as well.

NoQ updated this revision to Diff 133106. NoQ added a comment. Remove a couple of accidental blank lines. https://reviews.llvm.org/D42991 Files: include/clang/StaticAnalyzer/Core/PathSensitive/ExprEngine.h lib/StaticAnalyzer/Core/ExprEngine.cpp lib/StaticAnalyzer/Core/ExprEngineCXX.cpp

[PATCH] D42993: [AArch64] Fixes for ARMv8.2-A FP16 scalar intrinsic

az created this revision. az added a reviewer: SjoerdMeijer. Herald added subscribers: hiraditya, kristof.beyls, javed.absar, rengolin, aemerson. A couple of fixes on top of https://reviews.llvm.org/D41792: - Fixes for freceprical, and fsqrt instructions in the backend. - The intrinsics that gen

[PATCH] D42991: [analyzer] NFC: Use EvalCallOptions for destructors as well.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. In https://reviews.llvm.org/D42457 we added the `EvalCallOptions` structure to notify `evalCall()` when some other code believes that there's

r324425 - [Sema][ObjC] Use SmallSetVector to fix a failing test on the reverse

Author: ahatanak Date: Tue Feb 6 15:44:40 2018 New Revision: 324425 URL: http://llvm.org/viewvc/llvm-project?rev=324425&view=rev Log: [Sema][ObjC] Use SmallSetVector to fix a failing test on the reverse iteration bot. This commit reverts r315639, which was causing clang to print diagnostics that

[PATCH] D42983: [clang-tidy] Add readability-simd-intrinsics check.

Eugene.Zelenko added a comment. Please mention this check in docs/ReleaseNotes.rst (in alphabetical order). Comment at: clang-tidy/readability/SIMDIntrinsicsCheck.cpp:24 + +StringRef CheckPPC(StringRef Name) { + if (Name.startswith("vec_")) Please make functio

[PATCH] D42457: [analyzer] Don't communicate evaluation failures through memregion hierarchy.

NoQ added a comment. > Functional change here is accidental - by communicating array destructor > situation properly, we're able to fix an old FIXME. Minor temporary insanity. This test was "fixed" because in `mayInlineCall()` for destructors i started to look for the flag that i never set for

[libcxx] r324423 - Remove more of the std::experimental bits that are now in std::. All the _v type aliases, conjunction/disjunction, apply, etc. See https://libcxx.llvm.org/TS_deprecation.html

Author: marshall Date: Tue Feb 6 15:13:48 2018 New Revision: 324423 URL: http://llvm.org/viewvc/llvm-project?rev=324423&view=rev Log: Remove more of the std::experimental bits that are now in std::. All the _v type aliases, conjunction/disjunction, apply, etc. See https://libcxx.llvm.org/TS_dep

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay updated this revision to Diff 133091. MaskRay added a comment. Move CHECK-MESSAGES: to comform to the prevaling style Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D42987: [libc++abi] fix compilation in C++17 mode

rsmith created this revision. rsmith added reviewers: EricWF, mclow.lists. Herald added a subscriber: sanjoy. C++17 removes `std::unexpected_handler`, but libc++abi needs it to define `__cxa_exception`. When building against libc++, this is easily rectified by telling libc++ we're building the l

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

rsmith added a comment. Looks fine to me. Repository: rC Clang https://reviews.llvm.org/D42768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

compnerd updated this revision to Diff 133087. compnerd added a comment. address design changes Repository: rC Clang https://reviews.llvm.org/D42768 Files: lib/AST/MicrosoftMangle.cpp test/CodeGenCXX/msabi-swiftcall-cc.cpp Index: test/CodeGenCXX/msabi-swiftcall-cc.cpp =

[PATCH] D42882: [Myriad] Define __ma2x5x and __ma2x8x

This revision was automatically updated to reflect the committed changes. Closed by commit rC324420: [Myriad] Define __ma2x5x and __ma2x8x (authored by waltl, committed by ). Changed prior to commit: https://reviews.llvm.org/D42882?vs=132739&id=133086#toc Repository: rC Clang https://review

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

This revision was automatically updated to reflect the committed changes. Closed by commit rC324419: [Lex] Fix handling numerical literals ending with ' and signed exponent. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41834?vs=129125&id=133085#toc R

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

This revision was automatically updated to reflect the committed changes. Closed by commit rL324419: [Lex] Fix handling numerical literals ending with ' and signed exponent. (authored by vsapsai, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

vsapsai added a comment. Thanks for the review. https://reviews.llvm.org/D41834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

stephanemoore added a comment. Looks reasonable 👌 Repository: rL LLVM https://reviews.llvm.org/D42864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r324420 - [Myriad] Define __ma2x5x and __ma2x8x

Author: waltl Date: Tue Feb 6 14:39:47 2018 New Revision: 324420 URL: http://llvm.org/viewvc/llvm-project?rev=324420&view=rev Log: [Myriad] Define __ma2x5x and __ma2x8x Summary: Add architecture defines for ma2x5x and ma2x8x. Reviewers: jyknight Subscribers: fedor.sergeev, MartinO Differentia

r324419 - [Lex] Fix handling numerical literals ending with ' and signed exponent.

Author: vsapsai Date: Tue Feb 6 14:39:25 2018 New Revision: 324419 URL: http://llvm.org/viewvc/llvm-project?rev=324419&view=rev Log: [Lex] Fix handling numerical literals ending with ' and signed exponent. For input `0'e+1` lexer tokenized as numeric constant only `0'e`. Later NumericLiteralPars

[PATCH] D42708: [clang-format] Set ObjCBinPackProtocolList to Never for google style

stephanemoore added a comment. I believe that I have consensus from Google to be able to approve this. I sent out a last call for dissenting opinions. If I don't hear anything I plan on approving tomorrow. Repository: rC Clang https://reviews.llvm.org/D42708 _

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay added a comment. I haven't used clang-tidy before :) Do you have any suggestions on my workflow? % ninja -C ~/Dev/llvm/build clangTidyReadabilityModule % ~/Dev/llvm/build/bin/clang-tidy -checks='-*,readability-simd-intrinsics' a.cc # for local testing # Ensure tests are correc

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay updated this revision to Diff 133083. MaskRay added a comment. Add test/clang-tidy/readability-simd-intrinsics.cpp Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42983 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp cl

[PATCH] D42983: [clang-tidy] Add `readability-simd-intrinsics` check.

MaskRay created this revision. Herald added subscribers: cfe-commits, hintonda, kristof.beyls, xazax.hun, mgorny, aemerson, klimek. Many architectures provide SIMD operations (e.g. x86 SSE/AVX, Power AltiVec/VSX, ARM NEON). It is common that SIMD code implementing the same algorithm, is written i

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324407: Support special acronyms inside property names and allow plural forms (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D42947?vs=133069&id=133071#toc Rep

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 133069. Wizard added a comment. minor fix according to comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:144 + "[A-Z]?)?[a-z]+[a-z0-9]*(" + + AcronymsGroupRegex(EscapedAcronyms, true) + "|([A-

[PATCH] D41834: [Lex] Fix handling numerical literals ending with ' and signed exponent.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D41834 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D42942: [clangd] Collect definitions when indexing.

ioeric added inline comments. Comment at: clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp:67 + // XXX this is just to make running the tool fast during dev! + bool BeginInvocation(CompilerInstance &CI) override { +const auto &Inputs = CI.getInvocation()

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 133066. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index: test/clang-tidy/objc-property-

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:142 - return StartMatcher + "((" + - llvm::join(EscapedAcronyms.begin(), EscapedAcronyms.end(), "|") + - ")[A-Z]?)?[a-z]+[a-z0-9]*([A-Z][a-z0-9]+)*" + "(" + - llvm::j

[libcxx] r324399 - Mark P0777 as complete

Author: marshall Date: Tue Feb 6 13:00:58 2018 New Revision: 324399 URL: http://llvm.org/viewvc/llvm-project?rev=324399&view=rev Log: Mark P0777 as complete Modified: libcxx/trunk/www/cxx2a_status.html Modified: libcxx/trunk/www/cxx2a_status.html URL: http://llvm.org/viewvc/llvm-project/li

[PATCH] D42581: [NVPTX] Emit debug info in DWARF-2 by default for Cuda devices.

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Cuda.cpp:436-437 assert(Output.isNothing() && "Invalid output."); - if (Args.hasArg(options::OPT_g_Flag)) + if (mustEmitDebugInfo(Args) == FullDebug) CmdArgs.push_back("-g"); tra wrote

[libcxx] r324398 - Implement P0777: Treating unnecessay decay

Author: marshall Date: Tue Feb 6 12:56:55 2018 New Revision: 324398 URL: http://llvm.org/viewvc/llvm-project?rev=324398&view=rev Log: Implement P0777: Treating unnecessay decay Modified: libcxx/trunk/include/optional libcxx/trunk/include/tuple libcxx/trunk/include/type_traits lib

[clang-tools-extra] r324389 - [clangd] Make the premble tremble.

Author: d0k Date: Tue Feb 6 12:08:23 2018 New Revision: 324389 URL: http://llvm.org/viewvc/llvm-project?rev=324389&view=rev Log: [clangd] Make the premble tremble. No functionality change. Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/Clan

[clang-tools-extra] r324386 - Revert "[clangd] The new threading implementation" (r324356)

Author: ibiryukov Date: Tue Feb 6 11:22:40 2018 New Revision: 324386 URL: http://llvm.org/viewvc/llvm-project?rev=324386&view=rev Log: Revert "[clangd] The new threading implementation" (r324356) And the follow-up changes r324361 and r324363. These changes seem to break two buildbots: - http:/

[PATCH] D34249: [libc++] Don't use UTIME_OMIT to detect utimensat on Apple

thakis added a comment. I went ahead and landed this with the comments requested by Duncan in r324385. (http://llvm.org/viewvc/llvm-project?view=revision&revision=324385) I'm also quoting Duncan's email reply to my comment, since that's not showing up on phab: """ Using runtime availability che

[libcxx] r324385 - Fix building libc++ with the macOS 10.13 SDK with -mmacosx-version-min=10.12 or lower.

Author: nico Date: Tue Feb 6 11:17:41 2018 New Revision: 324385 URL: http://llvm.org/viewvc/llvm-project?rev=324385&view=rev Log: Fix building libc++ with the macOS 10.13 SDK with -mmacosx-version-min=10.12 or lower. The 10.13 SDK always defines utimensat() (with an availability(macosx=10.13)

[clang-tools-extra] r324382 - [clangd] Attempt to unbreak windows buildbots.

Author: ibiryukov Date: Tue Feb 6 11:09:44 2018 New Revision: 324382 URL: http://llvm.org/viewvc/llvm-project?rev=324382&view=rev Log: [clangd] Attempt to unbreak windows buildbots. Some buildbots are breaking on trace.test due to using Linux's path separators. This commit should unbreak them.

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values

erichkeane created this revision. erichkeane added reviewers: aaron.ballman, craig.topper, echristo. Herald added subscribers: fedor.sergeev, kbarton, aheejin, kristof.beyls, jgravelle-google, sbc100, javed.absar, nhaehnle, nemanjai, sdardis, dylanmckay, jyknight, dschuff, jfb, aemerson, jholewin

[PATCH] D42978: Make march/target-cpu print a note with the list of valid values

erichkeane added a comment. LLVM patch here: https://reviews.llvm.org/D42979 Repository: rC Clang https://reviews.llvm.org/D42978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133051. MaskRay added a comment. . Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting-literals.m tools/c-index-test/c-index-test.c

[PATCH] D42945: [libc++] Fix misleading indentation.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Committed as revision 324378 Repository: rCXX libc++ https://reviews.llvm.org/D42945 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133050. MaskRay added a comment. Simplify Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting-literals.m tools/c-index-test/c-index

[libcxx] r324378 - Fix misleading indentation; replace a couple of NULLs with nullptr. Resolves https://reviews.llvm.org/D42945 ; thanks to Bruce Mitchener for the patch.

Author: marshall Date: Tue Feb 6 10:58:05 2018 New Revision: 324378 URL: http://llvm.org/viewvc/llvm-project?rev=324378&view=rev Log: Fix misleading indentation; replace a couple of NULLs with nullptr. Resolves https://reviews.llvm.org/D42945 ; thanks to Bruce Mitchener for the patch. Modified:

r324377 - Pass around function pointers as CGCallees, not bare llvm::Value*s.

Author: rjmccall Date: Tue Feb 6 10:52:44 2018 New Revision: 324377 URL: http://llvm.org/viewvc/llvm-project?rev=324377&view=rev Log: Pass around function pointers as CGCallees, not bare llvm::Value*s. The intention here is to make it easy to write frontend-assisted CFI systems by propagating ex

[libclc] r324376 - Add vstore_half_rte implementation

Author: jvesely Date: Tue Feb 6 10:44:50 2018 New Revision: 324376 URL: http://llvm.org/viewvc/llvm-project?rev=324376&view=rev Log: Add vstore_half_rte implementation Passes CTS on carrizo Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified: libclc/trunk/generic/include/clc/share

[libclc] r324375 - Add vstore_half_rtp implementation

Author: jvesely Date: Tue Feb 6 10:44:47 2018 New Revision: 324375 URL: http://llvm.org/viewvc/llvm-project?rev=324375&view=rev Log: Add vstore_half_rtp implementation Passes CTS on carrizo Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified: libclc/trunk/generic/include/clc/share

[libclc] r324370 - vstore_half: Make sure the helper function is always inline

Author: jvesely Date: Tue Feb 6 10:44:35 2018 New Revision: 324370 URL: http://llvm.org/viewvc/llvm-project?rev=324370&view=rev Log: vstore_half: Make sure the helper function is always inline Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified: libclc/trunk/generic/lib/shared/vsto

[libclc] r324374 - Add vstore_half_rtn implementation

Author: jvesely Date: Tue Feb 6 10:44:45 2018 New Revision: 324374 URL: http://llvm.org/viewvc/llvm-project?rev=324374&view=rev Log: Add vstore_half_rtn implementation Passes CTS on carrizo Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified: libclc/trunk/generic/include/clc/share

[libclc] r324373 - Add vstore_half_rtz implementation

Author: jvesely Date: Tue Feb 6 10:44:43 2018 New Revision: 324373 URL: http://llvm.org/viewvc/llvm-project?rev=324373&view=rev Log: Add vstore_half_rtz implementation Passes CTS on carrizo Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified: libclc/trunk/generic/include/clc/share

[libclc] r324372 - vstore_half: Consolidate declarations

Author: jvesely Date: Tue Feb 6 10:44:41 2018 New Revision: 324372 URL: http://llvm.org/viewvc/llvm-project?rev=324372&view=rev Log: vstore_half: Consolidate declarations Add support for rounding suffix Reviewer: Jeroen Ketema Signed-off-by: Jan Vesely Modified: libclc/trunk/generic/incl

[libclc] r324371 - vstore_half: Add support for custom rounding functions

Author: jvesely Date: Tue Feb 6 10:44:39 2018 New Revision: 324371 URL: http://llvm.org/viewvc/llvm-project?rev=324371&view=rev Log: vstore_half: Add support for custom rounding functions Add another layer of indirection This will be used for specific rounding modes Reviewer: Jeroen Ketema Sig

[PATCH] D42945: [libc++] Fix misleading indentation.

mclow.lists added a comment. The second change is not quite right. There's a couple of lines that need indentation changes. Phab is not really good about changes like this. "This file was changed only by adding or removing whitespace" I'll just make these changes myself - thanks for calling th

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay added a comment. In https://reviews.llvm.org/D42895#998617, @yvvan wrote: > I feel quite ok about this patch. > > Can you please add unit-tests? Added // CHECK: [indexEntityReference]: kind: field | name: y | {{.*}} | loc: 70:5 | {{.*}} | role: ref write // CHECK: [index

[PATCH] D42895: [libclang] Add `CXSymbolRole role` to CXIdxEntityRefInfo

MaskRay updated this revision to Diff 133038. MaskRay added a comment. Update c-index-test.c and clang/test/Index tests Repository: rC Clang https://reviews.llvm.org/D42895 Files: include/clang-c/Index.h test/Index/index-decls.m test/Index/index-refs.cpp test/Index/index-subscripting

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rC324364: [clang-format] Add more tests for Objective-C 2.0 generic alignment (authored by benhamilton, committed by ). Changed prior to commit: https://reviews.llvm.org/D42864?vs=132654&id=133036#toc Re

[PATCH] D42864: [clang-format] Add more tests for Objective-C 2.0 generic alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rL324364: [clang-format] Add more tests for Objective-C 2.0 generic alignment (authored by benhamilton, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.o

[PATCH] D39571: [clangd] DidChangeConfiguration Notification

simark updated this revision to Diff 133034. simark added a comment. Fix assertion about parsing a document that is not open As found by Ilya, the getActiveFiles method would return the documents that were previously opened and then closed. Repository: rCTE Clang Tools Extra https://reviews

r324364 - [clang-format] Add more tests for Objective-C 2.0 generic alignment

Author: benhamilton Date: Tue Feb 6 10:01:47 2018 New Revision: 324364 URL: http://llvm.org/viewvc/llvm-project?rev=324364&view=rev Log: [clang-format] Add more tests for Objective-C 2.0 generic alignment Summary: In r236412, @djasper added a comment: // FIXME: We likely want to do this for

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

benhamilton requested changes to this revision. benhamilton added a comment. This revision now requires changes to proceed. Can you add test cases for non-plural acronyms in the middle of the string and plural acronyms at the start/end of the string, please? Comment at: clang-

[PATCH] D42650: [clang-format] New format param ObjCBinPackProtocolList

benhamilton marked an inline comment as done. benhamilton added a comment. > I don't understand why do we introduce an enum option if we are keeping the > default behavior for Google style. IMO we should have a single behavior for > any style and enforce it. https://reviews.llvm.org/D42708 chan

[PATCH] D42758: Support `#pragma comment(lib, "name")` in the frontend for ELF

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Just 1 format question, otherwise Looks good. Comment at: docs/LanguageExtensions.rst:2732 + +The ``#pragma comment(lib, ...)`` directive is supported on all ELF targ

  1   2   3   >